- Wine-Devel - list.winehq.org

Re: [QUARTZ] Add implementation for IFilterMapper interface
by Robert Shearman March 1, 2004

March 1, 2004

Christian Costa wrote: > > Hi, > > This patch adds implementation for the IFilterMapper interface. Nice. I have few comments (see below). > However filters registered with this interface require some work in > devenum to > be seen from application. This will be done when time permits. Ok. I had assumed devenum was complete, but obviously not. Does it spit out any fixme's? ... > @@ -879,7 +893,7 @@ > if (SUCCEEDED(hrSub)) > hrSub = > ICreateDevEnum_CreateClassEnumerator(pCreateDevEnum, &clsidCat, > &pEnum, 0); > > - if (SUCCEEDED(hrSub)) > + if (SUCCEEDED(hrSub) && (hrSub == S_OK)) You can remove the SUCCEEDED(hrSub) completely here. ... > + if (SUCCEEDED(hrSub)) > + { > + len = (strlenW((WCHAR*)&V_UNION(&var, bstrVal))+1) * > sizeof(WCHAR); > + if (!(regfilters[idx].Name = CoTaskMemAlloc(len*2))) > + hr = E_OUTOFMEMORY; > + } > + > + if (SUCCEEDED(hrSub)) > + { > + memcpy(regfilters[idx].Name, &V_UNION(&var, bstrVal), len); > + regfilters[idx].Clsid = clsid; > + idx++; > + } Indentation messed up a bit here and many other places. ... > + if (cFetched > 0) > + { > + for(i = 0; i < cFetched; i++) { > + /* The string in the REGFILTER structure must be > allocated in the same block as the REGFILTER structure itself */ > + ppRegFilter[i] = > (REGFILTER*)CoTaskMemAlloc(sizeof(REGFILTER)+(strlenW(This->RegFil > ters[i].Name)+1)*sizeof(WCHAR)); > + if (!ppRegFilter[i]) { > + while(i) { > + CoTaskMemFree(ppRegFilter[--i]); > + ppRegFilter[i] = NULL; > + } > + return E_OUTOFMEMORY; > + } > + ppRegFilter[i]->Clsid = This->RegFilters[i].Clsid; > + ppRegFilter[i]->Name = > (WCHAR*)((char*)ppRegFilter[i]+sizeof(REGFILTER)); > + CopyMemory(ppRegFilter[i]->Name, > This->RegFilters[i].Name, > (strlenW(This->RegFilters[i].Name)+1)*sizeof(WCHAR)); > + } Please choose one style of bracket placement and stick to it (this occurs in a few places too). Other than these things, it looks fine. Rob

3 5

My patch?
by Robert van Herk March 1, 2004

March 1, 2004

Hi, Did my patch of 2/17, that allowed for more options in the libraries dialogue of winecfg, go into the "silent void" that the wine website speaks of? :-). I didn't see any notice about it on this list... Grtz, Robert

2 1

Borland C++ 5.5 fails on Link, any ideas?
by Michael Pyne March 1, 2004

March 1, 2004

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi all, I've been trying to use the free Borland C++ 5.5 command-line tools to compile some Windows applications for my school assignments. To be specific, I am in a graphics class where every turnin has to be Windows. :-( Anyways, Borland C++ runs fine until it tries to link the program in question, at which point ilink32.exe just sits there and eats CPU cycles. I've tried letting it run in case it was simply slower than normal due to the Wine layer, but that doesn't seem to be case (I've let it sit for minutes at a time). This occurs no matter how I run it (with wine or either of wineconsole's two modes). I was wondering if there is a way I can help figure out what the problem is so that we can get this bug fixed. Obligatory specs: OS: Gentoo w/ Linux 2.6.3 (Wine was not compiled using NPTL, but OpenGL support is in) ATI OpenGL drivers XFree86 4.3 GCC 3.3.1 Using fake_windows support Please CC: any replies to me, as I am not subscribed to this list. Also, let me know if there is any other information which would be useful. Regards, - Michael Pyne -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.3 (GNU/Linux) iD8DBQFAQVAQqjQYp5Omm0oRAofOAKDEhWcFavrlg/3VdjMOcx90hF/iiwCgvWUj IS/FYImIKOxThQRj89LvwYc= =+Gxw -----END PGP SIGNATURE-----

6 7

Re: SafeArrayCreateVector
by Alexandre Julliard March 1, 2004

March 1, 2004

"Martin Fuchs" <martin-fuchs(a)gmx.net> writes: > Changelog: > correct parameter type for SafeArrayCreateVector() and SafeArrayCreateVectorEx() from ULONG to UINT The Microsoft headers have ULONG here, what headers are you using? -- Alexandre Julliard julliard(a)winehq.org

2 1

Authors.c Won't Compile
by Robert Shearman March 1, 2004

March 1, 2004

Hi, I can't compile authors.c due to some encoding issue with sed. I can generate the authors.c file fine on the command line, but the same command in the Makefile won't generate compilable code due to it terminating the string constant before a UTF-8 character. I am using Fedora Core 1 with latest updates. $ sed --version GNU sed version 4.0.8 Rob Example of errors: authors.c:19: error: stray '\366' in program authors.c:20: error: `m' undeclared here (not in a function) authors.c:20: error: initializer element is not constant authors.c:20: error: (near initialization for `SHELL_Authors[18]') authors.c:20: error: syntax error before string constant

2 7

Re: Program crash when moving a scrollbar
by Alexandre Julliard March 1, 2004

March 1, 2004

"Norbert Feulner" <feulner.norbert(a)web.de> writes: > WINPROC_MapMsg16To32A is used to restore some of the original values. It is called by > __wine_call_wndproc_32W (line 4). > > Here I added for the case of message msg16 equals SBM_GETRANGE to extend pwparam32 > to its 32-Bit value. This is done by using the upper word from plparam. This is wrong, wParam and lParam don't necessarily have the same high word. This problem has been discussed already, what needs to be done is to investigate how SBM_GETRANGE works on 16-bit Windows and then implement the proper translation based on that. -- Alexandre Julliard julliard(a)winehq.org

1 0

OLEPictureImpl_SaveAsFile
by Ross Clement March 1, 2004

March 1, 2004

Hi. I have an application (Halosim3) that I would like to have working under wine. The application works reasonably well, but is unable to save pictures to disk. With a bit of tracking, I've discovered that it calls OLEPictureImpl_SaveAsFile to save the image that it generates. This function (in dlls/oleaut32/olepicture.c) is a "stub" only, and writes back This->datalen bytes of This->data. Looking at the code further, it seems that This->data is only initialised when an image is loaded from disk. Hence any image editing or creating program that creates an image in memory, or modifies an image after it is loaded, won't work. I would like to ask if anyone is working on OLEPictureImpl_SaveAsFile, or planning to. Otherwise I may have a hack at it myself. I'm not subscribed to the winehq mailing list, but will check the archives sometime in the future. If anyone wants to contact me quicker than that, please cc it to my email address as per this email. Cheers, Ross-c -- -- Ross Clement (Dr) Senior Lecturer in Artificial Intelligence Harrow School of Computer Science University of Westminster Northwick Park Middlesex UK HA1 3TP clemenr _at_ wmin.ac.uk +44-20-7911-5000 ext. 4159

2 1

"Warning: Language '' was not recognized"
by Joel Konkle-Parker March 1, 2004

March 1, 2004

I've looked through the archives for an answer to this, but didn't find anything. When I run `wine ie6setup.exe` using Wine from CVS, the first lines are the following: -- Warning: Language '' was not recognized, defaulting to English. Building font metrics. This may take some time... -- Where is this language warning coming from? Thanks in advance. -- Joel Konkle-Parker Webmaster [Ballsome.com] E-mail [jjk3(a)msstate.edu]

1 0

Re: ole: define MKSYS_URLMONIKER
by Francois Gouget March 1, 2004

March 1, 2004

On Sun, 29 Feb 2004, Kevin Koltzau wrote: > Define MKSYS_URLMONIKER. This is not defined in any Windows headers I > can find, but does exist. Just FYI, I checked and it is present in the latest Microsoft SDK: sdk/include/UrlMon.h:#define MKSYS_URLMONIKER 6 It is also defined in ObjIdl.Idl. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ We are Pentium of Borg. You will be approximated. Division is futile.

1 0

Sibelius 2
by Andrew L. Bereson March 1, 2004

March 1, 2004

Sibelius is an app for scoring music. Sibelius 1 runs fine with wine. Sibelius 2 crashes on startup. When it crashes there is no useful message, only "Unhandled exception". Using winedbg I have found that Sibelius appears to be following a NULL pointer. I haven't yet managed to track down where it's getting the bad pointer from... any suggestions would be appreciated. I've got some time and energy to try to make this work, but first... Has anyone else worked or is some else currently working on this? What did you find? How far did you get? -- Andrew L. Bereson bereson(a)sea-ware.com (800)307-5754

2 1