- Wine-Devel - list.winehq.org

winxp version info
by Ivan Leo Murray-Smith Feb. 29, 2004

Feb. 29, 2004

To avoid problems like this one that recently appeared in the newsgroup > Wine emulates XP which is good, > however upon attempting installation it springs up a message requiring > that i have my pc install SP1 it may be a good idea to set the winxp emulation to return the values of winxp sp1. Ivan.

1 0

Re: [QUARTZ] Add implementation for IFilterMapper interface (RESEND)
by Tom Feb. 29, 2004

Feb. 29, 2004

Christian Costa wrote: > Hi, > > This time wih Rob's suggestions. > > Bye. > > Changelog : > Implemented IFilterMapper and IEnumRegFilters interfaces. > Fixed IFilterMapper2_EnumMatchingFilters. > > Christian Costa titan.costa(a)wanadoo.fr > Hi Christian, Should I add you as a worker on quartz? Tom

2 1

Re: help
by Tom Feb. 29, 2004

Feb. 29, 2004

Matt Jaggard wrote: > > hi, I left a message, a longgg time ago on your website, > I was wondering if you could please delete mjaggard(a)blueyonder.co.uk > <mailto:mjaggard(a)blueyonder.co.uk>. As I do not want spammers picking my > address up. Thanks, > The URL my address is on is called. > http://www.winehq.org/hypermail/wine-users/2000/12/0438.html. if you > could delete references to mjaggard(a)blueyonder.co.uk > <mailto:mjaggard(a)blueyonder.co.uk> or the page that would be brill > > Many Thanks > > M Jaggard This is a joke or what? Now you real addy with out the ( _ ) in it is on wine-devel not only by your post but with my reply as well... Your odds of being spammed have just increased by some 200% ... But don't worry spam is really good for you..... :) My dear sweet Grandma use to keep us nice and fat on it when we were just little tikes.. Tom

1 0

Re: GetDefaultPrinter A->W [resubmit]
by Alexandre Julliard Feb. 28, 2004

Feb. 28, 2004

Stefan Leichter <Stefan.Leichter(a)camLine.com> writes: > Hello, > i sent this patch one week ago, but it does not get commited. Anything wrong > with it? The handling of the buffer sizes looks very suspicious. For instance you check for namesize being NULL, but later on assign something to it anyway. Also allocations have to be in bytes but length arguments (for instance in the GetProfileStringW call) have to be in WCHARs, this isn't done correctly. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: PATCH: Compatibility issue with InternetCrackUrlA
by wire Feb. 28, 2004

Feb. 28, 2004

Hi. I have modified my patch about compatibility of InternetCrackUrlA function,to deal with the failed case. If the pointer member of one component is set to point a buffer,but the length member is not big enough,then the component should not be returned, and the length member is set to the value needed. And later i'll post the patch for the conformance test. Bye. ChangeLog: Fill the nPort field with the corresponding scheme; Fix the path and extrainfo components' parse; Deal with the failed case. Index: wine/dlls/wininet/internet.c =================================================================== RCS file: /home/wine/wine/dlls/wininet/internet.c,v retrieving revision 1.73 diff -u -r1.73 internet.c --- wine/dlls/wininet/internet.c 30 Dec 2003 19:16:37 -0000 1.73 +++ wine/dlls/wininet/internet.c 28 Feb 2004 10:22:19 -0000 @@ -845,29 +845,28 @@ DWORD nLength; URL_COMPONENTSW UCW; WCHAR* lpwszUrl; + BOOL result; if(dwUrlLength==0) dwUrlLength=strlen(lpszUrl); lpwszUrl=HeapAlloc(GetProcessHeap(), 0, sizeof(WCHAR)*(dwUrlLength+1)); memset(lpwszUrl,0,sizeof(WCHAR)*(dwUrlLength+1)); nLength=MultiByteToWideChar(CP_ACP,0,lpszUrl,dwUrlLength,lpwszUrl,dwUrlLength+1); - memset(&UCW,0,sizeof(UCW)); - if(lpUrlComponents->dwHostNameLength!=0) - UCW.dwHostNameLength=1; - if(lpUrlComponents->dwUserNameLength!=0) - UCW.dwUserNameLength=1; - if(lpUrlComponents->dwPasswordLength!=0) - UCW.dwPasswordLength=1; - if(lpUrlComponents->dwUrlPathLength!=0) - UCW.dwUrlPathLength=1; - if(lpUrlComponents->dwSchemeLength!=0) - UCW.dwSchemeLength=1; - if(lpUrlComponents->dwExtraInfoLength!=0) - UCW.dwExtraInfoLength=1; - if(!InternetCrackUrlW(lpwszUrl,nLength,dwFlags,&UCW)) - { - HeapFree(GetProcessHeap(), 0, lpwszUrl); - return FALSE; - } + + memcpy(&UCW,lpUrlComponents,sizeof(UCW)); + if (UCW.lpszScheme && UCW.dwSchemeLength) + UCW.lpszScheme = HeapAlloc(GetProcessHeap(), 0, sizeof(WCHAR)*(UCW.dwSchemeLength+1)); + if (UCW.lpszHostName && UCW.dwHostNameLength) + UCW.lpszHostName = HeapAlloc(GetProcessHeap(), 0, sizeof(WCHAR)*(UCW.dwHostNameLength+1)); + if (UCW.lpszUserName && UCW.dwUserNameLength) + UCW.lpszUserName = HeapAlloc(GetProcessHeap(), 0, sizeof(WCHAR)*(UCW.dwUserNameLength+1)); + if (UCW.lpszPassword && UCW.dwPasswordLength) + UCW.lpszPassword = HeapAlloc(GetProcessHeap(), 0, sizeof(WCHAR)*(UCW.dwPasswordLength+1)); + if (UCW.lpszUrlPath && UCW.dwUrlPathLength) + UCW.lpszUrlPath = HeapAlloc(GetProcessHeap(), 0, sizeof(WCHAR)*(UCW.dwUrlPathLength+1)); + if (UCW.lpszExtraInfo && UCW.dwExtraInfoLength) + UCW.lpszExtraInfo = HeapAlloc(GetProcessHeap(), 0, sizeof(WCHAR)*(UCW.dwExtraInfoLength+1)); + result = InternetCrackUrlW(lpwszUrl,nLength,dwFlags,&UCW); + ConvertUrlComponentValue(&lpUrlComponents->lpszHostName, &lpUrlComponents->dwHostNameLength, UCW.lpszHostName, UCW.dwHostNameLength, lpszUrl, lpwszUrl); @@ -888,7 +887,19 @@ lpszUrl, lpwszUrl); lpUrlComponents->nScheme=UCW.nScheme; lpUrlComponents->nPort=UCW.nPort; + lpUrlComponents->dwSchemeLength=UCW.dwSchemeLength; + lpUrlComponents->dwHostNameLength=UCW.dwHostNameLength; + lpUrlComponents->dwUserNameLength=UCW.dwUserNameLength; + lpUrlComponents->dwPasswordLength=UCW.dwPasswordLength; + lpUrlComponents->dwUrlPathLength=UCW.dwUrlPathLength; + lpUrlComponents->dwExtraInfoLength=UCW.dwExtraInfoLength; HeapFree(GetProcessHeap(), 0, lpwszUrl); + HeapFree(GetProcessHeap(), 0, UCW.lpszScheme); + HeapFree(GetProcessHeap(), 0, UCW.lpszHostName); + HeapFree(GetProcessHeap(), 0, UCW.lpszUserName); + HeapFree(GetProcessHeap(), 0, UCW.lpszPassword); + HeapFree(GetProcessHeap(), 0, UCW.lpszUrlPath); + HeapFree(GetProcessHeap(), 0, UCW.lpszExtraInfo); TRACE("%s: scheme(%s) host(%s) path(%s) extra(%s)\n", lpszUrl, debugstr_an(lpUrlComponents->lpszScheme,lpUrlComponents->dwSchemeLength), @@ -896,7 +907,7 @@ debugstr_an(lpUrlComponents->lpszUrlPath,lpUrlComponents->dwUrlPathLength), debugstr_an(lpUrlComponents->lpszExtraInfo,lpUrlComponents->dwExtraInfoLength)); - return TRUE; + return result; } /*********************************************************************** @@ -972,10 +983,14 @@ } else { - INT ncpylen = min((*dwComponentLen)-1, len); - strncpyW(*lppszComponent, lpszStart, ncpylen); - (*lppszComponent)[ncpylen] = '\0'; - *dwComponentLen = ncpylen; + if (*dwComponentLen<len+1) { + **lppszComponent = '\0'; + *dwComponentLen = len+1; + return FALSE; + } + strncpyW(*lppszComponent, lpszStart, len); + (*lppszComponent)[len] = '\0'; + *dwComponentLen = len; } } @@ -999,6 +1014,8 @@ LPWSTR lpszcp = NULL; WCHAR lpszSeparators[3]={';','?',0}; WCHAR lpszSlash[2]={'/',0}; + BOOL result = TRUE; + if(dwUrlLength==0) dwUrlLength=strlenW(lpszUrl); @@ -1027,12 +1044,12 @@ /* Parse <params> */ lpszParam = strpbrkW(lpszap, lpszSeparators); - if (lpszParam != NULL) + if (lpszParam != NULL && (lpUC->dwExtraInfoLength || lpUC->lpszExtraInfo)) { if (!SetUrlComponentValueW(&lpUC->lpszExtraInfo, &lpUC->dwExtraInfoLength, lpszParam, dwUrlLength-(lpszParam-lpszUrl))) { - return FALSE; + result = FALSE; } } @@ -1045,7 +1062,7 @@ lpUC->nScheme = GetInternetSchemeW(lpszUrl, lpszcp - lpszUrl); if (!SetUrlComponentValueW(&lpUC->lpszScheme, &lpUC->dwSchemeLength, lpszUrl, lpszcp - lpszUrl)) - return FALSE; + result = FALSE; /* Eat ':' in protocol. */ lpszcp++; @@ -1112,14 +1129,16 @@ lpszcp++; } - SetUrlComponentValueW(&lpUC->lpszUserName, &lpUC->dwUserNameLength, - lpszUser, lpszPasswd - lpszUser); + if (!SetUrlComponentValueW(&lpUC->lpszUserName, &lpUC->dwUserNameLength, + lpszUser, lpszPasswd - lpszUser)) + result = FALSE; if (lpszPasswd != lpszHost) lpszPasswd++; - SetUrlComponentValueW(&lpUC->lpszPassword, &lpUC->dwPasswordLength, + if (!SetUrlComponentValueW(&lpUC->lpszPassword, &lpUC->dwPasswordLength, lpszPasswd == lpszHost ? NULL : lpszPasswd, - lpszHost - lpszPasswd); + lpszHost - lpszPasswd)) + result = FALSE; lpszcp++; /* Advance to beginning of host */ } @@ -1133,8 +1152,9 @@ entire string up to the first '/' */ if(lpUC->nScheme==INTERNET_SCHEME_RES) { - SetUrlComponentValueW(&lpUC->lpszHostName, &lpUC->dwHostNameLength, - lpszHost, lpszPort - lpszHost); + if (!SetUrlComponentValueW(&lpUC->lpszHostName, &lpUC->dwHostNameLength, + lpszHost, lpszPort - lpszHost)) + result = FALSE; lpUC->nPort = 0; lpszcp=lpszNetLoc; } @@ -1158,12 +1178,29 @@ } else { - SetUrlComponentValueW(&lpUC->lpszHostName, &lpUC->dwHostNameLength, - lpszHost, lpszPort - lpszHost); + if (!SetUrlComponentValueW(&lpUC->lpszHostName, &lpUC->dwHostNameLength, + lpszHost, lpszPort - lpszHost)) + result = FALSE; if (lpszPort != lpszNetLoc) lpUC->nPort = atoiW(++lpszPort); else - lpUC->nPort = 0; + switch(lpUC->nScheme) { + case INTERNET_SCHEME_FTP: + lpUC->nPort = INTERNET_DEFAULT_FTP_PORT; + break; + case INTERNET_SCHEME_HTTPS: + lpUC->nPort = INTERNET_DEFAULT_HTTPS_PORT; + break; + case INTERNET_SCHEME_HTTP: + lpUC->nPort = INTERNET_DEFAULT_HTTP_PORT; + break; + case INTERNET_SCHEME_GOPHER: + lpUC->nPort = INTERNET_DEFAULT_GOPHER_PORT; + break; + default: + lpUC->nPort = 0; + break; + } } } } @@ -1198,7 +1235,7 @@ if (!SetUrlComponentValueW(&lpUC->lpszUrlPath, &lpUC->dwUrlPathLength, lpszcp, len)) - return FALSE; + result = FALSE; } else { @@ -1210,7 +1247,7 @@ debugstr_wn(lpUC->lpszUrlPath,lpUC->dwUrlPathLength), debugstr_wn(lpUC->lpszExtraInfo,lpUC->dwExtraInfoLength)); - return TRUE; + return result; } /***********************************************************************

1 0

Re: RPC Update Patch
by Dan Kegel Feb. 28, 2004

Feb. 28, 2004

> On Thu, 26 Feb 2004 23:16:23 -0600, Gregory M. Turner wrote: >> They are actually pretty well-documented on MSDN: >> >> http://msdn.microsoft.com/library/default.asp?url=/library/en-us/rpc/rpc/rp… >> >> Looks like a lot of work, Robert; thanks for your efforts. > > Hmm, interesting. I wonder why this doesn't show up when I google for "ndr > format strings". It does if you include the quotes... - Dan -- US citizens: if you're considering voting for Bush, look at these first: http://www.misleader.org/ http://www.cbc.ca/news/background/arar/ http://www.house.gov/reform/min/politicsandscience/

1 0

Re: implement fixme in CreateAcceleratorTable
by Dmitry Timoshkov Feb. 28, 2004

Feb. 28, 2004

"Pabs" <pabs3(a)bonedaddy.net> wrote: > ChangeLog > > Added some checks to CreateAcceleratorTableA/W (removes fixmes) IMO it's better to use if (!MapVirtualKeyW(lpaccel[i].key, 0)) { WARN("Invalid VK\n"); SetLastError(ERROR_INVALID_PARAMETER); return NULL; } for a check whether VK is a valid one. -- Dmitry.

2 1

catching first chance exception question
by Robert Reif Feb. 27, 2004

Feb. 27, 2004

I'm looking at how windows deals with invalid parameters in some of the winmm functions and it raises some questions. Sometimes they will check the parameters and return an error code and sometimes they will let a bad parameter cause a first-chance exception and catch it and return an error code. Is it ok to do a simple NULL pointer check and return an error rather than letting it cause an exception and catching it? If not, what's the best way to catch the exception and return the proper error code?

2 1

Re: build: avoid Unix file on MinGW
by Lionel Ulmer Feb. 27, 2004

Feb. 27, 2004

On Fri, Feb 27, 2004 at 09:19:08AM -0500, Dimitrie O. Paun wrote: > BTW, why do we need the {GLU32,GLUT32,OPENGL}FILES cases? > Should those just be listed under X files? And shouldn't > we just build those, and dload() the Unix libs at run time? We need these special cases as an user can have X installed but not GLU / GLUT or OpenGL. And as to why we cannot dload the Unix lib at run time, it would be a bit like 'why do we not build the X11DRV library all the time and dlsym all the X11 symbols'. Basically, if you do not have OpenGL installed, there is no way you will be able to get Wine's OpenGL library to run. So there is no point to offer some special 'dlopen' magic to be able to load it on these boxes. Lionel -- Lionel Ulmer - http://www.bbrox.org/

1 0

Re: winemaker: use winegcc
by Francois Gouget Feb. 27, 2004

Feb. 27, 2004

On Fri, 27 Feb 2004, Dimitrie O. Paun wrote: [...] > @@ -801,7 +753,7 @@ > $basename=~ s/\.(dll|exe)$//i; > # This is the default link list of Visual Studio, except odbccp32 > # which we don't have in Wine. > - my @std_imports=qw(advapi32 comdlg32 gdi32 kernel32 odbc32 ole32 oleaut32 shell32 user32 winspool); > + my @std_imports=qw(odbc32 ole32 oleaut32 winspool); > my @std_libraries=qw(uuid); Does winegcc systematically link applications and dlls to advapi32, comdlg32, etc? How does one do if one does not want to link with gdi32 for instance? -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ May your Tongue stick to the Roof of your Mouth with the Force of a Thousand Caramels.

2 1