- Wine-Devel - list.winehq.org

wine/controls/button.c (get_button_text) : potential memory leak
by Vincent Pelletier Feb. 18, 2004

Feb. 18, 2004

In get_button_text, the returned handle must be freed by caller (-> memory leak if it forgots about it). That could be solved using something like : /* BEGIN */ /* in button.c */ inline static void get_button_text(HWND hwnd, WCHAR *out, INT max_len) { INT len = MIN(GetWindowTextLengthW( hwnd ), max_len); GetWindowTextW( hwnd, buffer, len + 1 ); } /* everywhere needed */ #define MAX_BUTTON_TEXT_LEN 255 /* just as an example */ caller_func(HWND hwnd) { WCHAR button_text[MAX_BUTTON_TEXT_LEN]; /* can also be dynamicaly allocated of course */ get_button_text(hwnd, button_text, MAX_BUTTON_TEXT_LEN); /* do something with gathered string */ } /* END */ So, why wouldn't I do it myself ? Because I'm getting lost in sources :). I only crawl wine code for only 48 hours now... So about 5 hours of effective crawling. Vincent Pelletier

1 0

Re: Dll separation - Winedos from kernel32
by Eric Pouech Feb. 18, 2004

Feb. 18, 2004

Steven Edwards a écrit : > Hello, > This was from a totaly foolish attempt at building winedos on Mingw. I > was hoping we could create a ntvdm for ReactOS. I guess we are not > planning on totaly rewritting winedos to deal with Erics new filesystem > stuff right? So we could just move this call here. this is already taken care of in one of the patches I sent A+

1 0

Fixing the SysParametersInfoW->A crosscall
by Justin Chevrier Feb. 18, 2004

Feb. 18, 2004

Just a note that i'm working on correcting the SysParametersInfoW -> SysParametersInfoA crosscall, so that there's no duplicated effort I thought i'd send a message to wine-devel. I hope to have a patch in the next couple of days. Justin Chevrier _________________________________________________________________ Protect your PC - get McAfee.com VirusScan Online http://clinic.mcafee.com/clinic/ibuy/campaign.asp?cid=3963

1 0

WINE plugins
by KappaM KappaM Feb. 18, 2004

Feb. 18, 2004

Hi, I have an application and a Netscape plugin that run in Windows. That plugin is correctly loaded by either Netscape or my application. Now I need to "port" these modules on Linux. To do so I recompiled my application with the WineLib environment, I modified/added the interface function of my plugin and alse recompiled it with the WineLib environment. Every thing works fine if the plugin is loaded by my application. The problem arises when I try to load the plugin by Linux-Mozilla, as the plugin is not recognized. I think that the problem is due to the fact that the wine environment is not active, is it correct? Is it possible to load the wine environment to work only with the plugin (not with an application)? Do you have any suggestions to make my WinePlugin loadable by Linux Mozilla ? Thanks in advance Katia _________________________________________________________________ Add photos to your e-mail with MSN 8. Get 2 months FREE*. http://join.msn.com/?page=features/featuredemail

2 1

headers: define SPI_* values introduced in XP
by Kevin Koltzau Feb. 18, 2004

Feb. 18, 2004

Changelog Define SPI_* values introduced in XP

1 0

Re: winetest updates
by Dimitrie O. Paun Feb. 18, 2004

Feb. 18, 2004

On February 18, 2004 04:36 am, Ferenc Wagner wrote: > +Usage: winetest [OPTION]...\n\n\ > + -c console mode, no GUI\n\ > + -h print this message and exit\n\ > + -q quiet mode, no output at all\n\ > + -o FILE put report into FILE, do not submit\n\ > + -s FILE submit FILE, do not run tests\n\ > + -t TAG include TAG of characters [-.0-9a-zA-Z] in the report\n"); Cool. So I guess for automatic testing we use -q. Would be nice to have another parameter, say -a bob(a)corp.com to specify the email address of the guy running the program. This way, we have something to (1) identify the output, and (2) to contact them in case of problems. This would be useful for people donating boxes to the test pool, they would specify the email only once. Or maybe we should read it from the registry? Or both? -- Dimi.

1 0

ListView oddity
by Fabian Cenedese Feb. 18, 2004

Feb. 18, 2004

Hi I had a problem with the ListView control. I could circumvent it by changing (correcting?) my application. But I thought I'd still report it. I have an MFC-app which uses a CListCtrl-derived list. In the OnRButtonDown handler of my class I didn't call the baseclass handler from CListCtrl. Upon release of the right mouse button the context menu would appear on Windows. That's how it worked. On wine I can see that the LISTVIEW_RButtonDown function is never called. Understandable as I didn't call the base class. But in this handler is a flag called bRButtonDown which would be set to TRUE. In the corresponding handler LISTVIEW_RButtonUp this flag is again tested. As it was never set in my case the handler never sent the WM_CONTEXTMENU message. What is this flag for? Is this to detect drag'n'drops with the right button or something like that? As my app worked on Windows I guess it's not necessary that the ButtonDown handler is called as in wine. Or this flag should be set earlier and not in the (maybe not called) down handler. Or it could be cleared from mouse move messages, don't know. As I said I corrected my app to always call the base class handler and so it works now. But that's a difference to Windows that may need to be changed sometimes. I wonder why it worked on Windows anyway :) Thanks bye Fabi

1 0

News releases on the sf page
by Ivan Leo Murray-Smith Feb. 18, 2004

Feb. 18, 2004

Dimi, the "latest news" on the sf page is "wine-20031212 released", all new news is also put up on the sf main page, until it isn't pushed out of the way, so it might help stats to update the news section at every release, so people going to the sf.net home page would see a nice link to the news, and from there could go strait on to the download page. Ivan.

2 1

regedit : exporting keys
by Vincent Pelletier Feb. 17, 2004

Feb. 17, 2004

I'm curently working on #824 bug (\0 character is added to REG_MULTI_SZ registry values) and while hunting it I found that regedit uses it's own function to write to a file instead of using the RegSaveKey API. Although it shouldn't solve the bug, it should be interesting to use the API. I also got 2 bugs with the export function : - the "save as" window got a square shape, not a rectangle (right side cuted, down one too downward) - regedit always exports the whole hive, not only subkeys & values Vincent Pelletier

2 1

Re: GetDefaultPrinter A->W
by Alexandre Julliard Feb. 17, 2004

Feb. 17, 2004

Stefan Leichter <Stefan.Leichter(a)camLine.com> writes: > + if ((ptr = wcschr(buffer, (WCHAR) ',')) == NULL) { > + SetLastError (ERROR_INVALID_NAME); You can't use wcs functions in Wine. > +BOOL WINAPI GetDefaultPrinterA(LPSTR name, LPDWORD namesize) > +{ DWORD insize = namesize ? *namesize : 0; > + WCHAR bufferW[1000] = {0}; Please don't allocate huge buffers on the stack. Use HeapAlloc to get a buffer of reasonable size (based on the namesize parameter). -- Alexandre Julliard julliard(a)winehq.org

2 2