- Wine-Devel - list.winehq.org

Re: default config file creation
by Ivan Leo Murray-Smith Dec. 17, 2003

Dec. 17, 2003

>The less modification to the install process the better. >If there was a single location the files could be >installed to that would work for all distros I think this >is the route to head in. You can install the files anywhere, as long as the location isn't already used for something else, /etc/wine could do. Also, compiling the files means nobody could change the default config without recompiling wine, that sound short of weird. Ivan.

2 1

Re: default config file creation
by Ivan Leo Murray-Smith Dec. 17, 2003

Dec. 17, 2003

> Read documentation/PACKAGING, I had it added to CVS with most ideas already > inside on Jun 27, 1999. I've read this. I also had a look at the recording of your speech about wine packaging at wineconf 2002. I've followed the indications of documentation/PACKAGING at lines 385-404, mainly for usability. > Feel free to copy the attached SuSE default make_fakewindows setup script I > use and the included minimalistic wine patch to loader/main.c. It all seems quite SuSE specific, anyway I haven't yet seen a script that works as well as winesetuptk, and there are complaints from time to time about helper scripts shiped with RPMs. Also a script doesn't give a user the freedom of choosing if he wants to use a real or a fake windows partition, and doesn't allow the user to chose where to have the fake windows partition, simply because it can't interact with the user. Nobody seems to be currently shipping winelauncher,and having a scipt to start wine isn't a great idea for a beta/stable build and ideally we want a long term solution. Bill Medland wrote: >I don't like the idea; I much prefer the idea of copying them from somewhere >in /etc, as redhat does. The default config file in /etc can then be >modified so that it matches the distribution (redhat have their cd at >/mnt/cdrom) and it can be modified by the sysadmin There is no need to add text files to the wine binary, but the default config should be modified on the fly. Some computers don't have a cd or a floppy, some have 2 cd drives, some don't use distro-standard paths, so drives should be detected on the fly, already we have enough logs from users full of /mnt/floppy not found and /mnt/cdrom not found, and it's not a great feature for 0.9 or 1.0. Winesetuptk does thit very very very well, I'm no engineer but I suppose that something written in tcltk can be easily ported to C. A binary package (But also a normal make install) should install configb and registry in /etc/wine or /usr/share/doc/wine-version/samples or something like that. The user should then start wine, that would look for $HOME/.wine, create it if necesarry, figure out the removable media paths, create a config file on the fly, write it to $HOME/.wine, run 'wine regedit path/to/winedefault.reg' and start normally.This does not require a script, will create a properly working config file, and the default configuration can be tweaked/restored with winecfg, once it's finished. Ivan.

1 0

Mouse usage when Wine not in focus
by Mark Knecht Dec. 17, 2003

Dec. 17, 2003

Hi, Please excuse me for bringing this question here. I'm not a developer. I have asked this in a couple of different forums but to date have received no answers. I will copy a message sent earlier this week to Wine-Users and hope for some insights on how to handle it. I have done some Googling around and run across numerous emails about mouse focus, but there doesn't seem to be anything in the Wine-HQ FAQ or Online Docs that tells me how to handle this. The basic issue in a nutshell - How do I configure Wine to not pay attention to the mouse when the Wine window is not in focus? Just in case it matters, I'm using fluxbox on all my systems, but I checked xfce4 and had the same problem. Thanks, Mark <SNIP> Hi, Is there a way to have mouse movements & positions not be sent to a Wine app when the Wine desktop is not the active window? I have looked through the online docs and the FAQ but I see nothing about this problem I'm having. I hope it's just a configuration issue, but I cannot find much info in the docs about mouse configuration at all. Also, I have seen this issue under Crossover Office and WineX, but have not had a chance to check Wine CVS yet, so if it's fixed or a non-issue just let me know. Thanks in advance. Under Windows I have played a game called Caesar 3 for years. Finally with some help from another wine user, I got it working perfectly (as far as I can tell) on Saturday using an ebuild of WineX on a Gentoo 2.4.20 kernel. The game plays well. I do have one problem when the game resolution and the Wine desktop are not the same size, but we can save that for another email if it's of interest to anyone. Anyway, the way the game works is that it has a play area for building your city. To move around this play area you drag your mouse to the edge of the board and the area scrolls inside the window. When playing the game under Wine, using the first config files I had with WineX and cxoffice that had "DXGrab" = "Y", the mouse stayed inside the Wine desktop and the game always worked fine, but I couldn't use the system for anything else unless I tricked Wine into letting my mouse escape from the desktop trap by using another window in the background. I then found the "DXGrab" option and changed it to "N" and I was able to get my mouse out of my Wine desktop and get email, etc. However, even when the Wine desktop and game are not in focus the mouse position is being fed to the game, so the game scrolls around underneath while I use items and applications on my desktop. How can I configure Wine to not send any mouse position information to the game when the game is not in focus? Right now I cannot take a meaningful screenshot since the game area is drifting around all the time. Thanks in advance, Mark <SNIP>

1 0

Re: Wine Status Page Pre-1
by Brian Vincent (C) Dec. 17, 2003

Dec. 17, 2003

> 3) Send to Brian V for WWN coverage :) (Brian if you want you can get a > early start) Hm. 1.7 meters of snow this week at Steamboat and I have the next three days off. I'm guessing I won't have much done until Monday. --------------- Brian Vincent Copper Mountain Telecom vincentb(a)coppercolorado.com

1 0

Input Focus problems with IE
by Aric Stewart Dec. 17, 2003

Dec. 17, 2003

Hello, I am working on a problem with IE where if you start the application in full screen mode: (start IE, change to full screen using view->full screen, shutdown IE, restart IE) the keyboard focus never gets given to the application so you cannot enter any information into forms. Looking into this i found that we where never being given any ClientMessage events to take focus nor any FocusIn events. So the keyboard focus remains on whatever app last had it, such as the terminal used to start IE. A very simple, shotgun, way to solve this is this attached patch. Thinking about windows architecture i was trying to think of a time where a window would receive a button click and would not be given input focus (yes the app may modify focus but it would do that anyway) However this change is HUGE and will affect alot and wanted to bounce it off people before continuing to investigate it. This look ok to people? Other ideas on proper ways to deal with this issue? thanks -aric Index: dlls/x11drv/event.c =================================================================== RCS file: /home/wine/wine/dlls/x11drv/event.c,v retrieving revision 1.30 diff -u -w -r1.30 event.c --- dlls/x11drv/event.c 5 Dec 2003 04:45:50 -0000 1.30 +++ dlls/x11drv/event.c 16 Dec 2003 19:02:57 -0000 @@ -287,6 +287,14 @@ break; case ButtonPress: + /* + * I am sort of unsure about this however + * there should not be a case where the button is clicked somewhere + * and windows does not assume focus is sent there. + * + * it also fixes a bunch of input problems for forms in IE + */ + set_focus(hWnd,CurrentTime); X11DRV_ButtonPress( hWnd, (XButtonEvent*)event ); break;

3 4

Re: default config file creation
by Ivan Leo Murray-Smith Dec. 17, 2003

Dec. 17, 2003

> If wine-c is stored uncompressed, it's easier for a site admin to modify > it for all its users. True, but this shouldn't be necessary. Also any global configuration should be done via winecfg. > Also, there are a couple places in Wine which are dependant on how the > underlying distribution is setup, things like menu entries and such. Not > every distro ship a vanilla Gnome or KDE (and then there are many > versions of each). Sure, after all I ship mime types files and menu entries for the mandrake menu system in mdk rpms, but I'm reluctant to change the actual application source code, because the same source should work for all (After all that's why we use autoconf), so if any changes are needed, they should go in the CVS, and consequentially end up in all packages Ivan.

1 0

Re: default config file creation
by Ivan Leo Murray-Smith Dec. 17, 2003

Dec. 17, 2003

>I was chatting with Rudolf Kastl(che on #winehq) and he was mentioning the >things that he was doing for the rpm package. One of the patches he applies >to wine prior to packaging it is a patch that creates local user config files >if they don't exist. His patches modify wine/libs/wine/config.c and wine/misc/registry.c, I don't see the need to change things, they could do if Alexandre accepts them in the CVS. They would uniform wine packaging, and make things easier, also wine-c could be a comprssed dir as it's only usility would be to be copied to $HOME, it doesn't really need to be uncompressed in /usr/share. Of course, all packagers could just apply these patches to binaries, but official packages should just ship vanilla wine (Otherwise why call them "official"?), so this depends on Alexandre. Ivan.

2 1

Re: Fix for Japanese Font Names
by Michael Stefaniuc Dec. 17, 2003

Dec. 17, 2003

Hi, could you please resubmit your diff using the unified output format? See http://www.winehq.org/site/sending_patches for details. bye michael On Wed, Dec 17, 2003 at 12:00:56PM +0900, Vik wrote: > May last patch had some wrong font names for Japanese resource files. > The correct name for MS UI Gothic is 'Gothic' in English, and not 'Gothic' in > Japanese. > > Changelog > + fixed MS UI Gothic Font names in: > dlls/commdlg/cdlg_Ja.rc > dlls/user/resources/user32_Ja.rc -- Michael Stefaniuc Tel.: +49-711-96437-199 System Administration Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

1 0

Re: Always add a \ to temp file path
by Steven Edwards Dec. 16, 2003

Dec. 16, 2003

There is a prepackaged binary that works great for me on slackware if you want it. Builing one from scratch is to much of a pain in the ass. http://www.libsdl.org/extras/win32/cross/README.txt Thanks Steven --- Mike Hearn <mike(a)theoretic.com> wrote: > The NullSoft installer assumes this will be present, so it most > likely > always is on Windows. When I get a cross compiler setup (soon, > promise!) > I'll try writing a test case for this behaviour. > > Mike Hearn <mike(a)theoretic.com> > Always add a \ to temp file path. Add a warning to DeleteFile. > > Index: files/file.c > =================================================================== > RCS file: /home/wine/wine/files/file.c,v > retrieving revision 1.196 > diff -u -r1.196 file.c > --- files/file.c 12 Dec 2003 04:10:52 -0000 1.196 > +++ files/file.c 16 Dec 2003 19:47:04 -0000 > @@ -921,10 +921,8 @@ > strcpyW( buffer, path ); > p = buffer + strlenW(buffer); > > - /* add a \, if there isn't one and path is more than just the > drive letter ... */ > - if ( !((strlenW(buffer) == 2) && (buffer[1] == ':')) > - && ((p == buffer) || (p[-1] != '\\'))) *p++ = '\\'; > - > + *p++ = '\\'; > + > for (i = 3; (i > 0) && (*prefix); i--) *p++ = *prefix++; > > unique &= 0xffff; > @@ -1556,7 +1554,11 @@ > return FALSE; > } > > - if (!DOSFS_GetFullName( path, TRUE, &full_name )) return FALSE; > + if (!DOSFS_GetFullName( path, TRUE, &full_name )) > + { > + WARN("Unable to get full name from %s\n", debugstr_w(path)); > + return FALSE; > + } > > /* check if we are allowed to delete the source */ > hFile = FILE_CreateFile( full_name.long_name, > GENERIC_READ|GENERIC_WRITE, 0, > > > __________________________________ Do you Yahoo!? New Yahoo! Photos - easier uploading and sharing. http://photos.yahoo.com/

1 0

Re: Fix kernel heap test
by Dimitrie O. Paun Dec. 16, 2003

Dec. 16, 2003

On December 15, 2003 10:35 am, Hans Leidekker wrote: > The test succeeds on Wine. This is wrong of course, tests should > always succeed on Windows and either succeed on Wine or fail on > Wine and be marked todo_wine. Great, thanks for catching this. Our current implementation seems to be freeing memory on size=0, how can we check what Windows does? If it doesn't, we can just simpligy the code to this: Index: dlls/kernel/heap.c =================================================================== RCS file: /var/cvs/wine/dlls/kernel/heap.c,v retrieving revision 1.4 diff -u -r1.4 heap.c --- dlls/kernel/heap.c 27 Nov 2003 00:59:36 -0000 1.4 +++ dlls/kernel/heap.c 15 Dec 2003 16:19:04 -0000 @@ -615,37 +614,15 @@ SetLastError(ERROR_INVALID_HANDLE); } else #endif - if(size!=0) - { - hnew=hmem; - if(pintern->Pointer) - { - if((palloc = HeapReAlloc(GetProcessHeap(), heap_flags, - (char *) pintern->Pointer-HGLOBAL_STORAGE, - size+HGLOBAL_STORAGE)) == NULL) - hnew = 0; /* Block still valid */ - else - pintern->Pointer = (char *)palloc+HGLOBAL_STORAGE; - } - else - { - if((palloc=HeapAlloc(GetProcessHeap(), heap_flags, size+HGLOBAL_STORAGE)) - == NULL) - hnew = 0; - else - { - *(HGLOBAL *)palloc = hmem; - pintern->Pointer = (char *)palloc + HGLOBAL_STORAGE; - } - } - } + if(size == 0) size = 16; + hnew=hmem; + if(pintern->Pointer) palloc = HeapAlloc(GetProcessHeap(), heap_flags, size+HGLOBAL_STORAGE); + else palloc = HeapReAlloc(GetProcessHeap(), heap_flags, (char *) pintern->Pointer-HGLOBAL_STORAGE, size+HGLOBAL_STORAGE); + if (!palloc) hnew = 0; else { - if(pintern->Pointer) - { - HeapFree(GetProcessHeap(), 0, (char *) pintern->Pointer-HGLOBAL_STORAGE); - pintern->Pointer=NULL; - } + pintern->Pointer = (char *)palloc + HGLOBAL_STORAGE; + if (!pintern->Pointer) *(HGLOBAL *)palloc = hmem; } } } -- Dimi.

2 1