- Wine-Devel - list.winehq.org

Re: msdos/int21 CREAT special cases
by Andreas Mohr May 28, 2003

May 28, 2003

On Mon, May 26, 2003 at 01:04:49PM +0200, Ferenc Wagner wrote: > Volume label creation should fail, not create a regular file. > Similarly for file names ending in a slash (this is actually > needed for PKSFX Version 2.04g to unpack directory trees). > > Feri. > > Index: msdos/int21.c > =================================================================== > RCS file: /home/wine/wine/msdos/int21.c,v > retrieving revision 1.93 > diff -u -r1.93 int21.c > --- msdos/int21.c 19 May 2003 21:40:05 -0000 1.93 > +++ msdos/int21.c 26 May 2003 10:48:21 -0000 > @@ -474,8 +474,18 @@ > } > static BOOL INT21_CreateFile( CONTEXT86 *context ) > { > - SET_AX( context, _lcreat16( CTX_SEG_OFF_TO_LIN(context, context->SegDs, > - context->Edx ), CX_reg(context) ) ); > + LPCSTR path=CTX_SEG_OFF_TO_LIN(context, context->SegDs, context->Edx); > + > + if (CX_reg(context) == 0x0008) { > + SetLastError( ERROR_ACCESS_DENIED ); > + return TRUE; > + } > + if (path[strlen(path)-1] == '/') > + { > + SetLastError( ERROR_FILE_NOT_FOUND ); > + return TRUE; > + } > + SET_AX( context, _lcreat16( path, CX_reg(context) ) ); > return (AX_reg(context) == (WORD)HFILE_ERROR16); > } Hmm, and is there a reason to not do it in _lcreat16() instead? Or is _lcreat16() really "clever" enough to handle volume labels "properly" if called directly? Somehow I doubt it... ;) Or in fact you could walk further up the chain and maybe find that even _lcreat() should be the function to have that check instead... (or, for that matter, even CreateFileA and thus CreateFileW...) So my rough guess is that this should probably be prevented in CreateFileW instead even. -- Andreas Mohr Stauferstr. 6, D-71272 Renningen, Germany Tel. +49 7159 800604 http://mohr.de.tt

2 1

kernel32 file operations and wildcard filenames
by Rolf Kalbermatter May 28, 2003

May 28, 2003

Having done some tests on kernel32.dll file functions I have come across a problem with filenames containing wildcards. Under Windows (2K) all functions such as DeleteFile, CopyFile, MoveFile, CreateDirectory and such do return FALSE and normally set the last error to ERROR_INVALID_NAME (123) if one of the filenames passed in contains a wildcard (*?). Wines kernel32 behaves somewhat different. Apart from returning different last errors in most cases such as: DeleteFile: ERROR_FILE_NOT_FOUND (2) CopyFile: ERROR_BAD_PATHNAME (161) MoveFile: ERROR_FILE_NOT_FOUND (2) when source contains wildcards which all wouldn't really be a to big issue, there is one thing which seems not right at all to me: MoveFile with a valid existing source and a target with wildcards will create a file on disk containing wildcards in its name. This certainly can't be the intention! So according to Win2K it would be probably useful to check in all those functions for existence of wildcards in the input file paths and refuse them properly. I took a look at the kernel32 file.c functions and saw that they usually all call DOSFS_GetFullName which is supposed to check for valid filenames and such. Problem is this function is also used in many other places and I can't get a good idea if those might need to accept wildcards in file names. Is there anyone more familiar with the kernel32 implementation in Wine who could maybe give me some insight if an according change to DOSFS_GetFullName would be useful or rather cause possible regressions? Otherwise the best thing to do would probably be to add explicit wildcard tests to all those file function and refuse with an according last error set. If I do not get any reactions this is probably what I will do as I'm somewhat weary to change an internal low level function such as DOSFS_GetFullName without some third party encouragement. Rolf Kalbermatter PS: Other differences I saw, where that Wines MoveFile explicitedly forbids directories as source with ERROR_ACCESS_DENIED (5) whereas tests under W2K show that MoveFile happily will rename directories on the same volume, inde- pendant if they are empty or not. CopyFile under W2K however will complain with above error ERROR_ACCESS_DENIED (5) for directories as source. Maybe a possible mix up?

1 0

was cvs diff now .. future cvs patch
by Tom May 28, 2003

May 28, 2003

Hello, Does everyone here agree with Dimi's suggestion to add : "If you work over a slow link, you may want to compress the traffic with -z3. However, there are known bugs in CVS with this compressed communication mode, make sure you use cvs version 1.11.5 or later." Just thought I would ask before I sent the patch :)) Tom

1 0

Wine Run error
by 朱剑民 May 28, 2003

May 28, 2003

I have installed wine on Linux redhat 9.0. I want install Ms office and OICQ, but when i run: wine ***.exe occuring the "SYSDEPS_SpawnThread" and stop, someone can tell me why??? If the redhat 9.0 could support wine very well??? Thanks Kevin

1 0

Re: Listview alignment fix
by biggun from the sun May 27, 2003

May 27, 2003

1 0

Re: little WWN problem
by Brian Vincent (C) May 27, 2003

May 27, 2003

> How come "The top 5 posters of the week" are almost always screwed up: Because people like you post from two email accounts. When I generate the stats it considers each email address a unique name. So stats get generated for both email addresses. When Jeremy parses the XML he looks for something like the person who had the most posts and finds the correct person but sometimes the stats that get returned are for the last entry in the xml file. If you look at the xml file you'll probably notice right away what it's doing. The scripts I generate stats from are fairly intelligent in how they parse everything, but for people who post from more than one account I have to know the offending names and have sed fix it up. --------------- Brian Vincent Copper Mountain Telecom vincentb(a)coppercolorado.com

1 0

Re: Fix crash in WritePrivateProfileString
by Dimitrie O. Paun May 27, 2003

May 27, 2003

On Tue, 27 May 2003, Thomas Charbonnel wrote: > Hi, > > This fixes a crash in WritePrivateProfileString when the lpFileName > parameter was NULL. The behaviour is modeled after what I tested on > Windows machines: 9x/Me returns FALSE and nothing is done, NT/2K/XP > attempts to write the entry in the win.ini file and returns the > appropriate value. I think it's way too complicated for no good reason. Just do what NT does: if (!filename) filename = wininiW; It's just one line vs. 10+. -- Dimi.

1 0

Re: Listview alignment fix
by Dimitrie O. Paun May 27, 2003

May 27, 2003

On May 26, 2003 05:48 pm, BiGgUn wrote: > Fix label alignment with icon bottom. Sorry, I know I said it's OK in private, but now thinking about it some more, I realize it's not right. What if the text size changes? Does this work for you: Index: dlls/comctl32/listview.c =================================================================== RCS file: /var/cvs/wine/dlls/comctl32/listview.c,v retrieving revision 1.353 diff -u -r1.353 listview.c --- dlls/comctl32/listview.c 22 May 2003 03:37:10 -0000 1.353 +++ dlls/comctl32/listview.c 26 May 2003 22:57:01 -0000 @@ -347,7 +347,7 @@ /* Standard DrawText flags */ #define LV_ML_DT_FLAGS (DT_TOP | DT_NOPREFIX | DT_EDITCONTROL | DT_CENTER | DT_WORDBREAK | DT_WORD_ELLIPSIS | DT_END_ELLIPSIS) #define LV_FL_DT_FLAGS (DT_TOP | DT_NOPREFIX | DT_EDITCONTROL | DT_CENTER | DT_WORDBREAK | DT_NOCLIP) -#define LV_SL_DT_FLAGS (DT_TOP | DT_EDITCONTROL | DT_SINGLELINE | DT_WORD_ELLIPSIS | DT_END_ELLIPSIS) +#define LV_SL_DT_FLAGS (DT_BOTTOM | DT_EDITCONTROL | DT_SINGLELINE | DT_WORD_ELLIPSIS | DT_END_ELLIPSIS) /* The time in milliseconds to reset the search in the list */ #define KEY_DELAY 450 -- Dimi.

3 2

Application crashes (something to do with OLE 16/32 split)
by Hongli Lai May 27, 2003

May 27, 2003

I'm using the app Powersim (a Win 3.1 app). It loads fine but when I open an app it crashes. Mike Hearn said it may have got something to do with the OLE 16/32 split. Here's the full output: [hongli(a)izumi Pslite]$ wine POWERSIM.EXE fixme:reg:_nt_dump_lf unknown Win XP node id 0x686c: do we need to add support for it ? fixme:reg:_nt_dump_lf unknown Win XP node id 0x686c: do we need to add support for it ? fixme:reg:_nt_dump_lf unknown Win XP node id 0x686c: do we need to add support for it ? fixme:ole:CoRegisterClassObject16 ({30774246-086C-101B-9E18-04021C007002},0x41377e88,0x00000004,0x00000001,0x412a3ef0),stub fixme:ole:CoRegisterMessageFilter16 (0x412ee128,(nil)),stub! fixme:ole:CoLockObjectExternal16 (0x9570024,1,0),stub! fixme:ole:CoLockObjectExternal16 (0x9570024,1,0),stub! fixme:mdi:MDIRefreshMenu partially function stub fixme:ole:CoLockObjectExternal16 (0x9570030,1,0),stub! >>>>> here's when I open a project! fixme:seh:EXC_RtlRaiseException call to unimplemented function storage.dll.IStream16_Stat wine: Unhandled exception, starting debugger... WineDbg starting on pid 8 Loaded debug information from ELF 'wine' ((nil)) Breakpoint 1 at 0x4000d61c (_end+0x400bef0) Loaded debug information from ELF '/usr/local/wine/lib/libntdll.dll.so' (0x40017000) Loaded debug information from ELF '/usr/local/wine/lib/libwine.so.1' (0x40118000) Loaded debug information from ELF '/usr/local/wine/lib/libwine_unicode.so.1' (0x40130000) Loaded debug information from ELF '/lib/libc.so.6' (0x4022b000) Loaded debug information from ELF '/lib/libm.so.6' (0x40362000) Loaded debug information from ELF '/lib/libdl.so.2' (0x40384000) Loaded debug information from ELF '/lib/ld-linux.so.2' (0x40000000) Loaded debug information from ELF '/lib/libnss_files.so.2' (0x40388000) Loaded debug information from ELF '/usr/local/wine/lib/wine/winevdm.exe.so' (0x40211000) Loaded debug information from ELF '/usr/local/wine/lib/wine/winedos.dll.so' (0x406d3000) Loaded debug information from ELF '/usr/local/wine/lib/wine/user32.dll.so' (0x40714000) Loaded debug information from ELF '/usr/local/wine/lib/wine/gdi32.dll.so' (0x4085a000) Loaded debug information from ELF '/usr/local/wine/lib/wine/advapi32.dll.so' (0x408df000) Loaded debug information from ELF '/usr/local/wine/lib/wine/kernel32.dll.so' (0x4090e000) No debug information in ELF '/usr/lib/libfreetype.so.6' (0x409ec000) No debug information in ELF '/usr/lib/libz.so.1' (0x40a42000) Loaded debug information from ELF '/usr/local/wine/lib/wine/x11drv.dll.so' (0x40a50000) No debug information in ELF '/usr/X11R6/lib/libSM.so.6' (0x40393000) No debug information in ELF '/usr/X11R6/lib/libICE.so.6' (0x40ac3000) No debug information in ELF '/usr/X11R6/lib/libXext.so.6' (0x40ada000) No debug information in ELF '/usr/X11R6/lib/libX11.so.6' (0x40ae8000) No debug information in ELF '/usr/lib/libGL.so.1' (0x40bde000) No debug information in ELF '/usr/X11R6/lib/libXmu.so.6' (0x40db2000) No debug information in ELF '/usr/X11R6/lib/libXi.so.6' (0x40dc8000) No debug information in ELF '/usr/X11R6/lib/libXt.so.6' (0x40dd0000) No debug information in ELF '/usr/X11R6/lib/libXrender.so.1' (0x40e1c000) Loaded debug information from ELF '/lib/libgcc_s.so.1' (0x40e24000) Loaded debug information from ELF '/usr/local/wine/lib/wine/mmsystem.dll.so' (0x40e40000) Loaded debug information from ELF '/usr/local/wine/lib/wine/wineoss.drv.so' (0x40eae000) Loaded debug information from ELF '/usr/local/wine/lib/wine/msacm.drv.so' (0x409d2000) Loaded debug information from ELF '/usr/local/wine/lib/wine/msacm32.dll.so' (0x40ef1000) Loaded debug information from ELF '/usr/local/wine/lib/wine/midimap.drv.so' (0x41030000) Loaded debug information from ELF '/usr/local/wine/lib/wine/commdlg.dll.so' (0x413a0000) Loaded debug information from ELF '/usr/local/wine/lib/wine/shell32.dll.so' (0x4141f000) Loaded debug information from ELF '/usr/local/wine/lib/wine/ole32.dll.so' (0x414ab000) Loaded debug information from ELF '/usr/local/wine/lib/wine/rpcrt4.dll.so' (0x41528000) Loaded debug information from ELF '/usr/local/wine/lib/wine/shlwapi.dll.so' (0x41573000) Loaded debug information from ELF '/usr/local/wine/lib/wine/comctl32.dll.so' (0x415c6000) Loaded debug information from ELF '/usr/local/wine/lib/wine/winspool.drv.so' (0x4167a000) Loaded debug information from ELF '/usr/local/wine/lib/wine/ver.dll.so' (0x417b0000) Loaded debug information from ELF '/usr/local/wine/lib/wine/lz32.dll.so' (0x417cb000) No debug information in 32bit DLL 'C:\Program Files\Pslite\POWERSIM.EXE' (0x40220000) No debug information in 32bit DLL 'C:\WINDOWS\SYSTEM\NTDLL.DLL' (0x40040000) No debug information in 32bit DLL 'C:\WINDOWS\SYSTEM\KERNEL32.DLL' (0x40930000) No debug information in 32bit DLL 'C:\WINDOWS\SYSTEM\ADVAPI32.DLL' (0x408f0000) No debug information in 32bit DLL 'C:\WINDOWS\SYSTEM\GDI32.DLL' (0x40870000) No debug information in 32bit DLL 'C:\WINDOWS\SYSTEM\USER32.DLL' (0x40740000) No debug information in 32bit DLL 'C:\WINDOWS\SYSTEM\WINEDOS.DLL' (0x406e0000) No debug information in 32bit DLL 'C:\WINDOWS\SYSTEM\X11DRV.DLL' (0x40a60000) No debug information in 32bit DLL 'C:\WINDOWS\SYSTEM\WINMM.DLL' (0x40e50000) No debug information in 32bit DLL 'C:\WINDOWS\SYSTEM\WINEOSS.DRV' (0x40ec0000) No debug information in 32bit DLL 'C:\WINDOWS\SYSTEM\MSACM32.DLL' (0x40f00000) No debug information in 32bit DLL 'C:\WINDOWS\SYSTEM\MSACM.DRV' (0x409e0000) No debug information in 32bit DLL 'C:\WINDOWS\SYSTEM\MIDIMAP.DRV' (0x41040000) No debug information in 32bit DLL 'C:\WINDOWS\SYSTEM\RPCRT4.DLL' (0x41540000) No debug information in 32bit DLL 'C:\WINDOWS\SYSTEM\OLE32.DLL' (0x414c0000) No debug information in 32bit DLL 'C:\WINDOWS\SYSTEM\SHLWAPI.DLL' (0x41590000) No debug information in 32bit DLL 'C:\WINDOWS\SYSTEM\COMCTL32.DLL' (0x415d0000) No debug information in 32bit DLL 'C:\WINDOWS\SYSTEM\SHELL32.DLL' (0x41440000) No debug information in 32bit DLL 'C:\WINDOWS\SYSTEM\WINSPOOL.DRV' (0x41680000) No debug information in 32bit DLL 'C:\WINDOWS\SYSTEM\COMDLG32.DLL' (0x413b0000) No debug information in 32bit DLL 'C:\WINDOWS\SYSTEM\LZ32.DLL' (0x417d0000) No debug information in 32bit DLL 'C:\WINDOWS\SYSTEM\VERSION.DLL' (0x417c0000) Unhandled exception: unimplemented function storage.dll.IStream16_Stat called in 32-bit code (0x414d53b8). In 32-bit mode. Symbol __strtol_internal (0000:40384000) is invalid 0x414d53b8 (__wine_unimplemented+0x58 [storage.spec.c] in ole32.dll.so): subl $4,%esp Unable to open file storage.spec.c Wine-dbg>Wine-dbg>Wine-dbg>Wine-dbg>Wine-dbg>Wine-dbg>Wine-dbg>Wine-dbg> Wine-dbg>quit WineDbg terminated on pid 8 [hongli(a)izumi Pslite]$

5 8

Windows version handling
by Thomas Charbonnel May 27, 2003

May 27, 2003

Hi, I reported a crash some days ago, triggered when WritePrivateProfileString is called with a NULL lpFileName. I was advised to test windows' behaviour, which I did. The call behaves differently on Win9x/Me and WinNT/2K/XP. Should I model the patch after this ? If yes, is there an internal Wine mechanism to deal with windows versions, or should I just call GetVersionEx ? Thomas

3 2