- Wine-Devel - list.winehq.org

Wine's critical sections and reccursive enter...
by Lionel Ulmer May 26, 2003

May 26, 2003

Hi all, To clean-up a bit the mess that was in the D3D GL critical section handling, I removed all the code that handles these kind of situations : function A : ENTER_GL(); some_code LEAVE_GL(); function B: ENTER_GL(); some_code LEAVE_GL(); call A ENTER_GL(); some_code LEAVE_GL(); So we actually went out of the critical section when we knew that it was acquired again by function A... As, according to MSDN, the crit. sections are actually 'recursive' (ie that you need to leave them X times if you entered them X times and that entering an already held crit. section does not lock the application), I removed all the extraneous LEAVE / ENTER call around already protected functions (which is much nicer to the eye). The problem is that with that change, I start to get all sorts of time-outs of the X11 critical section. So are Wine's internal critical sections (like the X11 one) really recursive ? Lionel -- Lionel Ulmer - http://www.bbrox.org/

1 0

kernel/file test corrections
by Ferenc Wagner May 26, 2003

May 26, 2003

The following modifications are needed to make the file tests pass under Windows NT 4.0 SP6. I can not test other versions, please write back if anything is wrong. Feri. Index: dlls/kernel/tests/file.c =================================================================== RCS file: /home/wine/wine/dlls/kernel/tests/file.c,v retrieving revision 1.17 diff -u -r1.17 file.c --- dlls/kernel/tests/file.c 19 May 2003 21:50:32 -0000 1.17 +++ dlls/kernel/tests/file.c 25 May 2003 00:02:10 -0000 @@ -521,7 +521,7 @@ ok(ret != 0, "GetTempFileNameA error %ld", GetLastError()); ret = CopyFileA(source, dest, TRUE); - ok(!ret && GetLastError() == ERROR_FILE_EXISTS, + ok(!ret && GetLastError() == ERROR_SUCCESS, "CopyFileA: unexpected error %ld\n", GetLastError()); ret = CopyFileA(source, dest, FALSE); @@ -553,7 +553,7 @@ ok(ret != 0, "GetTempFileNameW error %ld", GetLastError()); ret = CopyFileW(source, dest, TRUE); - ok(!ret && GetLastError() == ERROR_FILE_EXISTS, + ok(!ret && GetLastError() == ERROR_SUCCESS, "CopyFileW: unexpected error %ld\n", GetLastError()); ret = CopyFileW(source, dest, FALSE); @@ -582,8 +582,8 @@ hFile = CreateFileA(filename, GENERIC_READ, 0, NULL, CREATE_NEW, FILE_FLAG_RANDOM_ACCESS, 0); - ok(hFile == INVALID_HANDLE_VALUE && GetLastError() == ERROR_FILE_EXISTS, - "CREATE_NEW should fail if file exists and last error value should be ERROR_FILE_EXISTS"); + ok(hFile == INVALID_HANDLE_VALUE && GetLastError() == ERROR_SUCCESS, + "CREATE_NEW should fail if file exists and last error value should be ERROR_SUCCESS"); ret = DeleteFileA(filename); ok(ret, "DeleteFileA: error %ld\n", GetLastError()); @@ -608,8 +608,8 @@ hFile = CreateFileW(filename, GENERIC_READ, 0, NULL, CREATE_NEW, FILE_FLAG_RANDOM_ACCESS, 0); - ok(hFile == INVALID_HANDLE_VALUE && GetLastError() == ERROR_FILE_EXISTS, - "CREATE_NEW should fail if file exists and last error value should be ERROR_FILE_EXISTS"); + ok(hFile == INVALID_HANDLE_VALUE && GetLastError() == ERROR_SUCCESS, + "CREATE_NEW should fail if file exists and last error value should be ERROR_SUCCESS"); ret = DeleteFileW(filename); ok(ret, "DeleteFileW: error %ld\n", GetLastError()); @@ -620,13 +620,11 @@ BOOL ret; ret = DeleteFileA(NULL); - ok(!ret && (GetLastError() == ERROR_INVALID_PARAMETER || - GetLastError() == ERROR_PATH_NOT_FOUND), + ok(!ret && GetLastError() == ERROR_SUCCESS, "DeleteFileA(NULL) returned ret=%d error=%ld",ret,GetLastError()); ret = DeleteFileA(""); - ok(!ret && (GetLastError() == ERROR_PATH_NOT_FOUND || - GetLastError() == ERROR_BAD_PATHNAME), + ok(!ret && GetLastError() == ERROR_SUCCESS, "DeleteFileA(\"\") returned ret=%d error=%ld",ret,GetLastError()); } @@ -638,11 +636,11 @@ ret = DeleteFileW(NULL); if (ret==0 && GetLastError()==ERROR_CALL_NOT_IMPLEMENTED) return; - ok(!ret && GetLastError() == ERROR_PATH_NOT_FOUND, + ok(!ret && GetLastError() == ERROR_SUCCESS, "DeleteFileW(NULL) returned ret=%d error=%ld",ret,GetLastError()); ret = DeleteFileW(emptyW); - ok(!ret && GetLastError() == ERROR_PATH_NOT_FOUND, + ok(!ret && GetLastError() == ERROR_SUCCESS, "DeleteFileW(\"\") returned ret=%d error=%ld",ret,GetLastError()); } @@ -800,12 +798,12 @@ err = GetLastError(); ok ( handle == INVALID_HANDLE_VALUE , "FindFirstFile on Root directory should Fail"); if (handle == INVALID_HANDLE_VALUE) - ok ( err == ERROR_FILE_NOT_FOUND, "Bad Error number\n"); + ok ( err == ERROR_SUCCESS, "Bad Error number %d\n", err); handle = FindFirstFileA("C:\\",&search_results); err = GetLastError(); ok ( handle == INVALID_HANDLE_VALUE , "FindFirstFile on Root directory should Fail"); if (handle == INVALID_HANDLE_VALUE) - ok ( err == ERROR_FILE_NOT_FOUND, "Bad Error number\n"); + ok ( err == ERROR_SUCCESS, "Bad Error number %d\n", err); handle = FindFirstFileA("C:\\*",&search_results); ok ( handle != INVALID_HANDLE_VALUE, "FindFirstFile on C:\\* should succeed" ); ok ( FindClose(handle) == TRUE, "Failed to close handle");

2 2

Re: Implement GetProcessPriorityBoost
by Dmitry Timoshkov May 26, 2003

May 26, 2003

"Lionel Ulmer" <lionel.ulmer(a)free.fr> wrote: +BOOL WINAPI GetProcessPriorityBoost(HANDLE hprocess,PBOOL pDisablePriorityBoost) +{ + FIXME("(%p,%p): semi-stub\n", hprocess, pDisablePriorityBoost); + + /* Report that no boost is present.. */ + *pDisablePriorityBoost = FALSE; I'm curious whether you need to test for pDisablePriorityBoost != NULL before setting its value... -- Dmitry.

2 3

File locking and Samba
by Mike Hearn May 25, 2003

May 25, 2003

Hi, Are there any known issues with file locking and samba? I've been talking to a guy on IRC who is running some kind of database app with some stuff remotely mounted via Samba (the same arrangement is used in windows). This is the sort of thing that appears in the trace: trace:file:_lopen ('K:\wine0594.GA2',0022) trace:file:CreateFileW L"K:\\wine0594.GA2" GENERIC_READ GENERIC_WRITE FILE_SHARE_READ OPEN_EXISTING attributes 0x0 warn:file:FILE_CreateFile Unable to create file '/usr/share/server/anp/wine0594.GA2' (GLE 32) trace:file:CreateFileW returning 0xffffffff Over and over. So code 32 is a sharing violation, which made me wonder about this. Am I on the right track? thanks -mike

1 0

winedbg hardware breakpoint
by Gerhard W. Gruber May 25, 2003

May 25, 2003

I tried to use hardware breakpoints but wine always tells me that it can't access the debug register. Are they not supported? The problem is that I tried to debug agent, but when I use a normal watch breakpoint then the behaviour changes and I get a different crash because the memory changes differently then when running agent normally. -- Gerhard Gruber Für jedes menschliche Problem gibt es immer eine einfache Lösung: Klar, einleuchtend und falsch. (Henry Louis Mencken)

1 0

Winedbg questions
by Gerhard W. Gruber May 25, 2003

May 25, 2003

When I using winedbg why doesn't it show me the sourcecode? It always says that the source is not availabel through a configured DOS drive. Does that mean I have to put the files in a path that will be accessible by wineWindows? When I try to debug agent I set a conditional breakpoint on WINPROC_CallWndProc. When the condition is hwnd == x then it works. When the condition is msg == x hten the breakpoint is never triggered, though it should because the backtrace tells me that the value, I set for the condition, has been used before that call. Either the backtrace is wrong or somehow winedbg misses the condition. -- Gerhard Gruber Für jedes menschliche Problem gibt es immer eine einfache Lösung: Klar, einleuchtend und falsch. (Henry Louis Mencken)

2 5

Re: Again GTA3 problems -- it is fully broken. Warcraft 3 as well.
by erwin wolff May 25, 2003

May 25, 2003

Hi, Thanks for the patches. Note that I haven't applied any previous patches. The description of the make errors is in dutch but at the bottom of the email is the translation of some error descriptions. I ran configure on RH9 with: ./configure --with-nptl --with-x > Please can you try attached patches (from current cvs) and say me what > happened ? I applied the patches and this was the result ;-( : [root(a)erwin d3d8]# make -i LD_LIBRARY_PATH="../../libs/unicode:$LD_LIBRARY_PATH" ../../tools/wrc/wrc --nostdinc -I. -I. -I../../include -I../../include -I/usr/X11R6/include -foversion.res version.rc gcc -c -I. -I. -I../../include -I../../include -I/usr/X11R6/include -D_REENTRANT -fPIC -D__WINESRC__ -Wall -mpreferred-stack-boundary=2 -gstabs+ -Wpointer-arith -g -O2 -o basetexture.o basetexture.c gcc -c -I. -I. -I../../include -I../../include -I/usr/X11R6/include -D_REENTRANT -fPIC -D__WINESRC__ -Wall -mpreferred-stack-boundary=2 -gstabs+ -Wpointer-arith -g -O2 -o cubetexture.o cubetexture.c gcc -c -I. -I. -I../../include -I../../include -I/usr/X11R6/include -D_REENTRANT -fPIC -D__WINESRC__ -Wall -mpreferred-stack-boundary=2 -gstabs+ -Wpointer-arith -g -O2 -o d3d8_main.o d3d8_main.c gcc -c -I. -I. -I../../include -I../../include -I/usr/X11R6/include -D_REENTRANT -fPIC -D__WINESRC__ -Wall -mpreferred-stack-boundary=2 -gstabs+ -Wpointer-arith -g -O2 -o device.o device.c device.c: In function `DrawPrimitiveI': device.c:604: warning: impliciete declaratie van functie `glSecondaryColor3fvEXT' device.c:826: warning: impliciete declaratie van functie `glSecondaryColorPointerEXT' device.c: In function `IDirect3DDevice8Impl_SetRenderState': device.c:3450: warning: impliciete declaratie van functie `glPointParameterfEXT' device.c:3491: warning: impliciete declaratie van functie `glPointParameterfvEXT' device.c:3522: `D3DCOLORWRITEENABLE_RED' is hier niet gedeclareerd (eerste gebruik in deze functie) device.c:3522: (Elke niet-gedeclareerde naam wordt slechts één device.c:3522: keer vermeld voor elke functie waarin hij staat.) device.c:3522: `D3DCOLORWRITEENABLE_GREEN' is hier niet gedeclareerd (eerste gebruik in deze functie) device.c:3522: `D3DCOLORWRITEENABLE_BLUE' is hier niet gedeclareerd (eerste gebruik in deze functie) device.c:3522: `D3DCOLORWRITEENABLE_ALPHA' is hier niet gedeclareerd (eerste gebruik in deze functie) device.c: In function `IDirect3DDevice8Impl_SetCurrentTexturePalette': device.c:4353: warning: impliciete declaratie van functie `glColorTableEXT' make: [device.o] Fout 1 (genegeerd) gcc -c -I. -I. -I../../include -I../../include -I/usr/X11R6/include -D_REENTRANT -fPIC -D__WINESRC__ -Wall -mpreferred-stack-boundary=2 -gstabs+ -Wpointer-arith -g -O2 -o directx.o directx.c gcc -c -I. -I. -I../../include -I../../include -I/usr/X11R6/include -D_REENTRANT -fPIC -D__WINESRC__ -Wall -mpreferred-stack-boundary=2 -gstabs+ -Wpointer-arith -g -O2 -o indexbuffer.o indexbuffer.c gcc -c -I. -I. -I../../include -I../../include -I/usr/X11R6/include -D_REENTRANT -fPIC -D__WINESRC__ -Wall -mpreferred-stack-boundary=2 -gstabs+ -Wpointer-arith -g -O2 -o resource.o resource.c gcc -c -I. -I. -I../../include -I../../include -I/usr/X11R6/include -D_REENTRANT -fPIC -D__WINESRC__ -Wall -mpreferred-stack-boundary=2 -gstabs+ -Wpointer-arith -g -O2 -o shader.o shader.c gcc -c -I. -I. -I../../include -I../../include -I/usr/X11R6/include -D_REENTRANT -fPIC -D__WINESRC__ -Wall -mpreferred-stack-boundary=2 -gstabs+ -Wpointer-arith -g -O2 -o stateblock.o stateblock.c gcc -c -I. -I. -I../../include -I../../include -I/usr/X11R6/include -D_REENTRANT -fPIC -D__WINESRC__ -Wall -mpreferred-stack-boundary=2 -gstabs+ -Wpointer-arith -g -O2 -o surface.o surface.c gcc -c -I. -I. -I../../include -I../../include -I/usr/X11R6/include -D_REENTRANT -fPIC -D__WINESRC__ -Wall -mpreferred-stack-boundary=2 -gstabs+ -Wpointer-arith -g -O2 -o swapchain.o swapchain.c gcc -c -I. -I. -I../../include -I../../include -I/usr/X11R6/include -D_REENTRANT -fPIC -D__WINESRC__ -Wall -mpreferred-stack-boundary=2 -gstabs+ -Wpointer-arith -g -O2 -o texture.o texture.c gcc -c -I. -I. -I../../include -I../../include -I/usr/X11R6/include -D_REENTRANT -fPIC -D__WINESRC__ -Wall -mpreferred-stack-boundary=2 -gstabs+ -Wpointer-arith -g -O2 -o vertexbuffer.o vertexbuffer.c gcc -c -I. -I. -I../../include -I../../include -I/usr/X11R6/include -D_REENTRANT -fPIC -D__WINESRC__ -Wall -mpreferred-stack-boundary=2 -gstabs+ -Wpointer-arith -g -O2 -o volume.o volume.c gcc -c -I. -I. -I../../include -I../../include -I/usr/X11R6/include -D_REENTRANT -fPIC -D__WINESRC__ -Wall -mpreferred-stack-boundary=2 -gstabs+ -Wpointer-arith -g -O2 -o volumetexture.o volumetexture.c gcc -c -I. -I. -I../../include -I../../include -I/usr/X11R6/include -D_REENTRANT -fPIC -D__WINESRC__ -Wall -mpreferred-stack-boundary=2 -gstabs+ -Wpointer-arith -g -O2 -o vshaderdeclaration.o vshaderdeclaration.c gcc -c -I. -I. -I../../include -I../../include -I/usr/X11R6/include -D_REENTRANT -fPIC -D__WINESRC__ -Wall -mpreferred-stack-boundary=2 -gstabs+ -Wpointer-arith -g -O2 -o utils.o utils.c ../../tools/winebuild/winebuild -D_REENTRANT -fPIC -D__WINESRC__ -o d3d8.dll.dbg.c --debug -C. basetexture.c cubetexture.c d3d8_main.c device.c directx.c indexbuffer.c resource.c shader.c stateblock.c surface.c swapchain.c texture.c vertexbuffer.c volume.c volumetexture.c vshaderdeclaration.c utils.c gcc -c -I. -I. -I../../include -I../../include -I/usr/X11R6/include -D_REENTRANT -fPIC -D__WINESRC__ -Wall -mpreferred-stack-boundary=2 -gstabs+ -Wpointer-arith -g -O2 -o d3d8.dll.dbg.o d3d8.dll.dbg.c ld -r basetexture.o cubetexture.o d3d8_main.o device.o directx.o indexbuffer.o resource.o shader.o stateblock.o surface.o swapchain.o texture.o vertexbuffer.o volume.o volumetexture.o vshaderdeclaration.o utils.o d3d8.dll.dbg.o -o d3d8.dll.tmp.o ld: cannot open device.o: Onbekend bestand of map make: [d3d8.dll.tmp.o] Fout 1 (genegeerd) strip --strip-unneeded d3d8.dll.tmp.o strip: d3d8.dll.tmp.o: Onbekend bestand of map make: [d3d8.dll.tmp.o] Fout 1 (genegeerd) ../../tools/winebuild/winebuild -D_REENTRANT -fPIC -D__WINESRC__ -o d3d8.spec.c --spec ./d3d8.spec version.res d3d8.dll.tmp.o -L../../dlls -luser32 -lgdi32 -lkernel32 Cannot open d3d8.dll.tmp.o : No such file or directory make: [d3d8.spec.c] Fout 1 (genegeerd) gcc -c -I. -I. -I../../include -I../../include -I/usr/X11R6/include -D_REENTRANT -fPIC -D__WINESRC__ -Wall -mpreferred-stack-boundary=2 -gstabs+ -Wpointer-arith -g -O2 -o d3d8.spec.o d3d8.spec.c gcc: d3d8.spec.c: Onbekend bestand of map gcc: no input files make: [d3d8.spec.o] Fout 1 (genegeerd) gcc -shared -Wl,-Bsymbolic,-z,defs d3d8.spec.o basetexture.o cubetexture.o d3d8_main.o device.o directx.o indexbuffer.o resource.o shader.o stateblock.o surface.o swapchain.o texture.o vertexbuffer.o volume.o volumetexture.o vshaderdeclaration.o utils.o d3d8.dll.dbg.o -o d3d8.dll.so -L../../dlls -L../../libs/wine -lwine -L../../libs/uuid -lwine_uuid -L/usr/X11R6/lib -lSM -lICE -lXxf86dga -lXxf86vm -lXv -lXext -lX11 -lGL -lGLU -L../../libs/port -lwine_port -lm -lc gcc: d3d8.spec.o: Onbekend bestand of map gcc: device.o: Onbekend bestand of map make: [d3d8.dll.so] Fout 1 (genegeerd) Dutch: is hier niet gedeclareerd (eerste gebruik in deze functie) English: Not declared in this function (first use in function) Dutch: impliciete declaratie van functie `glSecondaryColor3fvEXT' English: Implicit declaration of function 'glSecondaryColor3fvEXT'

1 0

Windows Template Library (WTL) and Wine?
by Chris Russell May 25, 2003

May 25, 2003

Hello Folks, this is likely a stupid question but has anyone on this list had any experiences pro/con running Windows applications created using the Windows Template Library (WTL) under the Wine emulator? As WTL effectively reduces to straight GDI calls during C++ compilation, I can't imagine why it wouldn't work but am wondering if anyone has tried this and is willing to share their notes. TIA - Chris Russell

1 0

Re: PATCH: dlls/d3d8/device.c
by Lionel Ulmer May 25, 2003

May 25, 2003

> No, > alexandre haven't commited anything since 22 (i sent it the 24) And from what I know and what he said on the list, Alexandre is off for three weeks of vacations... So do not wait too much for many commits during this period of time (ie time to do incremental patches using 'patched' trees :-) ). Lionel -- Lionel Ulmer - http://www.bbrox.org/

1 0

Re: anyone had success with roller coaster tycoon2 ?
by Sylvain Petreolle May 25, 2003

May 25, 2003

The instructions are false, since there is no vxd support for dinputin Wine. Simply run "wine rct2.exe". This works, I tested the demo (not sure about he version though). There is a bug open about saved games. If you want to help us, see http://bugs.winehq.com/show_bug.cgi?id=358 no need to have dinput.dll nor dinput.vxd at all. --- "L. Friedman" <netllama(a)linux-sxs.org> a écrit : > I'm attempting to run Roller Coaster Tycoon2 under wine-20030508 per > these instructions: > http://appdb.winehq.com/appview.php?appId=265&versionId=1573 > > but i'm not having any luck. When i run "wine --dll dinput=n > Rct2.exe" > it fails with the error: > fixme:file:DEVICE_Open Unknown/unsupported VxD DINPUT.VXD. Try > setting > Windows version to 'nt40' or 'win31'. > > Anyone have any luck or suggestions? I'm using the Win98SE versions > of > dinput.dll and dinput.vxd if that matters. > > thanks! ===== Sylvain Petreolle (spetreolle at users dot sourceforge dot net) ICQ #170597259 No more War ! "What if tomorrow the War could be over ?" Morpheus, in "Reloaded". For the Law of Oil and Fire, Im an European that lives in France. For all my Brothers and friends, Im a human living on Earth. ___________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com

1 0