- Wine-Devel - list.winehq.org

Re: Fixes for makepath
by Dimitrie O. Paun Feb. 6, 2003

Feb. 6, 2003

On Thu, 6 Feb 2003 Warren_Baird(a)cimmetry.com wrote: > - TRACE("got %s %s %s %s\n", drive, directory, > - filename, extension); > + char tmpPath[MAX_PATH]; > + TRACE("got %s %s %s %s\n", > + drive ? drive : "", > + directory ? directory : "", > + filename ? filename : "", > + extension ? extension : ""); Please use debugstr_a instead, like so: TRACE("got %s %s %s %s\n", debugstr_a(drive), debugstr_a(directory)... -- Dimi.

1 0

Re: Winspool errors with notepad
by Sylvain Petreolle Feb. 6, 2003

Feb. 6, 2003

trace:winspool:AddPrinterA ((null),2,0x407c2c1c): stub trace:winspool:DEVMODEdupAtoW trace:winspool:AddPrinterW (L"",2,0x4026ac58) Following these debug messages, we see that the name of the server on which the server is installed changes fromNULL to "". Currently we dont support remote printers and the the name must be NULL otherwise the function fails. It lies into wine/dlls/winspool/info.c : if(pName != NULL) { ERR("pName = %s - unsupported\n", debugstr_w(pName)); SetLastError(ERROR_INVALID_PARAMETER); return 0; The file was updated to avoid HEAP_strdupAtoW calls. Matthew, could you look at this ? ===== Sylvain Petreolle spetreolle(a)users.sourceforge.net Fight against Spam ! http://www.euro.cauce.org/en/index.html ICQ #170597259 "Don't think you are. Know you are." Morpheus, in "Matrix". ___________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com

4 7

Re: Implement SelectPalette and RealizePalette in mfdrv
by Dmitry Timoshkov Feb. 6, 2003

Feb. 6, 2003

<Warren_Baird(a)cimmetry.com> wrote: > diff -ur clean/wine/objects/palette.c wine/objects/palette.c > --- clean/wine/objects/palette.c Wed Jan 29 15:31:13 2003 > +++ wine/objects/palette.c Fri Jan 31 12:47:21 2003 > @@ -674,6 +674,7 @@ > } > if (!(dc = DC_GetDCPtr( hdc ))) return 0; > prev = dc->hPalette; > + if (dc->funcs->pSelectPalette) hpal = dc->funcs->pSelectPalette( ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ here hpal is zeroed out. > dc->physDev, hpal, FALSE ); > dc->hPalette = hpal; ^^^^^^^^^^^^^^^^^^^ 1. The above code chunk always sets dc->hPalette to zero in the case of metafile dc. 2. It seems that most of your all patches are wrapped by your mailer. 3. Some of your patches use C++ comments. 4. Some of your patches use a C++ style of declaring variables in the arbitrary place of the function. Please fix all of the above and resend the affected patches. Thanks. -- Dmitry.

1 0

RE: WineConf 2003
by Patrik Stridvall Feb. 6, 2003

Feb. 6, 2003

> LinuxTag is my favorite so far, fwiw, as > 1) it looks fairly well organized and interesting in its own right Yes, this is of course both good and bad. Good because it is as you said intresting, bad because we might lose the Wine focus. This is that IMHO happend at LinuxKongress in Erlangen (2000?). Sure it was a very nice social gathering and I enjoyed it very much but compared to WineConf 2002 in San Diego it didn't really amount to very much. Productively speaking that is. While I personnally are very likely to show up anyway, we really should carefully plan what we should do, not just take it as is comes as happend at LinuxKongress 2000. > 2) it's not freezing cold like Espoo in February would be True. It is quite cold here in Sweden right now and Finland is usually colder. :-) > 3) it's in a German-speaking country (I didn't learn my Grandma's > Finnish too well, but I did learn my Grandpa's German!) True. However the biggest use of I had of the little German I know was reading the menu at the resturant. :-) You will do fine with just English. > 4) it's the least likely of the bunch to conflict with the > arrival of my first kid on 31 July, the first day of the > Edinburgh event :-) 5) "The 9th Annual International LinuxTag will take place at the Convention Center in the Messe at Karlsruhe, Germany. Karlsruhe is located in the southern part of Germany near Heidelberg and can be easily reached via Frankfurt International Airport and by rail." Since AFAIK most European major airports (and quite a few minor airports) have flights to Frankfurt it will presumably be easier and cheaper traveling to than most of the alternatives. Please note if somebody wishes to speak at the conferance: "Abstract submission deadline: February 21, 2003"

1 0

Compile Error in d3d8
by Uwe Bonnes Feb. 6, 2003

Feb. 6, 2003

Hallo, since about last week, wine compilation stops in d3d8: > device.o: In function `DrawPrimitiveI': > /home/bon/tmp/wine/compile/wine/dlls/d3d8/device.c:535: undefined reference to `glMultiTexCoord3f' > /home/bon/tmp/wine/compile/wine/dlls/d3d8/device.c:516: undefined reference to `glMultiTexCoord2f' > /home/bon/tmp/wine/compile/wine/dlls/d3d8/device.c:416: undefined reference to `glMultiTexCoord3f' I did a "make distclean" and the problem persists. Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

3 3

Re: Opengl Glide
by Kristoffer Ericson Feb. 6, 2003

Feb. 6, 2003

Greetings, I'm hoping we are nearing a solution, with so many people involved =) http://bugs.winehq.com/show_bug.cgi?id=1234 has been updated with logfiles and my small info. http://bugs.winehq.com/show_bug.cgi?id=1254 has been created with my info and logfiles. What other log files do you want? Best wishes >From: Lionel Ulmer <lionel.ulmer(a)free.fr> >To: Kristoffer Ericson <kristoffer_e1(a)hotmail.com> >CC: wine-devel(a)winehq.com >Subject: Re: Opengl Glide >Date: Wed, 5 Feb 2003 23:24:16 +0100 > > > Guilty as charged, been working on this thing for quite some time now. > >Well, can't find your bug report again... The latest open on Wine + Tribes >is not from you. > > > just send me the www link and i will upload the logs. > >If you can't find the bug anymore, raise two new ones (we will close the >old >ones when we find them :-) ). > >Or rather use this one for the dinput problem : > > http://bugs.winehq.com/show_bug.cgi?id=1234 > >If you can do for me the trace I asked at the end I would be happy :-) > > > Any idea, why Tribes don't detect opengl? i'm not familiar with any >other > > game that does this. Although i know that Tribes didn't support Opengl > > nativly but it added it with a patch later on. > >Well, for this, create a new bug and attach the +opengl,+relay,+x11drv log >I >requested. > > Lionel > >-- > Lionel Ulmer - http://www.bbrox.org/ _________________________________________________________________ The new MSN 8: smart spam protection and 2 months FREE* http://join.msn.com/?page=features/junkmail

1 0

RtlUpperChar (was: some ntdll functions) [Virus checked]
by thomas.mertes＠t-mobile.at Feb. 6, 2003

Feb. 6, 2003

"Dmitry Timoshkov" <dmitry(a)baikal.ru> wrote: > > IMHO RtlUpperChar has nothing to do for unicode chars. > > Is there a way to use Wine internal code page to do the conversion without > > converting to unicode and back? > > Wine has only unicode case conversion tables and currently there is no way > to avoid forth and back conversions. My solution for this is: /************************************************************************** * RtlUpperChar (NTDLL.@) */ CHAR WINAPI RtlUpperChar( CHAR ch ) { WCHAR wch; wch = toupperW(((WCHAR) ch) & 0xff); if (wch >> 8) { return ch; } else { return (CHAR) wch; } } This would mean: Some ISO Latin 1 characters would be converted additionally to 'a' .. 'z'. I did a test on w2k trying to convert all chars between 0 and 255. The result was: Just 'a' .. 'z' are converted to 'A' .. 'Z', all other characters remain unchanged. I switched the machine between 'EN' (English) and 'DE' (German) and no difference. May be this was the wrong place to switch the locale / code pages ... My guess is: RtlUpperChar does not take the locale into account. It always convertes just 'a' .. 'z' and nothing else. Is this the right direction or did I miss something? Greetings Thomas

3 2

controls\edit.c
by Dietrich_Teickner＠t-online.de Feb. 6, 2003

Feb. 6, 2003

Hi , I have found, the undo_buffer_size for the realoated undo_buffer in controls\edit.c was invalid remembered, it was one to high (alloc_size/sizeof(WCHAR)). It must be alloc_size/sizeof(WCHAR) - 1. After second realloc and many(32) delete backwards was the word after the undo_buffer overwritten. Has the first allocated undo_buffer_size the VALUE from 15, so is the VALUE from undo_buffer_size after reallocation 32, not 31. Dietrich (from odin) /********************************************************************* * * EDIT_MakeUndoFit * * Try to fit size + 1 bytes in the undo buffer. * */ static BOOL EDIT_MakeUndoFit(EDITSTATE *es, UINT size) { UINT alloc_size; if (size <= es->undo_buffer_size) return TRUE; TRACE("trying to ReAlloc to %d+1\n", size); alloc_size = ROUND_TO_GROW((size + 1) * sizeof(WCHAR)); if ((es->undo_text = HeapReAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, es->undo_text, alloc_size))) { es->undo_buffer_size = alloc_size/sizeof(WCHAR) - 1; ------------------------------------------------------------------> return TRUE; } else { WARN("FAILED ! We now have %d+1\n", es->undo_buffer_size); return FALSE; } }

1 0

remote app problem: menus go away at wrong time
by Dan Kegel Feb. 6, 2003

Feb. 6, 2003

I was sitting at my wife's XP machine with a spare five minutes, and it suddently came to me that I haven't done enough remote testing of Wine. So I ran wcmd cygwin startx ssh -X mybox ssh mylaptop wine spyxx.exe just to see how well wine would work via two ssh hops on top of x on top of cygwin on top of winxp. First issue: you can't use the menus with the mouse! Sure, they'll pop up, but when you move the mouse down to one of the menu items, the menu goes away. It decides the user really wanted to highlight the toolbar, or something. Before you say "Aw, nobody'll do that", consider that LTSP is getting a lot more popular... and last week a local small business owner I know asked me to help set up diskless Linux workstations to run his existing Windows apps. - Dan -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045

4 6

Re: fix generation of PolyPolygon in mfdrv
by Dan Kegel Feb. 6, 2003

Feb. 6, 2003

Warren, thanks for taking the time to submit all those patches! - Dan -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045

1 0