- Wine-Devel - list.winehq.org

RE: shell32: SHChangeNotify is really Unicode/ANSI indifferent
by Robert Shearman Jan. 20, 2003

Jan. 20, 2003

> From: "Rolf Kalbermatter" <r.kalbermatter(a)hccnet.nl> > To: <wine-patches(a)winehq.com> > Subject: shell32: SHChangeNotify is really Unicode/ANSI indifferent > Date: Mon, 20 Jan 2003 21:53:34 +0100 > Reply-To: wine-devel(a)winehq.com <snip> > -/**************************************************************** > ********* > - * SHChangeNotify [SHELL32.@] > - */ > -void WINAPI SHChangeNotifyA (LONG wEventId, UINT uFlags, > LPCVOID dwItem1, LPCVOID dwItem2) > +void WINAPI SHChangeNotify(LONG wEventId, UINT uFlags, LPCVOID > dwItem1, LPCVOID dwItem2) <snip> > + else if (uFlags & SHCNF_PATHW) > + { > + DWORD dummy; > + if (dwItem1) SHILCreateFromPathW((LPCSTR)dwItem1, > &Pidls[0], &dummy); > + if (dwItem2) SHILCreateFromPathW((LPCSTR)dwItem2, > &Pidls[1], &dummy); > + } > + else if (uFlags & (SHCNF_PRINTERW || SHCNF_PRINTERW) There seems to be something strange with the line above (SHCNF_PRINTERW || SHCNF_PRINTERW) == SHCNF_PRINTERW. Should this be (SHCNF_PRINTERW || SHCNF_PRINTERA) by any chance? > + { > + FIXME("SHChangeNotify with (uFlags & SHCNF_PRINTER)"); > } Other than that, good work! Rob

2 1

trouble with winmm/tests and winearts.drv
by Greg Turner Jan. 20, 2003

Jan. 20, 2003

Linux 2.5.59 seems to have broken my ALSA. Rather than worry about fixing it, I guessed that "just waiting" will fix the problem as future releases of either gentoo or linux would probably eventually resolve whatever conflict I have. So, temporarily, I have put aRTS into "OSS/threaded" mode. This successfully uses ALSA's OSS emulation. Then, I activated winearts.drv to use that instead of my usual ALSA. Now, when I run make test, I get a failure. Here's some output: greg(a)yodull tests $ pwd /var/src/wine/dlls/winmm/tests greg(a)yodull tests $ wine winmm_test.exe.so wave mcop warning: user defined signal handler found for SIG_PIPE, overriding err:wave:ARTS_WaveInit arts_init() failed (-1) wave.c:182:found 10 WaveOut devices wave.c:206: 0: "" 0.0 (0:0): channels=0 formats=0000 support=0000 wave.c:220:Testing invalid 2MHz format wave.c:229: Test failed: opening the device at 2MHz should fail 0: rc=4 wave.c:248: Test failed: opening the device at 2MHz should fail 0: rc=4 wave.c:206: 1: "" 0.0 (0:0): channels=0 formats=0000 support=0000 wave.c:220:Testing invalid 2MHz format wave.c:229: Test failed: opening the device at 2MHz should fail 1: rc=4 wave.c:248: Test failed: opening the device at 2MHz should fail 1: rc=4 wave.c:206: 2: "" 0.0 (0:0): channels=0 formats=0000 support=0000 wave.c:220:Testing invalid 2MHz format wave.c:229: Test failed: opening the device at 2MHz should fail 2: rc=4 wave.c:248: Test failed: opening the device at 2MHz should fail 2: rc=4 wave.c:206: 3: "" 0.0 (0:0): channels=0 formats=0000 support=0000 wave.c:220:Testing invalid 2MHz format wave.c:229: Test failed: opening the device at 2MHz should fail 3: rc=4 wave.c:248: Test failed: opening the device at 2MHz should fail 3: rc=4 wave.c:206: 4: "" 0.0 (0:0): channels=0 formats=0000 support=0000 wave.c:220:Testing invalid 2MHz format wave.c:229: Test failed: opening the device at 2MHz should fail 4: rc=4 wave.c:248: Test failed: opening the device at 2MHz should fail 4: rc=4 wave.c:206: 5: "" 0.0 (0:0): channels=0 formats=0000 support=0000 wave.c:220:Testing invalid 2MHz format wave.c:229: Test failed: opening the device at 2MHz should fail 5: rc=4 wave.c:248: Test failed: opening the device at 2MHz should fail 5: rc=4 wave.c:206: 6: "" 0.0 (0:0): channels=0 formats=0000 support=0000 wave.c:220:Testing invalid 2MHz format wave.c:229: Test failed: opening the device at 2MHz should fail 6: rc=4 wave.c:248: Test failed: opening the device at 2MHz should fail 6: rc=4 wave.c:206: 7: "" 0.0 (0:0): channels=0 formats=0000 support=0000 wave.c:220:Testing invalid 2MHz format wave.c:229: Test failed: opening the device at 2MHz should fail 7: rc=4 wave.c:248: Test failed: opening the device at 2MHz should fail 7: rc=4 wave.c:206: 8: "" 0.0 (0:0): channels=0 formats=0000 support=0000 wave.c:220:Testing invalid 2MHz format wave.c:229: Test failed: opening the device at 2MHz should fail 8: rc=4 wave.c:248: Test failed: opening the device at 2MHz should fail 8: rc=4 wave.c:206: 9: "" 0.0 (0:0): channels=0 formats=0000 support=0000 wave.c:220:Testing invalid 2MHz format wave.c:229: Test failed: opening the device at 2MHz should fail 9: rc=4 wave.c:248: Test failed: opening the device at 2MHz should fail 9: rc=4 wave: 32 tests executed, 0 marked as todo, 20 failures. The code from winearts doesn't seem to check the frequency at all. Could this be because it's legitimately supported under aRTS? Either the test is broken, or the driver is broken. I don't know which fix would be the correct one, kill the test, or add a minimum frequency in the driver... Also: It seems odd when test behavior changes due to changes in ~/.wine/config and/or the installed wine. This happened for my RPC tests, although I was able to work around it. Shouldn't the tests always run the same way? Is it really acceptable to test things that may depend on the user's config and/or wine installation particulars? -- gmt "Everything that is really great and inspiring is created by the individual who can labor in freedom." --Albert Einstein

2 1

Re: resend: small DOS vga improvement
by Jukka Heinonen Jan. 20, 2003

Jan. 20, 2003

Christian Costa wrote: > Andreas Mohr wrote: > > So until there is further information about how to do it properly, > > I'll just remove the vga_refresh reset in the VGA_IsTimerRunning() case, > > and of course this makes Turbo Pascal 6 usable (although screen update is > > a bit slower than IDA, most likely due to using int 10h instead of video > > mem and also probing I/O port 0x3da). > > Sure it will help your app but others that need video sync will not work > properly. :-) > > In your case, VGA_Poll_Text is called periodicaly and should be running > at 33 fps. > Since 33 fps is just half the standard speed (70Hz), all should be fine. > But is VGA_Poll_Text running at 33 fps? > I suspect this function is too slow (maybe due to the console code). Well, after some trivial searching, I found out that VGA register 0x3da reports vertical retrace, horizontal retrace and some light pen stuff: 1xxx = Vertical retrace in progress if set x1xx = Light pen switched on xx1x = Light pen trigger set xxx1 = Either vertical or horizontal retrace in progress if set The original code emulated vertical retrace handling more or less correctly. The patch by Andreas Mohr on the other hand emulates horizontal retrace. Unfortunately, in both cases the other retrace is emulated incorrectly. And I have no idea what to do with light pen bits. So, Andreas, as you now know how to do it properly, can you prepare a patch that: - handles both vertical and horizontal retrace (and does something with light pen) - works even before any VGA mode has been initialized - includes the above documentation about 0x3da bits (so that the next person messing with 0x3da does have some starting point) - does not use inlines unless it really makes a difference (getting screen to update a few milliseconds faster is not worth making the patch longer) -- Jukka Heinonen <http://www.iki.fi/jhei/>

2 1

Re: Patch for Wine-20030115 heap allocation on Solaris 8 x86
by John Wehle Jan. 20, 2003

Jan. 20, 2003

> If you get any feedback about a proposed patch on the mailing > list, you need to deal with the feedback one way or another > before the patch will be applied. I'm familiar with that approach from other projects. Unfortunately I haven't received * any * feedback. However, I just did some digging in the wine-devel archive and I see Alexandre Julliard is having an ongoing discussion with Robert Lunnon regarding the Solaris ADDRESS_SPACE_LIMIT issue: http://www.winehq.com/hypermail/wine-devel/2003/01/0179.html so I guess I'll wait and see what Robert comes up with. -- John ------------------------------------------------------------------------- | Feith Systems | Voice: 1-215-646-8000 | Email: john(a)feith.com | | John Wehle | Fax: 1-215-540-5495 | | -------------------------------------------------------------------------

1 0

Re: allocate palette objects on the large heap.
by Christian Costa Jan. 20, 2003

Jan. 20, 2003

Rein Klazes wrote: >Hi, > >Girotel Offline creates 78 palette objects using 1044 bytes each. That >doesn't fit on the 16bit gdi heap. It is not a leak: each object is >freed when the program closes. Using NtObjects (www.smidgeonsoft.com) >shows that under NT2K the program creates the same number of palette >objects. > >Changelog: > > objects: gdiobj.c > Allocate palette objects on the large gdi heap. > >Rein. > > >------------------------------------------------------------------------ > >--- wine/objects/gdiobj.c 2002-12-03 20:18:41.000000000 +0100 >+++ mywine/objects/gdiobj.c 2003-01-19 14:09:46.000000000 +0100 >@@ -693,6 +693,7 @@ > case ENHMETAFILE_MAGIC: > case ENHMETAFILE_DC_MAGIC: > case BITMAP_MAGIC: >+ case PALETTE_MAGIC: > if (!(obj = alloc_large_heap( size, handle ))) goto error; > break; > } > SS2 was suffering the same problem and with your patch, it has gone. Great! :-) Thanks for the patch. Christian. PS: Does 16-bit apps that create palettes still work ?

1 0

Re: * Hack * for Wine-20030115 DOSFS_Hash on Solaris 8 x86
by John Wehle Jan. 20, 2003

Jan. 20, 2003

>> The enclosed * hack * allows wine photoed to load images. It is * not * >> the correct answer. One possible approach is to modify DOSFS_OpenDir_Normal >> to generate "proper" short names after it has read all the directory entries. > Hmm, somehow I don't think this is a proper solution. > The reasoning being that you probably have a Windows partition > in your Wine install with that ~1 path buried somewhere in the registry > or so. I do. > And IMHO if the registry contains such a setting (*from installation > only* - a program most likely wouldn't create a ~1 .3 shortcut pathname > on its own !), then we are SOL and probably should keep it like that instead > of adding hacks that probably don't improve the code a whole lot. Well ... the whole point of wine is compatibility, and in fact the existing code in wine to handle 8.3 names can be view as a hack for the sake of compatibility (long names good, 8.3 bad :-). All I'm suggesting is that the existing 8.3 code could be made more compatible. It's really unfortunate that Solaris (as far as I can tell) doesn't have a way reading the short filename from the DOS filesystem. -- John ------------------------------------------------------------------------- | Feith Systems | Voice: 1-215-646-8000 | Email: john(a)feith.com | | John Wehle | Fax: 1-215-540-5495 | | -------------------------------------------------------------------------

1 0

wrc arguements
by John Westerman Jan. 20, 2003

Jan. 20, 2003

Hi, Can anyone actually compile the minesweeper example with the current winemaker. Mine keeps failing when trying to convert the rc file using wrc. Is it possible the arguements winemaker generates are no longer correct for wrc. Thanks,

2 1

Re: Resubmission
by Eric POUECH Jan. 20, 2003

Jan. 20, 2003

different comments : - don't use C++ comments, not all C compilers understand them - it's better to split patches in small coherent pieces (in your last patch, msvideo issue has nothing to do with msacm) (disclaimer: since I won't be back to my PC until end of week, these answers are quick overviews of the patch, so don't take everything for granted) into the details : - msvideo: fix sounds correct - msacm: the path in format.c sounds correct. the hack around the PCM format was needed to get exactly what native msacm was giving as an expected results. basically, the driver was doing less than what it's supposed to do. it should be tested on native windows if the same is actually needed - msacm: regarding the Query flag, I don't think we need all your changes. If really windows accepts here a non NULL pointer, then a changing if ((fdwOpen & ACM_STREAMOPENF_QUERY) && phas) return MMSYSERR_INVALPARAM; info if ((fdwOpen & ACM_STREAMOPENF_QUERY) && phas) phas = NULL; would do. A+

1 0

Re: Re: Re: Some more thoughts on khtml
by fenix＠club-internet.fr Jan. 20, 2003

Jan. 20, 2003

>De: Adam Treat <manyoso(a)yahoo.com> >Sujet: Re: Re: Some more thoughts on khtml >A: Adam Treat <manyoso(a)yahoo.com> >Copie à: wine-devel(a)winehq.com, qt-interest(a)trolltech.com >Date: Mon, 20 Jan 2003 06:28:09 -0800 (PST) > >--- Adam Treat <manyoso(a)yahoo.com> wrote: >> >> --- fenix(a)club-internet.fr wrote: >> > >Why not just port the GPL version of Qt to Windows? The kde-cygwin project is doing that >> > And, i don't like the port idea, because trolltech use Qt under windows as main product, and >> > porting the GPL version to windows ... >> >> *sigh* yes, i agree this is a problem. I don't want to hurt Trolltech, I just wish Qt could be >> used as a GPL cross-platform lib. Am still looking for a creative solution that would work for >> both Trolltech and the community, so if anyone has any ideas... ;) > >hehe, maybe Trolltech could release a 'Shared Source' version of Qt for windows... It'd allow >people to try Qt (the latest version) and prohibit commercial software... After all, when on a >different platform 'do as the locals do' ;) As they have released a limited time free version for windows (only for non-commercial projects), i think they won't release a 'shared source' version :( Raphael

1 0

Re: rpc_K01-r1.diff
by Greg Turner Jan. 20, 2003

Jan. 20, 2003

On Monday 20 January 2003 09:33 am, Greg Turner wrote: > Note to Ove: widl_scraps.h contains those things that I needed, > but which were not generated by midl. correction: "not generated by /widl/." -- gmt "Everything that is really great and inspiring is created by the individual who can labor in freedom." --Albert Einstein

1 0