- Wine-Devel - list.winehq.org

Re: FW: shell32: SHChangeNotify is really Unicode/ANSI indifferent, take2
by Francois Gouget Jan. 21, 2003

Jan. 21, 2003

On Tue, 21 Jan 2003, Rolf Kalbermatter wrote: [...] > @@ -289,22 +257,11 @@ > LeaveCriticalSection(&SHELL32_ChangenotifyCS); > > /* if we allocated it, free it */ > - if(uFlags & SHCNF_PATHA) > + if (uFlags & SHCNF_PATHA || uFlags & SHCNF_PATHW) > { Just nitpicking (since Dimitrie is on vacation ;-): it's probably not necessary but I would be more confortable if the above test had more parentheses: > + if ((uFlags & SHCNF_PATHA) || (uFlags & SHCNF_PATHW)) -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ 145 = 1! + 4! + 5!

3 2

Re: 1995-era Microsoft MFCKIT installer fails to unpack one of its DLLs
by Dan Kegel Jan. 21, 2003

Jan. 21, 2003

lists.mrkidd(a)attbi.com wrote: > Does the file /home/dank/c/ms-setup.t/RBHEAP.DLL exist? In the first trace, it > looks like it gets created ok when the installer extracts it, but then when Wine > tries to load WBRUN20, and therefore RBHEAP.DLL, it fails to find the file. The first trace is running on XP on some other machine; it does create ms-setup.t/RBHEAP.DLL properly. The second trace is running on Wine; it does not create that file at all, from what I can see. - Dan -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045

3 3

Re: fonts go south halfway through OpenOffice1.0.2 install
by Greg Turner Jan. 21, 2003

Jan. 21, 2003

On Monday 20 January 2003 07:22 pm, Dan Kegel wrote: > Dan Kegel wrote: > 'all your chars are belong to box' hehehe -- gmt "Everything that is really great and inspiring is created by the individual who can labor in freedom." --Albert Einstein

1 0

Re: Re: Re: Some more thoughts on khtml
by fenix＠club-internet.fr Jan. 21, 2003

Jan. 21, 2003

>De: Adam Treat <manyoso(a)yahoo.com> >Sujet: Re: Re: Some more thoughts on khtml >A: fenix(a)club-internet.fr, jmayer(a)loplof.de >Copie à: wine-devel(a)winehq.com >Date: Mon, 20 Jan 2003 06:22:37 -0800 (PST) > > >--- fenix(a)club-internet.fr wrote: >> >Why not just port the GPL version of Qt to Windows? The kde-cygwin project is doing that right >.... >> I don't think it's a good idea :( >> Now, we only need a few classes and code for porting KWQ to windows specific code (and more >> platform optimised than Qt). >> While Qt need 10-15 huge base classes to be ported, and platform "tuning " on top level code >> (platform independent). >> >> And, i don't like the port idea, because trolltech use Qt under windows as main product, and >> porting the GPL version to windows ... > >*sigh* yes, i agree this is a problem. I don't want to hurt Trolltech, I just wish Qt could be >used as a GPL cross-platform lib. Am still looking for a creative solution that would work for >both Trolltech and the community, so if anyone has any ideas... ;) i don't have any :( >> In past, i have already done much of Qt (2.x version) porting under windows for a personal >> project. >> A first implementation is really easy but for a real industrial one, you need too much code with >> too much problems (you have to understand well what the top levels classes do, etc...) >> >> >BTW, I have setup a project and already started porting the build stuff to use mingw32. >> >> The mingw32 guy use a mix of win32 and unix compat layers (yakk) :( > >I think you are speaking of cygwin here. AFAIK, mingw creates native windows >executables/libraries... yes, i know but last time i saw they have partially used own compat librairies (who use native windows calls) >> as i said before, i think helping the kwq-win32 project is the right way > >yah, it sounds like KWQ is the answer for wines needs i think too :) >Cheers, > >Adam > Raphael

2 1

Re: fonts go south halfway through OpenOffice1.0.2 install
by Sylvain Petreolle Jan. 21, 2003

Jan. 21, 2003

Removing .wine/cachedmetrics* should have fixed it. > Interestingly, it looks like wine's cached font metrics got screwed > up, > as programs I ran later had the 'all your chars are belong to box' > problem. > Restarting X didn't fix it. > Doing 'make uninstall; make install' didn't fix it. > Doing 'rm -rf .wine c; cd wine; sh tools/wineinstall' did fix it > (whew!). > - Dan > ===== Sylvain Petreolle spetreolle(a)users.sourceforge.net Fight against Spam ! http://www.euro.cauce.org/en/index.html ICQ #170597259 "Don't think you are. Know you are." Morpheus, in "Matrix". ___________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com

1 0

fonts go south halfway through OpenOffice1.0.2 install
by Dan Kegel Jan. 21, 2003

Jan. 21, 2003

I tried installing OpenOffice1.0.2 under Wine today. It started out nicely, but somewhere in the middle, all the fonts got screwed up such that all characters were replaced with boxes. For what it's worth, there are quite a few fixme's. I had to kill Wine to abort the installation. - Dan -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045

1 0

ddraw/ddraw/hal.c:152: initialization from incompatible pointer type
by Gerald Pfeifer Jan. 20, 2003

Jan. 20, 2003

The following static DDHALDDRAWFNS hal_funcs = { sizeof(DDHALDDRAWFNS), ===>set_hal_info,<=== NULL, /* VidMemAlloc */ NULL /* VidMemFree */ }; in dlls/ddraw/ddraw/hal.c causes GCC 3.2 (on SuSE Linux 8.1) to warn: ddraw/hal.c:152: warning: initialization from incompatible pointer type Could someone please have a look? Thanks, Gerald -- Gerald "Jerry" pfeifer(a)dbai.tuwien.ac.at http://www.pfeifer.com/gerald/

2 2

RE: shell32: SHChangeNotify is really Unicode/ANSI indifferent
by Robert Shearman Jan. 20, 2003

Jan. 20, 2003

> From: "Rolf Kalbermatter" <r.kalbermatter(a)hccnet.nl> > To: <wine-patches(a)winehq.com> > Subject: shell32: SHChangeNotify is really Unicode/ANSI indifferent > Date: Mon, 20 Jan 2003 21:53:34 +0100 > Reply-To: wine-devel(a)winehq.com <snip> > -/**************************************************************** > ********* > - * SHChangeNotify [SHELL32.@] > - */ > -void WINAPI SHChangeNotifyA (LONG wEventId, UINT uFlags, > LPCVOID dwItem1, LPCVOID dwItem2) > +void WINAPI SHChangeNotify(LONG wEventId, UINT uFlags, LPCVOID > dwItem1, LPCVOID dwItem2) <snip> > + else if (uFlags & SHCNF_PATHW) > + { > + DWORD dummy; > + if (dwItem1) SHILCreateFromPathW((LPCSTR)dwItem1, > &Pidls[0], &dummy); > + if (dwItem2) SHILCreateFromPathW((LPCSTR)dwItem2, > &Pidls[1], &dummy); > + } > + else if (uFlags & (SHCNF_PRINTERW || SHCNF_PRINTERW) There seems to be something strange with the line above (SHCNF_PRINTERW || SHCNF_PRINTERW) == SHCNF_PRINTERW. Should this be (SHCNF_PRINTERW || SHCNF_PRINTERA) by any chance? > + { > + FIXME("SHChangeNotify with (uFlags & SHCNF_PRINTER)"); > } Other than that, good work! Rob

2 1

trouble with winmm/tests and winearts.drv
by Greg Turner Jan. 20, 2003

Jan. 20, 2003

Linux 2.5.59 seems to have broken my ALSA. Rather than worry about fixing it, I guessed that "just waiting" will fix the problem as future releases of either gentoo or linux would probably eventually resolve whatever conflict I have. So, temporarily, I have put aRTS into "OSS/threaded" mode. This successfully uses ALSA's OSS emulation. Then, I activated winearts.drv to use that instead of my usual ALSA. Now, when I run make test, I get a failure. Here's some output: greg(a)yodull tests $ pwd /var/src/wine/dlls/winmm/tests greg(a)yodull tests $ wine winmm_test.exe.so wave mcop warning: user defined signal handler found for SIG_PIPE, overriding err:wave:ARTS_WaveInit arts_init() failed (-1) wave.c:182:found 10 WaveOut devices wave.c:206: 0: "" 0.0 (0:0): channels=0 formats=0000 support=0000 wave.c:220:Testing invalid 2MHz format wave.c:229: Test failed: opening the device at 2MHz should fail 0: rc=4 wave.c:248: Test failed: opening the device at 2MHz should fail 0: rc=4 wave.c:206: 1: "" 0.0 (0:0): channels=0 formats=0000 support=0000 wave.c:220:Testing invalid 2MHz format wave.c:229: Test failed: opening the device at 2MHz should fail 1: rc=4 wave.c:248: Test failed: opening the device at 2MHz should fail 1: rc=4 wave.c:206: 2: "" 0.0 (0:0): channels=0 formats=0000 support=0000 wave.c:220:Testing invalid 2MHz format wave.c:229: Test failed: opening the device at 2MHz should fail 2: rc=4 wave.c:248: Test failed: opening the device at 2MHz should fail 2: rc=4 wave.c:206: 3: "" 0.0 (0:0): channels=0 formats=0000 support=0000 wave.c:220:Testing invalid 2MHz format wave.c:229: Test failed: opening the device at 2MHz should fail 3: rc=4 wave.c:248: Test failed: opening the device at 2MHz should fail 3: rc=4 wave.c:206: 4: "" 0.0 (0:0): channels=0 formats=0000 support=0000 wave.c:220:Testing invalid 2MHz format wave.c:229: Test failed: opening the device at 2MHz should fail 4: rc=4 wave.c:248: Test failed: opening the device at 2MHz should fail 4: rc=4 wave.c:206: 5: "" 0.0 (0:0): channels=0 formats=0000 support=0000 wave.c:220:Testing invalid 2MHz format wave.c:229: Test failed: opening the device at 2MHz should fail 5: rc=4 wave.c:248: Test failed: opening the device at 2MHz should fail 5: rc=4 wave.c:206: 6: "" 0.0 (0:0): channels=0 formats=0000 support=0000 wave.c:220:Testing invalid 2MHz format wave.c:229: Test failed: opening the device at 2MHz should fail 6: rc=4 wave.c:248: Test failed: opening the device at 2MHz should fail 6: rc=4 wave.c:206: 7: "" 0.0 (0:0): channels=0 formats=0000 support=0000 wave.c:220:Testing invalid 2MHz format wave.c:229: Test failed: opening the device at 2MHz should fail 7: rc=4 wave.c:248: Test failed: opening the device at 2MHz should fail 7: rc=4 wave.c:206: 8: "" 0.0 (0:0): channels=0 formats=0000 support=0000 wave.c:220:Testing invalid 2MHz format wave.c:229: Test failed: opening the device at 2MHz should fail 8: rc=4 wave.c:248: Test failed: opening the device at 2MHz should fail 8: rc=4 wave.c:206: 9: "" 0.0 (0:0): channels=0 formats=0000 support=0000 wave.c:220:Testing invalid 2MHz format wave.c:229: Test failed: opening the device at 2MHz should fail 9: rc=4 wave.c:248: Test failed: opening the device at 2MHz should fail 9: rc=4 wave: 32 tests executed, 0 marked as todo, 20 failures. The code from winearts doesn't seem to check the frequency at all. Could this be because it's legitimately supported under aRTS? Either the test is broken, or the driver is broken. I don't know which fix would be the correct one, kill the test, or add a minimum frequency in the driver... Also: It seems odd when test behavior changes due to changes in ~/.wine/config and/or the installed wine. This happened for my RPC tests, although I was able to work around it. Shouldn't the tests always run the same way? Is it really acceptable to test things that may depend on the user's config and/or wine installation particulars? -- gmt "Everything that is really great and inspiring is created by the individual who can labor in freedom." --Albert Einstein

2 1

Re: resend: small DOS vga improvement
by Jukka Heinonen Jan. 20, 2003

Jan. 20, 2003

Christian Costa wrote: > Andreas Mohr wrote: > > So until there is further information about how to do it properly, > > I'll just remove the vga_refresh reset in the VGA_IsTimerRunning() case, > > and of course this makes Turbo Pascal 6 usable (although screen update is > > a bit slower than IDA, most likely due to using int 10h instead of video > > mem and also probing I/O port 0x3da). > > Sure it will help your app but others that need video sync will not work > properly. :-) > > In your case, VGA_Poll_Text is called periodicaly and should be running > at 33 fps. > Since 33 fps is just half the standard speed (70Hz), all should be fine. > But is VGA_Poll_Text running at 33 fps? > I suspect this function is too slow (maybe due to the console code). Well, after some trivial searching, I found out that VGA register 0x3da reports vertical retrace, horizontal retrace and some light pen stuff: 1xxx = Vertical retrace in progress if set x1xx = Light pen switched on xx1x = Light pen trigger set xxx1 = Either vertical or horizontal retrace in progress if set The original code emulated vertical retrace handling more or less correctly. The patch by Andreas Mohr on the other hand emulates horizontal retrace. Unfortunately, in both cases the other retrace is emulated incorrectly. And I have no idea what to do with light pen bits. So, Andreas, as you now know how to do it properly, can you prepare a patch that: - handles both vertical and horizontal retrace (and does something with light pen) - works even before any VGA mode has been initialized - includes the above documentation about 0x3da bits (so that the next person messing with 0x3da does have some starting point) - does not use inlines unless it really makes a difference (getting screen to update a few milliseconds faster is not worth making the patch longer) -- Jukka Heinonen <http://www.iki.fi/jhei/>

2 1