- Wine-Devel - list.winehq.org

Re: strcat+strcat+strcat == baaad
by Morten Welinder Dec. 9, 2002

Dec. 9, 2002

Unless we're talking an inner and very intensive loop, all this is a bit silly. However, assuming that it does make sense, sprintf variants are not part of the answer. They're interpreted and var-arg type, both of which are little good for efficiency. More like something along these lines: char *tmpdst = dst; strcpy (tmpdst, src1); tmpdst += strlen (src1); strcpy (tmpdst, src2); tmpdst += strlen (src2); strcpy (tmpdst, src3); tmpdst += strlen (src3); ... strcpy (tmpdst, srcN); tmpdst += strlen (srcN); ... This works even better when the strlen calls have known results. Of course, nothing keeps the compiler from noticing a certain pattern of sprintf calls can producing an equaivalent of the above, but right now gcc will not do that if I recall correctly. Morten

2 1

Non latin fonts and non local fonts
by Shachar Shemesh Dec. 9, 2002

Dec. 9, 2002

Hi list, http://bugs.winehq.com/show_bug.cgi?id=1157 It appears that when I'm copying the Windows fonts to C:\windows\Fonts, setting LANG to he_IL is all it takes for Hebrew to be displayed in edit controls and dialog boxes. When I try to copy the exact same fonts to /usr/lib/X11/fonts/windows, and adding them to the XF86Config fonts dir, and running ttmkfdir, no go. The fonts are available to Wine (and each is enumerated multiple times in the fonts dialog), but Hebrew is not displayed by default. Sometimes, when I force the CHARSET to HEBREW_CHARSET, I get Hebrew after all, but I'm not at all sure the same font is used then. In addition to this problem, I was wondering why we no longer enumerate the X fonts the moment there is ONE font file in c:\windows\Fonts? Is there a reason for them to magically disappear? Shachar

2 1

Re: strcat+strcat+strcat == baaad
by Alexandre Julliard Dec. 9, 2002

Dec. 9, 2002

Francois Gouget <fgouget(a)free.fr> writes: > I don't like pieces of code that go: > > strcpy(foo, bar1); > strcat(foo, bar2); > strcat(foo, bar3); > strcat(foo, bar4); > strcat(foo, bar5); > strcat(foo, bar6); > > It's really inefficient: the cost increases quadratically with the size > of the resulting string. Well, no, the cost is linear. It would only be quadratic if the number of strcat calls depended on the length of the string. > It's more efficient to do: > > sprintf(foo, "%s%s%s%s%s%s", bar1,bar2,bar3,bar4,bar5,bar6); I seriously doubt that sprintf would be faster that a couple of strcats. And I don't think we need to worry about this kind of micro-optimizations right now... -- Alexandre Julliard julliard(a)winehq.com

10 26

Wine startup problem
by Leonardo Giordani Dec. 9, 2002

Dec. 9, 2002

I'm using CVS Wine 20021125, but I cannot start any application: what I gete is always -bash-2.05b$ wine War3.exe Loading required GL library /usr/X11R6/lib/libGL.so.1.2 err:ntdll:RtlpWaitForCriticalSection section 0x4010ad10 "../../loader/module.c: loader_section" wait timed out, retrying (60 sec) tid=09545090 It hangs and does nothing. What's the matter? Thank you ------------ Leonardo Giordani leo.giordani(a)libero.it

3 3

Disassembly of the adobe svg plugin
by Mike Hearn Dec. 9, 2002

Dec. 9, 2002

Well, I have about 2 hours now when I can work on trying to get the adobe svg plugin to work in Wine. I have a deadline to meet for Friday that requires the plugin, so if I can't get it working back to Windows it is (it's like a damn magnet). I've already located a mouse bug (problem with my last patch, oops) and fixed it (patch sent), but the lack of render on paint problem still eludes me. Having not got a response to the last email, I'll assume it's OK to try poking about inside the plugin itself to figure out what's going wrong. If anybody has some tips, now would be the time to tell me about them :) I hope this doesn't invalidate any patches I might produce..... -- Mike Hearn <m.hearn(a)signal.qinetiq.com> QinetiQ - Malvern Technology Center

4 6

Turkish keyboard Support
by Armish Dec. 9, 2002

Dec. 9, 2002

Hi all, I tried the latest wine (Wine-20021125.tar.gz) and saw that though it supports the Turkish Keyboard Layout, I cannot write the specail chars of Turkish (Like ı ş ğ � � � ...) Then I found a (Turkish) keyboard.c but still don't know where or how to it? (The keyboard.c is working well with my kernel) What can I do? (The keyboard.c is in the attach. for someone who want to check) Thanks __________________________________________________ Do you Yahoo!? Yahoo! Mail Plus - Powerful. Affordable. Sign up now. http://mailplus.yahoo.com

2 1

Re: Turkish keyboard Support
by Jeff Smith Dec. 9, 2002

Dec. 9, 2002

Was this working under Wine-20021031? I have been trying to figure out a similar problem with the Spanish keyboard layout. If this caused a regression for you as well, it means I have been looking at the wrong problem. If you could test with the 20021031 version and compare results, that could be very helpful. -- Jeff S >From: Armish <acemimsi(a)yahoo.com> > >Hi all, >I tried the latest wine (Wine-20021125.tar.gz) and saw >that though it supports the Turkish Keyboard Layout, I >cannot write the specail chars of Turkish (Like ý >þ ð ü ç ö ...) >Then I found a (Turkish) keyboard.c but still don't >know where or how to it? (The keyboard.c is working >well with my kernel) What can I do? >(The keyboard.c is in the attach. for someone who want >to check) >Thanks _________________________________________________________________ The new MSN 8: advanced junk mail protection and 2 months FREE* http://join.msn.com/?page=features/junkmail

1 0

Re: Fix the winmm/wave tests
by Alexandre Julliard Dec. 9, 2002

Dec. 9, 2002

Francois Gouget <fgouget(a)free.fr> writes: > * dlls/winmm/tests/wave.c > > Error handling in waveOutOpen works now (patch has been in CVs for a > couple of weeks) -> removing the todo_wine This doesn't work for me: ../../../tools/runtest -q -P wine -M winmm.dll -T ../../.. -p winmm_test.exe.so wave.c && touch wave.ok err:wave:wodOpen Rate doesn't match (requested 2000000 Hz, got 48000 Hz) err:wave:wodOpen Rate doesn't match (requested 2000000 Hz, got 48000 Hz) wave.c:145: Test failed: opening the device at 2MHz should fail 0: rc=4 -- Alexandre Julliard julliard(a)winehq.com

2 1

Question about STRICT
by Vincent Béron Dec. 9, 2002

Dec. 9, 2002

I was compiling the tests on MSVC (hence my patch), and the gdi32test wouldn't compile with the Wine headers (but would with MSVC's). The problem can be traced back to the absence of STRICT in windef.h. With the closure of bug #90 (compilation with -DSTRICT), I think it would make sense to define it in a header (windef.h seems logical), with an ifdef NO_STRICT provision (see the attached proposed patch). This would allow to remove all -DSTRICT on compilation command lines. I await your comments on it. Vincent --- wine-20021206-1700/include/windef.h 2002-10-23 20:47:38.000000000 -0400 +++ wine-20021206-1700/include/windef.h 2002-12-07 16:34:02.000000000 -0500 @@ -28,6 +28,12 @@ #ifndef WINVER #define WINVER 0x0500 #endif + +#ifndef NO_STRICT +#ifndef STRICT +#define STRICT +#endif /* STRICT */ +#endif /* NO_STRICT */ #include "winnt.h"

2 1

Fw: Loading Autorun.inf on CD's
by Dustin Navea Dec. 9, 2002

Dec. 9, 2002

----- Original Message ----- From: "Sylvain Petreolle" <spetreolle(a)yahoo.fr> To: "Tony Lambregts" <tony_lambregts(a)telusplanet.net>; "Dustin Navea" <speeddymon(a)sbcglobal.net> Cc: "Sylvain Petreolle" <spetreolle(a)yahoo.fr>; "Wine Developers" <wine-devel(a)winehq.com> Sent: Sunday, December 08, 2002 5:11 AM Subject: Re: Loading Autorun.inf on CD's > If you want act in this way, I have something for you. > This could help Paul Jones, who is searching how to "launch" *.msi > installers. interesting > The better way we can handle this is a program who tries to open every > document we give to it. A freeware utility exists in cygwin world and > is called cygstart, using the existing registry. If we give it a .doc, > it looks in HKCR and starts Worpad/Winword. > That is a definite must.. > If we tweak the registry of a .inf (winedefault.reg), we can ask it to > launch a tiny program that will open the .inf and run the program > specified. Sounds like it could work, but what about inf installer files (ie TweakUI's inf, or driver inf files) how would they be handled? > > I have not seen this work either and definitely not with an .inf. Yes > > it > > would be cool and if you want to start a bug concerning it feel free. > > I > > am not that worried about it though. The way I see it is that most of > > > > this is not realy a wine problem but rather with setting up autorun > > so > > that it is able to understand what to do with an .inf file. I suppose > > > > another way to look at it might be that wcmd could/should be able to > > handle something like "wcmd autorun.inf". > > -Dustin

2 2