- Wine-Devel - list.winehq.org

Re: strcat+strcat+strcat == baaad"
by vkxzjq6lg＠cswebmail.com Dec. 10, 2002

Dec. 10, 2002

"Dimitrie O. Paun" wrote: > > On December 5, 2002 11:16 am, Alexandre Julliard wrote: > > It's the kind of thinking that leads to having an exception > > handler inside strlen() like Windows does. It's just plain wrong. > > <nod/>. This is generally true for other things as well: > > 1. Many places in our code where we have invariant like > pointer p is never NULL, yet we always have: > > if (!p) return NULL; /* or whatever error condition */ > > Such a check is harmful (hides bugs), slow (useless > runtime check), bloat (more generated code), > ugly (clutters the code), at the very least. Just > Don't Do It (TM) -- let the code crash. Agreed that it's harmful because it hides what may be a real error. Lousy idea unless p really is allowed to have that value. If it's a call exposed to external callers it needs to warn somehow, even to the console if necessary (assuming that Wine wants to give end users some feedback they can give back to the Wine developers and to the developer of the faulty application). Those warnings can vanish should there ever be a production build with debugging removed. If it's internal only it should be an assert or fixme. Being too free with "let the code crash" is a bad idea. Microsoft got a lot of really bad heckling in the Windows 3.1 era for GPFs. Wine doesn't want to crash if it's reasonably harmless to continue (like for a failed screen update). Does want to report the problem, of course, rather than silently ignore it, otherwise it'll never get fixed. > > 2. ZeroMemory when we don't need to, when we pass struct > internally, yet same functions can be called externally > with no guarantee that the struct has unused field > zeroed out. > Agreed if it is a call to an internal only function. If it's to a function with an external API then it may need zeroing to get to the state required for that. > 3. In general, we have all sort of 'defensive programming' > checks for invariants. Problem is, we never going to > catch bugs in this area this way. Just use assert() > if you feel a check is needed. If it's a documented external interface it can't assert and die because the application making the call presumably works on real Windows. So it needs to be warned/fixme'd or whatever so end users can report the issue to Wine developers for fixing. If it's internal, assert is sort of OK, though as someone trying to get an application working I want a fixme rather than sudden death (except in file output interfaces!). I don't need perfect functionality. I do need to get the app to the point where it is safely functioning and an assert may kill it when it doesn't need to die. > In short, this defensive programming crap is just that: crap. Do you agree with the way I've explained how I see the difference between redundant defensive programming and detecting and reporting problems which need to be fixed? If not, where do you differ and why? James ___________________________________________________ The ALL NEW CS2000 from CompuServe Better! Faster! More Powerful! 250 FREE hours! Sign-on Now! http://www.compuserve.com/trycsrv/cs2000/webmail/

3 2

[Fwd: A registry editor taking shape ...]
by Dan Kegel Dec. 10, 2002

Dec. 10, 2002

Hey, looks like the Samba guys are doing a registry editor... - Dan -------- Original Message -------- Subject: A registry editor taking shape ... Date: Mon, 9 Dec 2002 01:56:50 -0800 (PST) From: Richard Sharpe <rsharpe(a)richardsharpe.com> To: <samba-technical(a)samba.org> Hi, A registry editor, editreg, is slowly taking shape in Samba-head. The goal is to be able to do things like: - delete keys and values - add keys and values - change keys and values - Change the SIDS/SecDescs applied to keys. - write out the changes tree - create a tree from scratch What would be useful is some thoughts on how the interface should be constructed, as in command-line, or a .reg file of commands, etc. Regards ----- Richard Sharpe, rsharpe[at]ns.aus.com, rsharpe[at]samba.org, sharpe[at]ethereal.com, http://www.richardsharpe.com

2 1

Import Lib patche
by Steven Edwards Dec. 10, 2002

Dec. 10, 2002

Hola, Just wondering if you were still doing the import lib stuff. I saw in a past message that you had some patches outstanding and assumed import lib patch is one of them. I think this is the only thing holding up being able to compile all of the regression tests under windows via Mingw. Thanks Steven __________________________________________________ Do you Yahoo!? Yahoo! Mail Plus - Powerful. Affordable. Sign up now. http://mailplus.yahoo.com

1 0

wpp
by Dimitrie O. Paun Dec. 10, 2002

Dec. 10, 2002

Folks, Anyone remembers why we need our own cpp implementation, instead of simply using cpp/gcc -E? -- Dimi.

5 11

Windows XP Conformance Test results...
by Kye Lewis Dec. 10, 2002

Dec. 10, 2002

Hi, My Results using the batch file and Windows XP. If you need any more information about msvcrt_test crash, just ask. My desktop also becomes smaller after running user32_test sysparams, the approximate time of this is marked below in the appropriate section. These results are obtained with Windows XP Home ==== advapi32_test ==== h:\wine\wine\dlls\advapi32\tests\registry.c:80: Test failed: data_count set to 24 instead of 7 h:\wine\wine\dlls\advapi32\tests\registry.c:81: Test failed: type 2 is not REG_SZ h:\wine\wine\dlls\advapi32\tests\registry.c:94: Test failed: data_count set to 24 instead of 7 h:\wine\wine\dlls\advapi32\tests\registry.c:95: Test failed: type 2 is not REG_SZ h:\wine\wine\dlls\advapi32\tests\registry.c:96: Test failed: value set to 'xxxxxxxxxx' instead of 'Te' h:\wine\wine\dlls\advapi32\tests\registry.c:97: Test failed: data set to 'xxxxxxxxxx' instead of 'foobar' h:\wine\wine\dlls\advapi32\tests\registry.c:108: Test failed: data_count set to24 instead of 7 h:\wine\wine\dlls\advapi32\tests\registry.c:109: Test failed: type 2 is not REG_SZ h:\wine\wine\dlls\advapi32\tests\registry.c:111: Test failed: data set to 'xxxxxxxxxx' instead of 'foobar' h:\wine\wine\dlls\advapi32\tests\registry.c:122: Test failed: data_count set to24 instead of 7 h:\wine\wine\dlls\advapi32\tests\registry.c:123: Test failed: type 2 is not REG_SZ h:\wine\wine\dlls\advapi32\tests\registry.c:134: Test failed: expected ERROR_SUCCESS, got 234 h:\wine\wine\dlls\advapi32\tests\registry.c:135: Test failed: val_count set to 20 instead of 4 h:\wine\wine\dlls\advapi32\tests\registry.c:136: Test failed: data_count set to 24 instead of 7 h:\wine\wine\dlls\advapi32\tests\registry.c:137: Test failed: type 2 is not REG_SZ h:\wine\wine\dlls\advapi32\tests\registry.c:138: Test failed: value is 'xxxxxxxxxx' instead of Test h:\wine\wine\dlls\advapi32\tests\registry.c:139: Test failed: data is 'xxxxxxxxxx' instead of foobar h:\wine\wine\dlls\advapi32\tests\registry.c:155: Test failed: data_count set to 48 instead of 7*sizeof(WCHAR) h:\wine\wine\dlls\advapi32\tests\registry.c:156: Test failed: type 2 is not REG_SZ h:\wine\wine\dlls\advapi32\tests\registry.c:169: Test failed: data_count set to 48 instead of 7*sizeof(WCHAR) h:\wine\wine\dlls\advapi32\tests\registry.c:170: Test failed: type 2 is not REG_SZ h:\wine\wine\dlls\advapi32\tests\registry.c:182: Test failed: val_count set to 5 instead of 4 h:\wine\wine\dlls\advapi32\tests\registry.c:183: Test failed: data_count set to 48 instead of 7*sizeof(WCHAR) h:\wine\wine\dlls\advapi32\tests\registry.c:184: Test failed: type 2 is not REG_SZ h:\wine\wine\dlls\advapi32\tests\registry.c:185: Test failed: value is not 'Test' h:\wine\wine\dlls\advapi32\tests\registry.c:195: Test failed: expected ERROR_SUCCESS, got 234 h:\wine\wine\dlls\advapi32\tests\registry.c:196: Test failed: val_count set to 5 instead of 4 h:\wine\wine\dlls\advapi32\tests\registry.c:197: Test failed: data_count set to 48 instead of 7*sizeof(WCHAR) h:\wine\wine\dlls\advapi32\tests\registry.c:198: Test failed: type 2 is not REG_SZ h:\wine\wine\dlls\advapi32\tests\registry.c:199: Test failed: value is not 'Test' h:\wine\wine\dlls\advapi32\tests\registry.c:200: Test failed: data is not 'foobar' registry: 56 tests executed, 0 marked as todo, 31 failures. ==== kernel32_test ==== alloc: 58 tests executed, 0 marked as todo, 0 failures. atom: 229398 tests executed, 0 marked as todo, 0 failures. codepage: 2 tests executed, 0 marked as todo, 0 failures. directory: 48 tests executed, 0 marked as todo, 0 failures. drive: 156 tests executed, 0 marked as todo, 0 failures. environ: 39 tests executed, 0 marked as todo, 0 failures. h:\wine\wine\dlls\kernel\tests\file.c:578: Test failed: DeleteFile should fail with an empty path, and last error value should be ERROR_FILE_NOT_FOUND h:\wine\wine\dlls\kernel\tests\file.c:610:Current offset = 0015 h:\wine\wine\dlls\kernel\tests\file.c:635:Current offset = 0015 file: 487238 tests executed, 0 marked as todo, 1 failure. format_msg: 58 tests executed, 0 marked as todo, 0 failures. generated: 609 tests executed, 0 marked as todo, 0 failures. locale: 54 tests executed, 0 marked as todo, 0 failures. h:\wine\wine\dlls\kernel\tests\path.c:927:TMP=C:\WINDOWS\TEMP h:\wine\wine\dlls\kernel\tests\path.c:935:TMP=C:\WINDOWS h:\wine\wine\dlls\kernel\tests\path.c:944:TMP=C:\ h:\wine\wine\dlls\kernel\tests\path.c:954:TMP=C: h:\wine\wine\dlls\kernel\tests\path.c:879: Test failed: win2000 BUG: expected 12, got 13 h:\wine\wine\dlls\kernel\tests\path.c:892: Test failed: win2000 BUG: expected 12, got 13 h:\wine\wine\dlls\kernel\tests\path.c:898: Test failed: win2000 BUG: should return path without terminating back slash path: 2083 tests executed, 0 marked as todo, 3 failures. tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. h:\wine\wine\dlls\kernel\tests\process.c:374: Test failed: StartupInfoA:lpDesktop expected (null), got WinSta0\Default h:\wine\wine\dlls\kernel\tests\process.c:375: Test failed: StartupInfoA:lpTitle expected (null), got C:\DOCUME~1\Owner\DESKTOP\WINETE~1\KERNEL32_TEST.exe tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. h:\wine\wine\dlls\kernel\tests\process.c:450: Test failed: StartupInfoA:lpDesktop expected (null), got WinSta0\Default tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. h:\wine\wine\dlls\kernel\tests\process.c:527: Test failed: StartupInfoA:lpTitle expected (null), got C:\DOCUME~1\Owner\DESKTOP\WINETE~1\KERNEL32_TEST.exe tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. process: 116 tests executed, 0 marked as todo, 4 failures. thread: 112 tests executed, 0 marked as todo, 0 failures. ==== msvcrt_test ==== Fails to run (msvcrt_test.exe has encountered a problem and needs to close. We are sorry for the inconvenience) Debug Shows Unhandled exception in msvcrt_test.exe (NTDLL.DLL): 0xC0000005: Access Violation More information available if required ==== netapi32_test ==== h:\wine\wine\dlls\netapi32\tests\access.c:95: Test failed: Bad Network Path access: 23 tests executed, 0 marked as todo, 1 failure. apibuf: 15 tests executed, 0 marked as todo, 0 failures. wksta: 14 tests executed, 0 marked as todo, 0 failures. ==== rpcrt4_test ==== h:\wine\wine\dlls\rpcrt4\tests\rpc.c:124: ** Uuid Conversion and Comparison Tests ** rpc: 901 tests executed, 0 marked as todo, 0 failures. ==== shell32_test ==== generated: 272 tests executed, 0 marked as todo, 0 failures. h:\wine\wine\dlls\shell32\tests\shlfileop.c:286: Test failed: Files are copied to other directory h:\wine\wine\dlls\shell32\tests\shlfileop.c:287: Test failed: The file is copied shlfileop: 121 tests executed, 0 marked as todo, 2 failures. ==== shlwapi_test ==== h:\wine\wine\dlls\shlwapi\tests\clist.c:367: Test failed: allowed bad element size h:\wine\wine\dlls\shlwapi\tests\clist.c:372: Test failed: allowed adding a container clist: 236 tests executed, 0 marked as todo, 2 failures. generated: 19 tests executed, 0 marked as todo, 0 failures. h:\wine\wine\dlls\shlwapi\tests\shreg.c:172: Test failed: (44,43) h:\wine\wine\dlls\shlwapi\tests\shreg.c:196: Test failed: (44,43) h:\wine\wine\dlls\shlwapi\tests\shreg.c:206: Test failed: () h:\wine\wine\dlls\shlwapi\tests\shreg.c:207: Test failed: () h:\wine\wine\dlls\shlwapi\tests\shreg.c:208: Test failed: (44,43) h:\wine\wine\dlls\shlwapi\tests\shreg.c:219: Test failed: (44,43) h:\wine\wine\dlls\shlwapi\tests\shreg.c:241: Test failed: didn't open dest shreg: 39 tests executed, 0 marked as todo, 7 failures. ==== user32_test ==== class: 80 tests executed, 0 marked as todo, 0 failures. generated: 1524 tests executed, 0 marked as todo, 0 failures. h:\wine\wine\dlls\user\tests\sysparams.c:184:testing SPI_{GET,SET}BEEP h:\wine\wine\dlls\user\tests\sysparams.c:306:testing SPI_{GET,SET}MOUSE h:\wine\wine\dlls\user\tests\sysparams.c:374:testing SPI_{GET,SET}BORDER h:\wine\wine\dlls\user\tests\sysparams.c:170: Test failed: Wrong value in registry: subKey=Control Panel\Desktop, valName=BorderWidth, testValue=1, value= h:\wine\wine\dlls\user\tests\sysparams.c:170: Test failed: Wrong value in registry: subKey=Control Panel\Desktop, valName=BorderWidth, testValue=0, value= h:\wine\wine\dlls\user\tests\sysparams.c:170: Test failed: Wrong value in registry: subKey=Control Panel\Desktop, valName=BorderWidth, testValue=7, value= h:\wine\wine\dlls\user\tests\sysparams.c:170: Test failed: Wrong value in registry: subKey=Control Panel\Desktop, valName=BorderWidth, testValue=20, value= h:\wine\wine\dlls\user\tests\sysparams.c:406:testing SPI_{GET,SET}KEYBOARDSPEED h:\wine\wine\dlls\user\tests\sysparams.c:440:testing SPI_ICONHORIZONTALSPACING h:\wine\wine\dlls\user\tests\sysparams.c:170: Test failed: Wrong value in registry: subKey=Control Panel\Desktop, valName=IconSpacing, testValue=101, value= h:\wine\wine\dlls\user\tests\sysparams.c:170: Test failed: Wrong value in registry: subKey=Control Panel\Desktop, valName=IconSpacing, testValue=32, value= h:\wine\wine\dlls\user\tests\sysparams.c:480:testing SPI_{GET,SET}SCREENSAVETIMEOUT h:\wine\wine\dlls\user\tests\sysparams.c:515:testing SPI_{GET,SET}SCREENSAVEACTIVE h:\wine\wine\dlls\user\tests\sysparams.c:555:testing SPI_{GET,SET}KEYBOARDDELAY h:\wine\wine\dlls\user\tests\sysparams.c:590:testing SPI_ICONVERTICALSPACING h:\wine\wine\dlls\user\tests\sysparams.c:170: Test failed: Wrong value in registry: subKey=Control Panel\Desktop, valName=IconVerticalSpacing, testValue=101, value= h:\wine\wine\dlls\user\tests\sysparams.c:170: Test failed: Wrong value in registry: subKey=Control Panel\Desktop, valName=IconVerticalSpacing, testValue=32, value= h:\wine\wine\dlls\user\tests\sysparams.c:635:testing SPI_{GET,SET}ICONTITLEWRAP h:\wine\wine\dlls\user\tests\sysparams.c:170: Test failed: Wrong value in registry: subKey=Control Panel\Desktop, valName=IconTitleWrap, testValue=1, value= h:\wine\wine\dlls\user\tests\sysparams.c:170: Test failed: Wrong value in registry: subKey=Control Panel\Desktop, valName=IconTitleWrap, testValue=0, value= h:\wine\wine\dlls\user\tests\sysparams.c:670:testing SPI_{GET,SET}MENUDROPALIGNMENT h:\wine\wine\dlls\user\tests\sysparams.c:707:testing SPI_SETDOUBLECLKWIDTH h:\wine\wine\dlls\user\tests\sysparams.c:738:testing SPI_SETDOUBLECLKHEIGHT h:\wine\wine\dlls\user\tests\sysparams.c:770:testing SPI_SETDOUBLECLICKTIME h:\wine\wine\dlls\user\tests\sysparams.c:817:testing SPI_SETMOUSEBUTTONSWAP // Desktop Resizes somewhere between here: h:\wine\wine\dlls\user\tests\sysparams.c:880:testing SPI_{GET,SET}DRAGFULLWINDOWS h:\wine\wine\dlls\user\tests\sysparams.c:915:testing SPI_{GET,SET}WORKAREA And Here // h:\wine\wine\dlls\user\tests\sysparams.c:953:testing SPI_{GET,SET}SHOWSOUNDS h:\wine\wine\dlls\user\tests\sysparams.c:997:testing SPI_{GET,SET}DESKWALLPAPER sysparams: 318 tests executed, 0 marked as todo, 10 failures. win: 373 tests executed, 0 marked as todo, 0 failures. wsprintf: 4 tests executed, 0 marked as todo, 0 failures. ==== wininet_test ==== generated: 252 tests executed, 0 marked as todo, 0 failures. h:\wine\wine\dlls\wininet\tests\http.c:90:Starting with flags 0x10000000 h:\wine\wine\dlls\wininet\tests\http.c:92:InternetOpenA <-- h:\wine\wine\dlls\wininet\tests\http.c:95:InternetOpenA --> h:\wine\wine\dlls\wininet\tests\http.c:101:InternetConnectA <-- h:\wine\wine\dlls\wininet\tests\http.c:78:Callback 00CC0004 0xdeadbeef INTERNET_STATUS_HANDLE_CREATED(60) 0012E990 4 h:\wine\wine\dlls\wininet\tests\http.c:104:InternetConnectA --> h:\wine\wine\dlls\wininet\tests\http.c:108:HttpOpenRequestA <-- h:\wine\wine\dlls\wininet\tests\http.c:78:Callback 00CC0008 0xdeadbead INTERNET_STATUS_HANDLE_CREATED(60) 0012EC04 4 h:\wine\wine\dlls\wininet\tests\http.c:122:HttpOpenRequestA --> h:\wine\wine\dlls\wininet\tests\http.c:126:HttpSendRequestA --> h:\wine\wine\dlls\wininet\tests\http.c:133:HttpSendRequestA <-- h:\wine\wine\dlls\wininet\tests\http.c:78:Callback 00CC000C 0xdeadbead INTERNET_STATUS_RESOLVING_NAME(10) 00D6FB04 15 h:\wine\wine\dlls\wininet\tests\http.c:78:Callback 00CC000C 0xdeadbead INTERNET_STATUS_NAME_RESOLVED(11) 00D6FAF4 12 h:\wine\wine\dlls\wininet\tests\http.c:78:Callback 00CC000C 0xdeadbead INTERNET_STATUS_CONNECTING_TO_SERVER(20) 00D6FB9C 12 h:\wine\wine\dlls\wininet\tests\http.c:78:Callback 00CC000C 0xdeadbead INTERNET_STATUS_CONNECTED_TO_SERVER(21) 00D6FD40 12 h:\wine\wine\dlls\wininet\tests\http.c:78:Callback 00CC000C 0xdeadbead INTERNET_STATUS_SENDING_REQUEST(30) 00000000 0 h:\wine\wine\dlls\wininet\tests\http.c:78:Callback 00CC000C 0xdeadbead INTERNET_STATUS_REQUEST_SENT(31) 00D6FCE0 4 h:\wine\wine\dlls\wininet\tests\http.c:78:Callback 00CC000C 0xdeadbead INTERNET_STATUS_RECEIVING_RESPONSE(40) 00000000 0 h:\wine\wine\dlls\wininet\tests\http.c:78:Callback 00CC000C 0xdeadbead INTERNET_STATUS_RESPONSE_RECEIVED(41) 00D6FD60 4 h:\wine\wine\dlls\wininet\tests\http.c:78:Callback 00CC000C 0xdeadbead INTERNET_STATUS_REQUEST_COMPLETE(100) 00D6FDA8 8 h:\wine\wine\dlls\wininet\tests\http.c:140:Option 0x17 -> 1 8 h:\wine\wine\dlls\wininet\tests\http.c:144:Option 0x22 -> 1 http://www.winehq.com/about/ h:\wine\wine\dlls\wininet\tests\http.c:149:Option 0x16 -> 1 HTTP/1.0 200 OK Date: Mon, 09 Dec 2002 22:47:48 GMT Server: Apache/1.3.22 (Unix) (Red-Hat/Linux) mod_ssl/2.8.5 OpenSSL/0.9.6 PHP/4. 1.2 X-Powered-By: PHP/4.1.2 Content-Type: text/html X-Cache: MISS from cache.net2000.com.au Connection: close h:\wine\wine\dlls\wininet\tests\http.c:154:Option 0x22 -> 1 http://www.winehq.com/about/ h:\wine\wine\dlls\wininet\tests\http.c:158:Option 0x5 -> 0 http://www.winehq.com/about/ (12150) h:\wine\wine\dlls\wininet\tests\http.c:163:Option 0x1 -> 1 text/html h:\wine\wine\dlls\wininet\tests\http.c:166:Entery Query loop h:\wine\wine\dlls\wininet\tests\http.c:183:ReadFile -> 1 773 h:\wine\wine\dlls\wininet\tests\http.c:183:ReadFile -> 1 465 h:\wine\wine\dlls\wininet\tests\http.c:172: Test failed: InternetQueryDataAvailable failed h:\wine\wine\dlls\wininet\tests\http.c:78:Callback 00CC000C 0xdeadbead INTERNET_STATUS_REQUEST_COMPLETE(100) 00D6FDA8 8 h:\wine\wine\dlls\wininet\tests\http.c:78:Callback 00CC000C 0xdeadbead INTERNET_STATUS_CLOSING_CONNECTION(50) 00000000 0 h:\wine\wine\dlls\wininet\tests\http.c:78:Callback 00CC000C 0xdeadbead INTERNET_STATUS_CONNECTION_CLOSED(51) 00000000 0 h:\wine\wine\dlls\wininet\tests\http.c:78:Callback 00CC000C 0xdeadbead INTERNET_STATUS_HANDLE_CLOSING(70) 0012EC30 4 h:\wine\wine\dlls\wininet\tests\http.c:78:Callback 00CC0008 0xdeadbeef INTERNET_STATUS_HANDLE_CLOSING(70) 0012EC30 4 h:\wine\wine\dlls\wininet\tests\http.c:90:Starting with flags 0x0 h:\wine\wine\dlls\wininet\tests\http.c:92:InternetOpenA <-- h:\wine\wine\dlls\wininet\tests\http.c:95:InternetOpenA --> h:\wine\wine\dlls\wininet\tests\http.c:101:InternetConnectA <-- h:\wine\wine\dlls\wininet\tests\http.c:78:Callback 00CC0004 0xdeadbeef INTERNET_STATUS_HANDLE_CREATED(60) 0012E990 4 h:\wine\wine\dlls\wininet\tests\http.c:104:InternetConnectA --> h:\wine\wine\dlls\wininet\tests\http.c:108:HttpOpenRequestA <-- h:\wine\wine\dlls\wininet\tests\http.c:78:Callback 00CC0008 0xdeadbead INTERNET_STATUS_HANDLE_CREATED(60) 0012EC04 4 h:\wine\wine\dlls\wininet\tests\http.c:122:HttpOpenRequestA --> h:\wine\wine\dlls\wininet\tests\http.c:126:HttpSendRequestA --> h:\wine\wine\dlls\wininet\tests\http.c:78:Callback 00CC000C 0xdeadbead INTERNET_STATUS_CONNECTING_TO_SERVER(20) 0012EA3C 12 h:\wine\wine\dlls\wininet\tests\http.c:78:Callback 00CC000C 0xdeadbead INTERNET_STATUS_CONNECTED_TO_SERVER(21) 0012EA18 12 h:\wine\wine\dlls\wininet\tests\http.c:78:Callback 00CC000C 0xdeadbead INTERNET_STATUS_SENDING_REQUEST(30) 00000000 0 h:\wine\wine\dlls\wininet\tests\http.c:78:Callback 00CC000C 0xdeadbead INTERNET_STATUS_REQUEST_SENT(31) 0012EB28 4 h:\wine\wine\dlls\wininet\tests\http.c:78:Callback 00CC000C 0xdeadbead INTERNET_STATUS_RECEIVING_RESPONSE(40) 00000000 0 h:\wine\wine\dlls\wininet\tests\http.c:78:Callback 00CC000C 0xdeadbead INTERNET_STATUS_RESPONSE_RECEIVED(41) 0012EB10 4 h:\wine\wine\dlls\wininet\tests\http.c:133:HttpSendRequestA <-- h:\wine\wine\dlls\wininet\tests\http.c:140:Option 0x17 -> 1 8 h:\wine\wine\dlls\wininet\tests\http.c:144:Option 0x22 -> 1 http://www.winehq.com/about/ h:\wine\wine\dlls\wininet\tests\http.c:149:Option 0x16 -> 1 HTTP/1.0 200 OK Date: Mon, 09 Dec 2002 22:47:49 GMT Server: Apache/1.3.22 (Unix) (Red-Hat/Linux) mod_ssl/2.8.5 OpenSSL/0.9.6 PHP/4. 1.2 X-Powered-By: PHP/4.1.2 Content-Type: text/html X-Cache: MISS from cache.net2000.com.au Connection: close h:\wine\wine\dlls\wininet\tests\http.c:154:Option 0x22 -> 1 http://www.winehq.com/about/ h:\wine\wine\dlls\wininet\tests\http.c:158:Option 0x5 -> 0 http://www.winehq.com/about/ (12150) h:\wine\wine\dlls\wininet\tests\http.c:163:Option 0x1 -> 1 text/html h:\wine\wine\dlls\wininet\tests\http.c:166:Entery Query loop h:\wine\wine\dlls\wininet\tests\http.c:183:ReadFile -> 1 773 h:\wine\wine\dlls\wininet\tests\http.c:183:ReadFile -> 1 465 h:\wine\wine\dlls\wininet\tests\http.c:183:ReadFile -> 1 1460 h:\wine\wine\dlls\wininet\tests\http.c:183:ReadFile -> 1 1460 h:\wine\wine\dlls\wininet\tests\http.c:183:ReadFile -> 1 1460 h:\wine\wine\dlls\wininet\tests\http.c:183:ReadFile -> 1 1460 h:\wine\wine\dlls\wininet\tests\http.c:183:ReadFile -> 1 1460 h:\wine\wine\dlls\wininet\tests\http.c:183:ReadFile -> 1 1460 h:\wine\wine\dlls\wininet\tests\http.c:183:ReadFile -> 1 1460 h:\wine\wine\dlls\wininet\tests\http.c:183:ReadFile -> 1 447 h:\wine\wine\dlls\wininet\tests\http.c:78:Callback 00CC000C 0xdeadbead INTERNET_STATUS_CLOSING_CONNECTION(50) 00000000 0 h:\wine\wine\dlls\wininet\tests\http.c:78:Callback 00CC000C 0xdeadbead INTERNET_STATUS_CONNECTION_CLOSED(51) 00000000 0 h:\wine\wine\dlls\wininet\tests\http.c:78:Callback 00CC000C 0xdeadbead INTERNET_STATUS_HANDLE_CLOSING(70) 0012EC30 4 h:\wine\wine\dlls\wininet\tests\http.c:78:Callback 00CC0008 0xdeadbeef INTERNET_STATUS_HANDLE_CLOSING(70) 0012EC30 4 http: 28 tests executed, 0 marked as todo, 1 failure. ==== winmm_test ==== h:\wine\wine\dlls\winmm\tests\wave.c:56:found 1 WaveOut devices h:\wine\wine\dlls\winmm\tests\wave.c:82: 0: "SB Live! Wave Device" 5.10 (1:100): channels=65535 formats=bffff support=002c h:\wine\wine\dlls\winmm\tests\wave.c:133:Testing invalid 2MHz format wave: 53 tests executed, 0 marked as todo, 0 failures. ==== ws2_32_test ==== sock: 128 tests executed, 0 marked as todo, 0 failures.

1 0

Re: strcat+strcat+strcat == baaad"
by vkxzjq6lg＠cswebmail.com Dec. 10, 2002

Dec. 10, 2002

Francois Gouget wrote: > Of course, that implies that we should promptly fix any such crash. > Otherwise it just makes Wine unusable without any benefit. That's the catch. I'm not approaching Wine as a Wine developer. Wine is almost ready for prime time now and as a non-Wine developer (who's roped in so far only as far as necessary to get the app I want to run running) I'm approaching it as a near production system. When only hard core Wine developers were seeing it, opening the debugger made sense. Wine is leaving the core development stage and now it's time to be arranging for bug reporting mechanisms which don't require that you be a programmer willing to start debugging Wine to get your applications running. That means avoiding a raw debugger window and providing something more end user friendly. To me that means something like logging every non-dangerous failure possible rather than killing the application. Then, when the application finishes, winseerver can pop up a polite window telling the user that there was a problem and asking them to report it to the developers, making it easy to do that. It definitely doesn't involve opening debugger windows. Those will scare away the end users who need to be submitting those logs so the developers can see which app or internal routine was breaking the rules and what needs to be fixed. So: Wine's almost there (and congratulations on getting to the point where I can seriously write that!). Time to be thinking about what end users can handle and changing how garbage data reporting is handled to make it more friendly to them. ___________________________________________________ The ALL NEW CS2000 from CompuServe Better! Faster! More Powerful! 250 FREE hours! Sign-on Now! http://www.compuserve.com/trycsrv/cs2000/webmail/

2 1

DOSMEM_Init VirtualProtect fails
by vkxzjq6lg＠cswebmail.com Dec. 10, 2002

Dec. 10, 2002

To further my porting work, I've patched my copy of DOSMEM.C like this: else if (dos_init && !already_mapped) { if (DOSMEM_dosmem) { ERR( "Needs access to the first megabyte for DOS mode\n" ); ExitProcess(1); } MESSAGE( "Warning: unprotecting the first 64KB of memory to allow real-mode calls.\n" " NULL pointer accesses will no longer be caught.\n" ); /* James Day added the if/FIXME/return false around this VirtualProtect because OzWin on my AMD K6-3 gave this result: wine --debugmsg +dosmem ozwin2 fixme:toolhelp:InterruptRegister16 (0000, 0x26f00ba), stub. Warning: unprotecting the first 64KB of memory to allow real-mode calls. NULL pointer accesses will no longer be caught. fixme:dosmem:DOSMEM_Init Failed to unprotect first 64KB of memory. init=1, done=1, mapped=0 fixme:toolhelp:InterruptUnRegister16 (0000), stub. */ if ( ! VirtualProtect( NULL, 0x10000, PAGE_EXECUTE_READWRITE, NULL ) ) { FIXME("Failed to unprotect first 64KB of memory. init=%d, done=%d, mapped=%d\n", (int)dos_init, already_done, already_mapped); return FALSE; } /* copy the BIOS and ISR area down */ memcpy( DOSMEM_dosmem, DOSMEM_sysmem, 0x400 + 0x100 ); NtProtectVirtualMemory is returning STATUS_INVALID_PARAMETER to VirtualProtectEx and DOSMEM_Init wasn't handling this failure gracefully - the memcpy was tripping the debugger and falling flat, taking the application with it. Anyone got any better ideas? Want more information on what's happening, like which of the STATUS_INVALID_PARAMETER cases is happening? Lindows 3.0 OS (Debian plus bits), Wine 20021125 compiled here with only this change. Not running as root. 128MB of RAM. ___________________________________________________ The ALL NEW CS2000 from CompuServe Better! Faster! More Powerful! 250 FREE hours! Sign-on Now! http://www.compuserve.com/trycsrv/cs2000/webmail/

1 0

How to find out if file is loaded?
by Klaus Niederkrueger Dec. 9, 2002

Dec. 9, 2002

Hello, I would like to know the following: I start some program with "wine -debugmsg +file" and I get quite a lot of times trace:file:CreateFileW L"tiles\\TS01.bmp" GENERIC_READ FILE_SHARE_READ FILE_SHARE_WRITE OPEN_EXISTING attributes 0x80 trace:file:CreateFileW returning 0x58 trace:file:_lopen ('tiles\TS01.BMP',0000) trace:file:CreateFileW L"tiles\\TS01.BMP" GENERIC_READ FILE_SHARE_READ FILE_SHARE_WRITE OPEN_EXISTING attributes 0x0 trace:file:CreateFileW returning 0x58 trace:file:ReadFile 0x58 0x406d2690 14 0x406d264c (nil) trace:file:ReadFile 0x58 0x406d2668 40 0x406d264c (nil) trace:file:ReadFile 0x58 0x406d26a4 1024 0x406d264c (nil) trace:file:_lclose handle 88 So it seems to me that the file tiles\TS01.BMP is loaded, but when I use "ltrace wine ..." I don't find any output regarding this file. Why is that? Thanks for any answer Klaus

2 2

Re: strcat+strcat+strcat == baaad
by Morten Welinder Dec. 9, 2002

Dec. 9, 2002

Unless we're talking an inner and very intensive loop, all this is a bit silly. However, assuming that it does make sense, sprintf variants are not part of the answer. They're interpreted and var-arg type, both of which are little good for efficiency. More like something along these lines: char *tmpdst = dst; strcpy (tmpdst, src1); tmpdst += strlen (src1); strcpy (tmpdst, src2); tmpdst += strlen (src2); strcpy (tmpdst, src3); tmpdst += strlen (src3); ... strcpy (tmpdst, srcN); tmpdst += strlen (srcN); ... This works even better when the strlen calls have known results. Of course, nothing keeps the compiler from noticing a certain pattern of sprintf calls can producing an equaivalent of the above, but right now gcc will not do that if I recall correctly. Morten

2 1

Non latin fonts and non local fonts
by Shachar Shemesh Dec. 9, 2002

Dec. 9, 2002

Hi list, http://bugs.winehq.com/show_bug.cgi?id=1157 It appears that when I'm copying the Windows fonts to C:\windows\Fonts, setting LANG to he_IL is all it takes for Hebrew to be displayed in edit controls and dialog boxes. When I try to copy the exact same fonts to /usr/lib/X11/fonts/windows, and adding them to the XF86Config fonts dir, and running ttmkfdir, no go. The fonts are available to Wine (and each is enumerated multiple times in the fonts dialog), but Hebrew is not displayed by default. Sometimes, when I force the CHARSET to HEBREW_CHARSET, I get Hebrew after all, but I'm not at all sure the same font is used then. In addition to this problem, I was wondering why we no longer enumerate the X fonts the moment there is ONE font file in c:\windows\Fonts? Is there a reason for them to magically disappear? Shachar

2 1