- Wine-Devel - list.winehq.org

RE: vxdcall calling convention
by Patrik Stridvall Nov. 18, 2002

Nov. 18, 2002

> On Mon, Nov 18, 2002 at 04:21:37PM +0100, Patrik Stridvall wrote: > > > Le lun 18/11/2002 à 02:51, Patrik Stridvall a écrit : > > > > > Corrects this line in winapi_check: > > > > > win32/device.c:544: kernel32: void > > > VxDCall(DWORD,CONTEXT86 *): calling > > > > > convention mismatch: cdecl != stdcall > > > > > > > > I'm not 100% sure this really is a bug. > > > > Don't trust winapi_check too much it is very ad hoc. :-) > > > > > > > > It might however be a bug but I never got around to test it > > > properly. > > > > > > > > So, have you verified that this really is correct? > > > > > > Well, kernel32.spec references them by "stdcall -register -i386". > > > Another API referenced the same way is CommonUnimpStub, and > > > in thunk.c, > > > it is declared as "void WINAPI". > > > > > > Is it sufficient checking? > > > > I'm not sure, it might be the other API(s) that are wrong > > or that VxDCall is a special case. That why I haven't dared > > changed anything. > > I think it needs to be WINAPI, the __wine_call_from_32_regs > assembler thunk > does not remove arguments from stack. Yes, I'm leaning in that direction as well the more I think about it. However, I don't think it is enough. It will work for the implemented VxDCall that pops the stack itself, however it will not work for unimplemented VxDCalls since they will not clean up the stack correctly AFAICS. Anyway, if so it has been wrong a long time (so long that I don't notice the warning from winapi_check any longer :-), so I wonder why it wasn't noticed by anybody else running an application using VxD calls.

2 1

RE: vxdcall calling convention
by Patrik Stridvall Nov. 18, 2002

Nov. 18, 2002

> Le lun 18/11/2002 à 02:51, Patrik Stridvall a écrit : > > > Corrects this line in winapi_check: > > > win32/device.c:544: kernel32: void > VxDCall(DWORD,CONTEXT86 *): calling > > > convention mismatch: cdecl != stdcall > > > > I'm not 100% sure this really is a bug. > > Don't trust winapi_check too much it is very ad hoc. :-) > > > > It might however be a bug but I never got around to test it > properly. > > > > So, have you verified that this really is correct? > > Well, kernel32.spec references them by "stdcall -register -i386". > Another API referenced the same way is CommonUnimpStub, and > in thunk.c, > it is declared as "void WINAPI". > > Is it sufficient checking? I'm not sure, it might be the other API(s) that are wrong or that VxDCall is a special case. That why I haven't dared changed anything. The problem with VxDCall is that is have multiple entries under different external names. ./dlls/kernel/kernel32.spec: 1 stdcall -register -i386 VxDCall0(long) VxDCall ./dlls/kernel/kernel32.spec: 2 stdcall -register -i386 VxDCall1(long) VxDCall ./dlls/kernel/kernel32.spec: 3 stdcall -register -i386 VxDCall2(long) VxDCall ./dlls/kernel/kernel32.spec: 4 stdcall -register -i386 VxDCall3(long) VxDCall ./dlls/kernel/kernel32.spec: 5 stdcall -register -i386 VxDCall4(long) VxDCall /dlls/kernel/kernel32.spec: 6 stdcall -register -i386 VxDCall5(long) VxDCall ./dlls/kernel/kernel32.spec: 7 stdcall -register -i386 VxDCall6(long) VxDCall ./dlls/kernel/kernel32.spec: 8 stdcall -register -i386 VxDCall7(long) VxDCall ./dlls/kernel/kernel32.spec: 9 stdcall -register -i386 VxDCall8(long) VxDCall Searching on the Internet reveals this page: http://www.mbs.spb.ru/kb/w32mbr.htm According to this page VxDCall[0-8] really should be stdcall. ---8<--- /* Kernel32 W32-caller prototypes */ DWORD WINAPI VxDCall0(DWORD service); DWORD WINAPI VxDCall1(DWORD service, DWORD); DWORD WINAPI VxDCall2(DWORD service, DWORD, DWORD); DWORD WINAPI VxDCall3(DWORD service, DWORD, DWORD, DWORD); DWORD WINAPI VxDCall4(DWORD service, DWORD, DWORD, DWORD, DWORD); DWORD WINAPI VxDCall5(DWORD service, DWORD, DWORD, DWORD, DWORD, DWORD); DWORD WINAPI VxDCall6(DWORD service, DWORD, DWORD, DWORD, DWORD, DWORD, DWORD); DWORD WINAPI VxDCall7(DWORD service, DWORD, DWORD, DWORD, DWORD, DWORD, DWORD, DWORD); DWORD WINAPI VxDCall8(DWORD service, DWORD, DWORD, DWORD, DWORD, DWORD, DWORD, DWORD, DWORD); ---8<--- and this ---8<--- vxdcall.def LIBRARY KERNEL32 EXPORTS VxDCall0(a)0 @1 VxDCall1(a)8 @2 VxDCall2(a)12 @3 VxDCall3(a)16 @4 VxDCall4(a)20 @5 VxDCall5(a)24 @6 VxDCall6(a)28 @7 VxDCall7(a)32 @8 VxDCall8(a)36 @9 ---8<--- However something with VxDCall is wrong nether the less. WINAPI functions (read: __stdcall) functions expects that the callee cleans up the argument stack and the number of arguments is different depending on which function is called. Looking at VxDCall (and what it calls) in win32/device.c I see that the implemented VxDCall pops the stack. However the unimplemented VxDCalls doesn't even though they might have gotten some arguments. This means AFAICS that VxDCall corrupts the stack in such cases... So I'm pretty convinced that something is wrong however I don't think you patch is the solution to the problem. It might possible be part of a solution though... Any suggestions?

2 1

RE: vxdcall calling convention
by Patrik Stridvall Nov. 18, 2002

Nov. 18, 2002

> Corrects this line in winapi_check: > win32/device.c:544: kernel32: void VxDCall(DWORD,CONTEXT86 *): calling > convention mismatch: cdecl != stdcall I'm not 100% sure this really is a bug. Don't trust winapi_check too much it is very ad hoc. :-) It might however be a bug but I never got around to test it properly. So, have you verified that this really is correct?

2 1

Re: Wine with .NET?
by Mark Hannessen Nov. 18, 2002

Nov. 18, 2002

> Ladies and Gentlemen, > > I am a Microsoft developer and currently pushing the capabilities of the > .NET Framework. On that same note, I am considering moving my laptop to > some version of Linux (either Solaris v8.0 or Red Hat). I assumed that > I would need to use VMWare or some equivalent to continue using Visual > Studio .NET. Can anyone give me some advice? > > Many thanx, > Fred Lackey > Orlando, Florida have you already tryd wine to run visual studio .NET ? in theory it is possible but i don't think anyone has ever tryd. ( and it will likely not work yet, feel free to send patches ) if you want to port visual studio .NET to linux using wine you should use winemaker. Mark Hannessen

7 8

RE: Nameless struct problem
by Patrik Stridvall Nov. 18, 2002

Nov. 18, 2002

> Dimitrie O. Paun wrote: > > >I had to use the following hack to allow this > >bit to go through my g++ compiler. > > > >I'm using RedHat 8.0, so this gives me: > > > >[dimi(a)dimi wine.src]$ g++ --version > >g++ (GCC) 3.2 20020903 (Red Hat Linux 8.0 3.2-7) > >Copyright (C) 2002 Free Software Foundation, Inc. > >This is free software; see the source for copying > conditions. There is NO > >warranty; not even for MERCHANTABILITY or FITNESS FOR A > PARTICULAR PURPOSE. > > > Glad you included the warranty bit :-) > > > > >Any ideas what's wrong here, and how it can be fixed? > > > > > Not particularly, but I know I've seen other examples of g++ > being more > strict / particular > about structs than gcc. What error do you get? You could try > -E for the > preprocessor > output and search through it for DUMMYSTRUCTNAME ; it could > be being defined > earlier on or somewhere else in a way that confuses it here... DUMMYSTRUCT is defined as nothing if the compiler supports nameless structs. GNU C++ was mistakenly believed by me to support nameless structs. I didn't check however, I have check now and it seem like no version of GNU C++ does. :-( Not that it really needs to support it since you could get the same effect with "dummy" structs/classes and inheritence, but then I really can't see any particular reason not to support it since makes at least as much sense (if not more) in C++ to have unnamed structs as in C... Anyway, there is a patch in wine-patches that fixes the problem and since it as I said is always possible to "fake it" in C++ there is no great need to ask the GNU C++ developers the fix the problem either...

1 0

Patch for bug 1150
by Andrew John Hughes Nov. 18, 2002

Nov. 18, 2002

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 This patch should resolve bug 1150, compiling commdlg with -DSTRICT. Hope this is okay - this is my first time hacking on Wine. The patch is also attached to the bug. - -- Andrew :-) Please avoid sending me Word or PowerPoint attachments. See http://www.fsf.org/philosophy/no-word-attachments.html -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.7 (GNU/Linux) iD8DBQE92DtTSE/kMce1ABARAgXdAJ0RKUv3appMGjMo1+TgyhyujuMzGwCdHhNc dYlWgrnc+lCHhrdfM2cwYXY= =hum9 -----END PGP SIGNATURE-----

1 0

RE: Nameless struct problem
by Patrik Stridvall Nov. 17, 2002

Nov. 17, 2002

> I had to use the following hack to allow this > bit to go through my g++ compiler. > > I'm using RedHat 8.0, so this gives me: > > [dimi(a)dimi wine.src]$ g++ --version > g++ (GCC) 3.2 20020903 (Red Hat Linux 8.0 3.2-7) > Copyright (C) 2002 Free Software Foundation, Inc. > This is free software; see the source for copying conditions. > There is NO > warranty; not even for MERCHANTABILITY or FITNESS FOR A > PARTICULAR PURPOSE. > > Any ideas what's wrong here, and how it can be fixed? Yes, it seems that GNU C++ 3.2 (unlike GNU C 3.2) doesn't support unnamed structs. Strange. Not that it really matters that much because you could do "magic" with inheritance in C++. See below. > Index: include/winuser.h > =================================================================== > RCS file: /var/cvs/wine/include/winuser.h,v > retrieving revision 1.152 > diff -u -r1.152 winuser.h > --- include/winuser.h 4 Nov 2002 22:47:59 -0000 1.152 > +++ include/winuser.h 17 Nov 2002 01:32:56 -0000 > @@ -2387,13 +2387,13 @@ > > typedef struct tagMONITORINFOEXA > { > - MONITORINFO DUMMYSTRUCTNAME; > + MONITORINFO DUMMYSTRUCTNAMEx; > CHAR szDevice[CCHDEVICENAME]; > } MONITORINFOEXA, *LPMONITORINFOEXA; > > typedef struct tagMONITORINFOEXW > { > - MONITORINFO DUMMYSTRUCTNAME; > + MONITORINFO DUMMYSTRUCTNAMEx; > WCHAR szDevice[CCHDEVICENAME]; > } MONITORINFOEXW, *LPMONITORINFOEXW; This uses inheritance with C++ in the Microsoft SDK. Working on patch. Coming very soon.

1 0

Nameless struct problem
by Dimitrie O. Paun Nov. 17, 2002

Nov. 17, 2002

I had to use the following hack to allow this bit to go through my g++ compiler. I'm using RedHat 8.0, so this gives me: [dimi(a)dimi wine.src]$ g++ --version g++ (GCC) 3.2 20020903 (Red Hat Linux 8.0 3.2-7) Copyright (C) 2002 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. Any ideas what's wrong here, and how it can be fixed? Index: include/winuser.h =================================================================== RCS file: /var/cvs/wine/include/winuser.h,v retrieving revision 1.152 diff -u -r1.152 winuser.h --- include/winuser.h 4 Nov 2002 22:47:59 -0000 1.152 +++ include/winuser.h 17 Nov 2002 01:32:56 -0000 @@ -2387,13 +2387,13 @@ typedef struct tagMONITORINFOEXA { - MONITORINFO DUMMYSTRUCTNAME; + MONITORINFO DUMMYSTRUCTNAMEx; CHAR szDevice[CCHDEVICENAME]; } MONITORINFOEXA, *LPMONITORINFOEXA; typedef struct tagMONITORINFOEXW { - MONITORINFO DUMMYSTRUCTNAME; + MONITORINFO DUMMYSTRUCTNAMEx; WCHAR szDevice[CCHDEVICENAME]; } MONITORINFOEXW, *LPMONITORINFOEXW; -- Dimi.

2 1

Problem running Anstoss2 under Wine
by Adrian Bunk Nov. 17, 2002

Nov. 17, 2002

I'm trying to run Anstoss2 (a five years old German soccer simulation - I'm only interested in the strategic part of the game) under Wine. I tried the Debian package of the 20021031 Release and a self-compiled package of a 20021116 CVS snapshot. The following messages occur during the start of the game: <-- snip --> $ wine anstoss2.exe fixme:file:DEVICE_Open Unknown/unsupported VxD SICE. Try setting Windows version to 'nt40' or 'win31'. fixme:file:DEVICE_Open Unknown/unsupported VxD NTICE. Try setting Windows version to 'nt40' or 'win31'. err:ntdll:RtlpWaitForCriticalSection section 0x400f10bc "../../loader/module.c: loader_section" wait timed out, retrying (60 sec) tid=081b1ce0 fixme:ddraw:Main_DirectDraw_SetCooperativeLevel (0x403a7528)->(00010024,00000008) fixme:ddraw:Main_DirectDrawClipper_Initialize (0x403a7e38)->(0x403a7534,0x00000000),stub! err:msg:DispatchMessageW BeginPaint not called on WM_PAINT for hwnd 10026! err:msg:DispatchMessageA BeginPaint not called on WM_PAINT for hwnd 10026! err:msg:DispatchMessageA BeginPaint not called on WM_PAINT for hwnd 10026! fixme:ddraw:Main_DirectDraw_SetCooperativeLevel (0x403a7428)->(0002002d,00000008) fixme:ddraw:Main_DirectDrawClipper_Initialize (0x403ae128)->(0x403a7434,0x00000000),stub! fixme:ddraw:DIB_DirectDrawSurface_Blt dwFlags DDBLT_WAIT and/or DDBLT_ASYNC: can't handle right now. <-- snip --> The "DEVICE_Open" messages might be related to the copy protection (?). At the beginning I see a small "Cannot open file" window [1] that seems to be non-fatal. The screenshot at [2] shows the main problem I observe: Something with the left-right justification of elements doesn't work. There are three checkbuttons and the one besides "Neues Spiel beginnen" is selected and that's the place where you can select it - but the background black circles that should indicate where you are able to click are 2cm left and a bit ahead of the correct location. The smiling ball at the right bottom is the place to click when you are finished with this page - but it's outside the rest, the thing that is painted in the two light blue colors (e.g. the "ADY" at the left bottom) is the background picture of my window manager. If there's any other information that might help simply ask. TIA Adrian [1] http://www.fs.tum.de/~bunk/TMP/cannot-open-file.png [2] http://www.fs.tum.de/~bunk/TMP/anstoss2-start.png -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed

1 0

Re: some ismbc* functions: third try
by Dmitry Timoshkov Nov. 17, 2002

Nov. 17, 2002

"Greg Turner" <gmturner007(a)ameritech.net> wrote: > totally untested, but it does compile, and seems logical > enough. while i was at it, i added a few more. Probably it would be better to create a common internal function which accepts C1_???? flags, does all remaining common operations with converting character(s) to unicode and returns (ctype & flags) != 0? -- Dmitry.

2 1