- Wine-Devel - list.winehq.org

RE: C++ tests (1/2)
by Patrik Stridvall Nov. 15, 2002

Nov. 15, 2002

> Patrik Stridvall <ps(a)leissner.se> writes: > > > Many normal "C" features are not commonly used either, shouldn't we > > have tests for them? > > If all the C framework could do was test the alignment of a few rarely > used structures, then it would clearly not be worth the > trouble either. Perhaps. But that is only ONE of the things we could do. Unless you have noticed the meantion examples (repeated below) contains INLINE FUNCTIONS that needs to be tested not just alignment and that sort of things. < A FEW examples of C++ only features: < 1. The D3D math classes (vector, matrices, quaternions, colors etc) in < d3dvec.inl d3dx8math.inl d3dxmath.inl < 2. The GDI+ API classes in gdiplus*.h < 3. The DAO API classes in dbdao.h < 4. STL compatible classes for accessing SAFEARRAY's in t_safevector.h

1 0

RE: C++ tests (1/2)
by Patrik Stridvall Nov. 15, 2002

Nov. 15, 2002

> Patrik Stridvall <ps(a)leissner.se> writes: > > > So my questions to you: > > 1. Should we support the C++ only features meantion above? > > 2. If yes, should we just include it in the tree without tests > > and just hope it works or should we have C++ tests for them? > > When someone has an app that requires these features they can > implement them, and test them by building their app. Or we can > implement them and write a small test program to test them once. The same can be said about every "C" feature as well. > No > need to build a new test environment for such uncommon features. Many normal "C" features are not commonly used either, shouldn't we have tests for them? Look, the point of tests is not testing once. It is testing for regressions when the code changes. > > I see no relevent comparsion between them: > > 1. C++ is actually used by the Microsoft SDK. Perl is not. > > 2. The Perl framework was big and required generated modules. > > The C++ framework is very small and uses the Wine header files > > as they are (or should be in order to be Microsoft compatiable) > > The issue is not really the size of the framework, it's the extra > dependencies. It would require everybody who wants to run tests to > have a working, compatible C++ installation; given the various levels > of brokenness of existing g++ versions that's far from trivial. Very true. Thanks for reminding me that it should be an optional feature. It you want to use it: ./configure --with-cxx No problem.

2 1

COM Enhancement patch
by Christian Costa Nov. 15, 2002

Nov. 15, 2002

Hi all, I've sent a patch for ddraw COM management, I did not have any comments and the patch has been rejected. Could someone tell me if something is wrong or lacking? Christian. PS: I've joined a small doc that explains how to use objects with multiple interfaces. This docs is based on what has been done before with the ddraw code plus the enhancement I did. --------------------------------------------------------------------------------- - COM OBJECTS MANAGEMENT - --------------------------------------------------------------------------------- 1) Definitions: --------------- a) Object classes An object class is a structure wich defines the data of an object and all the interfaces that act on the object data Example : struct ObjectClass { INTERFACE 1; INTERFACE 2; ............ INTERFACE N; DATA; } ; typedef struct ObjectClass ObjectClass; b) Objects An object is a instance of an object class. Example : An object is created as follows : ObjectClass* object = malloc(sizeof(ObjectClass),...) c) Interfaces An interface is a way for an application to interact with an object. It contains a pointer to a virtual table plus some other data than can help objects management. An interface is a structure, which is used internally, that can be defined with the INTERFACE macro : #define INTERFACE(iface) \ struct { \ iface interface; \ /* VTABLE */ LPVOID object; \ /* pointer to the object the interface belongs to */ } To add a field to the interface, just add it in this macro. For example, we could embed the version number inside an interface or a magic number to check if the interface's pointer points to a real interface. And, off course, modify some macros or create new ones to make use of them. 2) Implementing COM objects: --------------------------- a) Declaring a COM object with multiple interfaces To declare interfaces in a COM object the ICOM_VFIELD_MULTI must be used for each interface as shown below: struct IDirect3DImpl { /* IUnknown fields */ ICOM_VFIELD_MULTI(IDirect3D); ICOM_VFIELD_MULTI(IDirect3D2); ICOM_VFIELD_MULTI(IDirect3D3); ICOM_VFIELD_MULTI(IDirect3D7); DWORD ref; /* IDirect3D fields */ IDirectDrawImpl* ddraw; LPVOID private; }; b) Creating an object Just declare an pointer to an object and allocate the memory for it. Example: IDirect3DImpl* object = malloc(sizeof(IDirect3DImpl),...) c) Initializing interfaces It is done with the ICOM_INIT_INTERFACE(object_pointer, interface_name, virtual_table) ICOM_INIT_INTERFACE(object,IDirect3D, VTABLE_IDirect3D); ICOM_INIT_INTERFACE(object,IDirect3D2,VTABLE_IDirect3D2); ICOM_INIT_INTERFACE(object,IDirect3D3,VTABLE_IDirect3D3); ICOM_INIT_INTERFACE(object,IDirect3D7,VTABLE_IDirect3D4); d) Retreive an object from within an interface's function If we consider the function : IDirect3D_AddRef(IDirect3D iface,.......) To retrieve a pointer to an object within the function, both followings macro are used : 1) ICOM_OBJECT(object_class,iface) This macro return an pointer to the object, the value is of object_class* type Example: IDirect3DImpl* d3d = ICOM_OBJECT(IDirect3DImpl,iface); 2) ICOM_THIS_OBJECT(object class,iface) It simply declares a This pointer and initialize it with the object address. IDirect3DImpl* This = ICOM_OBJECT(IDirect3DImpl,iface); e) Sharing functions between multiple interfaces In the case where a function does no have to do specific actions depending on the interface, you can share directly a function. Example : If we consider the function : IDirect3D_AddRef(IDirect3D iface,.......) The different virtual tables would be : VTABLE_IDirect3D = {......,IDirect3D_AddRef,....); VTABLE_IDirect3D2 = {......,XCAST()IDirect3D_AddRef,....); VTABLE_IDirect3D3 = {......,XCAST()IDirect3D_AddRef,....); VTABLE_IDirect3D7 = {......,XCAST()IDirect3D_AddRef,....); Note that this is possible because the ICOM_OBJECT can retreive the object's pointer without knowing the interface involved. f) Thunking interface Interface thunking enable changing from one interface to another. The following macro COM_INTERFACE_CAST(impltype, ifnamefrom, ifnameto, ifaceptr) performs this task. impltype = object class ifnamefrom = interface type we have ifnamefrom = interface type we want ifaceptr = pointer to the interface to cast return = pointer to the casted interface Interface thunking is a another way to shared a single function across different interfaces but as shown below this is required only when structures must be translated, interfaces returned casted or to handle prototype change : Example: You want to share the IDirect3D_CreateDevice across all IDirect3DX interfaces (with X above 1 because a device in Direct3D is created in a different way). IDirect3D2_CreateDevice(IDirect3D2* iface,.....) is the only one implementation of the function. The others are thunks to the IDirect3D2_CreateDevice. IDirect3D3_CreateDevice(IDirect3D3* iface, .....,LPDIRECT3DDEVICE3 *lpdevice, LPUNKNOWN lpUnk) { IDirect3DDevice3 *dev; IDirect3D_CreateDevice(ICOM_INTERFACE_CAST(IDirect3DImpl,IDirect3D2,IDirect3D3,iface),.....,&dev); *lpdevice = ICOM_INTERFACE_CAST((IDirect3DImpl,IDirect3D3,IDirect3D2,device) } IDirect3D7_CreateDevice(IDirect3D7* iface, .....,LPDIRECT3DDEVICE7 *lpdevice) { IDirect3DDevice2 *dev; IDirect3D_CreateDevice(ICOM_INTERFACE_CAST(IDirect3DImpl,IDirect3D2,IDirect3D7,iface),.....,&dev); *lpdevice = ICOM_INTERFACE_CAST((IDirect3DImpl,IDirect3D7,IDirect3D2,dev) } Here, we have to deal with a returned interface and a prototype change. The VTABLE should be: VTABLE_IDirect3D2 = {......,IDirect3D2_CreateDevice,....); VTABLE_IDirect3D3 = {......,IDirect3D3_CreateDevice,....); VTABLE_IDirect3D7 = {......,IDirect3D7_CreateDevice,....); Note that there are few functions that need this, for the others, thunks are not necessary and the way described in e) must be preferred. g) Getting an specific interface of an object With the ICOM_INTERFACE(implobj, ifacename) macro, any interfaces can be retreive from an object. implobj = pointer to the object ifacename = interface name we want return = pointer to an interface Example: IDirect3DImpl* object; ............ IDirect3D3* iface_d3d3 = ICOM_INTERFACE(object,IDirect3D3) h) Calling an COM object functions from another If a function is shared across multiple interfaces, you should write: IDirect3D3_CreateDevice(IDirect3D* iface,.....) { ICOM_THIS_OBJECT(iface); ................. IDirect3D_AddRef(ICOM_INTERFACE(This,IDirect3D),.....); ................. } If you know the nature of iface (i.e. thunking is used or the function is used in only one interface), you can write : IDirect3D3_CreateDevice(IDirect3D* iface,.....) { ICOM_THIS_OBJECT(iface); ................. IDirect3D3_AddRef(iface,.....); ................. }

6 6

Wine without any X11 environment
by Michael Riedel Nov. 15, 2002

Nov. 15, 2002

Hello, is it possible to use wine in a telnet session to start a (command line) windows application? I get the error that x11drv can't connect to a display (which is correct). I'm also not very sure that the windows program itself does not perform some graphic related queries (there were some fixme messages when I tried to use 'ttydrv'). Any ideas? Is there any workaround to use a dummy display or whatever? Thanks, Michael --

3 3

Re: StgIsStorageFile
by Dmitry Timoshkov Nov. 15, 2002

Nov. 15, 2002

"Ryan Cumming" <ryan(a)completely.kicks-ass.org> wrote: > On a side note, I made a pretty nice testcase for this, but there seems to be > no dlls/ole32/tests directory. Just send a file with tests to wine-patches and somebody else will make a makefile magic for you. -- Dmitry.

3 3

Re: wine/ programs/rundll32/rundll32.c dlls/kernel ...
by Martin Wilck Nov. 15, 2002

Nov. 15, 2002

Am Fre, 2002-11-15 um 05.17 schrieb Alexandre Julliard: > ChangeSet ID: 6302 > Modified files: > programs/rundll32: rundll32.c > dlls/kernel : computername.c > > Log message: > Warning fixes. Your compiler seems to issue more warnings than mine :-/ It is good to see these patches are really reviewed. The lenW thingy is really embarrassing for me. Two questions/remarks: @@ -426,12 +426,13 @@ memcpy( name, buf, len ); name[len] = 0; *size = len; + ret = TRUE; This shouldn't be necessary because the whole block is executed only if ret == TRUE. } } __EXCEPT(page_fault) { SetLastError( ERROR_INVALID_PARAMETER ); - ret = FALSE; + return FALSE; } __ENDTRY What is the point of this one? (applies also to the last hunk) Martin -- Martin Wilck Phone: +49 5251 8 15113 Fujitsu Siemens Computers Fax: +49 5251 8 20409 Heinz-Nixdorf-Ring 1 mailto:Martin.Wilck(a)Fujitsu-Siemens.com D-33106 Paderborn http://www.fujitsu-siemens.com/primergy

2 1

RE: C++ tests (1/2)
by Patrik Stridvall Nov. 15, 2002

Nov. 15, 2002

> Patrik Stridvall <ps(a)leissner.se> writes: > > > Then of course we want normal C++ tests as well. Many (most?) > > applications likely to be ported by Winelib are C++ application > > so we really should have tests for possible C++ problems. > > The Wine tests are supposed to test the implementation, That is their primary use, yes. However I see no need to limit it to that. > not the > compilation. If some code interfaces incorrectly with Winelib, because of C++ problems or whatever, it doesn't really matter if the implementation is correct, does it? The result will still be wrong. Interface problems are inherently compilation specific. So yes, I really think we should have some tests for them. Sure I don't have much hope of catching that many bugs but then, it givens at least some confidence that the interface is reasonable bug free. > And building C++ apps with Winelib is a complex issue > that you won't be able to test in the Wine framework, except with > carefully tweaked code that won't match what real apps do anyway. > > Frankly, the likelihood of catching a real problem that way is much > too small to justify the complexity of a whole new test environment. What complexity? The patch is very small and half of it concerns the .c.cxx hack to compile tests with both with C and C++, that I can remove if you wish. Except for the file extension choping, it is possible to do with only changing "Makefile:s". Anyway if you don't accept the somewhat abstract argument above, here are some more concrete ones: How are we supposed to test specific C++ features in the Winelib header. Sure we doesn't have many yet, primarily because only C++ Winelib application needs then and we don't have any in the tree so we don't need that ourselves. But some (many?) C++ application ports from Windows certainly does. Sure we can add them to the Wine tree without any tests but if they are neither used internal nor tested they are very likely to be wrong. And yes, there are quite a lot of C++ only feature in the Microsoft SDK that are not in Wine yet. A FEW examples of C++ only features: 1. The D3D math classes (vector, matrices, quaternions, colors etc) in d3dvec.inl d3dx8math.inl d3dxmath.inl 2. The GDI+ API classes in gdiplus*.h 3. The DAO API classes in dbdao.h 4. STL compatible classes for accessing SAFEARRAY's in t_safevector.h Then of course we have COM... Sure we can test it in C to a large extent, but will it be enough? So my questions to you: 1. Should we support the C++ only features meantion above? 2. If yes, should we just include it in the tree without tests and just hope it works or should we have C++ tests for them? > We just got rid of the Perl framework, please let's not add a new one. I see no relevent comparsion between them: 1. C++ is actually used by the Microsoft SDK. Perl is not. 2. The Perl framework was big and required generated modules. The C++ framework is very small and uses the Wine header files as they are (or should be in order to be Microsoft compatiable)

2 1

Wine Fun Projects v0.2
by Dimitrie O. Paun Nov. 15, 2002

Nov. 15, 2002

Folks, The second release (much expanded) of the Fun Project page has been released, in all it's glory, at: http://www.dssd.ca/wine/Wine-Fun-0.2.html The working version of the above is at: http://www.dssd.ca/wine/Wine-Fun.html By now, you should know that comments, suggestions, and flames are not only appreciated, but expected. -- Dimi.

4 6

Re: Quick question about ANSI and Unicode
by Dustin Navea Nov. 15, 2002

Nov. 15, 2002

I fixed it, dang outlook defaults. Dustin ----- Original Message ----- From: "Tony Lambregts" <tony_lambregts(a)telusplanet.net> To: "Dustin Navea" <speeddymon(a)ev1.net> Sent: Friday, November 15, 2002 10:33 AM Subject: Re: Quick question about ANSI and Unicode > Dustin Navea wrote: > > > Ok, as you may have noticed Dimi sent a couple of patches that were > > supposed to fix Treeview Notifies a couple of weeks back. They didnt > > exactly work, but its not that the code he submitted didnt help. > > Basically when running the StarCraft installer in wine, it attempts to > > display the treeview-based directory listing in unicode which isnt > > supported by that installer, and so it ends up not showing anything. > > I was wondering if anyone thinks that the fact that my TextCP=0 in the > > wine config file has anything to do with it. I'm thinking that if I > > set it to TextCP=1252 or TextCP=437 then it will work as expected, but > > I have no way of testing this until tonight, as I'm not on a Linux box > > right now, being at work and all. Just thought I would check with > > everyone and see what they thought. > > > > Comments appreciated. > > > > I am sorry I can't help with the codepage thing. However, I am sure > that you didn't mean to, but you sent this in html format, and you know > this list is text only... Do you need some help with setting up outlook > to send text only? > > -- > > Tony Lambregts > > > >

1 0

RE: Wine without any X11 environment
by Patrik Stridvall Nov. 15, 2002

Nov. 15, 2002

> is it possible to use wine in a telnet session to start a > (command line) > windows application? Yes. > I get the error that x11drv can't connect to a > display (which is correct). I'm also not very sure that the windows > program itself does not perform some graphic related queries (there were > some fixme messages when I tried to use 'ttydrv'). If the application directly or indirectly loads GDI32.DLL or USER32.DLL it also load the x11drv with the result above if DISPLAY isn't set. > Any ideas? Is there any workaround to use a dummy display or whatever? In addition to the ttydrv (as you meantion above) you can use VNC like: vncserver :1 export DISPLAY=:1

1 0