- Wine-Devel - list.winehq.org

CallNextHookEx16 strageness
by Michael Stefaniuc July 27, 2002

July 27, 2002

Hello, while trying to convert HHOOK to a void* i found this strangeness: CallNextHookEx16 expects its first parameter to be a real HHOOK, that means it checks the HIWORD of the HHOOK to see it it contains 'HK' if (HIWORD(hhook) != HOOK_MAGIC) return 0; /* Not a new format hook */ In wine there are only 2 functions that call CallNextHookEx16, one is DefHookProc16, the other is ShellHookProc16. The first one calls CallNextHookEx16 with first parameter queue->hCurHook (an HANDLE16), the second one with WH_SHELL (the number 10). This parameters gets implicitly transformed to a HHOOK and will have their HIWORD set to 0, thus CallNextHookEx16 will always fail and return 0. I don't know what the right fix would be, I'm seeing two possibilities: - remove in CallNextHookEx16 the check if (HIWORD(hhook) != HOOK_MAGIC) return 0; - or transform in DefHookProc16 and ShellHookProc16 the first parameter passed to CallNextHookEx16 to a real HHOOK with the HIWORD set to 'HC' Comments? bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 System Administration Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

3 4

Re: shlwapi cleanup
by Alexandre Julliard July 27, 2002

July 27, 2002

"Jürgen Schmied" <juergenschmied(a)lycos.de> writes: > --- wine/dlls/shlwapi/Makefile.in 22 Jul 2002 20:32:53 -0000 1.21 > +++ wine/dlls/shlwapi/Makefile.in 24 Jul 2002 19:21:55 -0000 > @@ -4,8 +4,8 @@ > SRCDIR = @srcdir@ > VPATH = @srcdir@ > MODULE = shlwapi.dll > -# fixme: avoid ole32.dll import > -IMPORTS = ole32 user32 gdi32 advapi32 kernel32 > +IMPORTS = advapi32 gdi32 kernel32 user32 > +DELAYIMPORTS = comctl32 comdlg32 mpr ole32 shell32 version winmm Some of these (like shell32) will create circular dependencies. This must be avoided, our build process doesn't handle that. -- Alexandre Julliard julliard(a)winehq.com

2 2

Re: How to mantain complete CVS repository
by Max July 27, 2002

July 27, 2002

Thanx, Dimitrie, t works good and it's really fast! Regards Max

1 0

Compiling dll's
by steve_lustbader＠hsgmed.com July 26, 2002

July 26, 2002

I'm trying to build a dll using WineLib. The source compiles fine under windows. When I try to compile it with winelib, I get this error: c++ -shared -Wl,-rpath,/usr/local/lib -Wl,-Bsymbolic -o liberrh_auto.dll.so errh.o errhReg.o liberrh_auto.dll.spec.o -lwine -lwine_unicode -lwine_uuid -lm liberrh_auto.dll.spec.o: In function `LoadStringW': liberrh_auto.dll.spec.o(.data+0x188): undefined reference to `DllMain' My spec file only contains this line: init DllMain And DllMain is defined in errh.cpp as (it's not prototyped in errh.h): BOOL APIENTRY DllMain( HINSTANCE h,DWORD d, LPVOID l) Any help? ****************************** Steve Lustbader

2 1

Re: How to mantain complete CVS repository
by Tony Lambregts July 26, 2002

July 26, 2002

LUSTBADER,STEVE (Non-A-hsgAndover,ex1) wrote: >So there's no reason to use tools/wineinstall if you're just updating the source? > > > Yes, wineinstall sets up your ~/.wine/config file and the default registries in addition to compiling wine so most of the time if you already have these set up then it is not nessesary to use wineinstall. However the structure of both the .wine/config and registries and thier contents has changed over time and as new features are added to wine. For example over time more functionality has been added to the various dlls and in the default config file various dlls now default to builtin rather than native. So running wineinstall once a month and letting it overwrite your old config is not a really bad idea. Your old config is called config.sav and you can run "diff -u config.sav config>config.dif" to see what it has changed . Tony Lambregts

1 0

Re: PATCH: temp file fixes
by Gregg Mattinson July 26, 2002

July 26, 2002

>+ xstart = tmpfn+strlen(tmpfn); >+ while ((xstart > tmpfn) && (*xstart == 'X')) >+ xstart--; Marcus, the chunk of code above looks slightly wrong to me. Shouldn't it be: xstart = tmpfn + strlen(tmpfn) - 1; Here's why: If tmpfn is "X", then strlen(tmpfn) = 1. Hence, xstart will point to the '\0' at the end of the string, and hence the loop will never be run. Other than that, your patch looks great. Gregg Mattinson Co-op Developer Sun Microsystems of Canada

1 0

Re: Dinput - Keyb Bug
by Kristoffer Ericson July 26, 2002

July 26, 2002

Just a small update: I load the Dinput.dll (DirectX5, but DX6 works also) that fixes keyboard. I'm trying now to get OpenGL to work, i've run through the ./configure --enable-opengl, and checked the config.log to see that everything checks out (Which it does). OpenGl in X windows works fine OpenGl in windows demos also works fine (tried a couple small ones, where i clearly can see that opengl is in use) When i run the game it doesn't detect my OpenGL (i can't select it under video) so i've been trying to get it to work all day. When using a -dll opengl32.dll=n it can set the mode to opengl, but Tribes immediatly crashes after klicking apply. I've checked around on the web and found some old logs that tell about the exact same problem. http://www.winehq.com/hypermail/wine-users/2001/03/0630.html (OPENGL in Tribes) I get the exact same errors as that person, minus the mouse errors.. I've also tried an interesting thing that could be of some use for others, considering Tribes also can use Glide i got an idea to try a windows Glide-Wrapper = Translates Glide instructions into OpenGL. It worked somewhat, but due the lack of any 100% glidewrappers and that they are generally slow it wasn't a good solution. But i can imagine other "glide" based games would work with this, if there's no other choice. Isn't there anyway to nativly do this in linux? Best Wishes _________________________________________________________________ Chat with friends online, try MSN Messenger: http://messenger.msn.com

2 1

How to mantain complete CVS repository
by Max July 26, 2002

July 26, 2002

I downloaded complete CVS wine repository, but the instructions on how to use CVSUP to mantain it up to date are not complete (for me at least !). Can anybody explain me how to do it ? Thanx in advance Max

3 2

Symbol __strtol_internal is invalid
by Kevin DeKorte July 26, 2002

July 26, 2002

All, In the last couple of days I have been getting this in the WINE-DBG in apps where I was not getting this before... Specifically Smart Suite's WordPro. This did not seem to happen with the original 20020710 release. Wine 20020710 from CVS (current as of 7/25) I got this. (Lots of symbol data cut out). I can reproduce 100% of the time. Load WordPro and select "Create Blank Document" then boom. Looks to me like something got removed out of a lib. Symbol __strtol_internal is invalid 0x40a27c3a (_LocalServerThread+0x92 [compobj.c:1141] in ole32.dll.so): call *0x0(%ecx) 1141 hres = IUnknown_QueryInterface(newClass->classObject,&IID_IClassFactory,(LPVOID*)&classfac); Wine-dbg> 0x40a27c3a (_LocalServerThread+0x92 [compobj.c:1141] in ole32.dll.so): call *0x0(%ecx) 1141 hres = IUnknown_QueryInterface(newClass->classObject,&IID_IClassFactory,(LPVOID*)&classfac); Wine-dbg> 1141 hres = IUnknown_QueryInterface(newClass->classObject,&IID_IClassFactory,(LPVOID*)&classfac); Wine-dbg> Wine-dbg> ===== --------------------------------- Kevin DeKorte kdekorte(a)yahoo.com __________________________________________________ Do You Yahoo!? Yahoo! Health - Feel better, live better http://health.yahoo.com

2 1

Re: wine/dlls/shell32 shellord.c shlexec.c
by Duane Clark July 26, 2002

July 26, 2002

Alexandre Julliard wrote: > ChangeSet ID: 1027537179446510804425092 > CVSROOT: /opt/cvs-commit > Module name: wine > Changes by: julliard(a)wine.codeweavers.com 02/07/24 13:59:39 > > Modified files: > dlls/shell32 : shellord.c shlexec.c > > Log message: > Duane Clark <dclark(a)akamail.com> > Combined implementations of ShellExecute/Ex. > > Patch: http://cvs.winehq.com/patch.py?id=1027537179446510804425092 > > Revision Changes Path > 1.100 +0 -186 wine/dlls/shell32/shellord.c > 1.4 +326 -111 wine/dlls/shell32/shlexec.c Ouch, that version had some serious bugs. It would be much better to apply the version I posted to wine-devel, which I think works pretty good. I can supply a diff between this version and the fixed one, if desired.

6 13