- Wine-Devel - list.winehq.org

Re: PATCH: a bit further with a cygwin build (fixed patch)
by Francois Gouget July 31, 2002

July 31, 2002

On Tue, 30 Jul 2002, Rafael Kitover wrote: > Sorry, due to brain-deadness on my part the previous version of this > patch didn't build properly. This version is much cleaner and builds > properly on linux. > +#ifndef HAVE__FSTAT > int _fstat(int fd, struct _stat* buf) > +#else > +int MSVCRT(_fstat)(int fd, struct _stat* buf) > +#endif /* HAVE__FSTAT */ ... > +#ifndef HAVE__STAT > int _stat(const char* path, struct _stat * buf) > +#else > +int MSVCRT(_stat)(const char* path, struct _stat * buf) > +#endif /* HAVE__STAT */ You should systematically use MSVCRT(_fstat) and MSVCRT(_stat). Your previous patch was better :-) Basically, we use MSVCRT(xxx) for all symbols for which we may get a conflict with the native C library headers. On Unix systyems, the _xxx functions are never defined (though there may be a couple of exceptions) so we don't use MSVCRT() for readability's sake. But if you find a system where there is a conflict, then it's best to just systematically use MSVCRT() than to use ifdefs that make it even harder to read. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Any sufficiently advanced Operating System is indistinguishable from Linux

1 0

dos console apps question
by Chris Morgan July 30, 2002

July 30, 2002

Lately I've been trying to get some dos console apps running under wine. These apps run great under wineconsole but not so much just under wine due to the lack of a server side console for the routines in dlls/msdos/vga.c to output too. So, after poking all around it seems that at some point during the normal loading of an app that we should be calling out to the server with alloc_console to create a default console, and binding this console to the current terminal. Does anyone have any suggestions about this? What function this should be done in? Thanks, Chris

4 3

Re: Toolbar redraw problem
by Dusan Vujosevic July 30, 2002

July 30, 2002

I will add a bit later today it and put in the test app as well. Thanks, D. > > >---- Original Message ---- >From: galberte(a)neo.lrun.com >To: dusanv(a)cadlink.com, wine-devel(a)winehq.com >Subject: Re: Toolbar redraw problem >Date: Mon, 29 Jul 2002 21:09:06 -0400 > >> >>----- Original Message ----- >>From: "dusanv" <dusanv(a)cadlink.com> >>To: "wine-devel" <wine-devel(a)winehq.com> >>Sent: Monday, July 29, 2002 4:27 PM >>Subject: Toolbar redraw problem >> >> >>> Hi, >>> >>> I am seeing a bunch of apps have redrawing problems when a toolbar >is >>> dragged accross the window. Here's a screen shot: >>> >>> http://dusanv.net/files/wine-ss.png >>> >>> Does anyone have any info on this? I'd like to fix it but can't >find >>> anyhting relevant. >>> >> >>Could you please create a bug in Wine's Bugzilla >http://bugs.winehq.com/. >> >>And if that is a test program, that would be good to ad also. I >suspect that >>somewhere during the drag operation, the rectangle invalidated does >not >>contain the edges. It will be fun to find. >> >>Thanks, >>Guy >> >> >> >>

1 0

Re: Re: dos console apps question
by chrismorgan＠rcn.com July 30, 2002

July 30, 2002

> > From: Eric Pouech <eric.pouech(a)wanadoo.fr> > Date: 2002/07/29 Mon PM 12:34:11 EDT > To: Chris Morgan <cmorgan(a)alum.wpi.edu>, Jukka Heinonen <jhei(a)iki.fi>, > DanKegel <dank(a)kegel.com> > CC: wine-devel(a)winehq.com > Subject: Re: dos console apps question > > Chris Morgan a écrit : > > > > Lately I've been trying to get some dos console apps running under wine. > > These apps run great under wineconsole but not so much just under wine due to > > the lack of a server side console for the routines in dlls/msdos/vga.c to > > output too. So, after poking all around it seems that at some point during > > the normal loading of an app that we should be calling out to the server with > > alloc_console to create a default console, and binding this console to the > > current terminal. Does anyone have any suggestions about this? What > > function this should be done in? > > I don't think this is needed... normally, a program doesn't have to deal > with the creation of it's console > it's up to its parent > > however, what you're facing right now is running a DOS program directly > from the unix prompt (like wine mydospgm.com) > in this case, there is no way for the parent process to tell something > to its child, you it's up to you to do it by running the program with > wineconsole mydospgm.com > the only programs so far that may have to deal with creating a console > are: > - wcmd (but in fact it could deal with the current one) > - winedbg because we don't want the debugger to mix it's output with the > debuggee's one > > maybe something that will be done when the process creation bits are > done is as follows: > - the wine (or winewrapper) will just parse the unix parameters and then > call CreateProcess to spawn the child process > - this wine executable could then be in charge (if the process requested > for execution is a CUI process) to allocate a new console and ask > CreateProcess to make the child process inherit it. > - however, this scheme must also deal with the situation where we want > the child process to either use the current unix shell (btw, I have a > working version of wineconsole using (n)curses which does just that > (1)), or be retargeted to /dev/null (for example) > - in any case, we will need some more parameters to be giving at the > starting time (and yes, this could also be a per app setting in the > registry) > > (1): what's currently missing is a clean way to choose in wineconsole > between the (well known) windows (GDI/USER) version and (not yet > committed) (n)curse for display > > A+ > > Having the process use the current term window is exactly what I'm looking for. How far along is the patch you have and would you be in need of any assistance? I'm not sure what you mean by not being able to have the parent process communicate with the child process and how this affects things. Is the problem how to capture and render the output from the application that was directed to the console and the standard handles? Couldn't this just be done in the appropriate win32 console functions for input/output and with standard unix handles passed around for stdio? Thanks, Chris

2 1

winedbg again :-)
by Max July 30, 2002

July 30, 2002

Some questions about winedbg usability ! 1) - Would it difficult to add an options (something like SHOWREGS=on/off) that allows to have regs displayed automatically after a breakpoint AND after a NEXTI command ? I find it painful to have to issue NEXTI and then INFO REGS each time.... remember old good ms-dos debugger !!! :-) 2)- What about the possibility to set off-code breakpoints ? It happens often that I must set a break (in asm code) that is in a DLL which isn't already loaded... That gives a BAD ADRESS, of course. Borland debugger accepts the breakpoints and set it when the code gets loaded. Now the only way is to set breaks in dll-loading routine, wait up to the wanted dll gets loaded and then put the break... awful ! 3)- And now the difficultest ! After solving the point 2, what about a way to store/retrieve breakpoints settings from disk ? Finding a bug in asm code often requires days (hmmm... nights !) of stepping, and a way to save breakpoints settings would spare tons of notes on paper :-) Regards Max

4 6

(no subject)
by Raul Dias July 30, 2002

July 30, 2002

David D. Hagood <wowbagger(a)sktc.net> wrote: >Andreas Mohr wrote: > >> Add to that the fact that CUPS gets rather completely rid of the useful >> Unix filter machanism, and you really start to wonder whether CUPS really >> is better than say lpd+printtool. Quite the other way around or so... > > >Actually, I do beleive that CUPS does use a filter mechanism internally. > But I do agree - I'm not as sure that CUPS is all that much better. >But to REALLY fix printing would mean far more than what CUPS can do - >IMHO what we need is more of a RPC style system, where the client app >communicates bidirectionally with the print server, so that the client >can ask "What can you do for me?", the server responds "I can staple, >collate, bind, and add gold leaf inlay", and the client can present that >to the user. Maybe some sort of XML/SOAP sort of thing.... (-1, Offtopic). Hmm... Cups already does this for me. :) []'s Raul Dias (yes, I broke my mailer subject support)

1 0

Re: Resubmitting patch for memory-mapping problem -- See VirtualQuery post in wine-devel
by Massimo July 30, 2002

July 30, 2002

Tony Lambregts wrote : >Looks like Alexandre was at least thinking of this (a little) when >he wrote this patch >http://cvs.winehq.com/patch.py?id=1027987166850574216879071 >You should probably try this out and see if it fixes bug 890. Yes, I've seen it after posting.... Don't have fully tested for bug 890, but AutoCAD2000 starts good now, as with my patch. I'll test it later on and close bug 890 Regards Max

1 0

Re: Resubmitting patch for memory-mapping problem -- See VirtualQuery post in wine-devel
by Tony Lambregts July 30, 2002

July 30, 2002

Massimo wrote: >Was this patch lost in space or does it have some problem ? > >Took off in executable mapping VPROT_WRITE and VPROT_WRITECOPY flags >and > added VPROT_EXEC; that looks much more close to win2k mapping. >The only difference now is in Type field, wine maps as MEM_PRIVATE and win2k >as MEM_IMAGE (I guess that's the right one, but no time now to check. > >The patch solves (partially) bug 890, and allows AutoCAD 2000 to start up (only in >win95 mode, because of another problem on fibers). > >Here the attached patch.... any comment appreciated :-) > >Regards > >Max > > > > >------------------------------------------------------------------------ > >Index: virtual.c >=================================================================== >RCS file: /home/wine/wine/memory/virtual.c,v >retrieving revision 1.80 >diff -u -r1.80 virtual.c >--- virtual.c 3 Jul 2002 21:10:44 -0000 1.80 >+++ virtual.c 19 Jul 2002 19:33:10 -0000 >@@ -94,7 +94,6 @@ > PAGE_EXECUTE_WRITECOPY /* READ | WRITE | EXEC | WRITECOPY */ > }; > >- > static FILE_VIEW *VIRTUAL_FirstView; > static CRITICAL_SECTION csVirtual = CRITICAL_SECTION_INIT("csVirtual"); > >@@ -345,6 +344,7 @@ > ) { > if (protect) { > *protect = VIRTUAL_Win32Flags[vprot & 0x0f]; >+ > /* if (vprot & VPROT_GUARD) *protect |= PAGE_GUARD;*/ > if (vprot & VPROT_NOCACHE) *protect |= PAGE_NOCACHE; > >@@ -650,7 +650,8 @@ > > if (removable) hmapping = 0; /* don't keep handle open on removable media */ > if (!(view = VIRTUAL_CreateView( ptr, total_size, 0, >- VPROT_COMMITTED|VPROT_READ|VPROT_WRITE|VPROT_WRITECOPY, > this next line is redundant and should not be in the patch >+// PATCH VPROT_COMMITTED|VPROT_READ|VPROT_WRITE|VPROT_WRITECOPY, >+/*PATCH*/ VPROT_COMMITTED|VPROT_READ|VPROT_EXEC, > hmapping ))) > the /*patch */ should not be in the patch file. > { > SetLastError( ERROR_OUTOFMEMORY ); > > > Looks like Alexandre was at least thinking of this (a little) when he wrote this patch http://cvs.winehq.com/patch.py?id=1027987166850574216879071 You should probably try this out and see if it fixes bug 890. <g> Tony Lambregts

1 0

Re: PATCH: temp fixes, again
by Alexandre Julliard July 29, 2002

July 29, 2002

Marcus Meissner <meissner(a)suse.de> writes: > Check for mkstemp, added a port implementation if it is > not present. Use mkstemp() in various places needing tmp files. I'm not sure this is a good idea, mkstemp() is apparently buggy in old libc versions. tmpnam() is actually pretty reasonable assuming it is used correctly, which of course is not the case everywhere but that could be fixed. -- Alexandre Julliard julliard(a)winehq.com

4 7

Re: Dinput - Keyb Bug
by Lionel Ulmer July 29, 2002

July 29, 2002

> I have the game (tribes) and have trace logs for you. The first on is > +relay,+dinput,+event (which has me pressing the a key, then shuts down) > and the second is +opengl,+x11drv,-dsound. DGA is disabled as it breaks > my Nvidia driver when running the game. Well, I am investigating the DInput problem... Looks strange. I may well ask you to add some more TRACEs in the code to help me understand better what happens (ie if it's blocking in Wine code or in application code). But I would be interested on a +opengl trace too. And maybe you should try to remove all trace of glide2x.dll of your system (maybe once Tribes manages to load the glide2x it cancels OpenGL as it supposes that a system with Glide2x will work better with it than with OpenGL). Lionel -- Lionel Ulmer - http://www.bbrox.org/

2 1