- Wine-Devel - list.winehq.org

Small Fixes
by kenon＠go2.pl May 9, 2001

May 9, 2001

Hi, I had some problems with application Super Memo 8.0 . It is an old 16-bit app ( hard for debugging :-) ) written in Borland Delphi (I guess). I wrote a patch and posted to wine-patches two months ago ,but that patch was rejected :-( . Now I have much simpler and I think correct patch solving the problem. --- windows/painting.c_or Wed Mar 28 16:39:17 2001 +++ windows/painting.c Sat May 5 14:19:43 2001 @@ -1710,7 +1710,7 @@ { /* send palette change notification */ HWND hWnd = WindowFromDC( hDC ); - if (hWnd) SendMessageA( HWND_BROADCAST, WM_PALETTECHANGED, hWnd, 0L); + if (hWnd) PostMessageA( HWND_BROADCAST, WM_PALETTECHANGED, hWnd, 0L); } return realized; } There is another bug. When I press <ENTER> the app runs in other way under wine than it runs under Windoze. My workaround ( only workaround ) is --- controls/edit.c_or Thu May 10 03:24:06 2001 +++ controls/edit.c Thu May 10 03:24:10 2001 @@ -849,7 +849,7 @@ case WM_GETDLGCODE: DPRINTF_EDIT_MSG32("WM_GETDLGCODE"); - result = DLGC_HASSETSEL | DLGC_WANTCHARS | DLGC_WANTARROWS; + result = DLGC_HASSETSEL | DLGC_WANTCHARS | DLGC_WANTARROWS |DLGC_WANTMESSAGE; if (lParam && (((LPMSG)lParam)->message == WM_KEYDOWN)) { --

1 0

Is the DECIMAL variant type too long ?
by gerard patel May 9, 2001

May 9, 2001

After the following patch : ChangeSet ID: 989259340138108821120113 CVSROOT: /opt/cvs-commit Module name: wine Changes by: julliard(a)wine2. 01/05/07 14:15:40 Modified files: include : oleauto.h wtypes.h include/wine : obj_base.h obj_oleaut.h Log message: Francois Gouget <fgouget(a)codeweavers.com> Added support for the DECIMAL type. Names are no longer suffixed with 32! Removed it. Borland Builder 4 crashes while starting :-/ Tracing the crash shows that it hangs immediately after the *first* variant Api access : Call oleaut32.VariantCopyInd(405869b0,40586974) ret=405b2e6b tid=08065a10 trace:ole:VariantCopyInd (0x405869b0, 0x40586974) trace:ole:VariantCopy (0x405869b0, 0x40586974) trace:ole:VariantClear (0x405869b0) Ret oleaut32.VariantCopyInd() retval=00000000 ret=405b2e6b tid=08065a10 Call oleaut32.VariantChangeTypeEx(40586968,405869b0,00000400,00000000,00000003) ret=405b301c tid=08065a10 trace:ole:VariantInit (0x4058685c),stub trace:ole:VariantChangeTypeEx (0x40586968, 0x405869b0 (11), 1024, 0, 3),stub trace:ole:VariantClear (0x40586968) trace:ole:VarI4FromBool ( -1, 0x40586970 ), stub trace:ole:VariantClear (0x4058685c) Ret oleaut32.VariantChangeTypeEx() retval=00000000 ret=405b301c tid=08065a10 err:seh:EXC_DefaultHandling Exception frame is not in stack limits => unable to dispatch exception. I have changed the trace slightly, the 11 listed for the VariantChangeTypeEx shows that the original type is a boolean. The call is trying to change a boolean (11) into an integer (3). The changes in include/wtypes.h are the important ones. Replacing the new DECIMAL type by typedef struct tagDEC { BYTE aa[2]; } DECIMAL; get rid of the crash. If I make the byte array 16 bytes long, same crash as the current Wine behaviour. If I make it 10 bytes long, access violation. If I make it 8 bytes long, it works too. Could the DECIMAL type be a pointer to the real data ?? Gerard

2 1

Stupid winedbg question
by Francois Gouget May 9, 2001

May 9, 2001

This is probably a stupid question but I did not find the answer in the doc (Wine Developper's Guide). How do I copy-paste something from winedbg? A backtrace for instance. Or how do I copy/paste anything to/from any console application for that matter. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Linux: It is now safe to turn on your computer.

4 6

Stupid autoconf question
by Ian Pilcher May 9, 2001

May 9, 2001

Here is my first cut at adding a check for the FreeType libraries and header files to the Wine configuration scripts. It's basically a copy of Marcus' CUPS stuff. Since this is the first time I've done anything with autoconf, I figured I'd post it here for review: diff -urN ../wine-20010502cvs/configure.in ./configure.in --- ../wine-20010502cvs/configure.in Wed May 2 12:57:30 2001 +++ ./configure.in Thu May 3 01:44:48 2001 @@ -378,6 +378,19 @@ ) AC_SUBST(CUPSLIBS) +FREETYPELIBS="" +dnl **** Check for FreeType 2 **** +wine_cv_warn_ftsystem_h=no +AC_CHECK_LIB(freetype,FT_Init_FreeType, + AC_CHECK_HEADER(freetype2/freetype/ftsystem.h, + AC_DEFINE(HAVE_FREETYPE) + FREETYPELIBS="-lfreetype" + FREETYPEINCL="-I/usr/include/freetype2", + wine_cv_warn_ftsystem_h=yes) +) +AC_SUBST(FREETYPELIBS) +AC_SUBST(FREETYPEINCL) + dnl **** Check for IPX (currently Linux only) **** AC_CACHE_CHECK("for GNU style IPX support", ac_cv_c_ipx_gnu, AC_TRY_COMPILE( @@ -1316,6 +1329,15 @@ echo "*** Note: You have cups runtime libraries, but no development" echo "*** libraries. Install the cups-devel package or whichever package" echo "*** contains cups.h to enable CUPS support in WINE." +fi + +if test "$wine_cv_warn_ftsystem_h" = "yes" +then + echo + echo "*** Note: Your system appears to have the FreeType 2 runtime libraries" + echo "*** installed, but the corresponding header files are not installed in" + echo "*** /usr/include/freetype2/freetype. Install the freetype-devel package" + echo "*** to enable TrueType font support in Wine." fi echo diff -urN ../wine-20010502cvs/dlls/wineps/Makefile.in ./dlls/wineps/Makefile.in --- ../wine-20010502cvs/dlls/wineps/Makefile.in Sun Apr 29 13:21:22 2001 +++ ./dlls/wineps/Makefile.in Thu May 3 01:45:13 2001 @@ -6,7 +6,8 @@ SOVERSION = 1.0 ALTNAMES = wineps16 IMPORTS = user32 gdi32 winspool.drv kernel32 ntdll -EXTRALIBS = @CUPSLIBS@ +EXTRALIBS = @CUPSLIBS@ @FREETYPELIBS@ +EXTRAINCL = @FREETYPEINCL@ C_SRCS = \ afm.c \ diff -urN ../wine-20010502cvs/include/acconfig.h ./include/acconfig.h --- ../wine-20010502cvs/include/acconfig.h Sun Apr 29 13:21:22 2001 +++ ./include/acconfig.h Thu May 3 01:45:04 2001 @@ -122,3 +122,6 @@ /* Define if we have CUPS */ #undef HAVE_CUPS + +/* Define if FreeType 2 is installed */ +#undef HAVE_FREETYPE It seems to work on my system (Red Hat 7.1), although for some reason it can't even detect the FreeType library when the freetype-devel package is removed (no great loss). At this point I have a couple of questions: * Does anyone see anything wrong with this? * I've omitted the resulting changes to wine/configure and wine/include/config.h.in from the patch above. Is this form more convenient for final submission, or should I include the changes to those files? (If the latter is the case, I'll probably go ahead and submit the autoconf changes before I get any code written, so that wine/configure doesn't get hugely out of sync.) Thanks! -- ======================================================================== Ian Pilcher ian.pilcher(a)home.com ========================================================================

3 3

Re: doors IPC
by Alexandre Julliard May 9, 2001

May 9, 2001

Marcus Meissner <marcus(a)jet.franken.de> writes: > Since critical sections are thought to be 'fast' and 'short time' locking > primitives, and Win32 threads should not sleep in a critical section, > we can just give up our timeslice and wait for the other thread that > has the lock to continue. Well, there are tons of places where we will sleep inside a critical section, so it could potentially burn a lot of CPU. That doesn't necessarily make it slower, but it would probably impact other applications more. As usual, the only way to tell is to do benchmarks. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: Add missing newline to WARN messages
by Dmitry Timoshkov May 9, 2001

May 9, 2001

"Francois Gouget" <fgouget(a)free.fr> wrote: > * I scanned the source for TRACE/WARN/ERR/FIXME statements without a > terminating newline. There are few cases where this is justified because > of following DPRINTFs. But most of the time there should be a \n > otherwise the trace will not be flushed to disk immediately and the logs > will look bad. You forgot to remove redundant ' around %s in the traces when output is made by debugstr_a or debugstr_w. Actually you removed some of them, but not all.

2 1

PRESS: CodeWeavers: crossover plugins windows / linux
by Marcus Meissner May 9, 2001

May 9, 2001

Hi, The EETimes has an article about CodeWeavers current project, which appears to bring some Windows Browser plugins to Linux. http://www.eet.com/story/OEG20010508S0061 Ciao, Marcus

2 1

Re: Re: Stupid winedbg question
by Mike McCormack May 9, 2001

May 9, 2001

Cutting and pasting in winedbg's xterm only works for me if i hold the shift key down when doing it. Dunno why. i've got more serious problems with winedbg... when exceptions are thrown on critical sections, winedbg starts, but then itself gets stuck on _the same_ critical section. Happens all the time with netscape... i've applied Marcus's patch and i'll see if that reduces the frequency of failures, but it probably won't help winedbg's problems. Mike > > Francois Gouget wrote: > > > > > > A backtrace for instance. Or how do I copy/paste anything to/from any > > > console application for that matter. > > > > > > > Select the text you want to copy and click with your middle mouse button > > (mouse button 2) wherever you want to paste it. > > Nope. I tried that, of course, and it doesn't work. ------------------------------------------ mailto:Mike_McCormack(a)looksmart.com.au ph +82 16 430 0425 __________________________________________________________________ Get your own free web email at http://www.looksmart.com.au LookSmart Australia

1 0

PRESS: GameSpy: Ports vs. WINE
by Marcus Meissner May 9, 2001

May 9, 2001

Hi, Gamespy has an article regarding whether Games should be ported to Linux or emulated using WINE. Introduces porting Companies and Transgaming, then procedes to give statements from Gavriel, Michael Simms (CEO of TuxGames), Scott Draeker (Loki Games President), ... Except Gavriel (of course) all take on major flaming Wine, WineX and TransGaming. http://www.gamespy.com/articles/may01/wine/ Ciao, Marcus

1 0

Re: Add missing newline to WARN messages
by Francois Gouget May 8, 2001

May 8, 2001

Here's the list of weird traces: dlls/comctl32/datetime.c:221 dlls/comctl32/datetime.c:224 It looks like the goal was to print stuff on the same line in multiple steps (one TRACE has a '\n' at the beginning) but no DPRINTF is used. Also I'm not sure we would always end up printing a '\n'. Add '\n's everywhere? objects/region.c:908 objects/region.c:911 objects/region.c:918 objects/region.c:936 The '\n' usage is inconsistent. Put '\n's everywhere? dlls/ole32/compositemoniker.c:340 There's a DPRINTF I'm not sure of but there's also (comment by me): { FIXME("()\n"); /* FIXME: To whoever wrote this code: It's either return or break. it cannot be both! */ break; return E_NOTIMPL; } I would say that it should be a return but I'm not 100% sure. Anyone familiar with this code? -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Before you criticize someone, walk a mile in his shoes. That way, if he gets angry, he'll be a mile away - and barefoot.

1 0