- Wine-Devel - list.winehq.org

Re: New breakages
by gerard patel May 3, 2001

May 3, 2001

At 05:46 PM 02/05/2001 -0700, you wrote: >could you please give this a try? <snip> Excellent, this is fixing the painting problems. Now, all I have to do is to find the tooltip bug, the Eudora combo display problem and the 2 remaining crashes and my toy test suite will be in as good shape as before :-) Gerard

1 0

Wine and NetBSD
by Bang Jun-Young May 2, 2001

May 2, 2001

Hi, For the last couple of weeks I spent some time doing porting Wine to NetBSD (there used to be a port but was too out of date). After applying patches my own, it has been successfully compiled and started running. The most serious problem occurs, however, whenever I try to run a Windows binary with it: $ wine c:\\windows\\sol.exe No built-in EXE module loaded! Did you create a .spec file? Obviously sol.exe doesn't need a .spec file to run. When/Why do I get such an error? Jun-Young -- Bang Jun-Young <bjy(a)mogua.org>

3 4

Re: New breakages
by Alexandre Julliard May 2, 2001

May 2, 2001

gerard patel <gerard.patel(a)asi.fr> writes: > [patch snipped] > > I got the following results : > > Word viewer 32 bits, 16 bits, Lotus Notes (AFAICT), Statview, QuattroPro 1, and a > few old 16 bits apps I have display more or less as well as before (some crud for WW32 > that was not before, though :-/) Thanks a lot for tracking this down; I think I found the real bug, could you please give this a try? Index: windows/dce.c =================================================================== RCS file: /opt/cvs-commit/wine/windows/dce.c,v retrieving revision 1.53 diff -u -r1.53 dce.c --- windows/dce.c 2001/04/24 23:28:52 1.53 +++ windows/dce.c 2001/05/03 00:37:31 @@ -671,7 +671,12 @@ * means that we have to recompute the visible region. */ if( dce->DCXflags & DCX_DCEBUSY ) + { + /* Dirty bit has been cleared by caller, set it again so that + * pGetDC recomputes the update region. */ + SetHookFlags16( dce->hDC, DCHF_INVALIDATEVISRGN ); USER_Driver.pGetDC( dce->hwndCurrent, dce->hDC, dce->hClipRgn, dce->DCXflags ); + } else /* non-fatal but shouldn't happen */ WARN("DC is not in use!\n"); break; -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: New breakages
by gerard patel May 2, 2001

May 2, 2001

At 02:30 PM 25/04/2001 +0200, I wrote: >At 09:30 AM 25/04/2001 +0200, I wrote: > >Also several apps are not erasing parts of the screen : among others the word viewer 97 >(freeware downloadable). A few other strange crashes. Still talking to myself... I feel I'm soon one of these sad cases talking alone in the street ;-) I have found one way to fix a lot of the ugliness that the evil patch of 24 april has done; by doing : --- dce.c.orig Thu May 3 00:02:35 2001 +++ dce.c Wed May 2 23:49:19 2001 @@ -551,7 +551,7 @@ dce->DCXflags &= ~DCX_DCEDIRTY; hdc = dce->hDC; - if (bUpdateVisRgn) SetHookFlags16( hdc, DCHF_INVALIDATEVISRGN ); /* force update */ + if (bUpdateVisRgn) flags |= 0x8000; if (!USER_Driver.pGetDC( hwnd, hdc, hrgnClip, flags )) hdc = 0; and --- winpos.c.orig Wed Apr 25 01:28:52 2001 +++ winpos.c Wed May 2 23:49:01 2001 @@ -355,7 +355,8 @@ TSXSetClipOrigin( display, physDev->gc, dc->DCOrgX, dc->DCOrgY ); #endif - updateVisRgn = (dc->flags & DC_DIRTY) != 0; + updateVisRgn = (flags & 0x8000) != 0; + dc->flags &= ~DC_DIRTY; GDI_ReleaseObj( hdc ); if (updateVisRgn) I got the following results : Word viewer 32 bits, 16 bits, Lotus Notes (AFAICT), Statview, QuattroPro 1, and a few old 16 bits apps I have display more or less as well as before (some crud for WW32 that was not before, though :-/) Doing things in such a way is more conforming to the way they were done before - and it seems more simple that the SetHookFlags trick IMHO ;-) Gerard

1 0

Re: Script to get committed patches
by gerard patel May 2, 2001

May 2, 2001

At 08:04 PM 01/05/2001 +0200, you wrote: >as of today, the added files are marked with the &&& mark (instead of >the +++ and --- for the diffs), which of course causes some issues when >you use the whole file as a patch (normally, all the added files are at >the end; so the "easy" way of doing it is to remove that part, apply the >patch, and then create the new files) <snip> >I'd say it's a documented feature ;-), Documented ? Oops, I missed completely this part. This weekend I have browsed the wonderful Wine user manual for the first time , since I have now a computer with a working db2html - now I know what *is* the Wine user manual ;-) I have not seen where this info is hiding. Maybe it was in one of your (defunct) WWN. I tried to read them but I probably was lazy too. Btw, your successor has problems to get in the game; I noticed on LinuxToday that the last Kernel Cousin Wine was showing a 'slow week' - the week where Marcus posted CUPS support - IMHO the more interesting patch since months for all non-games apps. He is not following wine-patches and wine-cvs it seems :-/ > I'll try to give it a look later >on I see no reason for you to work on this rather trivial matter. All that is needed is to know the problem. I should have guessed it but I was probably too stressed by the idea of having this 200k patch to look at ;-( Now it's done, thanks for the tip. Gerard

4 4

Re: FreeLibrary() library freeing
by Alexandre Julliard May 2, 2001

May 2, 2001

gerard patel <gerard.patel(a)asi.fr> writes: > If you remember, there are glibc problems with dlclose. Alexandre Julliard > said that it was not a problem because FreeLibrary was not doing anything. > So I guess that people with 'old' glibc could have now new crashes. Actually we still cannot dlclose builtin libraries; the change I made is to free memory used by PE dlls. Freeing builtins properly will require dll separation to be completed first. And once this is done we will no longer rely on glibc dlclose reference counting so the bug shouldn't impact us. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: FreeLibrary() library freeing
by gerard patel May 2, 2001

May 2, 2001

At 11:23 PM 01/05/2001 +0200, you wrote: <snip> >I believe the potential problems that this can cause are way more important >than some claims that "there are some problems with library freeing". >I've had that FreeLibrary() #if hack removed for a long time, >and I haven't see any adverse effects (not that it's too easy to spot >and attribute to this problem probably, though). If you remember, there are glibc problems with dlclose. Alexandre Julliard said that it was not a problem because FreeLibrary was not doing anything. So I guess that people with 'old' glibc could have now new crashes. Gerard

2 1

Re: FreeLibrary() library freeing
by Alexandre Julliard May 2, 2001

May 2, 2001

Andreas Mohr <a.mohr(a)mailto.de> writes: > I for one would truly like to see it fixed ASAP. > > If FreeLibrary() has a problem, then we need to fix it. > Running away from the problem by implementing strange hacks does no good > to anybody. Agreed; I have uncommented the VirtualFree, and you are hereby volunteered to track down and fix any crash caused by this ;-) -- Alexandre Julliard julliard(a)winehq.com

3 2

Re: Quickbooks 5 and printing
by Alexandre Julliard May 2, 2001

May 2, 2001

"Dmitry Timoshkov" <dmitry(a)sloboda.ru> writes: > Please try the attached patch. It tries to solve the root of the problem: > for now Wine Postscript Driver lives in wineps.dll, but should be in wineps.drv. I'm not sure this is correct. The app is trying to load a 16-bit driver, so giving it the 32-bit dll is probably not a good idea. Maybe we should simply rename wineps16.dll to wineps.drv? -- Alexandre Julliard julliard(a)winehq.com

2 1

Re: FW: Notes and Java test on 20010216 drop
by Alexandre Julliard May 1, 2001

May 1, 2001

"Nerijus Baliunas" <nerijus(a)users.sourceforge.net> writes: > why the following patch is not applied? I don't think it was ever submitted; but anyway, it's quite ugly to check the callouts on every module load/unload. The right fix is to get rid of the Callout structure and do a GetProcAddress at the time we need a specific function. -- Alexandre Julliard julliard(a)winehq.com

1 0