Then would it be fine to create 2 MRs at the same time? I was a little biased towards 1 MR 2 Commits because of the wiki stating that multiple outstanding MRs from an individual are discouraged. On Thu, 23 Jul, 2026, 1:16 pm Eric Pouech, <eric.pouech@orange.fr> wrote:
Le 23/07/2026 à 08:15, Barath Rk via Wine-Devel a écrit :
Using MessageBeep for the implementation works on XWayland, but using Wayland I don't get the Beep as it is not implemented in the winewayland driver. How would the workflow look for implementing this? Would I have to open a separate MR or can I just add the Wayland Beep implementation as another commit in the same MR as the console Beep implementation?
both approaches are valid
using 1MR+2commits make clean why you're adding code to wayland driver
but has the drawback of involving several maintainers