October 2022 - Wine-GitLab - list.winehq.org

[PATCH v5 0/2] MR1015: wpcap: Convert Unix sockaddr to win32 before duplication
by Marc-Aurel Zent (＠marzent) Oct. 24, 2022

Oct. 24, 2022

Interpreting the fist two bytes of the `sockaddr` struct as `sa_family` produces incorrect behaviour on macOS and (presumbly) BSD. This change uses both Unix and Windows socket headers to convert the libpcap provided sockaddr before duplicating it. This fixes sockaddr being always NULL on macOS/BSD and ipv6 addresses not working in general since `AF_INET6` differs on Windows(23), macOS(30) and Linux(10) For reference https://www.ibm.com/docs/en/i/7.3?topic=family-af-inet-address and this is from the <sys/socket.h> on macOS ``` /* * [XSI] Structure used by kernel to store most addresses. */ struct sockaddr { __uint8_t sa_len; /* total length */ sa_family_t sa_family; /* [XSI] address family */ char sa_data[14]; /* [XSI] addr value (actually larger) */ }; ``` -- v5: wpcap: Convert unix sockaddr to win32 sockaddr https://gitlab.winehq.org/wine/wine/-/merge_requests/1015

4 4

[PATCH v19 0/6] MR1120: msvcrt: Add support for localized functions
by Bartosz Kosiorek (＠gang65) Oct. 23, 2022

Oct. 23, 2022

-- v19: msvcrt: Add _ismbstrail_l implementation. msvcrt: Add _ismbslead_l implementation. msvcrt: fix error handling for _mbscmp_l msvcrt: Add _mbclen_l implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/1120

3 8

[PATCH v18 0/6] MR1120: msvcrt: Add support for localized functions
by Bartosz Kosiorek (＠gang65) Oct. 23, 2022

Oct. 23, 2022

-- v18: msvcrt: Add _ismbstrail_l implementation. msvcrt: Add _ismbslead_l implementation. msvcrt: fix error handling for _mbscmp_l msvcrt: Add _mbclen_l implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/1120

3 7

[PATCH v3 0/3] MR1003: gdiplus: Use atomic write for releasing GpImage lock.
by Jinoh Kang (＠iamahuman) Oct. 23, 2022

Oct. 23, 2022

This fixes data race in ARM/ARM64 platforms, and prevents potential memory access reordering by the compiler. -- v3: gdiplus: Replace GpImage's busy flag with SRWLOCK. gdiplus: Avoid copying GpImage's busy flag in select_frame_wic(). gdiplus: Avoid recursively locking image in GdipImageRotateFlip. https://gitlab.winehq.org/wine/wine/-/merge_requests/1003

4 9

[PATCH v2 0/2] MR1081: win32u: Reject invalid length in SetWindowPlacement.
by Esme Povirk (＠madewokherd) Oct. 22, 2022

Oct. 22, 2022

This change has been in Proton to fix a bug in the DayZ launcher. The launcher is a .NET application that, best I can tell, contains marshaling code that calls SetWindowPlacement incorrectly. This results in undefined memory being passed in and broken values returned by GetWindowPlacement. I think the value passed in must be broken on Windows, but as the tests show, Windows rejects SetWindowPlacement calls that don't have length set correctly (but not GetWindowPlacement, as zeroing the structure to give it an invalid length in `other_process_proc` shows). -- v2: win32u: Reject invalid length in SetWindowPlacement. user32: Test Get/SetWindowPlacement with invalid length. https://gitlab.winehq.org/wine/wine/-/merge_requests/1081

3 3

Re: [PATCH v17 0/6] MR1120: Add support for localized functions in msvcrt dlls
by Bartosz Kosiorek (＠gang65) Oct. 22, 2022

Oct. 22, 2022

On Fri Oct 21 13:37:13 2022 +0000, Bartosz Kosiorek wrote: > changed this line in [version 14 of the diff](/wine/wine/-/merge_requests/1120/diffs?diff_id=14967&start_sha=1fe0022187d425723510d747a81973ae0a57dd29#5cc40c9a9717f9205417155123fc4bce95d55d9d_651_651) I implemented it as you said: ``` if(_ismbblead_l(*str, locale) && (str[1] != '\n')) return 2; return 1; ``` But maybe se should compare it to zero: ``` if(_ismbblead_l(*str, locale) && (str[1] != 0)) return 2; return 1; ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1120#note_11828

1 0

[PATCH v3 0/1] MR1145: kernelbase: Implement various transacted file APIs.
by Etaash Mathamsetty (＠etaash.mathamsetty) Oct. 22, 2022

Oct. 22, 2022

a hotfix for the recent release of Persona 5 Royal. -- v3: kernelbase: Implement various transacted file APIs. https://gitlab.winehq.org/wine/wine/-/merge_requests/1145

3 2

[PATCH 0/1] MR1145: kernelbase: Implement various transacted file APIs.
by Etaash Mathamsetty (＠etaash.mathamsetty) Oct. 22, 2022

Oct. 22, 2022

a hotfix for the recent release of Persona 5 Royal. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1145

3 2

Re: [PATCH 0/1] MR145: kernel32: Unstub MoveFileWithProgress, add test.
by Bernhard Kölbl Oct. 22, 2022

Oct. 22, 2022

You need to rebase the patch. Also you should add the tests in a separate commit. Lastly add a reviewer, idk who. Maybe Zeb, Huw, Jaceck... -- https://gitlab.winehq.org/wine/wine/-/merge_requests/145#note_11816

1 0

[PATCH v2 0/1] MR1128: msvcrt: Display message box in abort() in debug CRT only.
by Paul Gofman (＠gofman) Oct. 22, 2022

Oct. 22, 2022

As far as my testing goes, the message box is never shown on Windows when abort() is called with retail runtime is used, regardless of error mode and abort behaviour. That is not the case with _assert which still can show a dialog even in release mode. It happens rather often that an app meets the error condition during the process exit and that goes silent on Windows while we display the abort dialog on app's exit. The test program below shows that (and the same behaviour is, e. g., with ucrtbase vs ucrtbased). ``` #include <windows.h> #include <stdio.h> #include <stdlib.h> void CDECL _set_app_type(int app_type); #define D(name) static typeof(name) *p_##name #define L(name) p_##name = (void *)GetProcAddress(hdll, #name); if (!p_##name) printf("NULL %s.\n", #name) D(abort); D(_set_app_type); D(_set_abort_behavior); D(_set_error_mode); int main(int argc, char *argv[]) { HMODULE hdll = LoadLibraryA("msvcrt.dll"); printf("hdll %p.\n", hdll); L(_set_app_type); if (!p__set_app_type) if (!(p__set_app_type = (void *)GetProcAddress(hdll, "__set_app_type"))) printf("NULL p__set_app_type.\n"); L(abort); L(_set_abort_behavior); L(_set_error_mode); p__set_app_type(2); if (p__set_abort_behavior) p__set_abort_behavior(_WRITE_ABORT_MSG, _WRITE_ABORT_MSG); p__set_error_mode(_OUT_TO_MSGBOX); p_abort(); } ``` -- v2: msvcrt: Display message box in abort() for specific CRT versions only. https://gitlab.winehq.org/wine/wine/-/merge_requests/1128

4 9