October 2022 - Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/5] MR1078: mshtml: More HTMLDocumentNode / HTMLDocumentObj splitting.
by Gabriel Ivăncescu Oct. 22, 2022

Oct. 22, 2022

Wait, I messed up. It modified the existing (merged) MR instead of creating a new one since I used same branch name by accident. Sorry about this. (New MR is !1125) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1078#note_11549

1 0

[PATCH v3 0/6] MR1120: Draft: Add support for localized functions in msvcrt dlls
by Bartosz Kosiorek (＠gang65) Oct. 22, 2022

Oct. 22, 2022

-- v3: msvcrt: Add _ismbslead_l implementation. msvcrt: Add _ismbstrail_l implementation. msvcrt: fix error handling for _mbscmp_l msvcrt: Add _mbclen_l implementation. msvcrt: Add _mbsicmp_l implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/1120

3 7

[PATCH 0/1] MR1096: mmdevapi: Set the name of internal threads.
by Brendan Shanks (＠bshanks) Oct. 22, 2022

Oct. 22, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1096

4 4

[PATCH 0/1] MR1124: oleaut32/tests: Fix test failing on UTF-8 locale.
by eric pouech (＠epo) Oct. 22, 2022

Oct. 22, 2022

Method decriptor's strings are internally stored in ANSI, and potentially converted from Unicode using current code page. Test was expecting loss in Unicode to ANSI conversion. Adapt test to also support loss-less conversion (that's the case when code page is UTF-8). Wine-Bugs: https://bugs.winehq.org/show_bug.cgi?id=52873 Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1124

2 1

[PATCH v2 0/6] MR1120: Draft: Add support for localized functions in msvcrt dlls
by Bartosz Kosiorek (＠gang65) Oct. 22, 2022

Oct. 22, 2022

-- v2: msvcrt: Add _ismbslead_l implementation. msvcrt: Add _ismbstrail_l implementation. msvcrt: fix error handling for _mbscmp_l msvcrt: Add _mbclen_l implementation. msvcrt: Add _mbsicmp_l implementation. msvcrt: Add _mbschr_l implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/1120

3 7

Re: [PATCH v2 0/1] MR1107: kernelbase: Avoid memory leaks in GetConsoleTitleW()
by Hugh McMaster (＠hmc) Oct. 22, 2022

Oct. 22, 2022

On Thu Oct 20 13:10:51 2022 +0000, eric pouech wrote: > Hi Hugh, > IMO, this could be written without using 'goto' > for example > ``` > if (console_ioctl(...) && size >= sizeof(...)) > { > } > else size = 0; > HeapFree(...); > return size; > ``` Sure. That’s the merged version, which I think @julliard modified. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1107#note_11523

1 0

[PATCH 0/6] MR1120: Draft: Add support for localized functions in msvcrt dlls
by Bartosz Kosiorek (＠gang65) Oct. 22, 2022

Oct. 22, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1120

3 7

[PATCH v4 0/12] MR966: server: Some fixes for the shared Software\Classes registry.
by Sven Baars (＠sbaars) Oct. 22, 2022

Oct. 22, 2022

This seems to be more correct than what we previously had with fewer lines of code, so I like that. I still don't really like the extra flag I had to add for Nt{Create,Open}Key, but I couldn't find a way to make things work without it. I also checked that Windows doesn't use a similar flag (by iterating over all bit masks). -- v4: wine.inf: Put the Clients key in the right place. advapi32/tests: Copy Software\Classes tests from ntdll. ntdll/tests: Refactor the Software\Classes tests. ntdll/tests: Factor out the NtEnumerateKey() tests. kernelbase: Remove special Wow64 handling for HKEY_CLASSES_ROOT. kernelbase: Remove special Wow6432Node handling from RegCreateKeyEx(). kernelbase: Remove special Wow6432Node handling from RegOpenKeyEx(). server: Don't return the actual 32-bit Software\Classes key. ntdll/tests: Add some some Software\Classes query and enumerate tests. ntdll/tests: Test that NtCreateKeyEx() also recursively obtains the Wow6432Node parent. server: Recursively obtain the Wow6432Node parent. ntdll/tests: Add some Software\Classes subkey tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/966

4 16

[PATCH v8 0/1] MR1065: ntdll: Add CFI unwind info to __wine_syscall_dispatcher (x86_64)
by Florian Kübler Oct. 22, 2022

Oct. 22, 2022

This change is adding DWARF (CFI) unwind information to the hand-written assembly of the `__wine_syscall_dispatcher` function. This enables unwinding through the dispatcher from the Linux stack into (and through) the Windows stack. The general idea is that the `syscall_frame` struct contains the content of the callee-save registers before the function call (in particular the stack pointer and the return address). At any point of the execution, we have a pointer into the `syscall_frame` in $rcx, $rbp or $rsp. For the CFI codes the general idea is that we are defining the computations of the callee-save registers based on the `syscall_frame` using DWARF’s `breg` instruction, rather than relative to CFA. This change adds a bunch of convenience macros, to (hopefully) improve readability of the CFI instructions. Note: Those change was used with great success for unwinding through the dispatcher using a modified LLDB shown in the [“how-wine-works-101”](https://werat.dev/blog/how-wine-works-101/) blog post as well as for in the [Orbit profiler](https://github.com/google/orbit), that has mixed-callstack unwinding support. Test: Inspect callstacks reported by the Orbit profiler while running some Windows targets using the modified wine, as well as verify debugging reports correct callstacks when stepping with our modified LLDB through the dispatcher itself (so that we are able to unwind through the dispatcher at any instruction). -- v8: ntdll: Add CFI unwind info to __wine_syscall_dispatcher (x86_64) https://gitlab.winehq.org/wine/wine/-/merge_requests/1065

3 8

[PATCH v3 0/4] MR1089: win32u/font: Add font links for MS Gothic, MingLiU, Microsoft JhengHei.
by Ziqing Hui (＠zhui) Oct. 22, 2022

Oct. 22, 2022

More font links are added to avoid issues related to missing font links. Data comes from: https://testbot.winehq.org/JobDetails.pl?Key=125079 Test program in the tests above: [font_link_reg.c](/uploads/9d4a722450f0dd88344a2b098770aaa0/font_link_reg.c) -- v3: win32u: Add font links for MS Gothic. win32u: Add font links for MingLiU. win32u: Add font links for Microsoft JhengHei. win32u: Add locale_dependent member to struct system_link_reg. https://gitlab.winehq.org/wine/wine/-/merge_requests/1089

4 6