November 2022 - Wine-GitLab

[PATCH v2 0/10] MR1609: joy.cpl: Add an xinput tab and draw controller views with GDI.
by Rémi Bernon Nov. 30, 2022

Nov. 30, 2022

-- v2: joy.cpl: Remove unnecessary JoystickData structure. joy.cpl: Move dinput test tab logic to dinput.c. joy.cpl: Draw dinput axes state with gdi32. joy.cpl: Draw dinput button state with gdi32. joy.cpl: Add a checkbox to test xinput rumble. joy.cpl: Draw xinput controller state with gdi32. joy.cpl: Add a new xinput controller test tab. joy.cpl: Build without NONAMELESSUNION. joy.cpl: Use designated initializers in display_cpl_sheets. joy.cpl: Add DI_ prefix to dinput dialog constants. https://gitlab.winehq.org/wine/wine/-/merge_requests/1609

1 10

[PATCH 0/10] MR1609: joy.cpl: Add an xinput tab and draw controller views with GDI.
by Rémi Bernon Nov. 30, 2022

Nov. 30, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1609

1 10

[PATCH 0/1] MR1607: winex11.drv: Release window data before calling sync_window_cursor().
by Zhiyi Zhang (＠zhiyi) Nov. 30, 2022

Nov. 30, 2022

This prevents a deadlock between the window data lock and the ntdll loader lock because sync_window_cursor() eventually may grab the ntdll loader lock. So if another thread already grabbed the ntdll loader lock and wants to enter the same window data critical section, it will deadlock. Fix Youropa (SteamID: 640120) OpenGL launch option launching to a black screen. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1607

2 1

[PATCH v5 0/5] MR1520: comctl32: Use CRT allocation functions.
by Nikolay Sivov (＠nsivov) Nov. 30, 2022

Nov. 30, 2022

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v5: comctl32/listview: Use CRT allocation functions. comctl32/button: Use CRT allocation functions. comctl32/static: Use CRT allocation functions. comctl32/monthcal: Use CRT allocation functions. comctl32/header: Use CRT allocation functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/1520

3 7

Re: [PATCH v5 0/4] MR566: shell32: Implement SHBindToFolderIDListParent.
by Mohamad Al-Jaf (＠maljaf) Nov. 30, 2022

Nov. 30, 2022

It doesn't look like Zebediah is interested in reviewing this. Can any CodeWeavers employee please review this merge request? @nsivov would you mind reviewing it if possible? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/566#note_17982

1 0

[PATCH 0/5] MR1588: Draft: Add windows.system.profile.systemmanufacturers DLL.
by Mohamad Al-Jaf (＠maljaf) Nov. 30, 2022

Nov. 30, 2022

The test for ISmbiosInformationStatics_get_SerialNumber is broken on Window 10 testbot VMs, presumably because they don't have a serial number? It results in an HRESULT of E_UNEXPECTED. I added a broken test case for it. I'm assuming that normal installations of Windows return a valid serial number. Also, on my Linux OS running cat /sys/class/dmi/id/product_serial returns "To be filled by O.E.M". So I added a fallback to return 0 as the number. Or is it fine to just return whatever string is found? On the Windows 8 VMs, the test crashes at line 75, hr = ISmbiosInformationStatics_get_SerialNumber( smbios_statics, &serial ). Not sure what I should do in this case. I was hoping for a flag that checks if the VM is Windows 8, but there doesn't seem to be one. Should I wrap the test in if (0) or is there an alternative way? Another weird thing is the test fails prematurely on only the 32-bit version of debian11b, saying that the runtimeclass is not registered. I'm assuming it's an issue with the testbot. Debian11 32 bit runs fine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1588

5 18

[PATCH v2 0/1] MR1602: rpcrt4: Use standard C functions for memory allocation.
by Alex Henrie (＠alexhenrie) Nov. 30, 2022

Nov. 30, 2022

-- v2: rpcrt4: Use standard C functions for memory allocation. https://gitlab.winehq.org/wine/wine/-/merge_requests/1602

3 3

[PATCH 0/1] MR1605: include: Annotate I_RpcAllocate with __WINE_(ALLOC_SIZE|DEALLOC|MALLOC).
by Alex Henrie (＠alexhenrie) Nov. 30, 2022

Nov. 30, 2022

This gets us a nice warning if memory allocated by this function is freed incorrectly. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1605

2 1

[PATCH 0/1] MR1603: wshom: Fix WshNetwork interface definition.
by Nikolay Sivov (＠nsivov) Nov. 29, 2022

Nov. 29, 2022

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1603

2 1

[PATCH 0/1] MR1602: rpcrt4: Use standard C functions for memory allocation.
by Alex Henrie (＠alexhenrie) Nov. 29, 2022

Nov. 29, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1602

4 4