November 2022 - Wine-GitLab

[PATCH v9 0/1] MR1456: imm32: Prevent deadlock on unload
by Fabian Maurer (＠DarkShadow44) Nov. 23, 2022

Nov. 23, 2022

We need to make sure all (important) cleanup is finished when we exit DllMain, otherwise we might already unload krnl386 and deadlock Since we can't have a synchronous DestroyWindow, use an extra message Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52511 Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> Code flow is like follows: - DOSVM_Exit -> RtlExitUserThread -> LdrShutdownThread - acquire loader lock - send DLL_THREAD_DETACH to imm32 - - calls DestroyWindow on its window - - WM_DESTROY is handled asynchonously! - send DLL_THREAD_DETACH to krnl386.exe - - TASK_ExitTask - - try get win16 lock, is blocked by ime32 meanwhile, at ime32 - handles WM_DESTROY - already have win16 lock from user32 - __wine_ime_wnd_proc (WM_DESTROY) -> imm_couninit_thread -> CoRevokeInitializeSpy - LdrGetProcedureAddress (want CoRevokeInitializeSpy) - try get loader_lock, is blocked Solution is to wait in ime32 DllMain until the cleanup as happened, aka CoRevokeInitializeSpy has finished. -- v9: imm32: Prevent deadlock on unload https://gitlab.winehq.org/wine/wine/-/merge_requests/1456

3 2

[PATCH 0/1] MR1512: vbscript/tests: Fix redim tests.
by Nikolay Sivov (＠nsivov) Nov. 23, 2022

Nov. 23, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1512

4 3

[PATCH v2 0/4] MR1427: wined3d: Add a lower size bound for the streaming buffer allocation.
by Anton Baskanov (＠baskanov) Nov. 23, 2022

Nov. 23, 2022

v2: Expose wined3d_streaming_buffer_map() and wined3d_streaming_buffer_unmap() for strided data upload. -- v2: wined3d: Add a lower size bound for the streaming buffer allocation. ddraw: Use the wined3d_streaming_buffer helpers to manage the streaming index buffer. ddraw: Use the wined3d_streaming_buffer helpers to manage the streaming vertex buffer. wined3d: Factor out and expose functions to map/unmap wined3d_streaming_buffer. https://gitlab.winehq.org/wine/wine/-/merge_requests/1427

5 8

[PATCH 0/4] MR1511: ntdll: Various heap cleanups.
by Zebediah Figura (＠zfigura) Nov. 23, 2022

Nov. 23, 2022

I noticed these while trying to debug heap corruption. Rémi, if you have queued heap patches, please feel free to defer these until those are done. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1511

3 5

[PATCH v15 0/7] MR1297: gdiplus: Add CustomLineCap implementation (including displaying).
by Bartosz Kosiorek (＠gang65) Nov. 23, 2022

Nov. 23, 2022

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45273 -- v15: gdiplus: Add GdipSetCustomLineCapStrokeCaps implementation and usage. gdiplus: fix shape of CustomLineCap created by GdipCreateAdjustableArrowCap. gdiplus: Add support for widen path with GpCustomLineCap. gdiplus: use GpPointF for drawing in widen_closed_figure gdiplus: Add GdipSetCustomLineCapBaseInset implementation. gdiplus: Remove not used LineCustomCap parameter. gdiplus: Add GdipSetCustomLineCapBaseCap implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/1297

2 7

[PATCH 0/1] MR1518: mfplat: Use the iswxdigit function instead of reimplementing it.
by Alex Henrie (＠alexhenrie) Nov. 23, 2022

Nov. 23, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1518

3 3

[PATCH 0/1] MR1517: comsvcs: Use the iswxdigit function instead of reimplementing it.
by Alex Henrie (＠alexhenrie) Nov. 23, 2022

Nov. 23, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1517

2 1

[PATCH 0/1] MR1516: combase: Use the iswxdigit function instead of reimplementing it.
by Alex Henrie (＠alexhenrie) Nov. 23, 2022

Nov. 23, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1516

2 1

[PATCH 0/1] MR1514: dnsapi: Use the strdup and wcsdup functions instead of reimplementing them.
by Alex Henrie (＠alexhenrie) Nov. 23, 2022

Nov. 23, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1514

2 1

[PATCH 0/1] MR1503: wineusb.sys: Move event handling to a single thread.
by Ivo Ivanov (＠logos128) Nov. 23, 2022

Nov. 23, 2022

Also fixes a segmentation fault when exiting winedevice.exe. I can file a separate bug report, but it seems related to Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52213 On my system the core dump can be provoked when using the bus_udev backend in winebus.sys ("Enable SDL" 0). It creates two hid devices - a mouse and a keyboard. Since it resides in the same winedevice.exe process as wineusb.sys, something similar to the above bug occurs when handling the SIGQUIT signal. The actual crash happens in the libusb event thread while waiting in pthread_cond_wait(). I'm using this for months without any issues (with a device driver which uses wineusb.sys for device access, etc.). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1503

3 3