November 2022 - Wine-GitLab

[PATCH 0/1] MR1456: imm32: Prevent deadlock on unload
by Fabian Maurer (＠DarkShadow44) Nov. 20, 2022

Nov. 20, 2022

We need to make sure all (important) cleanup is finished when we exit DllMain, otherwise we might already unload krnl386 and deadlock Since we can't have a synchronous DestroyWindow, use an extra message Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52511 Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> Code flow is like follows: - DOSVM_Exit -> RtlExitUserThread -> LdrShutdownThread - acquire loader lock - send DLL_THREAD_DETACH to imm32 - - calls DestroyWindow on its window - - WM_DESTROY is handled asynchonously! - send DLL_THREAD_DETACH to krnl386.exe - - TASK_ExitTask - - try get win16 lock, is blocked by ime32 meanwhile, at ime32 - handles WM_DESTROY - already have win16 lock from user32 - __wine_ime_wnd_proc (WM_DESTROY) -> imm_couninit_thread -> CoRevokeInitializeSpy - LdrGetProcedureAddress (want CoRevokeInitializeSpy) - try get loader_lock, is blocked Solution is to wait in ime32 DllMain until the cleanup as happened, aka CoRevokeInitializeSpy has finished. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1456

3 3

[PATCH 0/1] MR1455: dinput: Wait on event instead of thread on stop
by Fabian Maurer (＠DarkShadow44) Nov. 20, 2022

Nov. 20, 2022

Since we stop the thread in DllMain, we always haev the loaderlock. Thread shutdown also requires the loader lock, so we will always time out So just wait until all cleanup is done, the thread itself can exit later Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52314 Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1455

3 2

[PATCH v2 0/1] MR1451: kernelbase: Add SetProcessInformation().
by Nikolay Sivov (＠nsivov) Nov. 20, 2022

Nov. 20, 2022

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53954 Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: kernelbase: Add SetProcessInformation(). https://gitlab.winehq.org/wine/wine/-/merge_requests/1451

2 1

[PATCH v2 0/2] MR1448: hid: parser and HidP_SetUsageValue fix
by Matthew Tran (＠0e4ef622) Nov. 20, 2022

Nov. 20, 2022

This fixes two things: * HID report descriptor parser enum for local items. Close inspection of page 40 of [Device Class Definition for HID 1.11](https://www.usb.org/document-library/device-class-definition-hid-111) reveals a jump between Designator Maximum (0101) and String Index (0111). This caused a controller of mine to not get recognized. * HidP_SetUsageValue for items that define multiple controls (with Report Count > 1). Attempting to set one value would result in HIDP_STATUS_BUFFER_TOO_SMALL. -- v2: hid: Fix HidP_SetUsageValue for usage ranges https://gitlab.winehq.org/wine/wine/-/merge_requests/1448

4 4

[PATCH 0/1] MR1452: win32u: Fix a memory leak.
by Zhiyi Zhang (＠zhiyi) Nov. 20, 2022

Nov. 20, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1452

3 2

[PATCH v3 0/3] MR1199: xmllite/writer : Implement a few APIs
by David Kahurani (＠kahurani) Nov. 20, 2022

Nov. 20, 2022

Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- v3: xmllite/writer: Implement WriteSurrogateCharEntity. xmllite/writer: Implement WriteRawChars. xmllite/writer: Implement WriteChars. https://gitlab.winehq.org/wine/wine/-/merge_requests/1199

4 15

[PATCH 0/1] MR1451: kernelbase: Add SetProcessInformation().
by Nikolay Sivov (＠nsivov) Nov. 20, 2022

Nov. 20, 2022

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53954 Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1451

3 2

[PATCH 0/1] MR1450: xmllite/reader: Use consistent formatting for traces.
by Nikolay Sivov (＠nsivov) Nov. 20, 2022

Nov. 20, 2022

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1450

3 2

[PATCH 0/1] MR1449: msado15: Avoid uninitialized variable use in fields_get_Item
by Gerald Pfeifer (＠gerald) Nov. 20, 2022

Nov. 20, 2022

This avoids the following warning by GCC 13: dlls/msado15/recordset.c:790:32: warning: 'i' may be used uninitialized -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1449

3 2

[PATCH v2 0/3] MR1199: xmllite/writer : Implement a few APIs
by David Kahurani (＠kahurani) Nov. 20, 2022

Nov. 20, 2022

Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- v2: xmllite/writer: Implement WriteSurrogateCharEntity. xmllite/writer: Implement WriteRawChars. xmllite/writer: Implement WriteChars. https://gitlab.winehq.org/wine/wine/-/merge_requests/1199

3 4