November 2022 - Wine-GitLab

Re: [PATCH v2 0/2] MR1319: Implement MB_SYSTEMMODAL for message boxes - approved
by Alexandre Julliard (＠julliard) Nov. 10, 2022

Nov. 10, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1319

1 0

Re: [PATCH v5 0/2] MR352: cmd: Don't loop infinitely on NUL. - approved
by Alexandre Julliard (＠julliard) Nov. 10, 2022

Nov. 10, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/352

1 0

Re: [PATCH v2 0/1] MR1320: winemac.drv: Stop using deprecated kIOMasterPortDefault constant. - approved
by Alexandre Julliard (＠julliard) Nov. 10, 2022

Nov. 10, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1320

1 0

Re: [PATCH v2 0/1] MR1290: mscoree: Use standard C functions for memory allocation in assembly.c. - approved
by Alexandre Julliard (＠julliard) Nov. 10, 2022

Nov. 10, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1290

1 0

Re: [PATCH v12 0/6] MR42: vkd3d-shader/hlsl: Some fixes. - approved
by Alexandre Julliard (＠julliard) Nov. 10, 2022

Nov. 10, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/42

1 0

[PATCH 0/1] MR1327: d2d1/tests: Use correct flags constants with D3D11CreateDevice().
by Nikolay Sivov (＠nsivov) Nov. 10, 2022

Nov. 10, 2022

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1327

3 2

[PATCH v2 0/1] MR1250: Draft: win32u: Initialize the server's cursor position from the user driver's.
by Tim Clem (＠tclem) Nov. 10, 2022

Nov. 10, 2022

The server's idea of the cursor position is never really initialized. Normally that's not a problem, since the first mouse movement and a number of other X events will update it. But in the case where the user never moves the mouse, it can remain out of sync. That manifests as `GetCursorPos` bouncing between the server's incorrect value and the real one from the user driver, depending on the age of the position on the server. I've marked this as a draft for two reasons: 1. I don't quite know where this belongs. We want to do it early in the lifespan of a user driver but after there's a desktop, so I've put it behind a `pthread_once` called from `get_desktop_window`. 2. I'm calling `NtUserSetCursorPos` to update the server, rather than a direct `set_cursor` request, because it contains some DPI logic. That has the side effect of potentially warping the cursor. That's not desirable or necessary, but it shouldn't be a problem. It's easily factored around if we want to avoid it. Any guidance would be greatly appreciated! -- v2: win32u: Initialize the server's cursor position from the user driver's. https://gitlab.winehq.org/wine/wine/-/merge_requests/1250

3 7

Re: [PATCH v2 0/1] MR1304: light.msstyles: Add nonclient metrics.
by Rémi Bernon Nov. 10, 2022

Nov. 10, 2022

On Thu Nov 10 16:26:09 2022 +0000, Zhiyi Zhang wrote: > https://gitlab.winehq.org/epo/wine/-/jobs/4880 succeeds It's for a MR that hasn't been rebased on top of latest HEAD and doesn't contain this change. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1304#note_13956

1 0

Re: [PATCH v2 0/1] MR1304: light.msstyles: Add nonclient metrics.
by Zhiyi Zhang (＠zhiyi) Nov. 10, 2022

Nov. 10, 2022

On Thu Nov 10 15:24:19 2022 +0000, Zhiyi Zhang wrote: > Tahoma is available so it's probably not that. > In the last comment, I mentioned there are no failures I meant no msg.c > failures. On second look, I can reliably reproduce those win.c failures > on FVWM, going as far back as wine-7.10. https://gitlab.winehq.org/epo/wine/-/jobs/4880 succeeds -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1304#note_13954

1 0

Re: [PATCH v2 0/1] MR1304: light.msstyles: Add nonclient metrics.
by Zhiyi Zhang (＠zhiyi) Nov. 10, 2022

Nov. 10, 2022

On Thu Nov 10 14:20:00 2022 +0000, Rémi Bernon wrote: > Reverting that single commit fixes the Gitlab pipeline, see > https://gitlab.winehq.org/rbernon/wine/-/pipelines/4066 vs > https://gitlab.winehq.org/rbernon/wine/-/pipelines/4064. It's perhaps > something with missing fonts? Tahoma is available so it's probably not that. In the last comment, I mentioned there are no failures I meant no msg.c failures. On second look, I can reliably reproduce those win.c failures on FVWM, going as far back as wine-7.10. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1304#note_13949

1 0