December 2022 - Wine-GitLab

[PATCH v5 0/5] MR1635: jscript: Implement a Garbage Collector to deal with circular references.
by Gabriel Ivăncescu Dec. 8, 2022

Dec. 8, 2022

Implement a basic GC based on the mark-and-sweep algorithm, without requiring manually specifying "roots", which vastly simplifies the management. For now, it is triggered every 30 seconds since it last finished, on a new object initialization. Better heuristics could be used in the future. The comments in the code should hopefully understand the high level logic of this approach without boilerplate details. I've tested it on FFXIV launcher (along with other patches from Proton to have it work) and it stops the massive memory leak successfully by itself, so at least it does its job properly. The last patch in the MR is just an optimization for a *very* common case. For artificial testing, one could use something like: ```javascript function leak() { var a = {}, b = {}; a.b = b; b.a = a; } ``` which creates a circular ref and will leak when the function returns. It also introduces and makes use of a "heap_stack", which prevents stack overflows on long chains. -- v5: jscript: Create the source function's 'prototype' prop object on demand. jscript: Run the garbage collector every 30 seconds on a new object jscript: Implement CollectGarbage(). jscript: Implement a Garbage Collector to deal with circular references. jscript: Use a jsdisp to hold refs for scopes. https://gitlab.winehq.org/wine/wine/-/merge_requests/1635

3 9

[PATCH v3 0/7] MR906: msvcr: Implement _StructuredTaskCollection::_RunAndWait and the constructor
by Torge Matthies (＠tmatthies) Dec. 8, 2022

Dec. 8, 2022

This implements the _RunAndWait member function and the constructor of the _StructuredTaskCollection, which enables the tests for that class to run. Also adds a throw of a missing_wait exception to the destructor when chores are scheduled and _RunAndWait was not called. Remaining stuff after this: - Task collection cancelling + IsCancelling function (next MR) - Cancellation token support (requires RE'ing the _CancellationTokenState class, currently in progress) -- v3: msvcr120: Throw exception in _StructuredTaskCollection_dtor if _RunAndWait was not called. msvcr100: Implement missing_wait exception. msvcr110: Implement _StructuredTaskCollection constructor. msvcr100: Implement exception passing from chore threads to _RunAndWait. msvcr100: Factor out EXCEPTION_RECORD to exception_ptr conversion. msvcr100: Move exception_ptr functions to a separate file. msvcr100: Implement _StructuredTaskCollection::_RunAndWait. https://gitlab.winehq.org/wine/wine/-/merge_requests/906

3 8

[PATCH 0/2] MR1744: wofutil: Stub WofShouldCompressBinaries().
by Hans Leidekker (＠hans) Dec. 8, 2022

Dec. 8, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1744

2 2

[PATCH 0/3] MR1742: win32u: A bit more user32 conversion
by Jacek Caban (＠jacek) Dec. 8, 2022

Dec. 8, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1742

3 4

[PATCH v2 0/1] MR1736: taskschd/tests: Fix test failures on newer version of Windows 10.
by Sven Baars (＠sbaars) Dec. 8, 2022

Dec. 8, 2022

I created some new test failures yesterday, sorry for that. -- v2: taskschd/tests: Fix test failures on newer version of Windows 10. https://gitlab.winehq.org/wine/wine/-/merge_requests/1736

3 2

[PATCH v3 0/1] MR1701: wshom.ocx: Implement IWshNetwork2_get_UserName().
by Robert Wilhelm (＠sloper42) Dec. 8, 2022

Dec. 8, 2022

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53971 -- v3: wshom.ocx: Implement IWshNetwork2_get_UserName(). https://gitlab.winehq.org/wine/wine/-/merge_requests/1701

3 3

[PATCH 0/1] MR1743: wtsapi32: Improve the stub for WTSQuerySessionInformation(WTSClientProtocolType).
by Hans Leidekker (＠hans) Dec. 8, 2022

Dec. 8, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1743

2 1

[PATCH v4 0/1] MR1578: ntdll: TlsIndex should not actually contain tls indices
by Evan Tang (＠etang-cw) Dec. 8, 2022

Dec. 8, 2022

> (The TlsIndex field in the LDR_DATA_TABLE_ENTRY structure appears to be unused except as a flag that the module has TLS (being always set to -1), at least as far back as Windows XP. It is worth mentioning that the WINE implementation of implicit TLS incorrectly uses TlsIndex as the real module TLS index, so it may be unreliable to assume that it is always -1 if you care about working on WINE.) > > \- http://www.nynaeve.net/?p=186 and the "links to that article but still doesn't work in wine" award goes to... [the D runtime](https://github.com/dlang/dmd/blob/6bf60ea0eb174631ede0074a77d3898d…! (Admittedly, there aren't too many ways to do what they're trying to do.) With this, the D runtime will now work in Wine, even if in a dll loaded into an exe with no tls (which gets it the tls index 0) The changes to the debugger are a bit icky, a possible alternative is to find some other easily-debugger-accessible place to stuff the tls index. -- v4: ntdll: TlsIndex should not actually contain tls indices https://gitlab.winehq.org/wine/wine/-/merge_requests/1578

4 3

[PATCH 0/1] MR1736: taskschd/tests: Fix test failures on newer version of Windows 10.
by Sven Baars (＠sbaars) Dec. 8, 2022

Dec. 8, 2022

I created some new test failures yesterday, sorry for that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1736

4 5

[PATCH v2 0/7] MR1714: cryptowinrt: Implement IKeyCredentialManagerStatics_IsSupportedAsync.
by Mohamad Al-Jaf (＠maljaf) Dec. 8, 2022

Dec. 8, 2022

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53176 1) The async test is broken on Windows 10 1507. This appears to be a trend among WinRT dlls. I'm thinking that we can add macro definitions for each testbot VM to avoid having to skip tests that would otherwise be working fine, and just greater control over tests in general. 2) The provider file that contains `interface IWineAsyncInfoImpl` is likely going to be reused again in the future. Perhaps a new file can be added in the include/wine folder to prevent duplicate code? I can do this in a separate merge request and cleanup the existing provider files. 3) All the check_bool_async tests return a random async_id so I skipped them. Testbot example: https://testbot.winehq.org/JobDetails.pl?Key=127232&f208=exe32.report#k208 -- v2: cryptowinrt: Implement IKeyCredentialManagerStatics_IsSupportedAsync. cryptowinrt/tests: Add IKeyCredentialManagerStatics_IsSupportedAsync tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/1714

4 17