December 2022 - Wine-GitLab

[PATCH 0/1] MR1859: winex11: Raise owned windows before setting input focus.
by Rémi Bernon Feb. 6, 2023

Feb. 6, 2023

Installers based on InnoSetup use invisible window owning the main installer window. When focus is given to the installer window popup, window managers sometimes do not raise it as their owner is invisible and it stays below other windows unless they are minimized. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=49933 This is not a regression and it is arguably perhaps a window manager bug, but it is also extremely annoying for users as installer windows tend to disappear from the pager, as well as missing from the window selector and below all other windows. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1859

1 2

[PATCH 0/1] MR1498: ntdll: Use RTLD_NOLOAD to find already mapped modules.
by Rémi Bernon Feb. 6, 2023

Feb. 6, 2023

This makes it possible to detect modules that weren't unmapped from dlclose, and that we should not fixup again. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=49640 This usually happens with C++ winelibs, where some C++ symbols may be inlined into the winelib, then later resolved in preference over other symbol definitions when libstdc++ loads. This results in circular dependency between the winelib and libstdc++, making dlclose no-op. In this case, reloading the lib later and calling `map_so_dll` on it again will fixup the RVAs again, ending up with invalid addresses. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1498

3 6

[PATCH v14 0/2] MR1268: wininet: Partially implement InternetSetFilePointer
by Jason Kuo (＠j20001970) Feb. 3, 2023

Feb. 3, 2023

-- v14: wininet: Partially implement InternetSetFilePointer wininet/tests: Add InternetSetFilePointer tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/1268

3 9

[PATCH 0/1] MR1749: mshtml: Add head, title and body elements to about:blank.
by Santino Mazza (＠tati1454) Jan. 28, 2023

Jan. 28, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1749

4 6

[PATCH v2 0/2] MR145: kernel32: Unstub MoveFileWithProgress, add test.
by James McDonnell (＠ElementalWarrior) Jan. 27, 2023

Jan. 27, 2023

-- v2: kernel32/tests: Implement test calling CopyFileExA with progress callback kernel32: Unstub MoveFileTransactedW, Use MoveFileWithProgressW https://gitlab.winehq.org/wine/wine/-/merge_requests/145

4 22

[PATCH 0/1] MR1167: wevtapi: Add EvtCreateBookmark stub.
by Mohamad Al-Jaf (＠maljaf) Jan. 26, 2023

Jan. 26, 2023

The launcher of Warhammer 40,000: Darktide calls this function. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1167

2 2

[PATCH 0/1] MR993: ieframe/tests: Mark tests failing randomly on Windows as flaky.
by Francois Gouget (＠fgouget) Jan. 26, 2023

Jan. 26, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/993

3 4

[PATCH 0/1] MR1855: makedep: Make output_filename more resilient
by Gerald Pfeifer (＠gerald) Jan. 26, 2023

Jan. 26, 2023

In early November 2022 builds on FreeBSD 12/amd64 saw makedep core dump 1791 times due to it being invoked with a NULL pointer. Turns out it did not validate its input for being non-NULL, so add such a check and add a diagnostics. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1855

3 3

[PATCH 0/27] MR27: vkd3d-shader/hlsl: Make hlsl_type_get_component_type() type argument
by Francisco Casas (＠fcasas) Jan. 25, 2023

Jan. 25, 2023

Okay, now the text is correctly written. Please disregard the previous MR I sent by mistake, I already closed it. *ehem* I don't expect this MR to be approved (because it is quite big) but I think it would be good if you review it so I start sending it in partitions, and to avoid working on conflicting patches. But, most importantly, because the patches in the middle of this series contain design decisions pertaining the handling of resource components and register spaces that, I think, are justified by their capability of supporting the many features in the second half of the patch series. Also, in case a different approach is deemed more convenient, it would be good to consider how it would manage the features in these patches. Most of these design decisions are implemented in the following patches of the series: ``` vkd3d-shader/hlsl: Span variables across multiple register spaces. vkd3d-shader/hlsl: Support variables that have multiple-registers in object reg. spaces. ``` I converged to these implementations by using Zeb's advice and by hitting myself against the wall while trying to implement these features with other approaches. In short, this patch series includes: * For SM1, the tex2D and tex3D intrinsics, inferring generic samplers dimension from usage, writing sampler declarations, and writing sample instructions. * Support for arrays of resources for both SM1 and SM4 (not to be confused with the resource-arrays of SM 5.1, which can have non-constant indexes). * Support for declaring resources within structs. * Support for synthetic combined samplers for SM1 and synthetic separated samplers for SM4, considering that they can be arrays or members of structs. * All of this while imitating the way the native compiler assigns the register indexes of the resources on allocation, which proved to be the most difficult thing, and the main reason behind the design decisions, because the rules are many, and all the previous things have combined effects in the assignment order. * (There are also many small fixes to corner cases I have stumbled upon, and validations for cases that should not be supported. Most of them are in short patches and in the first half of the MR). In order to test that the allocated register indexes (in both the sampler and texture spaces) were the same as the native compiler, I did manual tests using ps_4_0, ps_5_0 and ps_3_0 and compared the CTAB/RDEF sections while trying to deduct the assignment rules. Sadly, I cannot be sure that I am covering 100% of the possible scenarios. I had to do tests manually since it is difficult to test this with the shader_runner which is also limited to SM4, and I haven't learned how to implement C tests that check the reflection data yet (like the ones in wine that Zeb mentioned test_constant_table() in dlls/d3dcompiler_43/tests/hlsl_d3d9.c). Doing these tests automatically is still missing in this MR. Nevertheless, I could implement some tests for lowering combined samplers for SM4 that also double down as tests to check for the register assignment order in: ``` tests: Add lowering combined samplers tests. ``` For reference, these are some of the tests I have been running manually both for SM1 and SM4 (with the -GeC flag): [sm1-separated-samplers.hlsl](/uploads/56019f468f60bd942385c4267dd82754/sm1-separated-samplers.hlsl) [sm1-separated-samplers-array.hlsl](/uploads/a0d08ae30075db7290f63a91d79eb73c/sm1-separated-samplers-array.hlsl) [sm1-reserves-and-arrays.hlsl](/uploads/8bcec18556a3981a98b7a206ef2883cf/sm1-reserves-and-arrays.hlsl) [sm1-reserves-and-dims.hlsl](/uploads/ccbf1b6fe3907354164b8301d179ce5d/sm1-reserves-and-dims.hlsl) [sm1-separated-samplers-2.hlsl](/uploads/81929a9401bec2050f401a53ec6597e5/sm1-separated-samplers-2.hlsl) [sm1-separated-and-combined-samplers.hlsl](/uploads/5eb72698df741498bdea262298f88257/sm1-separated-and-combined-samplers.hlsl) [sm1-combined-order.hlsl](/uploads/6e3e7ee5bacd183ea8d3535ddcb2821c/sm1-combined-order.hlsl) -- This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/27

4 7

[PATCH 0/1] MR995: dsound/tests: Mark tests failing randomly on Windows as flaky.
by Francois Gouget (＠fgouget) Jan. 25, 2023

Jan. 25, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/995

2 2