December 2022 - Wine-GitLab

[PATCH 0/5] MR1622: d3d10/effect: Add support for more instructions.
by Nikolay Sivov (＠nsivov) Dec. 1, 2022

Dec. 1, 2022

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1622

3 9

[PATCH 0/2] MR1639: inetcomm: Fix some heap mismatches.
by Rémi Bernon Dec. 1, 2022

Dec. 1, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1639

1 2

[PATCH 0/1] MR1634: mshtml: Rename EVENTID_INVALID to EVENTID_INVALID_ID.
by Gabriel Ivăncescu Dec. 1, 2022

Dec. 1, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1634

2 2

[PATCH 0/1] MR1638: ntoskrnl.exe: use KeQueryMaximumProcessorCountEx for KeQueryMaximumProcessorCount.
by Etaash Mathamsetty (＠etaash.mathamsetty) Dec. 1, 2022

Dec. 1, 2022

this fixes a typo in one of my previously merged patches -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1638

2 1

[PATCH 0/1] MR1637: server: Fix buffer overrun in map_view handler.
by Alex Henrie (＠alexhenrie) Dec. 1, 2022

Dec. 1, 2022

Because of padding at the end of the struct, sizeof(*view) is greater than offsetof(struct memory_view, name[0]). Change the allocation to overallocate slightly instead of underallocating slightly. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1637

3 3

[PATCH v5 0/3] MR1502: Draft: winevulkan: wow64 memory mapping using VK_EXT_external_memory_host
by Jacek Caban (＠jacek) Dec. 1, 2022

Dec. 1, 2022

This MR implements memory mapping for wow64 using VK_EXT_external_memory_host. This has some problems (more below), but overall, it looks promising as a stopgap. It passes D3D tests and works fine in general. For proper solution, we'd need a new Vulkan extension. I experimented with a prototype extension https://github.com/KhronosGroup/Vulkan-Docs/pull/1906 and it looks like we can make it work, my WIP implementation is here https://gitlab.winehq.org/jacek/wine/-/tree/vulkan-map-placed. However, it would be nice to have a fallback working on existing drivers as well. The main problem of this MR is that it breaks Vulkan spec. The main rule it breaks is that according to spec, we should explicitly specify that we plan to use external memory when creating VkBuffer or VkImage. The problem is that we don't know if we will until we bind memory to the buffer. I tried some workarounds for that (delaying actual buffer creation, recreating buffer when needed). I got it mostly working and passing tests without validation errors, but it was more invasive than I'd like and still had other problems. I'd rather avoid that if possible. After looking at Mesa sources, I think that the way this MR breaks the spec should be harmless for its drivers. I don't have the hardware to test with Nvidia. If it works there, I'm tempted to ignore spec violation for now, given that the right path forward is VK_EXT_map_memory_placed anyway. Performance-wise, this MR is sub-optimal because we're limited in what memory types we can use. However, I ran Unigine benchmarks on radv and the difference was marginal. In case of Heaven, it was even slightly faster on wow64, which could be explained by 64-bit Vulkan driver being generally slightly faster, but the difference is too small to draw any conclusion. The last patch is not meant for (eventual) merge, but it's nice for testing the concept. It makes it possible to force using external memory in any kind of Wine build to experiment with its effects without need for wow64. To test that, just set `WINEVULKAN_EXTERNAL_MEMORY` environment variable. -- v5: winevulkan: Use VK_EXT_external_memory_host extension to map memory on wow64. winevulkan: Wrap VkDeviceMemory. winevulkan: Don't try to unwrap missing optional handle struct members. https://gitlab.winehq.org/wine/wine/-/merge_requests/1502

3 7

[PATCH 0/1] MR1632: taskschd: Use CRT functions for remaining heap allocations.
by Rémi Bernon Dec. 1, 2022

Dec. 1, 2022

Fixing heap mismatches introduced with !1466. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1632

2 2

[PATCH v2 0/2] MR1618: Draft: gdiplus: improve performance of GdipScaleMatrix
by Bartosz Kosiorek (＠gang65) Dec. 1, 2022

Dec. 1, 2022

-- v2: gdiplus: improve performance of matrix multiplication by unrolling loop gdiplus: improve performance of GdipScaleMatrix https://gitlab.winehq.org/wine/wine/-/merge_requests/1618

2 2

[PATCH v16 0/5] MR1148: ntdll: Mark created files beginning with a dot as not hidden.
by Torge Matthies (＠tmatthies) Dec. 1, 2022

Dec. 1, 2022

Fixes bug [53826](https://bugs.winehq.org/show_bug.cgi?id=53826). -- v16: https://gitlab.winehq.org/wine/wine/-/merge_requests/1148

3 8

[PATCH v2 0/2] MR1606: d3dx9/preshader: Move register table debug names to the rest of table info.
by Nikolay Sivov (＠nsivov) Dec. 1, 2022

Dec. 1, 2022

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: d3dx9/effect: Split parameters data from effect object. d3dx9/preshader: Handle input register table. https://gitlab.winehq.org/wine/wine/-/merge_requests/1606

3 5