July 2022 - Wine-GitLab - list.winehq.org

[PATCH v2 0/9] MR493: win32u: exception handling improvements and syscall conversion
by Jacek Caban (＠jacek) July 21, 2022

July 21, 2022

win32u is mostly ready for using syscall interface (for functions not taking HDC as an argument), but using client callbacks from syscalls will affect ability to unwind exceptions in a number of cases. On Windows, depending on kernel version, there are three different behaviors: (1) On 32-bit Windows kernels unwinding works across client callbacks. (2) On early 64-bit Windows kernels exceptions from client callbacks are filtered and ignored. (3) On recent Windows kernels exceptions from client callbacks are treated as unhandled exceptions. (1) is tempting because that's closest to how our pre-syscall code works. I prototyped that and I think we could make it work, but it's an additional complication to syscall interface that didn't really feel worth comparing to other options. ntdll part of this MR implements (2). I think we would ideally use (3) instead, but it's much more risky (and syscall conversion seems risky enough on its own). Microsoft incrementally transitioned from (2) to (3) with some compatibility mitigations involved. On top of that, some user32 calls that have win32u counterpars are still unwindable, unlike win32u variants. For example, DispatchMessageW behaves identical to NtUserDispatchMessage, except that it allow unwinding through the call, which suggests that the final call to window proc is done directly by user32, without kernel->client callback. SendMessage is also sometimes unwindable, but only when doing trivial winproc calls (but things like installing hook change that). -- v2: win32u: Get rid of no longer needed NtUserSetCallbacks. win32u: Use syscall interface for NtUserMessageCall and NtUserTrackPopupMenuEx. win32u: Use syscall interface for NtUserMsgWaitForMultipleObjectsEx. win32u/tests: Add tests for catching exceptions from timer proc. win32u: Use syscall interface for NtUserDispatchMessage. ntdll: Suppress callback exceptions in KiUserCallbackDispatcher. win32u: Avoid using client callbacks for NtUserSendMessage. win32u: Remove no longer needed NtUserDispatchMessageA. user32: Avoid using NtUserDispatchMessage in DispatchMessage. https://gitlab.winehq.org/wine/wine/-/merge_requests/493

2 10

[PATCH 0/6] MR488: uiautomationcore: Add support for retrieving properties from HUIANODEs.
by Connor McAdams (＠cmcadams) July 21, 2022

July 21, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/488

3 9

[PATCH v7 0/8] MR391: scrrun: Implement MoveFolder().
by Robert Wilhelm (＠sloper42) July 21, 2022

July 21, 2022

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52128 Signed-off-by: Robert Wilhelm <robert.wilhelm(a)gmx.net> -- v7: scrrun: Move directories only in MoveFolder(). scrrun: Support wildcards in MoveFolder(). scrrun: Move source dir into destination dir if destination ends with separator in MoveFolder(). https://gitlab.winehq.org/wine/wine/-/merge_requests/391

3 11

[PATCH 0/4] MR496: server: Try to improve error handling.
by Zebediah Figura (＠zfigura) July 20, 2022

July 20, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/496

2 4

Re: [PATCH v2 0/4] MR491: server: Various socket patches. - approved
by Alexandre Julliard (＠julliard) July 20, 2022

July 20, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/491

1 0

Re: [PATCH v4 0/1] MR489: jscript: return ParseProcedureText when compile fails. - approved
by Alexandre Julliard (＠julliard) July 20, 2022

July 20, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/489

1 0

Re: [PATCH v3 0/3] MR490: include: Add IMediaParamInfo definition. - approved
by Alexandre Julliard (＠julliard) July 20, 2022

July 20, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/490

1 0

Re: [PATCH v3 0/5] MR481: server: Use the token owner instead of the token user for default object owner. - approved
by Alexandre Julliard (＠julliard) July 20, 2022

July 20, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/481

1 0

Re: [PATCH v2 0/2] MR486: d3drm: Fix components of palette built when loading texture from file. - approved
by Zebediah Figura (＠zfigura) July 20, 2022

July 20, 2022

This merge request was approved by Zebediah Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/486

1 0

[PATCH 0/9] MR493: win32u: exception handling improvements and syscall conversion
by Jacek Caban (＠jacek) July 20, 2022

July 20, 2022

win32u is mostly ready for using syscall interface (for functions not taking HDC as an argument), but using client callbacks from syscalls will affect ability to unwind exceptions in a number of cases. On Windows, depending on kernel version, there are three different behaviors: (1) On 32-bit Windows kernels unwinding works across client callbacks. (2) On early 64-bit Windows kernels exceptions from client callbacks are filtered and ignored. (3) On recent Windows kernels exceptions from client callbacks are treated as unhandled exceptions. (1) is tempting because that's closest to how our pre-syscall code works. I prototyped that and I think we could make it work, but it's an additional complication to syscall interface that didn't really feel worth comparing to other options. ntdll part of this MR implements (2). I think we would ideally use (3) instead, but it's much more risky (and syscall conversion seems risky enough on its own). Microsoft incrementally transitioned from (2) to (3) with some compatibility mitigations involved. On top of that, some user32 calls that have win32u counterpars are still unwindable, unlike win32u variants. For example, DispatchMessageW behaves identical to NtUserDispatchMessage, except that it allow unwinding through the call, which suggests that the final call to window proc is done directly by user32, without kernel->client callback. SendMessage is also sometimes unwindable, but only when doing trivial winproc calls (but things like installing hook change that). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/493

4 11

[PATCH 0/3] MR495: wined3d: Do not try to unmap already unmapped BOs.
by Zebediah Figura (＠zfigura) July 20, 2022

July 20, 2022

This will silently succeed, and incorrectly unmap chunks which are still in use. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/495

2 3

Re: [PATCH v3 0/1] MR489: jscript: return ParseProcedureText when compile fails. - approved
by Jacek Caban (＠jacek) July 20, 2022

July 20, 2022

This merge request was approved by Jacek Caban. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/489

1 0

[PATCH v2 0/3] MR490: include: Add IMediaParamInfo definition.
by Zhiyi Zhang (＠zhiyi) July 20, 2022

July 20, 2022

Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com> -- v2: dsdmo: Add IMediaParamInfo stub interface. dsdmo/tests: Add IMediaParamInfo tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/490

3 4

[PATCH v2 0/1] MR352: cmd: Don't loop infinitely on NUL.
by Arek Hiler (＠ivyl) July 20, 2022

July 20, 2022

-- v2: cmd: Don't loop infinitely on NUL. https://gitlab.winehq.org/wine/wine/-/merge_requests/352

3 5

[PATCH v2 0/5] MR481: server: Use the token owner instead of the token user for default object owner.
by Jinoh Kang (＠iamahuman) July 20, 2022

July 20, 2022

This fixes Amazon Games not launching due to pipe client identity check in https://github.com/dotnet/runtime/blob/371905898f2c036cc30d662e8a6df162a219…. -- v2: server: Use the token owner instead of the token user for default object owner. advapi32/tests: Test that the token default DACL uses token owner instead of token user. advapi32/tests: Test that default object group match the token primary group. advapi32/tests: Test that default object owner match the token owner. advapi32/tests: Check that each ACE is ACCESS_ALLOWED_ACE in the default DACL. https://gitlab.winehq.org/wine/wine/-/merge_requests/481

2 6

[PATCH v3 0/3] MR418: mfplat: Support and test YV12, I410 and IYUV image formats.
by Giovanni Mascellani (＠giomasce) July 20, 2022

July 20, 2022

-- v3: mfplat/tests: Merge and reorganize image format tests. mfplat/buffer: Support YV12, I420 and IYUV image formats. mfplat/tests: Mark some tests as broken on Win 8 and 10 v1507. https://gitlab.winehq.org/wine/wine/-/merge_requests/418

2 3

[PATCH 0/3] MR490: include: Add IMediaParamInfo definition.
by Zhiyi Zhang (＠zhiyi) July 20, 2022

July 20, 2022

Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/490

3 4

[PATCH 0/4] MR491: server: Various socket patches.
by Zebediah Figura (＠zfigura) July 20, 2022

July 20, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/491

2 4

[PATCH 0/1] MR489: jscript: return ParseProcedureText when compile fails.
by Santino Mazza (＠tati1454) July 20, 2022

July 20, 2022

This prevents crashes when there is an invalid script inside a tag property. Because ParseProcedureText calls release_bytecode without checking if compile_script failed, "code" is not set, and this leads to a crash when release_bytecode tries to access it. To reproduce the bug you can create an html file and create a tag with a property having invalid JS in it. For example: ``` <script onerror="alert("></script> ``` Then you just open this file with iexplore. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/489

2 1

[PATCH v9 0/7] MR432: Add support for SPDRP_BASE_CONTAINERID by querying drivers with BusQueryContainerID
by Claire (＠ClearlyClaire) July 19, 2022

July 19, 2022

This is the hidclass/ntoskrnl/setupapi counterpart to !359. As with that merge request, implementing `BusQueryContainerID` in the bus driver is left out and will be addressed in a different MR. I believe this is useful to expose the Container ID no matter how those end up being assigned by the bus driver. -- v9: ntoskrnl: Set device ContainerID from driver hidclass: Expose ContainerID hidclass: Copy device ContainerID to child devices hidclass: Copy ContainerID from underlying driver in driver_add_device hidclass: Improve error handling in get_device_id ntoskrnl/tests: Add test for getting SPDRP_BASE_CONTAINERID from PnP driver setupapi: Add support for SPDRP_BASE_CONTAINERID https://gitlab.winehq.org/wine/wine/-/merge_requests/432

3 12

Re: [PATCH v2 0/3] MR353: shell32 improvements (fix $* wrongly quoted, allow file extensions as classname and verb "runas" to work) - approved
by Alexandre Julliard (＠julliard) July 19, 2022

July 19, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/353

1 0

Re: [PATCH v2 0/3] MR457: ntdll/tests: Add RtlFirstFreeAce tests - approved
by Alexandre Julliard (＠julliard) July 19, 2022

July 19, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/457

1 0

Re: [PATCH v2 0/5] MR472: server: Do not set connectionless sockets into the CONNECTING or CONNECTED state. - approved
by Alexandre Julliard (＠julliard) July 19, 2022

July 19, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/472

1 0

Re: [PATCH v3 0/5] MR471: uiautomationcore: Implement Property ID GUIDs and UiaNodeFromProvider. - approved
by Alexandre Julliard (＠julliard) July 19, 2022

July 19, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/471

1 0

[PATCH 0/1] MR400: shell32: Fix handling of very long URLs
by SmallJoker (＠SmallJoker) July 19, 2022

July 19, 2022

Move from stack to heap allocations where needed to avoid out-of-bounds writes resulting in stack corruptions caused by strcpy/strcat and alike. Tested using `wine shell32_test.exe.so shlexec` (64-bit only). Expected output: `0020:shlexec: 1724 tests executed (43 marked as todo, 0 failures), 0 skipped.` This change is based on https://www.winehq.org/pipermail/wine-devel/2021-May/187791.html and fixes some of the missing bounds checks in this file. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/400

2 3