July 2022 - Wine-GitLab - list.winehq.org

[PATCH v7 0/4] MR359: mmdevapi: copy ContainerID property from audio driver if available
by Claire (＠ClearlyClaire) Feb. 3, 2026

Feb. 3, 2026

Some games with support for the haptic feedback and speaker features of the Sony DualSense controller select the controller's audio output by filtering on the ContainerId IMMDevice property to find one that matches the controller's HID's. This MR allows this information to be accessible from the IMMDevice's property store when the audio driver provides it (none for now, but I intend to add that feature to `winepulse.drv` and maybe `winealsa.drv`) This is made specific to containerId rather than supporting VT_CLSID on every property because Wine currently stores VT_BLOBs directly in the registry value, which does not allow us to safely disambiguate between VT_CLSID and VT_BLOB values when reading from registry. -- v7: mmdevapi: Invalidate ContainerID of unavailable audio devices. https://gitlab.winehq.org/wine/wine/-/merge_requests/359

7 12

[PATCH v2 0/2] MR475: server: Fix object name resolution of \Device\Null.
by Jinoh Kang (＠iamahuman) Dec. 5, 2024

Dec. 5, 2024

This simplifies future tests that check for object name of devices. -- v2: server: Fix object name resolution of \Device\Null. server: Make explicit the ownership of the unix_name buffer. https://gitlab.winehq.org/wine/wine/-/merge_requests/475

3 4

[PATCH 0/2] MR482: advapi32/tests: Test kernel object security with the primary token as well.
by Jinoh Kang (＠iamahuman) Nov. 9, 2024

Nov. 9, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/482

2 3

[PATCH 0/1] MR474: server: Default the token owner to the token user.
by Jinoh Kang (＠iamahuman) Nov. 9, 2024

Nov. 9, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/474

2 3

[PATCH 0/1] MR411: win32u: Don't load bitmap only TTF fonts without bitmap table.
by Paul Gofman (＠gofman) Dec. 4, 2023

Dec. 4, 2023

The offending font is NotoColorEmoji.ttf which is present in, e. g., google-noto-emoji-color-fonts or noto-fonts-emoji packages available in various distribution. Attempting to load this font on Windows 10 (with AddFontResourceA() or open it with default font viewer) fails while currently succeeds on Windows. fontforge also refuses to open this font. That is because the font is bitmap only but missing bitmap table. Some apps (Glyph launcher is an example) try to GetOutlineTextMetrics() on this font and do not expect that to have an error return (as we currenly do), which leads to crash on unhandled division by zero exception. I am attaching a bitmap-only ttf test font (with only one bitmap) which I created with fontforge to make sure that such font can still be loaded in Wine. This font also loads on Windows (both with AddFontResourceA() and with default font viewer). There are other font types which can be legitimately missing EBDT table, but FT_Load_Sfnt_Table() returns a different error for those and my patch doesn't reject those fonts. [test.ttf](/uploads/b41472180b80c2c53f9dcc06055990f0/test.ttf) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/411

5 12

[PATCH 0/2] MR535: Draft: winebus: implement BusQueryContainerID for USB devices when using bus_udev
by Claire (＠ClearlyClaire) Sept. 4, 2023

Sept. 4, 2023

Some games with support for the haptic feedback and speaker features of the Sony DualSense controller select the controller's audio output by filtering on the ContainerId IMMDevice property to find one that matches the controller's HID's. While MRs !359 and !360 implement getting the ContainerID of the IMMDevice, this MR implements getting the ContainerID from the HID device. As for !360, I marked this MR as a draft because I understand that the way the ��GUID�� is generated is far from ideal. Furthermore, there is code duplication with !360 in the way the container's sysfspath is found and how a GUID is generated from it, so moving that part elsewhere would make sense. But as for !360, I think I will need help with those tasks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/535

4 4

[PATCH v4 0/3] MR417: riched20: Add font fallback support.
by Jactry Zeng (＠jactry) July 25, 2023

July 25, 2023

Signed-off-by: Jactry Zeng <jzeng(a)codeweavers.com> -- v4: riched20: Add font fallbacks for CJK. riched20: Add font fallback support. riched20: Use OpenType functions for painting and generating script tags. https://gitlab.winehq.org/wine/wine/-/merge_requests/417

4 10

[PATCH v5 0/1] MR477: d3drm/tests: Show Clear sets background color
by Alistair Leslie-Hughes (＠alesliehughes) July 17, 2023

July 17, 2023

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> -- v5: d3drm/tests: Show Clear sets background color https://gitlab.winehq.org/wine/wine/-/merge_requests/477

4 4

[PATCH 0/2] MR542: configure: Build with -mimpure-text if available when building with -fno-PIC.
by Zebediah Figura (＠zfigura) May 23, 2023

May 23, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/542

4 6

[PATCH 0/1] MR533: xactengine3_7/tests: Test wave bank pointer also when creating one.
by Giovanni Mascellani (＠giomasce) Feb. 20, 2023

Feb. 20, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/533

3 3

[PATCH 0/1] MR498: server: Allow creating named pipes using \Device\NamedPipe\ as RootDirectory. (#52105)
by Jinoh Kang (＠iamahuman) Oct. 11, 2022

Oct. 11, 2022

On Windows, \Device\NamedPipe\ is the root directory of the named pipe file system (NPFS), and can be used as RootDirectory to skip its path when accessing the NPFS namespace. This introduces a regression that makes it possible to use \Device\NamedPipe (note the lack of trailing backslash) as RootDirectory as well, since Wine does not distinguish between \Device\NamedPipe (the device itself) and \Device\NamedPipe\ (the root directory of the filesystem). (Previous iteration of this patch did distinguish between the two, but the method in which it was implemented was deemed hacky.) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/498

5 11

[PATCH v3 0/4] MR47: kernel32/tests: Add tests for CancelSynchronousIo.
by Daniel Lehman (＠dlehman25) Sept. 19, 2022

Sept. 19, 2022

Signed-off-by: Daniel Lehman <dlehman25(a)gmail.com> -- v3: kernelbase: Call NtCancelSynchronousIoFile in CancelSynchronousIo. ntdll: Partially implement NtCancelSynchronousIoFile. ntdll: Add NtCancelSynchronousIoFile stub. kernel32/tests: Add tests for CancelSynchronousIo. https://gitlab.winehq.org/wine/wine/-/merge_requests/47

5 17

[PATCH 0/5] MR502: winusb: Add WinUsb_Free stub.
by Mohamad Al-Jaf (＠maljaf) Sept. 12, 2022

Sept. 12, 2022

The program REVELPROG_IS runs with this patchset. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52677 Signed-off-by: Mohamad Al-Jaf <mohamadaljaf(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/502

3 10

[PATCH v3 0/6] MR492: Enhancements for C++ symbols undecoration
by eric pouech (＠epo) Aug. 30, 2022

Aug. 30, 2022

This series implements a couple of enhancements to symbol undecoration in msvcrt: - more C++ constructs are correctly supported (pointer to member, constructors/destructors from template class, non-type function pointer template parameter...) - some internal cleanups & simplification (most of them based on revamped helper to build up the undecorated C++ symbols) -- v3: dlls/msvcrt: Fix order of extended qualifiers and qualifiers dlls/msvcrt: Use enum to clarify post-processing actions. dlls/msvcrt: Undecorate function signature as template argument. dlls/msvcrt: Fix white space output for typecast operator. dlls/msvcrt: Improve support for template in methods. dlls/msvcrt: Correctly support space generation in pointers. https://gitlab.winehq.org/wine/wine/-/merge_requests/492

3 11

[PATCH 0/3] MR546: mfplat: Implement and use IMF2DBuffer2::Copy2DTo().
by Giovanni Mascellani (＠giomasce) Aug. 20, 2022

Aug. 20, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/546

4 7

[PATCH v24 0/5] MR464: Implement _StructuredTaskCollection::_Schedule{,_loc}
by Torge Matthies (＠tmatthies) Aug. 10, 2022

Aug. 10, 2022

- Based on !463 - _RunAndWait and exception handling implemented in later commits @piotr -- v24: msvcr100: Implement _StructuredTaskCollection::_Schedule and _Schedule_loc. msvcr100: Add reference counting to thread contexts. msvcr100: Factor out the mapping of a context to a scheduler. msvcr100: Factor out EXCEPTION_RECORD to exception_ptr conversion. msvcr100: Move exception_ptr functions to a separate file. https://gitlab.winehq.org/wine/wine/-/merge_requests/464

3 9

[PATCH 0/1] MR549: ws2_32: Move the #ifdef into the function
by André Zwing Aug. 9, 2022

Aug. 9, 2022

Signed-off-by: Andr�� Zwing <nerv(a)dawncrow.de> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/549

4 8

[PATCH v8 0/8] MR391: scrrun: Implement MoveFolder().
by Robert Wilhelm (＠sloper42) Aug. 2, 2022

Aug. 2, 2022

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52128 Signed-off-by: Robert Wilhelm <robert.wilhelm(a)gmx.net> -- v8: scrrun: Move directories only in MoveFolder(). scrrun: Support wildcards in MoveFolder(). scrrun: Move source dir into destination dir if destination ends with separator in MoveFolder(). scrrun: Check that source is directory in MoveFolder(). scrrun: Check for non-existant source in MoveFolder(). https://gitlab.winehq.org/wine/wine/-/merge_requests/391

3 19

[PATCH v3 0/4] MR565: Implement NCryptEncrypt and BCryptEncrypt
by Santino Mazza (＠tati1454) Aug. 2, 2022

Aug. 2, 2022

Some installer, like the visual studio installer, also make use of this function, instead of just NCryptVerifySignature. -- v3: ncrypt: Initial implementation for NCryptEncrypt. bcrypt: Initial RSA encryption implementation. bcrypt/tests: Test for BCryptEncrypt with RSA keys. https://gitlab.winehq.org/wine/wine/-/merge_requests/565

3 11

[PATCH 0/1] MR516: webservices: Write the correct headers when a request message is addressed.
by Shaun Ren (＠shaunren) Aug. 2, 2022

Aug. 2, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/516

3 2

[PATCH v3 0/7] MR536: xactengine3_7: Add helper function to add entries
by Alistair Leslie-Hughes (＠alesliehughes) Aug. 2, 2022

Aug. 2, 2022

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> -- v3: xactengine3_7: Return error on invalid notification value. xactengine3_7: Implement callback for supported messages xactengine3_7: Record context for each notications xactengine3_7: Map IXACT3Wave interfaces xactengine3_7: Map IXACT3Cue interfaces xactengine3_7: Map SoundBank interfaces xactengine3_7: Add helper function to add entries https://gitlab.winehq.org/wine/wine/-/merge_requests/536

3 12

[PATCH v3 0/2] MR521: ddraw: Don't account video memory for sysmem surfaces' draw textures.
by Stefan Dösinger Aug. 2, 2022

Aug. 2, 2022

Star Trek Starfleet Academy does not like it when available video memory goes down after creating a system memory resource. It destroys all its textures and recreates them, and in some sitations forgets to recreate one or another texture, resulting in rendering bugs. I suspect the game is trying to detect focus loss by monitoring for unexpected video memory changes. --- I am open to renaming WINED3DUSAGE_PRIVATE to something else, like WINED3DUSAGE_NO_VIDMEM_ACCOUNTING. This particular name is ugly long though. -- v3: ddraw/tests: Add some video memory accounting tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/521

3 5

[PATCH v2 0/6] MR543: wined3d: Cache the output mode lists where possible.
by Zebediah Figura (＠zfigura) Aug. 2, 2022

Aug. 2, 2022

-- v2: wined3d: Build the device list only once in wined3d_output_find_closest_matching_mode(). dxgi: Build the device list only once in dxgi_output_get_display_mode_list(). d3d8: Cache the output mode list. d3d9: Cache the output mode list. wined3d: Build a list of wined3d_display_mode structures in wined3d_output_get_mode[_count](). wined3d: Factor out mode_matches_filter(). https://gitlab.winehq.org/wine/wine/-/merge_requests/543

5 10

[PATCH v2 0/11] MR557: mciqtz32: Correct video window behavior by creating default window.
by Akihiro Sagawa (＠sgwaki) Aug. 2, 2022

Aug. 2, 2022

This is a new try of mciqtz32's video window patch. Comparing to the previous !370, I added a lot of tests regarding the video window behavior. Some portion of the previous patch are dropped to avoid complexity, I'll add that part later. -- v2: mciqtz32: Show the default video window when switching from another one. mciqtz32: Hide the default video window when switching to another one. mciqtz32: Reset the video size when changing video destination. mciqtz32: Correct initial video window dimensions. mciqtz32: Fix MCI_DGV_WHERE_WINDOW behavior. mciqtz32: Correct video window behavior by creating default window. winmm/tests: Add tests for destination of video window. winmm/tests: Add tests for dimensions of video window. winmm/tests: Add tests for window style of video window. mciqtz32: Don't hide video window when stopping. winmm/tests: Add tests for visibility of video window. https://gitlab.winehq.org/wine/wine/-/merge_requests/557

3 15

[PATCH v2 0/3] MR393: wmvcore: Asynchronous reader state transitions.
by Rémi Bernon Aug. 1, 2022

Aug. 1, 2022

Before https://gitlab.winehq.org/wine/wine/-/merge_requests/140, and to avoid a situation in the future where we might decide to implement this, and where the callback would be called asynchronously as they are supposed to, without the ASF reader filter supporting it. -- v2: winegstreamer: Make IWMReader state transitions asynchronous. winegstreamer: Move IWMReaderCallbackAdvanced *callback_advanced to a local variable. wmvcore/tests: Add more IWMReader_(Open|Start|Stop|Close) async checks. https://gitlab.winehq.org/wine/wine/-/merge_requests/393

2 7

[PATCH v2 0/1] MR564: cabinet.dll: implement DllGetVersion & GetDllVersion
by Tobias Görgens Aug. 1, 2022

Aug. 1, 2022

Fix stub DllGetVersion implementation to read Dll version and put it in correct structure. Implement GetDllVersion by using DllGetVersion function and return version -- v2: cabinet.dll: implement DllGetVersion & GetDllVersion https://gitlab.winehq.org/wine/wine/-/merge_requests/564

2 7

[PATCH v4 0/6] MR550: comctl32/listview: Fix LVS_OWNERDATA list view multi select.
by Angelo Haller (＠szanni) Aug. 1, 2022

Aug. 1, 2022

The following patches fix sending of the LVN_ODSTATECHANGED notification for LVS_OWNERDATA list views, adding more refined tests in the process and fixing various bugs. This is v5, with the added comment in 3/6 as requested on the mailing list. These are the patches sent as a response to v4 by Zhiyi Zhang on the mailing list, unmodified apart from 3/6 or f24f4b7fd. --- Warning: I have had access to the Windows Research Kernel (WRK) 1.2 ~10 years ago. These changes are regarding comctrl32 & tests which are NOT part of the WRK. As outlined in https://wiki.winehq.org/Developer_FAQ this should therefore satisfy the requirement of ONLY submitting patches to components I have NOT had access to. -- v4: comctl32/tests: Add more ownerdata listview tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/550

3 9

[PATCH 0/6] MR561: winex11.drv: Use DEVMODEW instead of x11drv_display_setting.
by Rémi Bernon Aug. 1, 2022

Aug. 1, 2022

In preparation for moving display placement to win32u, for https://gitlab.winehq.org/wine/wine/-/merge_requests/551. The idea for win32u to enumerate and work with full modes, with driver extra data, to do the display placement logic and validation, and pass the modes array for all adapters at once to the driver to apply them. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/561

2 11

[PATCH 0/3] MR504: shell32: Implement SHBindToFolderIDListParent.
by Mohamad Al-Jaf (＠maljaf) Aug. 1, 2022

Aug. 1, 2022

Called by IE11. Signed-off-by: Mohamad Al-Jaf <mohamadaljaf(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/504

2 5

[PATCH v2 0/4] MR565: Implement NCryptEncrypt and BCryptEncrypt
by Santino Mazza (＠tati1454) July 31, 2022

July 31, 2022

Some installer, like the visual studio installer, also make use of this function, instead of just NCryptVerifySignature. -- v2: ncrypt: Initial implementation for NCryptEncrypt. bcrypt: Initial RSA encryption implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/565

2 4

[PATCH 0/4] MR565: Implement NCryptEncrypt and BCryptEncrypt
by Santino Mazza (＠tati1454) July 31, 2022

July 31, 2022

Some installer, like the visual studio installer, also make use of this function, instead of just NCryptVerifySignature. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/565

2 4

[PATCH 0/1] MR564: cabinet.dll: implement DllGetVersion & GetDllVersion
by Tobias Görgens July 31, 2022

July 31, 2022

Fix stub DllGetVersion implementation to read Dll version and put it in correct structure. Implement GetDllVersion by using DllGetVersion function and return version -- https://gitlab.winehq.org/wine/wine/-/merge_requests/564

1 2

Re: [PATCH v3 0/11] MR557: mciqtz32: Correct video window behavior by creating default window.
by Akihiro Sagawa (＠sgwaki) July 31, 2022

July 31, 2022

Fix intermediate test failures. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/557#note_5382

1 0

[PATCH v2 0/7] MR536: xactengine3_7: Add helper function to add entries
by Alistair Leslie-Hughes (＠alesliehughes) July 31, 2022

July 31, 2022

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> -- v2: xactengine3_7: Return error on invalid notification value. xactengine3_7: Implement callback for supported messages xactengine3_7: Record context for each notications xactengine3_7: Map IXACT3Wave interfaces xactengine3_7: Map IXACT3Cue interfaces xactengine3_7: Map SoundBank interfaces xactengine3_7: Add helper function to add entries https://gitlab.winehq.org/wine/wine/-/merge_requests/536

2 7

[PATCH v2 0/6] MR553: mf: Some attribute tweaks to fix Resampler transform regressions.
by Rémi Bernon July 30, 2022

July 30, 2022

-- v2: winegstreamer: Use the correct name for WMADecMediaObject DMO. mf: Increase min_buffer_size to MF_MT_AUDIO_AVG_BYTES_PER_SECOND. mf: Implement SAR media type required attributes checks. winegstreamer: Set the MF_MT_AUDIO_AVG_BYTES_PER_SECOND attribute. mf: Return MF_E_NO_MORE_TYPE from AudioRenderer GetMediaTypeByIndex. mf/tests: Add required SAR media type attributes tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/553

2 8

Re: [PATCH v2 0/1] MR563: opengl32/tests: Remove depth 32 / stencil 0 test in test_choosepixelformat(). - approved
by Alexandre Julliard (＠julliard) July 29, 2022

July 29, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/563

1 0

Re: [PATCH v3 0/5] MR562: mshtml: Doctype node and windowless document fixes. - approved
by Alexandre Julliard (＠julliard) July 29, 2022

July 29, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/562

1 0

Re: [PATCH v2 0/1] MR560: dwrite: Fix fallback config ranges text parsing. - approved
by Alexandre Julliard (＠julliard) July 29, 2022

July 29, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/560

1 0

Re: [PATCH v2 0/2] MR559: Type 'pointer to type' in WineDbg. - approved
by Alexandre Julliard (＠julliard) July 29, 2022

July 29, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/559

1 0

[PATCH 0/1] MR563: opengl32/tests: Remove depth 32 / stencil 0 test in test_choosepixelformat().
by Paul Gofman (＠gofman) July 29, 2022

July 29, 2022

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53429 As the bug states, the test is failing on Wine / Intel GPU. The test was added in commit 83cbcdefa3f55afc449b6be51e215c4f646869f4 which was a test for cc8d8b5ee33561e984d4abe4112ddd6324f77115 (opengl32: Prioritize stencil check over depth check in wglChoosePixelFormat()). The motivation under that change was to avoid the situation when we erroneously return the no-stencil format (which was breaking a game) and not vice versa. This specific test was probably added for completeness. I don't have a Windows Intel GPU machine to check how it looks like there but it seems to me that this aspect (returning 0 depth stencil instead of 8 when no stencil requested) is much less likely to affect things in practice, so just remove the test instead of trying to fix that in Wine on Intel. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/563

3 2

[PATCH v2 0/5] MR562: mshtml: Doctype node and windowless document fixes.
by Gabriel Ivăncescu July 29, 2022

July 29, 2022

-- v2: mshtml: Handle lack of window in methods for detached documents. https://gitlab.winehq.org/wine/wine/-/merge_requests/562

2 6

[PATCH 0/5] MR562: mshtml: Doctype node and windowless document fixes.
by Gabriel Ivăncescu July 29, 2022

July 29, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/562

1 5

[PATCH v3 0/6] MR550: comctl32/listview: Fix LVS_OWNERDATA list view multi select.
by Angelo Haller (＠szanni) July 29, 2022

July 29, 2022

The following patches fix sending of the LVN_ODSTATECHANGED notification for LVS_OWNERDATA list views, adding more refined tests in the process and fixing various bugs. This is v5, with the added comment in 3/6 as requested on the mailing list. These are the patches sent as a response to v4 by Zhiyi Zhang on the mailing list, unmodified apart from 3/6 or f24f4b7fd. --- Warning: I have had access to the Windows Research Kernel (WRK) 1.2 ~10 years ago. These changes are regarding comctrl32 & tests which are NOT part of the WRK. As outlined in https://wiki.winehq.org/Developer_FAQ this should therefore satisfy the requirement of ONLY submitting patches to components I have NOT had access to. -- v3: comctl32/tests: Add more ownerdata listview tests. comctl32/listview: Don't send LVN_ODSTATECHANGED for empty ranges. comctl32/listview: Send LVN_ODSTATECHANGED notification for LVS_OWNERDATA listview on selection changes. comctl32/listview: Send LVN_ODSTATECHANGED only for LVS_OWNERDATA listviews. comctl32/listview: Move sending LVN_ODSTATECHANGED notifications to a function. comctl32/listview: Send one deselect all items notification for LVS_OWNERDATA listviews. https://gitlab.winehq.org/wine/wine/-/merge_requests/550

3 10

[PATCH 0/1] MR560: dwrite: Fix fallback config ranges text parsing.
by Nikolay Sivov (＠nsivov) July 29, 2022

July 29, 2022

Currently it's using all 16 slots, filling trailing ones with rudimentary ranges. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/560

2 2

[PATCH 0/2] MR559: Type 'pointer to type' in WineDbg.
by eric pouech (＠epo) July 29, 2022

July 29, 2022

This series ensures that when WineDbg looks up for the type 'pointer to a given type', this type always exists. There's no reason this is always available from DbgHelp, so synthetize the relevant type when it's not. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/559

2 2

[PATCH v2 0/5] MR551: win32u: Complete support for display modes in nulldrv.
by Rémi Bernon July 29, 2022

July 29, 2022

With this series it's now possible to run and pass `user32:monitor` and `user32:sysparams` tests with nulldrv, and so most `user32` tests (except for a few desktop cursor position tests). This still requires some prefix configuration to enable the nulldrv driver, or a change like https://gitlab.winehq.org/rbernon/wine/-/commit/753368ad0ec52f03f8d6e78ca79… to enable it when `DISPLAY` environment variable is unset. This then shows that some of the user32 tests are failing with winex11 but passing with nulldrv, as in https://gitlab.winehq.org/rbernon/wine/-/commit/6d5f4109a514a0dc266899fcacf…. -- v2: win32u: Add a default EnumDisplaySettingsEx driver implementation. win32u: Add a default ChangeDisplaySettingsEx driver implementation. win32u: Move enumeration of available modes out of graphics drivers. win32u: Validate NtUserChangeDisplaySettings mode against available modes. win32u: Ignore DM_POSITION mode fields for available modes. https://gitlab.winehq.org/wine/wine/-/merge_requests/551

2 25

Re: [PATCH v2 0/6] MR550: comctl32/listview: Fix LVS_OWNERDATA list view multi select.
by Zhiyi Zhang (＠zhiyi) July 29, 2022

July 29, 2022

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/listview.c: > ok_sequence(sequences, PARENT_ODSTATECHANGED_SEQ_INDEX, > - ownerdata_multiselect_odstatechanged_seq, > - "ownerdata select multiple notification", FALSE); > + ownerdata_multiselect_move_3_to_2_odstatechanged_seq, > + "ownerdata multiselect: keep selection but move cursor via CONTROL+UP ", FALSE); > + res = SendMessageA(hwnd, WM_KEYUP, VK_UP, 0); > + expect(0, res); > + res = SendMessageA(hwnd, LVM_GETSELECTEDCOUNT, 0, 0); > + expect(1, res); > > - res = SendMessageA(hwnd, WM_KEYUP, VK_DOWN, 0); > + hold_key(VK_SHIFT); > + > + flush_sequences(sequences, NUM_MSG_SEQUENCES); > + > + /* Select multiple via SHIFT+CONTROL+DOWN after moving cursor over an item without selecting */ Wrong comment. Should be SHIFT+CONTROL+UP. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/550#note_5317

1 0

Re: [PATCH v2 0/6] MR550: comctl32/listview: Fix LVS_OWNERDATA list view multi select.
by Zhiyi Zhang (＠zhiyi) July 29, 2022

July 29, 2022

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/listview.c: > + res = SendMessageA(hwnd, WM_KEYDOWN, VK_DOWN, 0); > + expect(0, res); > + ok_sequence(sequences, PARENT_ODSTATECHANGED_SEQ_INDEX, > + ownerdata_multiselect_select_3_odstatechanged_seq, > + "ownerdata multiselect: deselect all, select item 3 via DOWN", FALSE); > + res = SendMessageA(hwnd, WM_KEYUP, VK_DOWN, 0); > + expect(0, res); > + res = SendMessageA(hwnd, LVM_GETSELECTEDCOUNT, 0, 0); > + expect(1, res); > + > + hold_key(VK_SHIFT); > + > + flush_sequences(sequences, NUM_MSG_SEQUENCES); > + > + /* First up then down */ > + /* Select multiple items via SHIFT+UP */ For consistency, let's move hold_key() to the start of each test. Right now some of them are at the start and some are at the up. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/550#note_5316

1 0

Re: [PATCH v2 0/6] MR550: comctl32/listview: Fix LVS_OWNERDATA list view multi select.
by Zhiyi Zhang (＠zhiyi) July 29, 2022

July 29, 2022

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/listview.c: > > - /* disable per item notifications on LVS_OWNERDATA style > - FIXME: single LVN_ODSTATECHANGED should be used */ > + /* Disable per item notifications on LVS_OWNERDATA style */ > old_mask = infoPtr->notify_mask & NOTIFY_MASK_ITEM_CHANGE; > if (infoPtr->dwStyle & LVS_OWNERDATA) > infoPtr->notify_mask &= ~NOTIFY_MASK_ITEM_CHANGE; > > LISTVIEW_DeselectAllSkipItems(infoPtr, selection); > > - > iterator_rangesitems(&i, selection); > while(iterator_next(&i)) > - LISTVIEW_SetItemState(infoPtr, i.nItem, &item); > + { > + // Find the range for LVN_ODSTATECHANGED Please use /**/ instead. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/550#note_5315

1 0

Re: [PATCH v2 0/1] MR558: win32u: Fix typo in font handle creation in NtUserDrawCaptionTemp(). - approved
by Alexandre Julliard (＠julliard) July 28, 2022

July 28, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/558

1 0