July 2022 - Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/4] MR47: kernel32/tests: Add tests for CancelSynchronousIo.
by Jinoh Kang (＠iamahuman) July 10, 2022

July 10, 2022

Jinoh Kang (@iamahuman) commented about dlls/ntdll/unix/file.c: > */ > NTSTATUS WINAPI NtCancelSynchronousIoFile( HANDLE handle, IO_STATUS_BLOCK *io, IO_STATUS_BLOCK *io_status ) > { > - FIXME( "(%p,%p,%p) stub\n", handle, io, io_status ); > - return STATUS_NOT_IMPLEMENTED; > + NTSTATUS status; > + > + TRACE( "(%p %p %p)\n", handle, io, io_status ); I'd at least leave a "partial fixme" here, since this is, after all, a partial implementation. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/47#note_3835

2 1

Re: [PATCH v2 0/4] MR47: kernel32/tests: Add tests for CancelSynchronousIo.
by Daniel Lehman (＠dlehman25) July 10, 2022

July 10, 2022

On Sun Jul 10 17:41:41 2022 +0000, Jinoh Kang wrote: > I'd at least leave a "partial fixme" here, since this is, after all, a > partial implementation. will do still isn't clear to me what the 2nd argument does. 32-bit windows treats it differently from 64-bit windows, but only in the returned ntstatus. doesn't seem to affect the intended behavior -- https://gitlab.winehq.org/wine/wine/-/merge_requests/47#note_3838

1 0

Re: [PATCH v2 0/4] MR47: kernel32/tests: Add tests for CancelSynchronousIo.
by Jinoh Kang (＠iamahuman) July 10, 2022

July 10, 2022

Jinoh Kang (@iamahuman) commented about dlls/ntdll/tests/pipe.c: > Sleep(100); > memset(&iosb, 0x55, sizeof(iosb)); > res = pNtCancelSynchronousIoFile(thread, NULL, &iosb); > - todo_wine { > ok(res == STATUS_SUCCESS, "Failed to cancel I/O\n"); > ok(U(iosb).Status == STATUS_SUCCESS, "iosb.Status got changed to %lx\n", U(iosb).Status); > ok(U(iosb).Information == 0, "iosb.Information got changed to %Iu\n", U(iosb).Information); > - CloseHandle(ctx.pipe); > WaitForSingleObject(thread, INFINITE); > CloseHandle(thread); > + CloseHandle(ctx.pipe); Any reason why the call to `CloseHandle` is being moved? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/47#note_3837

1 0

[PATCH 0/3] MR414: fltmgr.sys: Implement FltBuildDefaultSecurityDescriptor
by Alistair Leslie-Hughes (＠alesliehughes) July 10, 2022

July 10, 2022

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/414

2 3

Re: [PATCH v2 0/4] MR47: kernel32/tests: Add tests for CancelSynchronousIo.
by Daniel Lehman (＠dlehman25) July 10, 2022

July 10, 2022

@julliard does this look ok? there anything i should change? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/47#note_3831

1 0

[PATCH 0/4] MR413: ntoskrnl: Enumerate child devices on a separate thread.
by Zebediah Figura (＠zfigura) July 9, 2022

July 9, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/413

2 4

[PATCH 0/1] MR412: wineusb.sys: Fix memory leak on control transfer.
by Jinoh Kang (＠iamahuman) July 9, 2022

July 9, 2022

Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/412

3 5

[PATCH v8 0/1] MR320: riched20/tests: Test for ITextDocument::Undo and ITextDocument::Redo (#53289).
by Jinoh Kang (＠iamahuman) July 9, 2022

July 9, 2022

Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> -- v8: riched20/tests: Test for ITextDocument::Undo and ITextDocument::Redo. https://gitlab.winehq.org/wine/wine/-/merge_requests/320

2 2

[PATCH v2 0/1] MR408: ntdll: Fix x64 single step exception detection on macOS.
by Piotr Caban (＠piotr) July 9, 2022

July 9, 2022

On macOS si_code is always set to TRAP_BRKPT. -- v2: ntdll: Fix x64 single step exception detection on macOS. https://gitlab.winehq.org/wine/wine/-/merge_requests/408

3 2

[PATCH 0/1] MR408: ntdll: Fix x64 single step exception detection on macOS.
by Piotr Caban (＠piotr) July 9, 2022

July 9, 2022

On macOS si_code is always set to TRAP_BRKPT. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/408

3 3

Re: [PATCH 0/4] MR384: winsock: Support fallback to ICMP over SOCK_DGRAM on Linux
by Paul Gofman (＠gofman) July 9, 2022

July 9, 2022

Thanks for all the detailed comments. But I suppose before going into these details and improving the neats it would be great to hear from Zebediah or Alexandre if this MR is a go in principle. As it is not apparent to me from the initial Zeb's comment. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/384#note_3817

1 0

Re: [PATCH 0/4] MR384: winsock: Support fallback to ICMP over SOCK_DGRAM on Linux
by Jinoh Kang (＠iamahuman) July 9, 2022

July 9, 2022

Jinoh Kang (@iamahuman) commented about server/protocol.def: > - int force_async; /* Force asynchronous mode? */ > + async_data_t async; /* async I/O parameters */ > + int force_async; /* Force asynchronous mode? */ > @REPLY > obj_handle_t wait; /* handle to wait on for blocking send */ > unsigned int options; /* device open options */ > int nonblocking; /* is socket non-blocking? */ > + int fixup_type; /* socket protocol fixup */ > +(a)END > + > + > +/* Store info needed for protocol fixup */ > +(a)REQ(socket_fixup_send_data) > + obj_handle_t handle; /* socket handle */ > + unsigned short icmp_id; /* ICMP packet id */ > + unsigned short icmp_seq; /* ICMP packed sequence */ Instead of re-aligning tabbing of `@REQ(send_socket)`, maybe we can also use `int` or `short` here. Although `unsigned short` makes more sense if we're going to restrict the scope of the two new server calls only to ICMP packets. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/384#note_3814

1 0

Re: [PATCH 0/4] MR384: winsock: Support fallback to ICMP over SOCK_DGRAM on Linux
by Jinoh Kang (＠iamahuman) July 9, 2022

July 9, 2022

Jinoh Kang (@iamahuman) commented about dlls/ntdll/unix/socket.c: > wait_handle = wine_server_ptr_handle( reply->wait ); > options = reply->options; > nonblocking = reply->nonblocking; > + fixup_type = reply->fixup_type; > } > SERVER_END_REQ; > > + if (fixup_type == SOCK_PROT_FIXUP_ICMP_OVER_DGRAM && async->count > + && (!status || status == STATUS_ALERTED || status == STATUS_PENDING)) We can just write `!NT_ERROR(status)`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/384#note_3813

1 0

Re: [PATCH 0/4] MR384: winsock: Support fallback to ICMP over SOCK_DGRAM on Linux
by Jinoh Kang (＠iamahuman) July 9, 2022

July 9, 2022

Jinoh Kang (@iamahuman) commented about server/sock.c: > struct fd *fd; > > if (!sock) return; > + > + if (sock->fixup_type != req->fixup_type) > + { > + /* Protocol fixup information should be reflected in client's async data before the > + * async is delivered to process. So let the client set up the info and restart the > + * call. */ > + reply->fixup_type = sock->fixup_type; > + set_error( STATUS_MORE_PROCESSING_REQUIRED ); > + release_object( sock ); > + return; > + } > + We can save the `fixup_type` round trip in the optimal case by returning `STATUS_MORE_PROCESSING_REQUIRED` _only_ when the async would otherwise enter the pending state (i.e. final `status` is `STATUS_PENDING`), and setting `reply->fixup_type` in all cases (specifically, `status == STATUS_ALERTED`). Not sure if this improvement would be worth it, though, especially since 1) it doesn't eliminate `STATUS_MORE_PROCESSING_REQUIRED` (the raison d'��tre of which being that can't pass extra info via `APC_ASYNC_IO`, and we can't normally synchronize with the APC either, since it's asynchronous by nature) completely, and thus doesn't help simplify the patch, 2) not many tools rely on ICMP packet performace (save for a few network testing tools), and 3) server calls make us lose in the first place. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/384#note_3812

1 0

Re: [PATCH 0/4] MR384: winsock: Support fallback to ICMP over SOCK_DGRAM on Linux
by Jinoh Kang (＠iamahuman) July 9, 2022

July 9, 2022

Jinoh Kang (@iamahuman) commented about dlls/ws2_32/socket.c: > } > > > -static BOOL protocol_matches_filter( const int *filter, int protocol ) > +static BOOL protocol_matches_filter( const int *filter, unsigned int index ) Would it be more clear to accept `const WSAPROTOCOL_INFOW *` instead of an index into the `supported_protocols` array? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/384#note_3811

1 0

Re: [PATCH 0/4] MR384: winsock: Support fallback to ICMP over SOCK_DGRAM on Linux
by Jinoh Kang (＠iamahuman) July 9, 2022

July 9, 2022

Jinoh Kang (@iamahuman) commented about dlls/ws2_32/tests/sock.c: > + sum += s; > + carry = s > sum; > + count -= 2; > + } > + sum += carry; /* This won't produce another carry */ > + sum = (sum & 0xffff) + (sum >> 16); > + > + if (count) sum += *data; /* LE-only */ > + > + sum = (sum & 0xffff) + (sum >> 16); > + /* fold in any carry */ > + sum = (sum & 0xffff) + (sum >> 16); > + > + check = ~sum; > + return check; > +} It's much simpler to implement 1's complement checksum without the use of an explicit `carry` variable. How about the following: ```suggestion:-25+0 static UINT16 chksum(BYTE *data, unsigned int count) { UINT16 *ptr = (UINT16 *)data, *end = ptr + count / 2; unsigned int sum = 0; while (ptr != end) { sum += *ptr++; sum = (sum & 0xffff) + (sum >> 16); } if (count % 2) { sum += *(BYTE *)ptr; /* LE-only */ sum = (sum & 0xffff) + (sum >> 16); } return ~sum; } ``` Note that `sum` is in range `[0, 0xfffe]` at the start of each iteration. After addition, the range extends to `[0, 0x1fffd]`; however, since `0xfffd + 0x1 = 0xfffe`, the range folds back to `[0, 0xfffe]`. Ditto for tests in ntdll. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/384#note_3810

1 0

Re: [PATCH v3 0/3] MR405: winegstreamer: More wg_transform fixes for CoD: BO3, Mortal Kombat 11 and Shadow Warrior 2. - approved
by Alexandre Julliard (＠julliard) July 8, 2022

July 8, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/405

1 0

Re: [PATCH v5 0/4] MR375: ntdll: Fixes for runtime 64-bit shift functions. - approved
by Alexandre Julliard (＠julliard) July 8, 2022

July 8, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/375

1 0

Re: [PATCH v2 0/1] MR404: mscms: Merge the profile and transform handle tables. - approved
by Alexandre Julliard (＠julliard) July 8, 2022

July 8, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/404

1 0

Re: [PATCH v2 0/2] MR403: ddraw/tests: Build without -DWINE_NO_LONG_TYPES. - approved
by Alexandre Julliard (＠julliard) July 8, 2022

July 8, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/403

1 0

Re: [PATCH v2 0/2] MR402: http.sys: Add support for relative URLs. - approved
by Alexandre Julliard (＠julliard) July 8, 2022

July 8, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/402

1 0

[PATCH v2 0/3] MR405: winegstreamer: More wg_transform fixes for CoD: BO3, Mortal Kombat 11 and Shadow Warrior.
by Rémi Bernon July 8, 2022

July 8, 2022

-- v2: winegstreamer: Check H264 ProcessOutput sample against actual image size. winegstreamer: Use H264 input media type frame size when specified. winegstreamer: Implement H264 SetOutputType by reconfiguring the pipeline. https://gitlab.winehq.org/wine/wine/-/merge_requests/405

2 5

[PATCH 0/1] MR409: crypt32: Recognize 'Microsoft Root Certificate Authority 2011' when verifying...
by Paul Gofman (＠gofman) July 8, 2022

July 8, 2022

crypt32: Recognize 'Microsoft Root Certificate Authority 2011' when verifying the Microsoft root policy. Signed-off-by: Paul Gofman <pgofman(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/409

2 1

[PATCH v5 0/7] MR391: scrrun: Implement MoveFolder().
by Robert Wilhelm (＠sloper42) July 8, 2022

July 8, 2022

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52128 Signed-off-by: Robert Wilhelm <robert.wilhelm(a)gmx.net> -- v5: scrrun: Support wildcards in MoveFolder(). scrrun: Move source dir into destination dir if destination ends with separator in MoveFolder(). scrrun: Check that source is directory in MoveFolder. https://gitlab.winehq.org/wine/wine/-/merge_requests/391

3 9

[PATCH 0/3] MR405: winegstreamer: More wg_transform fixes for CoD: BO3, Mortal Kombat 11 and Shadow Warrior.
by Rémi Bernon July 8, 2022

July 8, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/405

1 4

[PATCH 0/3] MR406: win32u: Introduce new add_modes device manager callback.
by Rémi Bernon July 8, 2022

July 8, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/406

2 5

[PATCH 0/1] MR404: mscms: Merge the profile and transform handle tables.
by Hans Leidekker (＠hans) July 8, 2022

July 8, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/404

2 1

Re: [PATCH 0/4] MR388: d2d1: Introduce D2DERR_NOT_FOUND.
by Nikolay Sivov (＠nsivov) July 8, 2022

July 8, 2022

On Fri Jul 8 04:21:30 2022 +0000, Ziqing Hui wrote: > I didn't checkout the SDK header files though. If it's not in SDK, we shouldn't have it in public headers either. There is an equivalent E_NOT_SET macro that you can use, and if D2DERR one appears in SDK at some point we'll switch to it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/388#note_3597

1 0

Re: [PATCH 0/4] MR388: d2d1: Introduce D2DERR_NOT_FOUND.
by Nikolay Sivov (＠nsivov) July 8, 2022

July 8, 2022

Nikolay Sivov (@nsivov) commented about dlls/d2d1/d2d1_private.h: > void d2d_factory_register_effect(struct d2d_factory *factory, > struct d2d_effect_registration *effect) DECLSPEC_HIDDEN; > > +struct d2d_offset_transform > +{ > + ID2D1OffsetTransform ID2D1OffsetTransform_iface; > + LONG refcount; > + D2D1_POINT_2L offset; > +}; > + Do we need a separate structure for each type of node? Maybe we could have a structure similar to d2d_brush. My understanding is it's not possible to have user-defined node types. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/388#note_3596

1 0

[PATCH 0/2] MR403: ddraw/tests: Build without -DWINE_NO_LONG_TYPES.
by Zebediah Figura (＠zfigura) July 8, 2022

July 8, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/403

2 2

[PATCH 0/2] MR402: http.sys: Add support for relative URLs.
by Julian Klemann (＠jklemann) July 8, 2022

July 8, 2022

The queue with the most specific path should be the one to receive the request. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/402

3 3

Re: [PATCH 0/4] MR388: d2d1: Introduce D2DERR_NOT_FOUND.
by Ziqing Hui (＠zhui) July 8, 2022

July 8, 2022

On Fri Jul 8 04:20:45 2022 +0000, Ziqing Hui wrote: > MS doc: https://docs.microsoft.com/en-us/windows/win32/api/d2d1effectauthor/nf-d2d1… > "Return value" part says: > | D2DERR_NOT_FOUND = (HRESULT_FROM_WIN32(ERROR_NOT_FOUND)) | Direct2D > could not locate the specified node. I didn't checkout the SDK header files thought. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/388#note_3592

1 0

Re: [PATCH 0/4] MR388: d2d1: Introduce D2DERR_NOT_FOUND.
by Ziqing Hui (＠zhui) July 8, 2022

July 8, 2022

On Thu Jul 7 06:56:42 2022 +0000, Nikolay Sivov wrote: > I don't see in 10.0.2200.0 SDK. Where does it come from? MS doc: https://docs.microsoft.com/en-us/windows/win32/api/d2d1effectauthor/nf-d2d1… "Return value" part says: | D2DERR_NOT_FOUND = (HRESULT_FROM_WIN32(ERROR_NOT_FOUND)) | Direct2D could not locate the specified node. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/388#note_3591

1 0

[PATCH v4 0/4] MR375: ntdll: Fixes for runtime 64-bit shift functions.
by Zebediah Figura (＠zfigura) July 8, 2022

July 8, 2022

Based on <https://source.winehq.org/patches/data/238821> by Zhao Yi. -- v4: ntdll: Correctly handle shift greater than the type width in 64-bit shift functions. ntdll: Avoid depending on compiler support for 64-bit shift functions. ntdll/tests: Add tests for runtime 64-bit shift functions. ntdll: Fix the calling convention for runtime 64-bit shift functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/375

2 4

Re: [PATCH v2 0/1] MR401: wbemprox: Provide more accurate system information - approved
by Alexandre Julliard (＠julliard) July 7, 2022

July 7, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/401

1 0

Re: [PATCH v2 0/1] MR397: regedit: Replace heap_x*() functions with malloc(), realloc() and free() - approved
by Alexandre Julliard (＠julliard) July 7, 2022

July 7, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/397

1 0

Re: [PATCH v2 0/1] MR381: mciqtz32: Fix thread handle leak if a second play. - approved
by Alexandre Julliard (＠julliard) July 7, 2022

July 7, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/381

1 0

Re: [PATCH v3 0/2] MR394: d3d8/tests: Build without -DWINE_NO_LONG_TYPES. - approved
by Alexandre Julliard (＠julliard) July 7, 2022

July 7, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/394

1 0

[PATCH v3 0/4] MR358: atl: Avoid NULL pointer reference in AtlComModuleGetClassObject().
by Zhiyi Zhang (＠zhiyi) July 7, 2022

July 7, 2022

Fix crash in CAXA CAD when clicking component library. Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com> -- v3: atl: Avoid NULL pointer reference in AtlComModuleRevokeClassObjects(). atl: Avoid NULL pointer reference in AtlComModuleRegisterClassObjects(). atl: Avoid NULL pointer reference in AtlComModuleGetClassObject(). atl110: Add importlib. https://gitlab.winehq.org/wine/wine/-/merge_requests/358

3 5

Re: [PATCH v2 0/2] MR382: widl: Fix missing support for struct / union parameterized type replacement. - approved
by Alexandre Julliard (＠julliard) July 7, 2022

July 7, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/382

1 0

Re: [PATCH v2 0/1] MR379: wined3d: Don't transition GENERAL layouts for blits. - approved
by Alexandre Julliard (＠julliard) July 7, 2022

July 7, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/379

1 0

Re: [PATCH v2 0/2] MR396: dinput/tests: Fix reported test failures. - approved
by Alexandre Julliard (＠julliard) July 7, 2022

July 7, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/396

1 0

Re: [PATCH v3 0/4] MR395: win32u: Move reading and writing mode from registry out of graphics drivers. - approved
by Alexandre Julliard (＠julliard) July 7, 2022

July 7, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/395

1 0

[PATCH v7 0/3] MR302: winegstreamer: Some wg_transform H264 fixes for Mortal Kombat 11 and Yakuza 4.
by Rémi Bernon July 7, 2022

July 7, 2022

-- v7: winegstreamer: Use an atomic queue for wg_transform input buffers. winegstreamer: Release requested samples if they are too small. mf/tests: Add todo_wine for newer FFmpeg versions. https://gitlab.winehq.org/wine/wine/-/merge_requests/302

2 4

[PATCH v4 0/7] MR391: scrrun: Implement MoveFolder().
by Robert Wilhelm (＠sloper42) July 7, 2022

July 7, 2022

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52128 Signed-off-by: Robert Wilhelm <robert.wilhelm(a)gmx.net> -- v4: scrrun: Support wildcards in MoveFolder(). scrrun: Move source dir into destination dir if destination ends with separator in MoveFolder(). scrrun: Check that source is directory in MoveFolder. scrrun: Check for non-existant source in MoveFolder. scrrun: Test MoveFolder with already existing destination. scrrun: Check for null and empty arguments in MoveFolder. scrrun: Implement MoveFolder(). https://gitlab.winehq.org/wine/wine/-/merge_requests/391

2 8

[PATCH 0/1] MR401: wbemprox: Provide more accurate system information
by SmallJoker (＠SmallJoker) July 7, 2022

July 7, 2022

This re-uses existing functions from Win32_ComputerSystemProduct to provide more accurate values, which are helpful to system overview applications. How to test: `wmic.exe computersystem GET Manufacturer` Previously discussed with davidebeatrici, 2022-07-02 in #winehackers. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/401

3 2

Re: [PATCH 0/1] MR381: mciqtz32: Fix thread handle leak if a second play. - approved
by Zebediah Figura (＠zfigura) July 7, 2022

July 7, 2022

This merge request was approved by Zebediah Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/381

1 0

[wine-gitlab] [PATCH v3 0/7] MR391: scrrun: Implement MoveFolder().
by Robert Wilhelm (＠sloper42) July 7, 2022

July 7, 2022

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52128 Signed-off-by: Robert Wilhelm <robert.wilhelm(a)gmx.net> -- v3: scrrun: Support wildcards in MoveFolder(). scrrun: Move source dir into destination dir if destination ends with separator in MoveFolder(). https://gitlab.winehq.org/wine/wine/-/merge_requests/391

3 12

[PATCH v2 0/1] MR398: xactengine3_7/tests: Test notifications when loading a wave bank.
by Giovanni Mascellani (＠giomasce) July 7, 2022

July 7, 2022

"The King of Fighters '98 Ultimate Match Final Edition" depends on this behavior. At least, the build I have is; it seems other builds are not. Signed-off-by: Giovanni Mascellani <gmascellani(a)codeweavers.com> -- v2: xactengine3_7/tests: Test notifications when loading a wave bank. https://gitlab.winehq.org/wine/wine/-/merge_requests/398

2 1

Re: [PATCH v2 0/4] MR358: atl: Avoid NULL pointer reference in AtlComModuleGetClassObject(). - approved
by Jacek Caban (＠jacek) July 7, 2022

July 7, 2022

This merge request was approved by Jacek Caban. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/358

1 0