July 2022 - Wine-GitLab - list.winehq.org

[PATCH v2 0/1] MR425: ntdll: Do not use find_subheap() to find the subheap corresponding to an uncommitted region.
by Zebediah Figura (＠zfigura) July 25, 2022

July 25, 2022

The commit end of a subheap may be equal to the beginning of another subheap, in which case find_subheap() will return that one, and we may effectively skip backwards in the subheap list. --- There may be a more architecturally palatable way to solve this problem, but hopefully this is enough to at least demonstrate it. -- v2: ntdll: Do not use find_subheap() to find the subheap corresponding to an uncommitted region. https://gitlab.winehq.org/wine/wine/-/merge_requests/425

3 3

Re: [PATCH v2 0/1] MR518: d3drm: Fix components of palette when loading texture from 8-bit BMP file. - approved
by Alexandre Julliard (＠julliard) July 25, 2022

July 25, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/518

1 0

Re: [PATCH v2 0/3] MR524: dwrite: Add a few more fallback ranges. - approved
by Alexandre Julliard (＠julliard) July 25, 2022

July 25, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/524

1 0

Re: [PATCH v4 0/7] MR507: dinput: Properly expose dials. - approved
by Alexandre Julliard (＠julliard) July 25, 2022

July 25, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/507

1 0

Re: [PATCH v2 0/3] MR522: regedit: Further clean-ups for modifying registry value data - approved
by Alexandre Julliard (＠julliard) July 25, 2022

July 25, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/522

1 0

Re: [PATCH v3 0/2] MR500: ntdll: Allow changes to DEP flags under Wow64. - approved
by Alexandre Julliard (＠julliard) July 25, 2022

July 25, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/500

1 0

Re: [PATCH v3 0/1] MR427: ntdll: Preserve rbx register when calling DLL entry point on x64. - approved
by Alexandre Julliard (＠julliard) July 25, 2022

July 25, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/427

1 0

Re: [PATCH v2 0/1] MR328: wow64: Respect the large address aware flag. - approved
by Alexandre Julliard (＠julliard) July 25, 2022

July 25, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/328

1 0

Re: [PATCH v2 0/1] MR517: xactengine3_7: Remove Entry after FAudio Destroyed call - approved
by Alexandre Julliard (＠julliard) July 25, 2022

July 25, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/517

1 0

Re: [PATCH v12 0/5] MR432: Add support for SPDRP_BASE_CONTAINERID by querying drivers with BusQueryContainerID - approved
by Alexandre Julliard (＠julliard) July 25, 2022

July 25, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/432

1 0

Re: [PATCH v2 0/2] MR494: Let programs/winedbg use CRT allocation functions - approved
by Alexandre Julliard (＠julliard) July 25, 2022

July 25, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/494

1 0

Re: [PATCH v2 0/3] MR510: uiautomationcore: Add support for more UI Automation property types. - approved
by Alexandre Julliard (＠julliard) July 25, 2022

July 25, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/510

1 0

Re: [PATCH v2 0/7] MR519: win32u: syscall conversion - approved
by Alexandre Julliard (＠julliard) July 25, 2022

July 25, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/519

1 0

Re: [PATCH v2 0/3] MR484: Misc tweaks for the tests - approved
by Alexandre Julliard (＠julliard) July 25, 2022

July 25, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/484

1 0

Re: [PATCH v2 0/4] MR503: server: Properly implement AFD_POLL_RESET. - approved
by Alexandre Julliard (＠julliard) July 25, 2022

July 25, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/503

1 0

[PATCH 0/3] MR523: ntdll: Fixup the RtlWalkHeap entry pointer before subheap lookup.
by Rémi Bernon July 25, 2022

July 25, 2022

This should do the same thing as https://gitlab.winehq.org/wine/wine/-/merge_requests/425. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/523

2 4

Re: [PATCH v2 0/1] MR1: vkd3d-shader: Initialize counter_var_info unconditionally. - approved
by Alexandre Julliard (＠julliard) July 25, 2022

July 25, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/1

1 0

[PATCH 0/1] MR518: d3drm: Fix components of palette when loading texture from 8-bit BMP file.
by Jeffrey Smith (＠whydoubt) July 25, 2022

July 25, 2022

Previous fix took care of palette created from 24bpp BMP. I found that loading the palette from a 8bpp BMP also needed fixed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/518

3 2

[PATCH 0/1] MR517: xactengine3_7: Remove Entry after FAudio Destroyed call
by Alistair Leslie-Hughes (＠alesliehughes) July 25, 2022

July 25, 2022

FACTWaveBank_Destroy will invoke the callback which we attempt to lookup the wavebank. The callback must have a pointer, help states it isn't valid but still points to the wavebank that was destroyed. Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/517

3 2

[PATCH 0/3] MR524: dwrite: Add a few more fallback ranges.
by Nikolay Sivov (＠nsivov) July 25, 2022

July 25, 2022

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/524

2 4

[PATCH v2 0/10] MR487: mshtml events improvements
by Gabriel Ivăncescu July 25, 2022

July 25, 2022

Some notes for the loaded/total props for ProgressEvent: they are todo_wine for loadend initially because wine-gecko is never informed of OnProgress, but the last commit fixes this. It's placed last so that its effects can be shown. Also, if it wasn't deferred until OnDataAvailable, it would assume it's for uploading state, because it's OnStartRequest on gecko's XHR that changes the state... -- v2: mshtml: Inform Gecko of progress done via OnProgress. mshtml: Implement ProgressEvent's total prop. mshtml: Implement ProgressEvent's loaded prop. mshtml: Implement ProgressEvent's lengthComputable prop. mshtml: Fix copy-paste mistake in test message. mshtml: Remove FIXME comment from MessageEvent in event_types. mshtml: Allocate Keyboard events via the types table. mshtml: Allocate Mouse events via the types table. mshtml: Allocate UI events via the types table. mshtml: Use a table to construct the different event types by their interface. https://gitlab.winehq.org/wine/wine/-/merge_requests/487

2 15

[PATCH v3 0/7] MR507: dinput: Properly expose dials.
by Arek Hiler (＠ivyl) July 25, 2022

July 25, 2022

Throttle that comes with Thrustmaster T16000M FCS has a dial that doesn't work / is usassignable in many games (e.g. Elite Dangerous). Returning correct GUID and name would be enough but it breaks the tests due to some quirks of the default format so that is also fixed. -- v3: dinput/tests: Test GetObjectInfo() with three sliders and a proper format. https://gitlab.winehq.org/wine/wine/-/merge_requests/507

3 8

[PATCH v3 0/1] MR477: d3drm/tests: Show Clear sets background color
by Alistair Leslie-Hughes (＠alesliehughes) July 25, 2022

July 25, 2022

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> -- v3: d3drm/tests: Show Clear sets background color https://gitlab.winehq.org/wine/wine/-/merge_requests/477

4 3

[PATCH v2 0/7] MR507: dinput: Properly expose dials.
by Arek Hiler (＠ivyl) July 25, 2022

July 25, 2022

Throttle that comes with Thrustmaster T16000M FCS has a dial that doesn't work / is usassignable in many games (e.g. Elite Dangerous). Returning correct GUID and name would be enough but it breaks the tests due to some quirks of the default format so that is also fixed. -- v2: dinput/tests: Test GetObjectInfo() with three sliders and a proper format. dinput/tests: Assert that we can't get info about the third slider with c_dfDIJoystick2. dinput: Use GUID_Slider type for dials. dinput: Enumerate user format object forwards. dinput/tests: Use helper for checking device object instances. dinput: Get rid of unused parameter in match_device_object. dinput: Set correct object names for dials and sliders. https://gitlab.winehq.org/wine/wine/-/merge_requests/507

3 9

[PATCH v4 0/2] MR289: d3drm: Implement IDirect3DRMFrame2::SetSceneBackgroundImage
by Alistair Leslie-Hughes (＠alesliehughes) July 25, 2022

July 25, 2022

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> -- v4: d3drm: Implement IDirect3DRMViewport Render d3drm: Implement IDirect3DRMFrame{1/2/3}::SetSceneBackgroundImage https://gitlab.winehq.org/wine/wine/-/merge_requests/289

3 5

[PATCH 0/3] MR522: regedit: Further clean-ups for modifying registry value data
by Hugh McMaster (＠hmc) July 25, 2022

July 25, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/522

2 3

[PATCH 0/8] MR507: dinput: Properly expose dials.
by Arek Hiler (＠ivyl) July 25, 2022

July 25, 2022

Throttle that comes with Thrustmaster T16000M FCS has a dial that doesn't work / is usassignable in many games (e.g. Elite Dangerous). Returning correct GUID and name would be enough but it breaks the tests due to some quirks of the default format so that is also fixed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/507

3 14

[PATCH 0/1] MR1: vkd3d-shader: Initialize counter_var_info unconditionally.
by Stefan Dösinger July 25, 2022

July 25, 2022

--- It is only set if certain shader properties are met, and Visual Studio rightfully complains that we read an uninitialized variable later. Maybe resource_symbol.info.resource.uav_counter_array is never used later on, but it still is bad style to propagate uninitialized values. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/1

2 2

[PATCH v11 0/5] MR432: Add support for SPDRP_BASE_CONTAINERID by querying drivers with BusQueryContainerID
by Claire (＠ClearlyClaire) July 25, 2022

July 25, 2022

This is the hidclass/ntoskrnl/setupapi counterpart to !359. As with that merge request, implementing `BusQueryContainerID` in the bus driver is left out and will be addressed in a different MR. I believe this is useful to expose the Container ID no matter how those end up being assigned by the bus driver. -- v11: ntoskrnl: Set device ContainerID from driver. hidclass: Expose ContainerID from underlying driver. hidclass: Improve error handling in get_device_id. ntoskrnl/tests: Add test for getting SPDRP_BASE_CONTAINERID from PnP driver. setupapi: Add support for SPDRP_BASE_CONTAINERID. https://gitlab.winehq.org/wine/wine/-/merge_requests/432

3 6

[PATCH 0/2] MR485: riched20: Ensure that cursor is visible when selecting text.
by Santino Mazza (＠tati1454) July 25, 2022

July 25, 2022

This mr fixes https://bugs.winehq.org/show_bug.cgi?id=40444 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/485

3 3

[PATCH 0/2] MR494: Let programs/winedbg use CRT allocation functions
by eric pouech (＠epo) July 25, 2022

July 25, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/494

3 4

[PATCH 0/3] MR510: uiautomationcore: Add support for more UI Automation property types.
by Connor McAdams (＠cmcadams) July 25, 2022

July 25, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/510

3 4

[PATCH 0/7] MR519: win32u: syscall conversion
by Jacek Caban (＠jacek) July 25, 2022

July 25, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/519

3 8

[PATCH v10 0/7] MR432: Add support for SPDRP_BASE_CONTAINERID by querying drivers with BusQueryContainerID
by Claire (＠ClearlyClaire) July 25, 2022

July 25, 2022

This is the hidclass/ntoskrnl/setupapi counterpart to !359. As with that merge request, implementing `BusQueryContainerID` in the bus driver is left out and will be addressed in a different MR. I believe this is useful to expose the Container ID no matter how those end up being assigned by the bus driver. -- v10: ntoskrnl: Set device ContainerID from driver hidclass: Expose ContainerID hidclass: Copy device ContainerID to child devices hidclass: Copy ContainerID from underlying driver in driver_add_device hidclass: Improve error handling in get_device_id ntoskrnl/tests: Add test for getting SPDRP_BASE_CONTAINERID from PnP driver setupapi: Add support for SPDRP_BASE_CONTAINERID https://gitlab.winehq.org/wine/wine/-/merge_requests/432

4 12

[PATCH 0/3] MR484: Misc tweaks for the tests
by Francois Gouget (＠fgouget) July 25, 2022

July 25, 2022

Signed-off-by: Francois Gouget <fgouget(a)free.fr> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/484

3 4

[PATCH 0/5] MR520: include: Allow printing test failure messages in color.
by Zebediah Figura (＠zfigura) July 25, 2022

July 25, 2022

Gated behind a boolean environment variable WINETEST_COLOR for the moment (default off). I've experimented with this locally for a while, and I've found it helps me immensely when looking for a specific kind of message. Too often failure or succeeded-inside-todo messages get buried among todo messages, WINEDEBUG output, or (in the case of some badly written test units) trace() output, but this has also helped me check whether there are any todo and skip messages, in cases where I want to make sure that one or the other doesn't show up. I'm quite open to bikeshedding :-) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/520

3 5

[PATCH v2 0/2] MR500: ntdll: Allow changes to DEP flags under Wow64.
by Brendan Shanks (＠bshanks) July 24, 2022

July 24, 2022

Under Wow64, disabling no-exec (done at the bottom of `alloc_module`) was failing. Fixes crashes in games using older Steam DRM (where the EXE entry point is in a '.bind' section which is not marked executable) -- v2: wow64: Allow setting NtSetInformationProcess(ProcessExecuteFlags). ntdll: Allow changes to DEP flags under Wow64. https://gitlab.winehq.org/wine/wine/-/merge_requests/500

2 2

Re: [PATCH v4 0/1] MR105: winegstreamer: reintroduce flushing for wg_parser - closed
by Alexandre Julliard (＠julliard) July 23, 2022

July 23, 2022

This merge request was closed by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/105

1 0

Re: [PATCH v4 0/1] MR105: winegstreamer: reintroduce flushing for wg_parser
by Alexandre Julliard (＠julliard) July 23, 2022

July 23, 2022

I'd suggest filing a bug for this, if there isn't one already. A merge request is not the right place for that kind of information. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/105#note_4805

1 0

Re: [PATCH v4 0/1] MR105: winegstreamer: reintroduce flushing for wg_parser
by zlice (＠zlice) July 23, 2022

July 23, 2022

Just an update, 7.13 compile times almost halved, awesome! But audio studder is worse, sat for almost a minute loading a save file. Patching with this makes everything smooth again. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/105#note_4804

1 0

[PATCH 0/1] MR515: webservices: Handle in/out parameters properly in WsCall.
by Shaun Ren (＠shaunren) July 23, 2022

July 23, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/515

2 1

Re: [PATCH v2 0/1] MR514: user32: Remove some dead code from unpack_dde_message() (Coverity). - approved
by Alexandre Julliard (＠julliard) July 22, 2022

July 22, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/514

1 0

Re: [PATCH v2 0/1] MR513: win32u: Remove some dead code from get_scroll_range() helper (Coverity). - approved
by Alexandre Julliard (＠julliard) July 22, 2022

July 22, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/513

1 0

Re: [PATCH v2 0/1] MR512: d2d1/tests: Add a missing return value test (Coverity). - approved
by Alexandre Julliard (＠julliard) July 22, 2022

July 22, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/512

1 0

Re: [PATCH v2 0/1] MR501: wined3d: Redirect vkd3d log output to the Unix stderr. - approved
by Alexandre Julliard (＠julliard) July 22, 2022

July 22, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/501

1 0

Re: [PATCH v3 0/3] MR495: wined3d: Do not try to unmap already unmapped BOs. - approved
by Alexandre Julliard (＠julliard) July 22, 2022

July 22, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/495

1 0

Re: [PATCH v2 0/1] MR506: d3d11: Use CRT allocation functions. - approved
by Alexandre Julliard (＠julliard) July 22, 2022

July 22, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/506

1 0

Re: [PATCH v2 0/10] MR505: dwrite: Improvements to font fallback implementation. - approved
by Alexandre Julliard (＠julliard) July 22, 2022

July 22, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/505

1 0

Re: [PATCH v2 0/9] MR508: win32u: syscall conversion - approved
by Alexandre Julliard (＠julliard) July 22, 2022

July 22, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/508

1 0

[PATCH v6 0/5] MR464: Implement _StructuredTaskCollection::_Schedule{,_loc}
by Torge Matthies (＠tmatthies) July 22, 2022

July 22, 2022

- Based on !463 - _RunAndWait and exception handling implemented in later commits @piotr -- v6: msvcr100: Implement _StructuredTaskCollection::_Schedule and _Schedule_loc. msvcr100: Factor out the mapping of a context to a scheduler. msvcr100: Cache one Context instance. msvcr100: Factor out EXCEPTION_RECORD to exception_ptr conversion. msvcr100: Move exception_ptr functions to a separate file. https://gitlab.winehq.org/wine/wine/-/merge_requests/464

3 14