August 2022 - Wine-GitLab - list.winehq.org

[PATCH v7 0/4] MR359: mmdevapi: copy ContainerID property from audio driver if available
by Claire (＠ClearlyClaire) Feb. 3, 2026

Feb. 3, 2026

Some games with support for the haptic feedback and speaker features of the Sony DualSense controller select the controller's audio output by filtering on the ContainerId IMMDevice property to find one that matches the controller's HID's. This MR allows this information to be accessible from the IMMDevice's property store when the audio driver provides it (none for now, but I intend to add that feature to `winepulse.drv` and maybe `winealsa.drv`) This is made specific to containerId rather than supporting VT_CLSID on every property because Wine currently stores VT_BLOBs directly in the registry value, which does not allow us to safely disambiguate between VT_CLSID and VT_BLOB values when reading from registry. -- v7: mmdevapi: Invalidate ContainerID of unavailable audio devices. https://gitlab.winehq.org/wine/wine/-/merge_requests/359

7 12

[PATCH v2 0/2] MR475: server: Fix object name resolution of \Device\Null.
by Jinoh Kang (＠iamahuman) Dec. 5, 2024

Dec. 5, 2024

This simplifies future tests that check for object name of devices. -- v2: server: Fix object name resolution of \Device\Null. server: Make explicit the ownership of the unix_name buffer. https://gitlab.winehq.org/wine/wine/-/merge_requests/475

3 4

[PATCH 0/2] MR482: advapi32/tests: Test kernel object security with the primary token as well.
by Jinoh Kang (＠iamahuman) Nov. 9, 2024

Nov. 9, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/482

2 3

[PATCH 0/1] MR474: server: Default the token owner to the token user.
by Jinoh Kang (＠iamahuman) Nov. 9, 2024

Nov. 9, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/474

2 3

[PATCH 0/1] MR667: win32u: Ignore SetWindowPos() if it is trying to change topmost state for child window.
by Paul Gofman (＠gofman) March 3, 2024

March 3, 2024

I think the behaviour of SetWindowPos() in this case is partially explained by the fact that topmost state is not strictly applicable to child windows and so Windows denies such requests. Child window can still end up with WS_EX_TOPMOST style if it was set at window creation (doesn't work this way in Wine now) or, e. g., like in the test added in the patch. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=20190 Also fixes game load dialog in Indiana Jones and the Infernal Machine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/667

6 6

[PATCH 0/1] MR411: win32u: Don't load bitmap only TTF fonts without bitmap table.
by Paul Gofman (＠gofman) Dec. 4, 2023

Dec. 4, 2023

The offending font is NotoColorEmoji.ttf which is present in, e. g., google-noto-emoji-color-fonts or noto-fonts-emoji packages available in various distribution. Attempting to load this font on Windows 10 (with AddFontResourceA() or open it with default font viewer) fails while currently succeeds on Windows. fontforge also refuses to open this font. That is because the font is bitmap only but missing bitmap table. Some apps (Glyph launcher is an example) try to GetOutlineTextMetrics() on this font and do not expect that to have an error return (as we currenly do), which leads to crash on unhandled division by zero exception. I am attaching a bitmap-only ttf test font (with only one bitmap) which I created with fontforge to make sure that such font can still be loaded in Wine. This font also loads on Windows (both with AddFontResourceA() and with default font viewer). There are other font types which can be legitimately missing EBDT table, but FT_Load_Sfnt_Table() returns a different error for those and my patch doesn't reject those fonts. [test.ttf](/uploads/b41472180b80c2c53f9dcc06055990f0/test.ttf) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/411

5 12

[PATCH 0/2] MR535: Draft: winebus: implement BusQueryContainerID for USB devices when using bus_udev
by Claire (＠ClearlyClaire) Sept. 4, 2023

Sept. 4, 2023

Some games with support for the haptic feedback and speaker features of the Sony DualSense controller select the controller's audio output by filtering on the ContainerId IMMDevice property to find one that matches the controller's HID's. While MRs !359 and !360 implement getting the ContainerID of the IMMDevice, this MR implements getting the ContainerID from the HID device. As for !360, I marked this MR as a draft because I understand that the way the ��GUID�� is generated is far from ideal. Furthermore, there is code duplication with !360 in the way the container's sysfspath is found and how a GUID is generated from it, so moving that part elsewhere would make sense. But as for !360, I think I will need help with those tasks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/535

4 4

[PATCH v4 0/3] MR417: riched20: Add font fallback support.
by Jactry Zeng (＠jactry) July 25, 2023

July 25, 2023

Signed-off-by: Jactry Zeng <jzeng(a)codeweavers.com> -- v4: riched20: Add font fallbacks for CJK. riched20: Add font fallback support. riched20: Use OpenType functions for painting and generating script tags. https://gitlab.winehq.org/wine/wine/-/merge_requests/417

4 10

[PATCH v5 0/1] MR477: d3drm/tests: Show Clear sets background color
by Alistair Leslie-Hughes (＠alesliehughes) July 17, 2023

July 17, 2023

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> -- v5: d3drm/tests: Show Clear sets background color https://gitlab.winehq.org/wine/wine/-/merge_requests/477

4 4

[PATCH v2 0/4] MR585: Improve is_gecko_path() for handling non-ASCII characters.
by Jactry Zeng (＠jactry) July 8, 2023

July 8, 2023

This fixes an issue when the path includes non-ASCII characters. Signed-off-by: Jactry Zeng <jzeng(a)codeweavers.com> -- v2: mshtml: Call UrlUnescapeW() with URL_UNESCAPE_AS_UTF8 in is_gecko_path(). shlwapi/tests: Test UrlUnescapeW() with URL_UNESCAPE_AS_UTF8. kernelbase: Implement URL_UNESCAPE_AS_UTF8 for UrlUnescapeW(). shlwapi/tests: Test UrlUnescapeW() with independent data. https://gitlab.winehq.org/wine/wine/-/merge_requests/585

4 6

[PATCH 0/2] MR542: configure: Build with -mimpure-text if available when building with -fno-PIC.
by Zebediah Figura (＠zfigura) May 23, 2023

May 23, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/542

4 6

[PATCH 0/1] MR671: include: Add dxcore.idl
by Biswapriyo Nath (＠Biswa96) March 20, 2023

March 20, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/671

3 5

[PATCH v3 0/2] MR626: Zooming fixes
by David Kahurani (＠kahurani) March 10, 2023

March 10, 2023

Manipulating the font size results in the script_cache going stale. From MSDN[1] `The application should never pass the same handle for different fonts or different sizes.` This is however exactly what happens when the font size changes as a result of zooming(both in and out). ScriptShape and relative functions will only inspect the hardware device context only if the required data is not cached[2] and hence the data from a previous call to these functions is retrieved even though the font size has changed hence the bug where text both doesn't wrap and doesn't paint as it should. In patch one, I have tried to keep track of the script_cache objects alongside the relevant font. Patch two fixes an issue where the cursor doesn't scale after zooming until after one interacts with the editor. Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> 1. https://docs.microsoft.com/en-us/windows/win32/intl/caching 2. https://docs.microsoft.com/en-us/windows/win32/intl/script-cache -- v3: riched20: update caret on zooming riched20: Cache script_cache alongside font cache https://gitlab.winehq.org/wine/wine/-/merge_requests/626

3 4

[PATCH 0/1] MR533: xactengine3_7/tests: Test wave bank pointer also when creating one.
by Giovanni Mascellani (＠giomasce) Feb. 20, 2023

Feb. 20, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/533

3 3

[PATCH 0/3] MR566: shell32: Implement SHBindToFolderIDListParent.
by Mohamad Al-Jaf (＠maljaf) Oct. 26, 2022

Oct. 26, 2022

Called by IE11. Signed-off-by: Mohamad Al-Jaf <mohamadaljaf(a)gmail.com> v3: Fix failed test. Don't know how to change the subject version number. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/566

4 7

[PATCH 0/1] MR498: server: Allow creating named pipes using \Device\NamedPipe\ as RootDirectory. (#52105)
by Jinoh Kang (＠iamahuman) Oct. 11, 2022

Oct. 11, 2022

On Windows, \Device\NamedPipe\ is the root directory of the named pipe file system (NPFS), and can be used as RootDirectory to skip its path when accessing the NPFS namespace. This introduces a regression that makes it possible to use \Device\NamedPipe (note the lack of trailing backslash) as RootDirectory as well, since Wine does not distinguish between \Device\NamedPipe (the device itself) and \Device\NamedPipe\ (the root directory of the filesystem). (Previous iteration of this patch did distinguish between the two, but the method in which it was implemented was deemed hacky.) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/498

5 11

[PATCH v4 0/1] MR745: ntdll: Improve stub of NtQueryEaFile.
by Joel Holdsworth (＠jhol) Sept. 26, 2022

Sept. 26, 2022

Based on a patch by Qian Hong. -- v4: ntdll: Improve stub of NtQueryEaFile. https://gitlab.winehq.org/wine/wine/-/merge_requests/745

3 2

[PATCH v3 0/4] MR47: kernel32/tests: Add tests for CancelSynchronousIo.
by Daniel Lehman (＠dlehman25) Sept. 19, 2022

Sept. 19, 2022

Signed-off-by: Daniel Lehman <dlehman25(a)gmail.com> -- v3: kernelbase: Call NtCancelSynchronousIoFile in CancelSynchronousIo. ntdll: Partially implement NtCancelSynchronousIoFile. ntdll: Add NtCancelSynchronousIoFile stub. kernel32/tests: Add tests for CancelSynchronousIo. https://gitlab.winehq.org/wine/wine/-/merge_requests/47

5 17

[PATCH v5 0/8] MR716: windows.devices.enumeration: Add DeviceWatcher class and IDeviceInformationStatics2 interface.
by Julian Klemann (＠jklemann) Sept. 14, 2022

Sept. 14, 2022

Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=53328 -- v5: windows.devices.enumeration/tests: Add test for Stopped DeviceWatcher event. windows.devices.enumeration: Implement Stopped handler for DeviceWatcher. windows.devices.enumeration: Add DeviceWatcher stub. windows.devices.enumeration: Create private header file. windows.devices.enumeration: Add IDeviceInformationStatics2 interface. windows.devices.enumeration: Replace STDMETHODCALLTYPE with WINAPI. include/windows.devices.enumeration: Update file to newer formatting. widl: Use "cinterface(IInspectable)" for IInspectable signature. https://gitlab.winehq.org/wine/wine/-/merge_requests/716

3 18

[PATCH 0/5] MR657: wined3d: Managed texture patches.
by Zebediah Figura (＠zfigura) Sept. 13, 2022

Sept. 13, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/657

6 12

[PATCH 0/1] MR688: ntdll: Introduce "WINEWOW64" environment variable, to enable new WoW64 behavior.
by Davide Beatrici (＠davidebeatrici) Sept. 13, 2022

Sept. 13, 2022

https://www.winehq.org/pipermail/wine-devel/2022-April/213620.html -- https://gitlab.winehq.org/wine/wine/-/merge_requests/688

7 10

[PATCH 0/5] MR502: winusb: Add WinUsb_Free stub.
by Mohamad Al-Jaf (＠maljaf) Sept. 12, 2022

Sept. 12, 2022

The program REVELPROG_IS runs with this patchset. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52677 Signed-off-by: Mohamad Al-Jaf <mohamadaljaf(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/502

3 10

[PATCH 0/3] MR698: d2d1: Implement transform graph.
by Ziqing Hui (＠zhui) Sept. 8, 2022

Sept. 8, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/698

3 9

[PATCH v2 0/8] MR695: winegstreamer: Initial fixes and refactor of the WM async reader.
by Rémi Bernon Sept. 6, 2022

Sept. 6, 2022

This includes some fixes for obvious mistakes as well as initial cleanup of the WM async reader, in preparation for implementing proper threading support. I'm planning on doing some more refactoring first, ultimately implementing the async reader on top of the sync reader, and removing the need for a private interface. I've checked that it can indeed work on Windows too, and it'll make the code simpler overall. -- v2: winegstreamer: Query IWMReaderCallbackAdvanced interface in Open. winegstreamer: Avoid waiting for callback thread on allocation failure. winegstreamer: Release callback and context in async_reader_close. winegstreamer: Move open_stream / close_stream helpers around. winegstreamer: Leave async reader callback_cs on calloc error. winegstreamer: Leave WM reader CS on invalid output format. winegstreamer: Avoid leaking async ops on release or multiple close. winegstreamer: Rename async reader stream_thread to callback_thread. https://gitlab.winehq.org/wine/wine/-/merge_requests/695

2 10

[PATCH v3 0/1] MR726: msvfw32: Use string comparison to determine class name equality.
by Alexandros Frantzis (＠afrantzis) Sept. 5, 2022

Sept. 5, 2022

The current version of the code incorrectly assumes that the lpszClass member of CREATESTRUCT passed with WM_CREATE will point to the same memory used for the CreateWindowEx class name parameter, and uses a pointer comparison to check for class name equality. As a side effect of commit e41c255be6ba66d1eec7affe674b8cc7699226b8 "win32u: Use send_message_timeout for WM_CREATE and WM_NCCREATE" the CREATESTRUCT lpszClass member started pointing to different memory, breaking the current implementation of MCIWND_Create(). This commit fixes the problem by performing a proper, case-insensitive string comparison to determine class name equality. Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=53578 -- v3: msvfw32: Use string comparison to determine class name equality. https://gitlab.winehq.org/wine/wine/-/merge_requests/726

4 14