August 2022 - Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/1] MR737: evr/filter: Initialize interface pointer in GetService() (Coverity). - approved
by Alexandre Julliard (＠julliard) Aug. 31, 2022

Aug. 31, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/737

1 0

Re: [PATCH v2 0/1] MR736: mfsrcsnk/wave: Initialize buffer pointer in ProcessSample() (Coverity). - approved
by Alexandre Julliard (＠julliard) Aug. 31, 2022

Aug. 31, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/736

1 0

Re: [PATCH v2 0/1] MR735: bcrypt/tests: Use CRT allocation functions. - approved
by Alexandre Julliard (＠julliard) Aug. 31, 2022

Aug. 31, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/735

1 0

Re: [PATCH 0/3] MR332: d3dx10: Support creating effect from pre-built shader - closed
by Matteo Bruni (＠Mystral) Aug. 31, 2022

Aug. 31, 2022

This merge request was closed by Matteo Bruni. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/332

1 0

[PATCH v4 0/6] MR697: Implement d3dx10 effect creation for compiled shader.
by Ziqing Hui (＠zhui) Aug. 31, 2022

Aug. 31, 2022

Note for patch 7: See https://docs.microsoft.com/en-us/windows/win32/api/d3d10/ns-d3d10-d3d10_map… : > A block-compressed texture is encoded in 4x4 blocks (see virtual size vs physical size) ; therefore, RowPitch is the number of bytes in a block of 4x4 texels. -- v4: d3dx10: Return E_FAIL in D3DX10CreateEffectFromFile for NULL file name. d3dx10: Support effect creation for compiled shader. d3dx10: Introduce create_effect(). d3dx10/tests: Add tests for D3DX10CreateEffectFromResource. d3dx10/tests: Add tests for D3DX10CreateEffectFromFile. d3dx10/tests: Add tests for D3DX10CreateEffectFromMemory. https://gitlab.winehq.org/wine/wine/-/merge_requests/697

3 9

[PATCH 0/2] MR753: dwrite: Skip variation selectors in MapCharacters().
by Nikolay Sivov (＠nsivov) Aug. 31, 2022

Aug. 31, 2022

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/753

2 2

[PATCH v2 0/1] MR730: user32: Implement DefRawInputProc.
by Andrey Gusev (＠agusev) Aug. 31, 2022

Aug. 31, 2022

-- v2: user32: Implement DefRawInputProc. https://gitlab.winehq.org/wine/wine/-/merge_requests/730

4 4

[PATCH 0/5] MR731: mshtml: Implement props forwarding for Storage.
by Gabriel Ivăncescu Aug. 31, 2022

Aug. 31, 2022

This implements props access to the underlying items in the storage, which is supported on native (although quirky). Unlike most normal props, the underlying storage for the props is asynchronous, so it can disappear or appear at any point, so they have to be re-checked as needed. The props themselves just map a name to a DISPID, but other than that, DISP_E_MEMBERNOTFOUND can return even after a successful GetDispID for example, even if GetDispID already checked for the item (which it has to, for e.g. (x in y) check). It also contains some fixes for enumerating props, which are needed now because these props also have to be enumerated. They are custom props, so it's needed to have GetMemberName work for them. And since they are asynchronous it makes it even more complicated when enumerating. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/731

3 7

[PATCH v2 0/6] MR749: uiautomationcore: Implement UI Automation Runtime IDs and UiaHUiaNodeFromVariant.
by Connor McAdams (＠cmcadams) Aug. 31, 2022

Aug. 31, 2022

-- v2: uiautomationcore: Implement UiaHUiaNodeFromVariant. uiautomationcore: Add support for UIA_RuntimeIdPropertyId. uiautomationcore: Partially implement UiaGetRuntimeId. https://gitlab.winehq.org/wine/wine/-/merge_requests/749

3 8

[PATCH 0/1] MR737: evr/filter: Initialize interface pointer in GetService() (Coverity).
by Nikolay Sivov (＠nsivov) Aug. 31, 2022

Aug. 31, 2022

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/737

3 2

[PATCH 0/6] MR749: uiautomationcore: Implement UI Automation Runtime IDs and UiaHUiaNodeFromVariant.
by Connor McAdams (＠cmcadams) Aug. 31, 2022

Aug. 31, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/749

3 8

Re: [PATCH v5 0/11] MR7: vkd3d-shader/hlsl: Translate copy propagation to index paths. Check for non-static object references. Implicit array initialization.
by Francisco Casas (＠fcasas) Aug. 31, 2022

Aug. 31, 2022

On Wed Aug 31 14:00:14 2022 +0000, Giovanni Mascellani wrote: > For the future, please do code cleaning stuff (like renaming variables) > in dedicated commits, so that the "meaty" commits are easier to read. Okay, I agree with this policy, now that merge requests have to be approved as a whole. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/7#note_7348

1 0

[PATCH 0/1] MR752: winecrt0: run C++ object destructors in DLL_PROCESS_DETACH
by Kevin Puetz (＠puetzk) Aug. 31, 2022

Aug. 31, 2022

Run C++ global/static destructors during DLL_PROCESS_DETACH while other other dllimport functions they may want to call are still viable. While windows imposes many restrictions on what may be done in such destructors (given that the run inside the loader lock), there are lots of legal and useful kernel32 functions like DestroyCriticalSection, DeleteAtom, TlsFree, etc that are both useful and legal. Currently this does not work for builtin modules because all the Win32 structures are discarded well before NtUnmapViewOfSection finally does the dlllose. Even for a winelib .dll.so module, it woudl be preferable for destructors to execute during process_detach (before wine tears down the MODREF and detaches dependant dlls), rather than be left until after the last NtUnmapViewOfSection (when we finally reach dlclose) Therefore, winegcc now always uses the DllMainCRTStartup entry point unless you specify your own --entry=func. Previously it did this only for PE modules using msvcrt. Making this default consistent matches cl.exe, which also always defaults to _DllMainCRTStartup unless overridden by /entry:foo https://docs.microsoft.com/en-us/cpp/build/reference/entry-entry-point-symb… The ELF version of winecrt0.a now provides a DllMainCRTStartup which, per the Itanium ABI that is in practice what is used by gcc and clang, performs this this destruction by calling __cxa_finalize(&__dso_handle).. This libc function is required to be idempotent, so it's OK that dlclose still calls it again later (there will just be no further work to do). Multiple calls to __cxa_finalize shall not result in calling termination function entries multiple times; the implementation may either remove entries or mark them finished. https://itanium-cxx-abi.github.io/cxx-abi/abi.html#dso-dtor-runtime-api This has two main effects; it moves ELF destructors earlier (before imports are unmapped), and it moves them inside the Nt loader lock. Being earlier was the intended goal, and moving them inside the lock seems fine. Any Win32 API calls in destructors are just being subjected to the same lock-hiearchy rules as usual on windows (MSVC also runs destructors from DllMainCrtStartup) https://docs.microsoft.com/en-us/cpp/build/run-time-library-behavior?view=m… And any purely-ELF destructors that happen to also run earlier should never call functions exported from wine (and thus don't care about ntdll's locks). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/752

2 2

[PATCH 0/1] MR751: windows.media.speech: Remove WINAPI on static functions where not needed.
by Francois Gouget (＠fgouget) Aug. 31, 2022

Aug. 31, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/751

2 1

[PATCH 0/1] MR750: winecrt0: remove free_delay_imports.
by Kevin Puetz (＠puetzk) Aug. 31, 2022

Aug. 31, 2022

MSVC's delayimp.lib does not actually free delayload dependencies. winecrt0's attempt to do so from ELF __attribute__((destructor)) is unnecessary and potentially harmful: - When triggered naturally via LdrUnloadDll, this leads to recursive calls to FreeLibrary, violating free_lib_count and missing DLL_PROCESS_DETACH - when triggered by glibc's _dl_fini (at process exit), it leads to use-after-free of the TEB (GetCurrentThreadID after the main thread is no longer Win32) via FreeLibrary -> LdrLdrUnloadDll -> RtlEnterCriticalSection( &loader_section ) - double-free of the library itself, since the DLL_PROCESS_DETACH has already been handled by LdrShutdownProcess - Race against wineserver sending a SIGKILL from process_killed, since all Win32 threads of the process have exited Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53032 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/750

2 2

Re: [PATCH v3 0/2] MR747: dinput: Remove WINAPI on static functions where not needed. - approved
by Rémi Bernon Aug. 31, 2022

Aug. 31, 2022

This merge request was approved by R��mi Bernon. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/747

1 0

[PATCH 0/1] MR748: crypt32: Remove WINAPI on static functions where not needed.
by Francois Gouget (＠fgouget) Aug. 31, 2022

Aug. 31, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/748

2 1

[PATCH v3 0/1] MR745: ntdll: Improve stub of NtQueryEaFile.
by Joel Holdsworth (＠jhol) Aug. 31, 2022

Aug. 31, 2022

Based on a patch by Qian Hong. -- v3: ntdll: Improve stub of NtQueryEaFile. https://gitlab.winehq.org/wine/wine/-/merge_requests/745

2 1

Re: [PATCH 0/0] MR747: dinput: Remove WINAPI on static functions where not needed. - closed
by Francois Gouget (＠fgouget) Aug. 31, 2022

Aug. 31, 2022

This merge request was closed by Francois Gouget. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/747

1 0

Re: [PATCH v2 0/1] MR744: winealsa.drv: Make functions static where possible.
by Huw Davies (＠huw) Aug. 31, 2022

Aug. 31, 2022

Huw Davies (@huw) commented about dlls/winealsa.drv/alsa.c: > return key; > } > > -ULONG reg_query_value( HKEY hkey, const WCHAR *name, > +static ULONG reg_query_value( HKEY hkey, const WCHAR *name, > KEY_VALUE_PARTIAL_INFORMATION *info, ULONG size ) Could you correctly indent the second line? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/744#note_7335

1 0

[PATCH 0/1] MR746: static winex11
by Francois Gouget (＠fgouget) Aug. 31, 2022

Aug. 31, 2022

- kernelbase: Fix error value for PE files without resource. - include: Simplify handling of va_list in debug printf functions. - include: Add va_list version of the debug printf functions. - include: Avoid _t-suffixes. - include: Add list_move_after() and list_move_before(). - user32: Call winproc_init before dpiaware_init. - combase: Omit thread ID from the stub manager ipid for MTA objects. - d3dx10: Factor out image format conversion function. - d3dx10: Use WIC functions to obtain info about DDS image. - d3dx10: Add support for texture cubes in D3DX10CreateTexture functions. - d3dx10: Don't check frame count in load_texture_data. - d3dx10: Add support for loading MipLevels data in load_texture_data. - d3dx10/tests: Improve cube textures data testing. - winemac.drv: Rename display modes cache variables. - winemac.drv: Invalidate mode cache when enum flags changes. - winemac.drv: Remove unnecessary macdrv_EnumDisplaySettingsEx declaration. - winemac.drv: Check for non-primary adapter earlier in macdrv_ChangeDisplaySettingsEx. - winemac.drv: Support getting non-primary adapter current display mode. - winemac.drv: Support enumerating non-primary adapters display modes. - evr/filter: Implement pin's connect/disconnect. - d3dx10: Implement D3DX10PreprocessShaderFromMemory(). - d3dx10/tests: Add a test for D3DX10PreprocessShaderFromMemory(). - wmvcore/tests: Use a constant for test.wmv duration. - wmvcore/tests: Test sync reader output settings read / write. - wmvcore/tests: Test async reader output settings read / write. - wmvcore/tests: Test that the callback thread is always the same. - wmvcore/tests: Test async reader compressed sample monotonic pts. - wmvcore/tests: Test async reader DedicatedDeliveryThread setting. - mshtml/tests: Fix a spelling error in an ok() message. - dbghelp: Fix a couple of spelling errors in a comment. - mscvpdb: Fix a spelling error in a comment. - winspool.drv/tests: Fix the spelling of a variable name. - winex11.drv: Make get_unix_file_name() static. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/746

2 1

Re: [PATCH v5 0/11] MR7: vkd3d-shader/hlsl: Translate copy propagation to index paths. Check for non-static object references. Implicit array initialization.
by Giovanni Mascellani (＠giomasce) Aug. 31, 2022

Aug. 31, 2022

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/hlsl_codegen.c: > > static void copy_propagation_invalidate_whole_variable(struct copy_propagation_var_def *var_def) > { > + unsigned int component_count = hlsl_type_component_count(var_def->var->data_type); > unsigned i; > > TRACE("Invalidate variable %s.\n", var_def->var->name); > > - for (i = 0; i < var_def->var->data_type->reg_size; ++i) > + for (i = 0; i < component_count; ++i) > var_def->values[i].state = VALUE_STATE_DYNAMICALLY_WRITTEN; > } > > -static void copy_propagation_set_value(struct copy_propagation_var_def *var_def, unsigned int offset, > - unsigned char writemask, struct hlsl_ir_node *node) > +static void copy_propagation_set_value(struct copy_propagation_var_def *var_def, unsigned int comp, For the future, please do code cleaning stuff (like renaming variables) in dedicated commits, so that the "meaty" commits are easier to read. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/7#note_7330

1 0

[PATCH 0/1] MR745: ntdll: Improve stub of NtQueryEaFile.
by jhol (＠jhol) Aug. 31, 2022

Aug. 31, 2022

Based on a patch by Qian Hong. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/745

2 1

[PATCH 0/7] MR743: static
by Francois Gouget (＠fgouget) Aug. 31, 2022

Aug. 31, 2022

- kernelbase: Fix error value for PE files without resource. - include: Simplify handling of va_list in debug printf functions. - include: Add va_list version of the debug printf functions. - include: Avoid _t-suffixes. - include: Add list_move_after() and list_move_before(). - user32: Call winproc_init before dpiaware_init. - combase: Omit thread ID from the stub manager ipid for MTA objects. - d3dx10: Factor out image format conversion function. - d3dx10: Use WIC functions to obtain info about DDS image. - d3dx10: Add support for texture cubes in D3DX10CreateTexture functions. - d3dx10: Don't check frame count in load_texture_data. - d3dx10: Add support for loading MipLevels data in load_texture_data. - d3dx10/tests: Improve cube textures data testing. - winemac.drv: Rename display modes cache variables. - winemac.drv: Invalidate mode cache when enum flags changes. - winemac.drv: Remove unnecessary macdrv_EnumDisplaySettingsEx declaration. - winemac.drv: Check for non-primary adapter earlier in macdrv_ChangeDisplaySettingsEx. - winemac.drv: Support getting non-primary adapter current display mode. - winemac.drv: Support enumerating non-primary adapters display modes. - evr/filter: Implement pin's connect/disconnect. - d3dx10: Implement D3DX10PreprocessShaderFromMemory(). - d3dx10/tests: Add a test for D3DX10PreprocessShaderFromMemory(). - wmvcore/tests: Use a constant for test.wmv duration. - wmvcore/tests: Test sync reader output settings read / write. - wmvcore/tests: Test async reader output settings read / write. - wmvcore/tests: Test that the callback thread is always the same. - wmvcore/tests: Test async reader compressed sample monotonic pts. - wmvcore/tests: Test async reader DedicatedDeliveryThread setting. - mshtml/tests: Fix a spelling error in an ok() message. - dbghelp: Fix a couple of spelling errors in a comment. - mscvpdb: Fix a spelling error in a comment. - winspool.drv/tests: Fix the spelling of a variable name. - winealsa.drv: Make functions static where possible. - winex11.drv: Make get_unix_file_name() static. - dinput: Remove WINAPI on static functions where not needed. - dinput/tests: Remove WINAPI on static functions where not needed. - crypt32: Remove WINAPI on static functions where not needed. - windows.media.speech: Remove WINAPI on static functions where not needed. - winexinput.sys: Remove WINAPI on static functions where not needed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/743

2 8

[PATCH v3 0/3] MR742: winevulkan: Get rid of unix_funcs.
by Jacek Caban (＠jacek) Aug. 31, 2022

Aug. 31, 2022

-- v3: winevulkan: Get rid of unix_funcs. winevulkan: Use __wine_unix_call for checking Vulkan functions availability. winevulkan: Use vk_unix_call in loader.c. https://gitlab.winehq.org/wine/wine/-/merge_requests/742

2 4