August 2022 - Wine-GitLab - list.winehq.org

Re: [PATCH v3 0/1] MR705: combase: Omit thread ID from the stub manager ipid for MTA objects. - approved
by Alexandre Julliard (＠julliard) Aug. 30, 2022

Aug. 30, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/705

1 0

Re: [PATCH v2 0/1] MR728: user32: DPI handling regression fix. - approved
by Alexandre Julliard (＠julliard) Aug. 30, 2022

Aug. 30, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/728

1 0

[PATCH 0/1] MR734: tests: Make sure only one thread prints traces at a time.
by Francois Gouget (＠fgouget) Aug. 30, 2022

Aug. 30, 2022

Some Wine tests are multi-threaded or start child processes which can result in traces and failure messages being garbled which prevents them from being recognized by continuous integration tools. So printing the tests messages is now serialized. Note that if a process crashes while holding the mutex, that mutex will be abandonned and not cause a deadlock. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/734

2 1

[PATCH 0/6] MR685: wmvcore/tests: Add tests for output settings, pts ordering and threading support.
by Rémi Bernon Aug. 30, 2022

Aug. 30, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/685

4 10

[PATCH 0/1] MR727: evr/filter: Implement pin's connect/disconnect.
by Nikolay Sivov (＠nsivov) Aug. 30, 2022

Aug. 30, 2022

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/727

4 3

[PATCH 0/2] MR732: d3dx10: Implement D3DX10PreprocessShaderFromMemory().
by Matteo Bruni (＠Mystral) Aug. 30, 2022

Aug. 30, 2022

Supersedes !601. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/732

3 3

[PATCH 0/1] MR601: d3dx10: Implement D3DX10PreprocessShaderFromMemory.
by Andrey Gusev (＠agusev) Aug. 30, 2022

Aug. 30, 2022

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53427 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/601

3 5

[PATCH v5 0/6] MR720: winemac: Allow enumeration of non-primary display modes.
by Rémi Bernon Aug. 30, 2022

Aug. 30, 2022

In preparation for with https://gitlab.winehq.org/wine/wine/-/merge_requests/576. I think support for changing non-primary display modes in winemac will be easier /after/ the display placement logic is moved to win32u. I also don't really know how to handle the display position on macOS. -- v5: winemac.drv: Support enumerating non-primary adapters display modes. winemac.drv: Support getting non-primary adapter current display mode. winemac.drv: Check for non-primary adapter earlier in macdrv_ChangeDisplaySettingsEx. winemac.drv: Remove unnecessary macdrv_EnumDisplaySettingsEx declaration. winemac.drv: Invalidate mode cache when enum flags changes. winemac.drv: Rename display modes cache variables. https://gitlab.winehq.org/wine/wine/-/merge_requests/720

3 8

[PATCH v3 0/6] MR492: Enhancements for C++ symbols undecoration
by eric pouech (＠epo) Aug. 30, 2022

Aug. 30, 2022

This series implements a couple of enhancements to symbol undecoration in msvcrt: - more C++ constructs are correctly supported (pointer to member, constructors/destructors from template class, non-type function pointer template parameter...) - some internal cleanups & simplification (most of them based on revamped helper to build up the undecorated C++ symbols) -- v3: dlls/msvcrt: Fix order of extended qualifiers and qualifiers dlls/msvcrt: Use enum to clarify post-processing actions. dlls/msvcrt: Undecorate function signature as template argument. dlls/msvcrt: Fix white space output for typecast operator. dlls/msvcrt: Improve support for template in methods. dlls/msvcrt: Correctly support space generation in pointers. https://gitlab.winehq.org/wine/wine/-/merge_requests/492

3 11

Re: [PATCH v2 0/6] MR641: d3dx: MipLevels and CubeTextures support
by Piotr Caban (＠piotr) Aug. 30, 2022

Aug. 30, 2022

On Tue Aug 30 13:26:41 2022 +0000, Matteo Bruni wrote: > I wonder if this should happen for all the mip level 0 elements of an > array / cube texture (i.e. condition should just be !j instead). We're creating the img_info structure only once (in D3DX10GetImageInfoFromMemory call) so there's no need to do it multiple times. Probably it should be moved outside of the loop to make it easier to read. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/641#note_7229

1 0

[PATCH 0/5] MR729: windows.media.speech: Initial recognition session work.
by Bernhard Kölbl Aug. 30, 2022

Aug. 30, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/729

2 8

[PATCH v4 0/6] MR720: winemac: Allow enumeration of non-primary display modes.
by Rémi Bernon Aug. 30, 2022

Aug. 30, 2022

In preparation for with https://gitlab.winehq.org/wine/wine/-/merge_requests/576. I think support for changing non-primary display modes in winemac will be easier /after/ the display placement logic is moved to win32u. I also don't really know how to handle the display position on macOS. -- v4: winemac.drv: Support enumerating non-primary adapters display modes. winemac.drv: Support getting non-primary adapter current display mode. winemac.drv: Check for non-primary adapter earlier in macdrv_ChangeDisplaySettingsEx. winemac.drv: Remove unnecessary macdrv_EnumDisplaySettingsEx declaration. winemac.drv: Invalidate mode cache when enum flags changes. winemac.drv: Rename display modes cache variables. https://gitlab.winehq.org/wine/wine/-/merge_requests/720

2 8

[PATCH 0/6] MR641: d3dx: MipLevels and CubeTextures support
by Piotr Caban (＠piotr) Aug. 30, 2022

Aug. 30, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/641

3 9

[PATCH v2 0/1] MR705: combase: Omit thread ID from the stub manager ipid for MTA objects.
by Connor McAdams (＠cmcadams) Aug. 30, 2022

Aug. 30, 2022

Fixes a bug that occurs when: - `CoInitializeEx(NULL, COINIT_MULTITHREADED);` is called on thread 1 - `CoInitializeEx(NULL, COINIT_MULTITHREADED);` is called on thread 2 - `CoUninitialize()` is called on thread 1. - `CoInitializeEx(NULL, COINIT_APARTMENTTHREADED);` is called on thread 1. After this, when attempting to marshal an interface on thread 2, when `ipid_to_ifstub` is called, `apartment_findfromtid()` will find thread 1's STA and not the MTA. -- v2: combase: Omit thread ID from the stub manager ipid for MTA objects. https://gitlab.winehq.org/wine/wine/-/merge_requests/705

3 3

[PATCH v4 0/7] MR716: windows.devices.enumeration: Add DeviceWatcher class and IDeviceInformationStatics2 interface.
by Julian Klemann (＠jklemann) Aug. 30, 2022

Aug. 30, 2022

Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=53328 -- v4: windows.devices.enumeration/tests: Add test for Stopped DeviceWatcher event. windows.devices.enumeration: Add DeviceWatcher class. windows.devices.enumeration: Create private header file. windows.devices.enumeration: Add IDeviceInformationStatics2 interface. windows.devices.enumeration: Replace STDMETHODCALLTYPE with WINAPI. include/windows.devices.enumeration: Update file to newer formatting. widl: Use "cinterface(IInspectable)" for IInspectable signature. https://gitlab.winehq.org/wine/wine/-/merge_requests/716

4 10

[PATCH 0/1] MR728: user32: DPI handling regression fix.
by Jacek Caban (＠jacek) Aug. 30, 2022

Aug. 30, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/728

3 2

[PATCH v4 0/4] MR607: mf: Fix session command handling and SESSION_CMD_END.
by Rémi Bernon Aug. 30, 2022

Aug. 30, 2022

-- v4: mf: Actually implement SESSION_CMD_END internal command. mf: Use session_submit_command to put SESSION_CMD_END ahead of the queue. mf: Keep pending session command out of the queued commands list. mf: Use a dedicated session callback interface for sample requests. https://gitlab.winehq.org/wine/wine/-/merge_requests/607

2 8

[PATCH v3 0/5] MR720: winemac: Allow enumeration of non-primary display modes.
by Rémi Bernon Aug. 30, 2022

Aug. 30, 2022

In preparation for with https://gitlab.winehq.org/wine/wine/-/merge_requests/576. I think support for changing non-primary display modes in winemac will be easier /after/ the display placement logic is moved to win32u. I also don't really know how to handle the display position on macOS. -- v3: winemac.drv: Support enumerating non-primary adapters display modes. winemac.drv: Support getting non-primary adapter current display mode. winemac.drv: Invalidate mode cache when enum flags changes. winemac.drv: Remove unnecessary macdrv_EnumDisplaySettingsEx declaration. winemac.drv: Rename display modes cache variables. https://gitlab.winehq.org/wine/wine/-/merge_requests/720

2 7

[PATCH v2 0/1] MR726: msvfw32: Use string comparison to determine class name equality.
by Alexandros Frantzis (＠afrantzis) Aug. 30, 2022

Aug. 30, 2022

The previous version of the code incorrectly assumed that the lpszClass member of CREATESTRUCT passed with WM_CREATE would point to the same memory used for the CreateWindowEx class name parameter, and used a pointer comparison to check for class name equality. As a side effect of commit e41c255be6ba66d1eec7affe674b8cc7699226b8 "win32u: Use send_message_timeout for WM_CREATE and WM_NCCREATE" the CREATESTRUCT lpszClass member started pointing to different memory, breaking the current implementation of MCIWND_Create(). This commit fixes the problem by performing a proper, case-insensitive string comparison to determine class name equality. Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=53578 -- v2: msvfw32: Use string comparison to determine class name equality. https://gitlab.winehq.org/wine/wine/-/merge_requests/726

2 1

[PATCH 0/1] MR726: msvfw32: Use string comparison to determine class name equality.
by Alexandros Frantzis (＠afrantzis) Aug. 30, 2022

Aug. 30, 2022

The previous version of the code incorrectly assumed that the lpszClass member of CREATESTRUCT passed with WM_CREATE would point to the same memory used for the CreateWindowEx class name parameter, and used a pointer comparison to check for class name equality. As a side effect of commit e41c255be6ba66d1eec7affe674b8cc7699226b8 "win32u: Use send_message_timeout for WM_CREATE and WM_NCCREATE" the CREATESTRUCT lpszClass member started pointing to different memory, breaking the current implementation of MCIWndCreate(). This commit fixes the problem by performing a proper, case-insensitive string comparison to determine class name equality. Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=53578 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/726

2 1

[PATCH v11 0/2] MR672: comdlg32: Common item dialog fixes
by Ben Cottrell (＠bgc) Aug. 30, 2022

Aug. 30, 2022

Made changes to comdlg32/itemdlg.c to add missing controls, which are the address bar and the up button. Updated bitmaps in comctl32 and SVG files for history icons. My changes help to resolve this bug: https://bugs.winehq.org/show_bug.cgi?id=50338. -- v11: comdlg32: Add missing controls to the common item dialog, only affecting the implementation comdlg32: Add missing controls and their functionality to IFileDialog, or the common item dialog. https://gitlab.winehq.org/wine/wine/-/merge_requests/672

3 4

Re: [PATCH v8 0/9] MR6: Avoid performance degradation due to vDSO unmapping (BZ#52313)
by Olivia/Isabelle Mahadevan (＠doubledge-spec) Aug. 30, 2022

Aug. 30, 2022

Any update on this? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6#note_7189

1 0

Re: [PATCH v3 0/3] MR725: evr/filter: Implement media type testing for QueryAccept().
by Nikolay Sivov (＠nsivov) Aug. 30, 2022

Aug. 30, 2022

On Mon Aug 29 20:13:37 2022 +0000, **** wrote: > Zebediah Figura replied on the mailing list: > ``` > On 8/29/22 09:39, Nikolay Sivov wrote: > > @@ -296,6 +299,15 @@ static void test_interfaces(void) > > check_interface(filter, &IID_IReferenceClock, FALSE); > > check_interface(filter, &IID_IVideoWindow, FALSE); > > > > + /* The scope of IMediaEventSink */ > > + hr = IBaseFilter_QueryInterface(filter, &IID_IMediaEventSink, > (void **)&unk); > > + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); > > + hr = IUnknown_QueryInterface(unk, &IID_IBaseFilter, (void **)&filter2); > > + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); > > + ok(filter == filter2, "Unexpected pointer.\n"); > > + IBaseFilter_Release(filter2); > > + IUnknown_Release(unk); > > + > > ref = IBaseFilter_Release(filter); > > ok(!ref, "Got unexpected refcount %ld.\n", ref); > > } > Somewhat out of curiosity, why this test? > ``` It's done differently in mf/evr.c where this interface is not exposed, except during InitServices(). The test was to show that it's done in a usual way in this case. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/725#note_7188

1 0

Re: [PATCH v3 0/3] MR725: evr/filter: Implement media type testing for QueryAccept(). - approved
by Alexandre Julliard (＠julliard) Aug. 29, 2022

Aug. 29, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/725

1 0

Re: [PATCH v7 0/5] MR708: windows.media.speech: Fix test breakage and misc changes. - approved
by Alexandre Julliard (＠julliard) Aug. 29, 2022

Aug. 29, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/708

1 0