August 2022 - Wine-GitLab - list.winehq.org

Re: [PATCH v3 0/1] MR656: jscript: Implement fdexNameCaseInsensitive flag handling. - approved
by Alexandre Julliard (＠julliard) Aug. 17, 2022

Aug. 17, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/656

1 0

Re: [PATCH v3 0/1] MR647: winex11.drv: Make last_cursor per-thread. - approved
by Alexandre Julliard (＠julliard) Aug. 17, 2022

Aug. 17, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/647

1 0

Re: [PATCH v3 0/2] MR653: Dsdmo fx - approved
by Alexandre Julliard (＠julliard) Aug. 17, 2022

Aug. 17, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/653

1 0

Re: [PATCH v3 0/2] MR661: wshom: Support default style argument in IWshShell3::Run. - approved
by Alexandre Julliard (＠julliard) Aug. 17, 2022

Aug. 17, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/661

1 0

Re: [PATCH v2 0/8] MR663: mfreadwrite/writer: Implement some functionality. - approved
by Alexandre Julliard (＠julliard) Aug. 17, 2022

Aug. 17, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/663

1 0

Re: [PATCH v2 0/1] MR662: mfsrcsnk/wave: Add a type handler stub. - approved
by Alexandre Julliard (＠julliard) Aug. 17, 2022

Aug. 17, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/662

1 0

[PATCH 0/10] MR7: vkd3d-shader/hlsl: Translate copy propagation to index paths. Check for non-static object references. Implicit array initialization.
by Francisco Casas (＠fcasas) Aug. 17, 2022

Aug. 17, 2022

Copy propagation is translated to index paths, invalidation of variable components is made more precise. This, together with checking for non-static object references (which are not allowed in HLSL) allows to set object register sizes back to zero without overlapping registers. I also included implicit array initialization, since, if I remember correctly, what was holding it back was that structs/arrays with object components couldn't be represented with the correct register offsets. After this, we have to decide if (and how to) move register allocation and register offset calculation to each shader model. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/7

4 21

[PATCH 0/9] MR664: wow64win: thunk fixes
by Jacek Caban (＠jacek) Aug. 17, 2022

Aug. 17, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/664

3 10

[PATCH 0/3] MR666: compstui: Add partial CommonPropertySheetUIW implementation
by Piotr Caban (＠piotr) Aug. 17, 2022

Aug. 17, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/666

2 3

[PATCH v2 0/1] MR656: jscript: Implement fdexNameCaseInsensitive flag handling.
by Gabriel Ivăncescu Aug. 17, 2022

Aug. 17, 2022

Despite common sense, native doesn't seem to look for exact match first; it simply case-insensitively compares the props and returns as soon as it finds one. This is also reliant on implementation details in case the object has multiple props with same case-insensitive names, e.g. an object having `Foo` prop, with `foo` prop on its prototype, can still find `Foo` even if you look up `foo` instead (which matches exactly on the prototype). Which is not always reliable, sometimes it finds the prototype first. See the following diff to illustrate possible behavior on native (which is what I get). Note that especially for jscript, the behavior makes no sense logically; first it picks 'Foo', despite 'foo' being available on the prototype (i.e. exact match). You might think it just looks up on props first, and prototype later, but the second ok() added shows that it finds the prototype's prop first, instead! ```diff diff --git a/dlls/jscript/tests/jscript.c b/dlls/jscript/tests/jscript.c index 03774da..2428363 100644 --- a/dlls/jscript/tests/jscript.c +++ b/dlls/jscript/tests/jscript.c @@ -999,6 +999,7 @@ static void test_case_sens(void) /* Native picks one "arbitrarily" here, depending how it's laid out, so can't compare exact id */ hr = IDispatchEx_GetDispID(disp, bstr, fdexNameCaseInsensitive, &id2); ok(hr == S_OK, "GetDispID failed: %08lx\n", hr); + ok(id != id2, "id == id2\n"); hr = IDispatchEx_GetIDsOfNames(disp, &IID_NULL, &bstr, 1, 0, &id2); ok(hr == S_OK, "GetIDsOfNames failed: %08lx\n", hr); @@ -1031,6 +1032,7 @@ static void test_case_sens(void) hr = IDispatchEx_GetDispID(disp, bstr, fdexNameCaseInsensitive | fdexNameEnsure, &id2); ok(hr == S_OK, "GetDispID failed: %08lx\n", hr); + ok(id == id2, "id != id2\n"); SysFreeString(bstr); IDispatchEx_Release(disp); diff --git a/dlls/mshtml/tests/script.c b/dlls/mshtml/tests/script.c index 14e3a14..563b87a 100644 --- a/dlls/mshtml/tests/script.c +++ b/dlls/mshtml/tests/script.c @@ -241,6 +241,7 @@ static void test_script_vars(unsigned argc, VARIANTARG *argv) /* Native picks one "arbitrarily" here, depending how it's laid out, so can't compare exact id */ hres = IDispatchEx_GetDispID(disp, bstr, fdexNameCaseInsensitive, &id2); ok(hres == S_OK, "GetDispID failed: %08lx\n", hres); + ok(id != id2, "id == id2\n"); hres = IDispatchEx_GetIDsOfNames(disp, &IID_NULL, &bstr, 1, 0, &id2); ok(hres == S_OK, "GetIDsOfNames failed: %08lx\n", hres); @@ -273,6 +274,7 @@ static void test_script_vars(unsigned argc, VARIANTARG *argv) hres = IDispatchEx_GetDispID(disp, bstr, fdexNameCaseInsensitive | fdexNameEnsure, &id2); ok(hres == S_OK, "GetDispID failed: %08lx\n", hres); + ok(id != id2, "id == id2\n"); SysFreeString(bstr); IDispatchEx_Release(disp); ``` Strangely, mshtml's jscript still finds the prop on the object the second time, but that could be to different underlying implementation. I don't think it's necessary to replicate this quirk. The main point of this case insensitive handling is that it will be needed later when IE9+ modes use jscript proxy objects for the mshtml objects, because those default to case-insensitive search in GetIDsOfNames, likely to preserve backwards compatibility with pre-IE9 modes. It's a weird quirk, I know, but we have tests for that, which would otherwise break when proxies get added. I'll also add more tests around it later, to prove this, of course, that it also applies to jscript props (e.g. hasOwnProperty on the prototype is still looked case-insensitively if GetIDsOfNames is used). -- v2: jscript: Implement fdexNameCaseInsensitive flag handling. https://gitlab.winehq.org/wine/wine/-/merge_requests/656

3 4