January 2023 - Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/5] MR2056: ntdll: Make some definitions static or hidden. - approved
by Alexandre Julliard (＠julliard) Jan. 30, 2023

Jan. 30, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2056

1 0

Re: [PATCH v2 0/1] MR2050: include: Remove __WINE_MALLOC from functions that shouldn't have it. - approved
by Alexandre Julliard (＠julliard) Jan. 30, 2023

Jan. 30, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2050

1 0

Re: [PATCH v2 0/1] MR2052: tools: Include limits.h for PATH_MAX - approved
by Alexandre Julliard (＠julliard) Jan. 30, 2023

Jan. 30, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2052

1 0

[PATCH 0/1] MR74: vkd3d-shader/hlsl: Support dot() for SM1.
by Nikolay Sivov (＠nsivov) Jan. 30, 2023

Jan. 30, 2023

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/74

6 15

Re: [PATCH v2 0/1] MR2029: dmime: Store WAVE data when Loading.
by Michael Stefaniuc (＠mstefani) Jan. 30, 2023

Jan. 30, 2023

There is another things that bothers me: The while loop in parse_wave_form(): - WAVE file chunk order is fmt and then data - The last fmt or data chunk will "win"; doubt there are any dmusic related WAVE files with duplicate fmt or data chunks. But for now we can start with the while() loop: - No clue where those extra chunks are placed - We don't do anything with the WAV file; we just store it. Though we might run into memory issues with big WAV files. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2029#note_22349

1 0

Re: [PATCH v2 0/1] MR2029: dmime: Store WAVE data when Loading.
by Michael Stefaniuc (＠mstefani) Jan. 30, 2023

Jan. 30, 2023

Michael Stefaniuc (@mstefani) commented about dlls/dmime/segment.c: > + case FOURCC_LIST: { > + FIXME("Skipping LIST tag\n"); > + break; > + } > + case mmioFOURCC('I','S','F','T'): { > + FIXME("Skipping ISFT tag\n"); > + break; > + } > + case mmioFOURCC('f','a','c','t'): { > + FIXME("Skipping fact tag\n"); > + break; > + } > + } > + } > + > + return S_OK; The stream_next_chunk() in the while loop can fail too and you'll need to return that failure too. S_FALSE indicates "no more chunks". -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2029#note_22348

1 0

Re: [PATCH v2 0/1] MR2029: dmime: Store WAVE data when Loading.
by Michael Stefaniuc (＠mstefani) Jan. 30, 2023

Jan. 30, 2023

Michael Stefaniuc (@mstefani) commented about dlls/dmime/segment.c: > > if (riff.type == DMUS_FOURCC_SEGMENT_FORM) > hr = parse_segment_form(This, stream, &riff); > - else { > - FIXME("WAVE form loading not implemented\n"); > - hr = S_OK; > - } > + else Please check that the RIFF has the proper type and add an else for the error case. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2029#note_22346

1 0

Re: [PATCH v2 0/1] MR2029: dmime: Store WAVE data when Loading.
by Michael Stefaniuc (＠mstefani) Jan. 30, 2023

Jan. 30, 2023

Michael Stefaniuc (@mstefani) commented about dlls/dmime/segment.c: > return CONTAINING_RECORD(iface, IDirectMusicSegment8Impl, dmobj.IPersistStream_iface); > } > > +static HRESULT parse_wave_form(IDirectMusicSegment8Impl *This, IStream *stream, const struct chunk_entry *riff) > +{ > + HRESULT hr; > + struct chunk_entry chunk = {.parent = riff}; > + > + TRACE("Parsing segment wave in %p: %s\n", stream, debugstr_chunk(riff)); > + > + while ((hr = stream_next_chunk(stream, &chunk)) == S_OK) { > + switch (chunk.id) { > + case mmioFOURCC('f','m','t',' '): { > + if (FAILED(hr = stream_chunk_get_data(stream, &chunk, &This->wave_format, chunk.size))) Don't use the chunk.size there; use the sizeof the destination object, here sizeof(This->wave_format) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2029#note_22347

1 0

[PATCH v5 0/3] MR65: hlsl: More function-related tests.
by Zebediah Figura (＠zfigura) Jan. 30, 2023

Jan. 30, 2023

-- v5: tests: Test entry point semantics on function declarations. tests: Add more tests for early return from the entry point. tests: Add some tests for early return from user-defined functions. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/65

2 3

[PATCH 0/1] MR2068: Draft: comdlg32: Enable visual styles when showing IFileDialog.
by Vladislav Timonin (＠vt) Jan. 30, 2023

Jan. 30, 2023

Required for !1857 to not break when comctl32 version 6 isn't requested by application (in particular, found this in [qapitrace](https://github.com/apitrace/apitrace)) Manifest resource id and assembly identity name match with Windows. For isolation purposes, activation context is disabled while emitting events. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2068

3 2