October 2023 - Wine-GitLab - list.winehq.org

[PATCH 0/1] MR4002: oleaut32: Fix typelib cache race condition.
by Connor McAdams (＠cmcadams) Nov. 8, 2023

Nov. 8, 2023

This fixes the following issue: - Thread X holds the typelib cache list CS, and is iterating through the list. - Thread Y calls Release on the typelib interface, reference count hits 0, it's waiting for the cache list CS to remove this typelib. - Thread X finds the typelib in the cache list, returns it, exits the CS. - Thread Y enters now the CS, removes the typelib from the cache list, and proceeds to free all of the resources associated with the typelib. - Thread X tries to use the typelib, use after free. The method used here to prevent incrementing the reference count is borrowed from MR !2752. An alternative could be to decouple the actual typelib data from the `ITypeLib2` interface itself, e.g what gets stored into the typelib cache is just the data for the typelib, which would have its own private reference count locked behind the cache list CS. When the public `ITypeLib2` interface's reference count hits 0, it'd lock the typelib cache list CS, decrement the private reference count, and if the private reference count is 0 remove it from the list. The alternative method would require major restructuring of the code, which is why I'd prefer to use the one in this MR. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4002

5 6

[PATCH v2 0/3] MR3839: kernel32: Add structure size checks to CreateActCtx().
by Dmitry Timoshkov (＠dmitry) Nov. 8, 2023

Nov. 8, 2023

Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> -- v2: ntdll: Add ACTCTX field limit checks to RtlCreateActivationContext(). kernel32: Add ACTCTX field limit checks to CreateActCtxA(). kernel32/tests: Add some tests for CreateActCtx() with different structure sizes. https://gitlab.winehq.org/wine/wine/-/merge_requests/3839

3 7

[PATCH 0/1] MR333: vkd3d-shader/hlsl: Add refract() function.
by Nikolay Sivov (＠nsivov) Nov. 7, 2023

Nov. 7, 2023

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/333

4 10

[PATCH v2 0/1] MR234: vkd3d-shader/hlsl: Partially implement Load() for the Buffer object.
by Nikolay Sivov (＠nsivov) Nov. 7, 2023

Nov. 7, 2023

-- v2: vkd3d-shader/hlsl: Partially implement Load() for the Buffer object. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/234

5 5

[PATCH v2 0/5] MR4057: wined3d: Translate sampler states to sampler objects in wined3d_device_apply_stateblock().
by Zebediah Figura (＠zfigura) Nov. 7, 2023

Nov. 7, 2023

-- v2: wined3d: Translate sampler states to sampler objects in wined3d_device_apply_stateblock(). d3d8: Store the texture's parent device as a d3d8_device pointer. wined3d: Pass shader type and unmodified index to context_preload_texture(). wined3d: Handle texture LOD in wined3d_sampler_desc_from_sampler_states(). wined3d: Pass a wined3d_texture to wined3d_sampler_desc_from_sampler_states(). https://gitlab.winehq.org/wine/wine/-/merge_requests/4057

4 7

[PATCH 0/5] MR4173: wined3d/glsl: Handle out-of-bounds vlaues in ftoi/ftou.
by Zebediah Figura (＠zfigura) Nov. 7, 2023

Nov. 7, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4173

3 6

[PATCH 0/7] MR4194: d3d*/tests: Fix various d3d tests on AMD Windows.
by Zebediah Figura (＠zfigura) Nov. 7, 2023

Nov. 7, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4194

4 9

[PATCH 0/1] MR4223: wined3d: Add entry info for NVidia RTX 3070.
by Christian Costa (＠titan) Nov. 7, 2023

Nov. 7, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4223

4 6

[PATCH v5 0/8] MR3810: winegstreamer: Implement add_stream and push_sample for muxer.
by Ziqing Hui (＠zhui) Nov. 7, 2023

Nov. 7, 2023

-- v5: winegstreamer: Implement wg_muxer_push_sample. winegstreamer: Implement ProcessSample for media sink. winegstreamer: Implement wg_muxer_start. winegstreamer: Implement wg_muxer_add_stream. winegstreamer: Introduce create_element_by_factory. winegstreamer: Introduce find_element_factory. winegstreamer: Introduce link_src_to_sink. https://gitlab.winehq.org/wine/wine/-/merge_requests/3810

4 23

[PATCH v3 0/2] MR4232: ntdll: Handle LFH blocks allocated in large blocks in heap_validate_ptr().
by Paul Gofman (＠gofman) Nov. 6, 2023

Nov. 6, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55842 The bug blames commit 059094c1c18ddc33b04eac53a72fd0eb7510be94 ("ntdll: Define heap block's BLOCK_FLAG_LFH as 0x80.") but actually before the blamed commit that worked essentially by chance. The problem the patch is solving is that RtlValidateHeap() currently always fails for LFH blocks allocated from large block memory (vs subheap blocks). That can happen for large enough LFH block sizes. In case of the regressed game the user of RtlValidateHeap() is msvcr80.msvcrt_heap_free() which uses HeapValidate() to guess the heap used to allocate the pointer to free. I am attaching a standalone test program which can be used to reproduce the problem without the patch. [test_lfh_validate.c](/uploads/006b04a9a00ffb7949956b66a275d5cf/test_lfh_validate.c) -- v3: ntdll: Fix pending free block validation in heap_validate() for LFH blocks. ntdll: Handle LFH blocks allocated in large blocks in heap_validate_ptr(). https://gitlab.winehq.org/wine/wine/-/merge_requests/4232

3 5