October 2023 - Wine-GitLab - list.winehq.org

[PATCH v3 0/3] MR4207: gdiplus: Fix GdipAddPathCurve3 curve calculation with offset and nseg variables
by Bartosz Kosiorek (＠gang65) Oct. 31, 2023

Oct. 31, 2023

The MR is divided to three commits: 1. Extend AddPathCurve3 test with offset and nseg variables 2. Moving main curve implementation from GdipAddPathCurve2 to GdipAddPathCurve3, allow for use offset and nseg variables in GdipAddPathCurve3. The offset and nseg variables, will be used for fixing curve calculation in next commit. 3. Fix GdipAddPathCurve3 curve calculation with offset and nseg variables -- v3: gdiplus: Fix GdipAddPathCurve3 curve calculation with offset and nseg variables gdiplus: Move main Curve implementation from GdipAddPathCurve2 to GdipAddPathCurve3 gdiplus/test: Extend AddPathCurve3 test with offset and nseg https://gitlab.winehq.org/wine/wine/-/merge_requests/4207

2 3

[PATCH v7 0/2] MR2740: winemenubuilder: Create .desktop files for programs that open URIs
by Alex Henrie (＠alexhenrie) Oct. 31, 2023

Oct. 31, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=22904 -- v7: winecfg: Mention protocol associations. winemenubuilder: Create .desktop files for programs that open URIs. https://gitlab.winehq.org/wine/wine/-/merge_requests/2740

2 2

[PATCH 0/1] MR4233: winmm: Fix pszSound allocation in PlaySound_Alloc().
by Paul Gofman (＠gofman) Oct. 31, 2023

Oct. 31, 2023

In general, ucrtbase allocation are used here (and later ucrtbase.free for freeing memory). RtlCreateUnicodeStringFromAsciiz() is using RtlAllocateHeap(GetProcessHeap(),...) for allocation. Using ucrtbase.free() may results in freeing from a different heap which leaks the string as best or aborts the program when heap validation is enabled. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4233

2 1

[PATCH v2 0/2] MR4232: ntdll: Handle LFH blocks allocated in large blocks in heap_validate_ptr().
by Paul Gofman (＠gofman) Oct. 31, 2023

Oct. 31, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55842 The bug blames commit 059094c1c18ddc33b04eac53a72fd0eb7510be94 ("ntdll: Define heap block's BLOCK_FLAG_LFH as 0x80.") but actually before the blamed commit that worked essentially by chance. The problem the patch is solving is that RtlValidateHeap() currently always fails for LFH blocks allocated from large block memory (vs subheap blocks). That can happen for large enough LFH block sizes. In case of the regressed game the user of RtlValidateHeap() is msvcr80.msvcrt_heap_free() which uses HeapValidate() to guess the heap used to allocate the pointer to free. I am attaching a standalone test program which can be used to reproduce the problem without the patch. [test_lfh_validate.c](/uploads/006b04a9a00ffb7949956b66a275d5cf/test_lfh_validate.c) -- v2: ntdll: Fix pending free block validation in heap_validate() for LFH blocks. https://gitlab.winehq.org/wine/wine/-/merge_requests/4232

2 2

[PATCH 0/1] MR4232: ntdll: Handle LFH blocks allocated in large blocks in heap_validate_ptr().
by Paul Gofman (＠gofman) Oct. 31, 2023

Oct. 31, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55842 The bug blames commit 059094c1c18ddc33b04eac53a72fd0eb7510be94 ("ntdll: Define heap block's BLOCK_FLAG_LFH as 0x80.") but actually before the blamed commit that worked essentially by chance. The problem the patch is solving is that RtlValidateHeap() currently always fails for LFH blocks allocated from large block memory (vs subheap blocks). That can happen for large enough LFH block sizes. In case of the regressed game the user of RtlValidateHeap() is msvcr80.msvcrt_heap_free() which uses HeapValidate() to guess the heap used to allocate the pointer to free. I am attaching a standalone test program which can be used to reproduce the problem without the patch. [test_lfh_validate.c](/uploads/006b04a9a00ffb7949956b66a275d5cf/test_lfh_validate.c) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4232

2 1

[PATCH v2 0/9] MR432: ir: Validate TEMP registers.
by Giovanni Mascellani (＠giomasce) Oct. 30, 2023

Oct. 30, 2023

-- v2: vkd3d-shader/ir: Validate the index of a TEMP register. vkd3d-shader/ir: Validate the DCL_TEMPS instruction. vkd3d-shader/ir: Validate unused indices in a register. vkd3d-shader/ir: Validate the register index count. vkd3d-shader/ir: Validate the register dimension. vkd3d-shader/ir: Validate the register data type. vkd3d-shader/ir: Validate the register precision. vkd3d-shader/dxil: Use vsir_register_init() to initialize registers. vkd3d-shader: Deduplicate profile version comparison functions. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/432

3 10

[PATCH v3 0/4] MR423: vkd3d: Fix the macOS build.
by Giovanni Mascellani (＠giomasce) Oct. 30, 2023

Oct. 30, 2023

A few recent changes broke the macOS build. Unfortunately nobody noticed, because the macOS CI job always fails. :-( However, we can still fix that. I'm not sure that the last commit is the best approach, would like to have comments from Henri. -- v3: ci: Make the MoltenVK logging less verbose. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/423

3 5

[PATCH 0/2] MR421: spirv: Remove some code no longer used after I/O normalization.
by Zebediah Figura (＠zfigura) Oct. 30, 2023

Oct. 30, 2023

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/421

3 3

Re: [PATCH v2 0/1] MR4226: advapi32/tests: Fix a typo (Coverity). - approved
by Alexandre Julliard (＠julliard) Oct. 30, 2023

Oct. 30, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4226

1 0

Re: [PATCH v2 0/1] MR4205: user32/tests: Improve timer measurement method. - approved
by Alexandre Julliard (＠julliard) Oct. 30, 2023

Oct. 30, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4205

1 0