October 2023 - Wine-GitLab - list.winehq.org

[PATCH v2 0/5] MR4168: cmd: Handle caret / blocks with whitespace only lines better
by userid0x0 (＠userid0x0) Oct. 25, 2023

Oct. 25, 2023

This series of patches is heavily inspired by https://gitlab.winehq.org/wine/wine/-/merge_requests/277 and solves problems related to - whitespace only lines in blocks - EOF in the middle of the blocks - lines with caret followed by EOF -- v2: cmd: Handle whitespace only lines in parentheses blocks - Try 2 Tests cmd: Handle whitespace only lines in parentheses blocks - Try 2 Code https://gitlab.winehq.org/wine/wine/-/merge_requests/4168

4 11

[PATCH 0/1] MR4179: winemac.drv: Disable declaration-after-statement warnings in ObjC files.
by Brendan Shanks (＠bshanks) Oct. 25, 2023

Oct. 25, 2023

Xcode 14.3 (and upstream LLVM 14) fixed [a bug](https://github.com/llvm/llvm-project/issues/51273) where `-Wdeclaration-after-statement` would be ignored when building with C99 or a later language standard. This revealed 22 warnings in ObjC files where variables are declared in the middle of a block. We could simply fix all of these, but declaring variables in the middle of blocks does feel like idiomatic Objective-C (which is why it was done to begin with). It would also mean changes in 22 places. Disabling the warning is the other option. It's not ideal, but using a pragma in each file seems like the best way to do so. (We don't have a way to pass special ObjC-only compiler flags, and even if we did, the '-Wno-declaration-after-statement' would have to come after the '-W', which is fragile.) Alternately, the pragma (guarded by `#ifdef __OBJC__`) could go into a header file included by all files, like `macdrv_cocoa.h`. Opinions/suggestions/comments are welcome. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4179

2 1

[PATCH v2 0/4] MR418: tests/shader-runner: finer control over model ranges and [shader] directive execution for backends, part 1.
by Francisco Casas (＠fcasas) Oct. 25, 2023

Oct. 25, 2023

First part of a series that allows the shader-runner to test SM1 compilation on [shader] directives even if a backend to run these tests is not available and prepare they way for SM1-only tests. Specifically: - Compile [shader] directives separately from backend execution (on part 1). - Allow specifying more detailed shader ranges for todo(), fail() and notimpl() qualifiers (on part 2). - Always test shader compilation with SM1 profiles (on part 2). The `minimum_shader_model` and `maximum_shader_model` parameters for run_shader_tests() are interpreted in the following way: > Ask the pertaining backend to run the shader_test file so that each test is executed with the lowest profile it can support within the range of shader models specified, if any. This allows us to control how many shader models we want to test for each backend, e.g.: ``` run_shader_tests(..., SHADER_MODEL_2_0, SHADER_MODEL_3_0) run_shader_tests(..., SHADER_MODEL_4_0, SHADER_MODEL_5_1) run_shader_tests(..., SHADER_MODEL_6_0, SHADER_MODEL_6_0) ``` versus ``` for (i = SHADER_MODEL_2_0, i <= SHADER_MODEL_6_0, ++i) run_shader_tests(..., i, i); ``` Also, to allow to compile [shader] directives, which are not backend-specific, separately from the [test] directives, which are, the run_shader_tests() function is modified to skip backend specific directives if the shader_runner_ops is NULL. Following patches are on my [master6i](https://gitlab.winehq.org/fcasas/vkd3d/-/commits/master6i) branch. -- v2: tests/shader-runner: Compile [shader] directives separately from backend execution. tests/shader-runner: Decouple run_shader_tests() ranges from those supported by the backend. tests/shader-runner: Discern between the minimum_shader_model and the selected_shader_model. tests/shader-runner: Add missing requirement checks for backends. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/418

4 16

[PATCH v7 0/1] MR4165: gdiplus: Fix transformation in GdipIsOutlineVisiblePathPoint
by Bartosz Kosiorek (＠gang65) Oct. 25, 2023

Oct. 25, 2023

-- v7: gdiplus: Fix transformation in GdipIsOutlineVisiblePathPoint https://gitlab.winehq.org/wine/wine/-/merge_requests/4165

3 2

[PATCH v3 0/6] MR4176: dmusic, dmsynth: Miscellaneous fixes.
by Rémi Bernon Oct. 25, 2023

Oct. 25, 2023

Fixing a couple of flaky tests, a missed change for MIDI time adjustment, as well fixing voice looping that causes notes to end too early. -- v3: dmime: Force recompute MIDI message reference time. dmsynth: Set loop and sample generators on the fluid_voice. dmusic/tests: Skip test_default_gm_collection if gm.dls is missing. dmime/tests: Ignore failure on missing gm.dls in test_band_track_play. dmime/tests: Avoid checking message segment state reference count. dmime/tests: Remove flaky track playing state test. https://gitlab.winehq.org/wine/wine/-/merge_requests/4176

2 9

[PATCH v6 0/1] MR4165: gdiplus: Fix transformation in GdipIsOutlineVisiblePathPoint
by Bartosz Kosiorek (＠gang65) Oct. 25, 2023

Oct. 25, 2023

-- v6: gdiplus: Improve performance of GdipIsOutlineVisiblePathPoint https://gitlab.winehq.org/wine/wine/-/merge_requests/4165

2 3

[PATCH v2 0/1] MR4170: mf: Shutdown media sinks before releasing them.
by Yuxuan Shui (＠yshui) Oct. 25, 2023

Oct. 25, 2023

This probably suppresses !3067 -- v2: mf: Shutdown media sinks before releasing them. https://gitlab.winehq.org/wine/wine/-/merge_requests/4170

4 7

[PATCH v2 0/6] MR4176: dmusic, dmsynth: Miscellaneous fixes.
by Rémi Bernon Oct. 25, 2023

Oct. 25, 2023

Fixing a couple of flaky tests, a missed change for MIDI time adjustment, as well fixing voice looping that causes notes to end too early. -- v2: dmime: Force recompute MIDI message reference time. dmsynth: Set loop and sample generators on the fluid_voice. dmusic/tests: Skip test_default_gm_collection if gm.dls is missing. dmime/tests: Ignore failure on missing gm.dls in test_band_track_play. dmime/tests: Avoid checking message segment state reference count. dmime/tests: Remove flaky track playing state test. https://gitlab.winehq.org/wine/wine/-/merge_requests/4176

2 9

[PATCH v5 0/2] MR4165: gdiplus: Fix transformation in GdipIsOutlineVisiblePathPoint
by Bartosz Kosiorek (＠gang65) Oct. 25, 2023

Oct. 25, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55717 -- v5: gdiplus: Fix transformation in GdipIsOutlineVisiblePathPoint gdiplus/test: Add test for GdipIsOutlineVisiblePathPoint https://gitlab.winehq.org/wine/wine/-/merge_requests/4165

4 11

[PATCH 0/1] MR4177: gdiplus: Improve performance of units_to_pixels by not using division
by Bartosz Kosiorek (＠gang65) Oct. 25, 2023

Oct. 25, 2023

Single float division (divss) is at least four time slower, than multiplication (mulss). More information: https://www.agner.org/optimize/instruction_tables.pdf The units_to_pixels was optimized to use only multiplication (mulss), and avoid using divisions (divss). ![Screenshot_2023-10-25_at_12.15.14](/uploads/4db35ba503b97b070ac20f35e6456445/Screenshot_2023-10-25_at_12.15.14.png) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4177

3 2