October 2023 - Wine-GitLab - list.winehq.org

[PATCH 0/1] MR4126: winex11.drv: Send missed KEYUP events on KeymapNotify.
by Arek Hiler (＠ivyl) Oct. 17, 2023

Oct. 17, 2023

Full focus lost / focus gained events on the Windows side are not feasible for X11's FocusIn/FocusOut events generated by keyboard grabs (see XGrabKeyboard()) that are used for example for Atl+Tab handling. Using them would degrade user's experience by causing the window to minimize or flash multiple times depending on a game/window manager combo. Because of that the programs may miss on some KEYUP events that happen during the grab, and since there are no focus changes on the Windows side the state doesn't get resynced. This change attempts to improve user experience by syncing any missed key release events that happened while the window haven't had focus on the X11 side. There's no syncing of key presses as those are more problematic because of window manager quirks, e.g. on KDE it may end up syncing the Tab press portion of Alt+Tab. Luckily missing key events for keys that were pressed and not released while the WM had the keyboard grab is not nearly as confusing as stuck keys. For Warhammer: Chaosbane, theHunter: Call of the Wild, Far Cry Primal and many other games that end up with stuck Alt after Alt+Tabbing. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4126

2 1

[PATCH 0/9] MR413: Draft: ci: Run the crosstests on Windows.
by Giovanni Mascellani (＠giomasce) Oct. 17, 2023

Oct. 17, 2023

This depends on !412, and might need some finishing touches before being ready. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/413

2 9

Re: [PATCH v2 0/1] MR4107: wbemprox: Use correct string id.
by Hans Leidekker (＠hans) Oct. 17, 2023

Oct. 17, 2023

Hans Leidekker (@hans) commented about dlls/wbemprox/builtin.c: > rec->manufacturer = get_bios_manufacturer( buf, len ); > rec->name = L"Default System BIOS"; > rec->releasedate = get_bios_releasedate( buf, len ); > - rec->serialnumber = get_bios_serialnumber( buf, len ); > + rec->serialnumber = L"Serial number"; You also need to remove COL_FLAG_DYNAMIC from the column definition otherwise free() will be called on a static string. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4107#note_48966

1 0

Re: [PATCH v2 0/1] MR4107: wbemprox: Use correct string id.
by Hans Leidekker (＠hans) Oct. 17, 2023

Oct. 17, 2023

Hans Leidekker (@hans) commented about dlls/wbemprox/builtin.c: > { > const struct smbios_header *hdr; > - const struct smbios_baseboard *baseboard; > UINT offset; > > - if (!(hdr = find_smbios_entry( SMBIOS_TYPE_BASEBOARD, buf, len ))) return NULL; > + if (!(hdr = find_smbios_entry( type, buf, len ))) return NULL; > > - baseboard = (const struct smbios_baseboard *)hdr; > - offset = (const char *)baseboard - buf + baseboard->hdr.length; > - return get_smbios_string( id, buf, offset, len ); > + if (field_offset + sizeof(BYTE) > hdr->length) return NULL; > + > + offset = (const char *)hdr - buf + hdr->length; > + return get_smbios_string_internal( ((const BYTE*)hdr)[field_offset], buf, offset, len ); > } Please add a space before the asterisk. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4107#note_48965

1 0

Re: [PATCH v2 0/1] MR4107: wbemprox: Use correct string id.
by Hans Leidekker (＠hans) Oct. 17, 2023

Oct. 17, 2023

Hans Leidekker (@hans) commented about dlls/wbemprox/builtin.c: > return hdr; > } > > -static WCHAR *get_smbios_string( BYTE id, const char *buf, UINT offset, UINT buflen ) > +static WCHAR *get_smbios_string_internal( BYTE id, const char *buf, UINT offset, UINT buflen ) > { get_smbios_string_by_id() is a better name. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4107#note_48964

1 0

[PATCH 0/1] MR4112: mf/tests: Increase buffer to prevent stack corruption
by Fabian Maurer (＠DarkShadow44) Oct. 17, 2023

Oct. 17, 2023

init_dmo_media_type_video uses head + extra bytes memory, and with MEDIASUBTYPE_RGB8 the extra bytes are already 1024. This leads to stack corruption. Note that not all of those are strictly necessary to prevent a crash, but I think it's safer in case it becomes relevant in the future. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4112

4 6

[PATCH v3 0/16] MR4046: windows.media.mediacontrol: Implement some IMusicDisplayProperties and IMusicDisplayProperties2 properties.
by Mohamad Al-Jaf (＠maljaf) Oct. 17, 2023

Oct. 17, 2023

Called by Roon. -- v3: windows.media.mediacontrol: Return success in ISystemMediaTransportControlsDisplayUpdater::Update(). windows.media.mediacontrol: Implement IMusicDisplayProperties2::get/put_AlbumTitle(). windows.media.mediacontrol/tests: Add IMusicDisplayProperties2::get/put_AlbumTitle() tests. windows.media.mediacontrol: Add IMusicDisplayProperties2 stub interface. include: Add IMusicDisplayProperties2 interface definition. windows.media.mediacontrol: Implement IMusicDisplayProperties::get/put_Artist(). windows.media.mediacontrol/tests: Add IMusicDisplayProperties::get/put_Artist() tests. windows.media.mediacontrol: Implement IMusicDisplayProperties::get/put_Title(). windows.media.mediacontrol/tests: Add IMusicDisplayProperties::get/put_Title() tests. windows.media.mediacontrol: Implement ISystemMediaTransportControlsDisplayUpdater::get_MusicProperties(). include: Add IMusicDisplayProperties interface definition. windows.media.mediacontrol: Implement ISystemMediaTransportControlsDisplayUpdater::get/put_Type(). windows.media.mediacontrol/tests: Add ISystemMediaTransportControlsDisplayUpdater::get/put_Type() tests. windows.media.mediacontrol: Implement ISystemMediaTransportControls::get_DisplayUpdater(). This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/4046

2 2

Re: [PATCH v5 0/8] MR3994: include: Introduce wine_dbgstr_fourcc and debugstr_fourcc.
by Alex Henrie (＠alexhenrie) Oct. 17, 2023

Oct. 17, 2023

On Tue Oct 17 05:34:53 2023 +0000, Nikolay Sivov wrote: > We have a number of debugstr_an(..., 4) used for the same purpose in > different modules. It will give different output if replaced with fourcc > helper, because of isprint(), but still might be worth considering. Thanks for pointing that out. I've started to send merge requests to clean those up. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3994#note_48952

1 0

[PATCH 0/1] MR4121: iccvid: Use debugstr_fourcc instead of debugstr_an.
by Alex Henrie (＠alexhenrie) Oct. 17, 2023

Oct. 17, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4121

2 1

[PATCH 0/2] MR4115: loader: Translate wine.desktop to Catalan.
by Alex Henrie (＠alexhenrie) Oct. 17, 2023

Oct. 17, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4115

2 2