October 2023 - Wine-GitLab - list.winehq.org

Re: [PATCH v4 0/3] MR4168: cmd: Handle caret / blocks with whitespace only lines better - closed
by eric pouech (＠epo) Oct. 27, 2023

Oct. 27, 2023

This merge request was closed by eric pouech. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4168

1 0

[PATCH v4 0/1] MR4133: mfmediaengine: Don't send event notify when engine is shutdown.
by Yuxuan Shui (＠yshui) Oct. 27, 2023

Oct. 27, 2023

-- v4: mfmediaengine: Don't send event notify when engine is shutdown. https://gitlab.winehq.org/wine/wine/-/merge_requests/4133

3 3

[PATCH v2 0/1] MR4198: mf/tests: Test hr before checking propvar.pwszVal.
by Rémi Bernon Oct. 27, 2023

Oct. 27, 2023

Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=55588 -- v2: mf/tests: Avoid crashing if MF_BYTESTREAM_EFFECTIVE_URL is missing. https://gitlab.winehq.org/wine/wine/-/merge_requests/4198

1 2

[PATCH v6 0/3] MR4073: msxml3: Stop possible typelib out of bounds access (Coverity)
by Alistair Leslie-Hughes (＠alesliehughes) Oct. 27, 2023

Oct. 27, 2023

typelib has an array size of 2 (eg LibXml_Last), so a lookup of IID_NULL will result in a lookup of the third index. -- v6: msxml3: Do not leak bind context on error paths (Coverity) https://gitlab.winehq.org/wine/wine/-/merge_requests/4073

3 4

[PATCH 0/1] MR4198: mf/tests: Test hr before checking propvar.pwszVal.
by Rémi Bernon Oct. 27, 2023

Oct. 27, 2023

Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=55588 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4198

2 3

Re: [PATCH v4 0/3] MR4168: cmd: Handle caret / blocks with whitespace only lines better
by userid0x0 (＠userid0x0) Oct. 27, 2023

Oct. 27, 2023

Okay, oh dear. I need to apologize it's the first time I contribute to wine and as always the user learns over time. Now I have the build environment on a Windows 10 Machine set up and I can run the testbench on Windows as well. Cool feature! Lesson learned: I focussed on the unbalanced parentheses case first. Windows quits/ends the complete `cmd` execution if it do a `call block_if_eof1.cmd`. Did you have this case yet? In regards of testing this means I need to setup a own `.cmd`/`.cmd.exp` file again? Lets form a simple setup ``` echo @echo off>block_if_eof1.cmd echo echo sanity1>>block_if_eof1.cmd echo if 1 == 1 (>>block_if_eof1.cmd echo echo should not be executed>>block_if_eof1.cmd call block_if_eof1.cmd REM This command is NEVER executed as cmd exe quited. ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4168#note_49957

1 0

Re: [PATCH v4 0/3] MR4168: cmd: Handle caret / blocks with whitespace only lines better
by userid0x0 (＠userid0x0) Oct. 27, 2023

Oct. 27, 2023

On Thu Oct 26 17:31:50 2023 +0000, eric pouech wrote: > nitpick: you could have saved one line of modif by keeping the == 0x00 > test (instead of rewritten to 0x0) Can fix that as well. No Problem must have happened while fixup. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4168#note_49956

1 0

[PATCH v5 0/3] MR4073: msxml3: Stop possible typelib out of bounds access (Coverity)
by Alistair Leslie-Hughes (＠alesliehughes) Oct. 27, 2023

Oct. 27, 2023

typelib has an array size of 2 (eg LibXml_Last), so a lookup of IID_NULL will result in a lookup of the third index. -- v5: msxml3: Free IBindCtx on error paths (Coverity) msxml3: Move tid_NULL out of possible enum values. msxml3: Dont call qsort if we have no data (Coverity). https://gitlab.winehq.org/wine/wine/-/merge_requests/4073

2 3

[PATCH v4 0/3] MR4073: msxml3: Stop possible typelib out of bounds access (Coverity)
by Alistair Leslie-Hughes (＠alesliehughes) Oct. 26, 2023

Oct. 26, 2023

typelib has an array size of 2 (eg LibXml_Last), so a lookup of IID_NULL will result in a lookup of the third index. -- v4: msxml3: Free IBindCtx on error paths (Coverity) https://gitlab.winehq.org/wine/wine/-/merge_requests/4073

2 3

Re: [PATCH v3 0/3] MR4073: msxml3: Stop possible typelib out of bounds access (Coverity)
by Nikolay Sivov (＠nsivov) Oct. 26, 2023

Oct. 26, 2023

On Fri Oct 27 00:52:11 2023 +0000, Nikolay Sivov wrote: > If it's a matter of silencing typelib[LibXml_Last] access warning, just > change it to LibXml2, and add an assert for tid range in get_typeinfo(). Or maybe just change Last -> LibXml2, without asserts. All the calls are internal, there is more value in keeping this looking close to other modules using the same logic, than trying to fix what can't happen. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4073#note_49942

1 0