November 2023 - Wine-GitLab

Re: [PATCH v2 0/2] MR4490: msxml4/tests: Copy create namespace tests. - approved
by Alexandre Julliard (＠julliard) Nov. 24, 2023

Nov. 24, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4490

1 0

Re: [PATCH v4 0/1] MR4486: shcore: Add stub for RegisterScaleChangeEvent. - approved
by Alexandre Julliard (＠julliard) Nov. 24, 2023

Nov. 24, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4486

1 0

Re: [PATCH v2 0/1] MR4489: winedbg: Use dbghelp extended module info. - approved
by Alexandre Julliard (＠julliard) Nov. 24, 2023

Nov. 24, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4489

1 0

Re: [PATCH v6 0/2] MR4440: regsvr32: Explicitly output of unix fd. - approved
by Alexandre Julliard (＠julliard) Nov. 24, 2023

Nov. 24, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4440

1 0

Re: [PATCH v2 0/2] MR4485: Implement codepages priority for GetStrCodepages - approved
by Alexandre Julliard (＠julliard) Nov. 24, 2023

Nov. 24, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4485

1 0

[PATCH 0/2] MR4493: user32/tests: Add a simpler test for SetParent's internal message.
by Esme Povirk (＠madewokherd) Nov. 24, 2023

Nov. 24, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54037 test_SendMessage_other_thread(2), which is supposed to show that Windows doesn't use an internal sent message for SetParent, tacks this onto another more complex test, which introduces a race condition (see Comment 2 on the bug). I am not sure if it can be fixed in the existing function, perhaps it can and I just can't keep track of all the moving parts well enough, but I see no need to make it so difficult. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4493

3 3

[PATCH v2 0/3] MR4492: configure: Use --no-default-config option on clang when available.
by Jacek Caban (＠jacek) Nov. 24, 2023

Nov. 24, 2023

Some distros arbitrary flags into clang config files without guarding it for applicable targets, which breaks cross compilation. -- v2: winegcc: Support --no-default-config argument. https://gitlab.winehq.org/wine/wine/-/merge_requests/4492

2 3

[PATCH v4 0/2] MR4475: gdiplus: Avoid computation overflow and underflow by using hypotf
by Bartosz Kosiorek (＠gang65) Nov. 24, 2023

Nov. 24, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45123 In `gdiplus/graphicspath.c` calculating the Pythagorean addition is needed, which is defined as: a ⊕ b = sqrt(a^2+b^2) This is hypotenuse, or the length of the longest side of a right-angled triangle, that we know the other 2 sides, a and b. https://en.wikipedia.org/wiki/Pythagorean_addition By using `sqrt(a * a + b * b)`, for large (or small) `a` or `b`, there is a possibility of overflow (underflow), although the result itself is not that big (small) to cause overflow (underflow). To overcome this problem, there are implementations of hypotenuse that do not use power of 2, and use other methods to calculate the result. To calculate `a ⊕ b`, you can easily use `hypotf(a,b)`. https://en.cppreference.com/w/cpp/numeric/math/hypot -- v4: gdiplus/font: Avoid computation overflow and underflow by using hypotf gdiplus/graphicspath: Avoid computation overflow and underflow by using hypotf. https://gitlab.winehq.org/wine/wine/-/merge_requests/4475

3 4

[PATCH 0/3] MR4492: configure: Use --no-default-config option on clang when available.
by Jacek Caban (＠jacek) Nov. 24, 2023

Nov. 24, 2023

Some distros arbitrary flags into clang config files without guarding it for applicable targets, which breaks cross compilation. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4492

2 3

[PATCH 0/1] MR4491: oleaut32: Remove some deadcode from VarMod().
by Nikolay Sivov (＠nsivov) Nov. 24, 2023

Nov. 24, 2023

Always true/false conditions appear to exist since initial implementation was introduced in 2d1bccd0c478274c727de0a531df2da35039e136. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4491

2 1