December 2023 - Wine-GitLab

Re: [PATCH v4 0/1] MR4393: gdiplus: Boost performance of GdipDrawImagePointsRect. - closed
by Esme Povirk (＠madewokherd) Dec. 8, 2023

Dec. 8, 2023

This merge request was closed by Esme Povirk. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4393

1 0

Re: [PATCH v4 0/1] MR4393: gdiplus: Boost performance of GdipDrawImagePointsRect.
by Esme Povirk (＠madewokherd) Dec. 8, 2023

Dec. 8, 2023

I agree, there's no reason to essentially inline floorf here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4393#note_55554

1 0

[PATCH v2 0/2] MR4638: gdiplus: Partially implement GdipDrawImageFX.
by Jinoh Kang (＠iamahuman) Dec. 8, 2023

Dec. 8, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55945 Based on https://gitlab.winehq.org/gang65/wine/-/merge_requests/12. cc/ @gang65 -- v2: gdiplus: Partially implement GdipDrawImageFX. https://gitlab.winehq.org/wine/wine/-/merge_requests/4638

3 7

[PATCH v4 0/4] MR292: vkd3d: Write Vulkan descriptors in a worker thread.
by Conor McCarthy (＠cmccarthy) Dec. 8, 2023

Dec. 8, 2023

-- v4: vkd3d: Co-locate all descriptor-related members. vkd3d: Rename the device mutex to pipeline_cache_mutex. vkd3d: Write Vulkan descriptors in a worker thread. vkd3d: Update the descriptor `next` index before getting a reference for writing. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/292

2 6

Re: [PATCH v6 0/5] MR4593: winewayland.drv: part 11: Mouselook support
by Alexandros Frantzis (＠afrantzis) Dec. 8, 2023

Dec. 8, 2023

On Thu Dec 7 18:47:06 2023 +0000, Rémi Bernon wrote: > Well, code freeze is tomorrow so I don't intend to do anything soon. > You can submit it in a separate MR if you think it's critical for the > well behaving of the driver, and then @julliard will decide what to do > with it, but I would personally wait until we try to fix these > activation issues. Thanks. As a possibly more freeze-safe alternative, I proposed a mitigation in the driver itself https://gitlab.winehq.org/wine/wine/-/merge_requests/4651 . -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4593#note_55533

1 0

[PATCH v2 0/6] MR4625: wined3d: Reduce command stream CPU usage, part 2
by Matteo Bruni (＠Mystral) Dec. 8, 2023

Dec. 8, 2023

These are all the patches in this area that I think make sense at this point in the release cycle (i.e. a couple of days before code freeze...) I originally had many more. A few are not really suitable at this time; a couple turned out to not really make a difference or generally not feeling like it would be an improvement overall. Many ended up in the way (or not in the spirit) of what we probably want to do at some point, which is grouping the whole draw state setup data together with the draw itself. Not that I could find the time to explore that yet... -- v2: wined3d: Add a bunch of d3d_perf traces. wined3d: Add a frametime debug channel. wined3d: Increase WINED3D_CS_QUERY_POLL_INTERVAL to 100. wined3d: Sleep when waiting for the CS thread. wined3d: Do a blocking wait for CS commands even when there are active queries. https://gitlab.winehq.org/wine/wine/-/merge_requests/4625

5 10

Re: [PATCH v6 0/5] MR4593: winewayland.drv: part 11: Mouselook support
by Vlad Zahorodnii (＠zzag) Dec. 8, 2023

Dec. 8, 2023

> I have also seen this with KDE, and my current inclination is to say that this is a compositor problem. Looking at the logs it seems the driver is issuing the proper requests, but the cursor remains visible. Yeah, the wayland log looks okay. ``` [ 858989.759] -> wl_pointer(a)15.set_cursor(172832, nil, 0, 0) [ 858989.762] -> zwp_relative_pointer_manager_v1(a)10.get_relative_pointer(new id zwp_relative_pointer_v1(a)59, wl_pointer(a)15) [ 858990.080] -> wl_compositor(a)4.create_region(new id wl_region(a)57) [ 858990.083] -> wl_region(a)57.add(1280, 720, 0, 0) [ 858990.086] -> zwp_pointer_constraints_v1(a)9.confine_pointer(new id zwp_confined_pointer_v1(a)49, wl_surface(a)3, wl_pointer(a)15, wl_region(a)57, 2) ``` this should work, there's only one pointer enter event and no leave event before. Will check why kwin refuses to hide the cursor. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4593#note_55526

1 0

[PATCH v4 0/1] MR4633: winu32: Fix key state not updating before WH_KEYBOARD hook
by Hans Lehnert (＠hanslehnert) Dec. 8, 2023

Dec. 8, 2023

If a message is removed from the queue with PeekMessage/GetMessage, the key state should get updated before calling the WH_KEYBOARD hooks. -- v4: winu32: Fix key state not updating before WH_KEYBOARD hook https://gitlab.winehq.org/wine/wine/-/merge_requests/4633

3 2

[PATCH v3 0/1] MR4566: ntdll/unix: Add an option to inherit the Unix console handle.
by Aida Jonikienė Dec. 8, 2023

Dec. 8, 2023

I know this breaks Windows behavior but having apps print out special debug messages to the terminal provides a good look into the applications' development (for example I know that NFS Underground has some "done" messages likely used for debugging). I also don't want to keep another revert in my Wine tree just for this one feature either so that's why I'm MR'ing this. I considered adding a registry/winecfg entry for this behavior but it would make this change much larger (and there's no good place in winecfg to put this behavior in). To enable this behavior, you can set WINEDEBUG=+unixcon variable before launching an application. Xkcd-Entry: https://xkcd.com/1172/ Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55435 -- v3: ntdll/unix: Add an option to inherit the Unix console handle. https://gitlab.winehq.org/wine/wine/-/merge_requests/4566

1 3

[PATCH v3 0/15] MR895: msxml3/tests: Filter attributes tests by version.
by Daniel Lehman (＠dlehman25) Dec. 8, 2023

Dec. 8, 2023

Based on patch from Damjan Jovanovic <damjan.jov(a)gmail.com> https://bugs.winehq.org/show_bug.cgi?id=53531 -- v3: msxml3: Handle default namespace in get_namespaceURI. msxml3: Handle default namespace in get_prefix. msxml3: Handle default namespace in get_nodeName. msxml3: Handle default namespace in get_baseName. msxml3: Handle null prefix in get_item. msxml6/tests: Add tests for default namespace. msxml4/tests: Add tests for default namespace. msxml3/tests: Add tests for default namespace. msxml6/tests: Copy create namespace tests. msxml4/tests: Copy create namespace tests. msxml6/tests: Copy namespaces as attributes tests. msxml4/tests: Copy namespaces as attributes tests. msmxl3/tests: Add tests for get_xml. msxml3/tests: Remove msxml6 tests. msxml3/tests: Fix failure messages. https://gitlab.winehq.org/wine/wine/-/merge_requests/895

2 18