December 2023 - Wine-GitLab

Re: [PATCH v2 0/1] MR4617: xml2: Allow encoding name "ISO8859-1".
by Vijay Kiran Kamuju (＠infyquest) Dec. 6, 2023

Dec. 6, 2023

rather than mapping manually internally in msxml, would it be better to use the MIME database registry and its AliasForCharset key. https://learn.microsoft.com/en-us/previous-versions/troubleshoot/msxml/xml-… Please refer to XML Encodings section -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4617#note_55208

1 0

[PATCH v2 0/6] MR4593: winewayland.drv: part 11: Mouselook support
by Alexandros Frantzis (＠afrantzis) Dec. 6, 2023

Dec. 6, 2023

This MR implements mouselook, which requires support for ClipCursor and relative motion events. The latter we can implement directly without using `SetCursorPos` for which no Wayland protocol exists at the moment. 1. Implement setting the foreground window, as this is required for clipping to work properly (i.e., for the ClipCursor driver callback to be called in the proper process/thread, see commit (2)). We can't unconditionally set the foreground window on keyboard focus, since compositors are eager to give the focus and some windows strongly dislike that (see https://gitlab.winehq.org/wine/wine/-/merge_requests/4102#note_51733) This MR borrows the "managed" window concept from WineX11 to detect windows that we shouldn't allow the compositor to manage, and avoids setting such windows as the foreground on keyboard focus. 2. Implement cursor clipping using the pointer-constraints protocol. 3. Switch to emitting relative motion events using the relative-pointer protocol when the cursor is not visible. --- 4. Finally, a potential fix for an issue I have been seeing where apps may transiently lose the active status (see commit message for more) as a result of the foreground state changes in this MR, which has undesirable side-effects. I have included this here for MR completeness/correctness, but it can be moved to a subsequent MR if preferred. Note: the velocity of relative motion events when scaling is involved is somewhat inconsistent among Wayland compositors. Thanks! -- v2: win32u: Don't deactivate the target thread when setting the foreground window. winewayland.drv: Prefer to lock the pointer if the confine area is small. winewayland.drv: Implement relative mouse motion. winewayland.drv: Implement ClipCursor. https://gitlab.winehq.org/wine/wine/-/merge_requests/4593

2 8

Re: [PATCH v2 0/1] MR4617: xml2: Allow encoding name "ISO8859-1".
by Nikolay Sivov (＠nsivov) Dec. 6, 2023

Dec. 6, 2023

For non-standard names, or msxml extensions, we have init_char_encoders(). Please try that first. The library change should be proposed upstream instead. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4617#note_55202

1 0

[PATCH v5 0/5] MR498: server: Allow creating named pipes using \Device\NamedPipe\ as RootDirectory. (#52105)
by Jinoh Kang (＠iamahuman) Dec. 6, 2023

Dec. 6, 2023

On Windows, \Device\NamedPipe\ is the root directory of the named pipe file system (NPFS), and can be used as RootDirectory to skip its path when accessing the NPFS namespace. --- **Note**: `subpath->str` may look hacky, but it's used to indicate trailing `\\`[^bks] and existing code already does it too: - `server/directory.c` checks `name->str`[^dir] to test if this is the last component. This is evident by the fact that changing it to `name->len` will lead to major regression. - `server/registry.c` has similar lookup logic.[^reg1][^reg2] [^bks]: https://gitlab.winehq.org/wine/wine/-/blob/c64aa0006e4a33d755a57a693cd81dc1… [^dir]: https://gitlab.winehq.org/wine/wine/-/blob/c64aa0006e4a33d755a57a693cd81dc1… [^reg1]: <https://gitlab.winehq.org/wine/wine/-/blob/c64aa0006e4a33d755a57a693cd81dc1…> [^reg2]: <https://gitlab.winehq.org/wine/wine/-/blob/c64aa0006e4a33d755a57a693cd81dc1…> -- v5: server: Allow creating named pipes using \Device\NamedPipe\ as RootDirectory. server: Add stub lookup_name implementation for named_pipe_device_file_ops. server: Pass the object subpath to open_file instead of rejecting it. server: Inline open_named_object() call in open_file_object handler. ntdll/tests: Test opening a named pipe with \Device\NamedPipe\ as RootDirectory. https://gitlab.winehq.org/wine/wine/-/merge_requests/498

3 10

[PATCH 0/4] MR513: Release 1.10.
by Henri Verbeet (＠hverbeet) Dec. 6, 2023

Dec. 6, 2023

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/513

3 5

[PATCH 0/1] MR4617: xml2: Allow encoding name "ISO8859-1".
by Bernhard Übelacker Dec. 6, 2023

Dec. 6, 2023

This fixes eFilmLt.exe when running with builtin msxml6. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55804 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4617

1 1

[PATCH 0/1] MR4616: mlang: Allow encoding name "ISO8859-1".
by Bernhard Übelacker Dec. 6, 2023

Dec. 6, 2023

This fixes eFilmLt.exe when running with native msxml6. https://bugs.winehq.org/show_bug.cgi?id=13340 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4616

1 1

[PATCH 0/3] MR4609: winegstreamer: Some tiny fixes
by Alfred Agrell (＠Alcaro) Dec. 6, 2023

Dec. 6, 2023

Just some tiny fixes I found while creating !4449. No functional changes intended. Wine's code review process, and commit history, is a lot more comprehensive than anything else I've seen. This means I can't just write code, submit patch, and call it a day; but it also means the codebase is clean and easy to work with, so fixing bugs and missing pieces is relatively straightforward. While this does increase the total time needed on my side (especially splitting commits), it's easy (though somewhat boring) work, so in total, it's a win. And splitting makes it easier for the maintainers - you have more to do than me, so if it saves your time at the expense of mine, I have no right to complain. Thank you for your patience with my prior MRs. 8.2/10 would contribute again (I've seen a few other games with broken videos that I suspect have still-unfixed causes) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4609

3 5

[PATCH v2 0/1] MR4566: ntdll/unix: Add an option to inherit the Unix console handle.
by Aida Jonikienė Dec. 6, 2023

Dec. 6, 2023

I know this breaks Windows behavior but having apps print out special debug messages to the terminal provides a good look into the applications' development (for example I know that NFS Underground has some "done" messages likely used for debugging). I also don't want to keep another revert in my Wine tree just for this one feature either so that's why I'm MR'ing this. I considered adding a registry/winecfg entry for this behavior but it would make this change much larger (and there's no good place in winecfg to put this behavior in). To enable this behavior, you can set WINEDEBUG=+unixcon variable before launching an application. Xkcd-Entry: https://xkcd.com/1172/ Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55435 -- v2: ntdll/unix: Add an option to inherit the Unix console handle. https://gitlab.winehq.org/wine/wine/-/merge_requests/4566

2 3

Re: [PATCH v2 0/2] MR4608: msvcrt: Demangler C++/CLI related improvements
by eric pouech (＠epo) Dec. 6, 2023

Dec. 6, 2023

@piotr you may also want to update tools/winedump/msmangle.c (it has been synchronized recently with msvcrt code) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4608#note_55184

1 0