February 2023 - Wine-GitLab

[PATCH 0/10] MR2275: winewayland.drv: part 1: Introduce the Wayland driver
by Alexandros Frantzis (＠afrantzis) Feb. 27, 2023

Feb. 27, 2023

Introduction ------------ This is the first of (many) parts in the upstreaming of the Wayland driver for Wine. Since the amount of code and commits is large, my approach is to upstream the driver in multiple parts in a serial fashion, with each part being a cohesive (to the degree possible) set of not too many commits. When each part is reviewed and merged, I will move on to proposing the next part. My main goal with this approach is to make reviewing easier and more focused. If you have other ideas about how to improve this process for the reviewers, please let me know. A lot of pieces need to fall into place before the driver becomes even remotely functional, so, some MRs (especially the initial ones) will be a bit more preparatory in nature. To aid in the understanding of and justification for some of the code introduced in such MRs, all the remaining driver commits are always going to be available at https://gitlab.winehq.org/afrantzis/wine/-/tree/wayland. Part 1 ------- This MR introduces the Wayland driver PE and unixlib components with some basic code, and prepares the makedep tool to be able to handle Wayland protocol files. Please see the individual commit message for more details. Some questions I would appreciate some feedback on in the context of this MR: 1. Should the Wayland driver build be enabled by default at this point? (currently it's explicitly opt-in with --with-wayland) 2. How should the Wayland driver build be integrated with CI? (currently piggybacking on gitlab/build-linux by adding --with-wayland) Note that building the Wayland driver should not affect running/testing on X11/Xwayland etc, since it's placed lower in the driver priority list. Part 2 preview: We will handle basic Wayland wl_output (i.e., display) events and populate the Wine monitor information. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2275

7 21

[PATCH v2 0/1] MR110: vkd3d-shader: Make documentation for "messages" parameters self contained.
by Giovanni Mascellani (＠giomasce) Feb. 27, 2023

Feb. 27, 2023

Otherwise it's not clear which clauses in vkd3d_shader_compile() really apply to other functions. For example, many of the functions currently refering to vkd3d_shader_compile() don't even take a vkd3d_shader_compile_info parameter. -- v2: vkd3d-shader: Make documentation for "messages" parameters self contained. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/110

2 1

[PATCH v3 0/4] MR94: Fix other synchronization problems
by Giovanni Mascellani (＠giomasce) Feb. 27, 2023

Feb. 27, 2023

-- v3: vkd3d: Delete a misleading comment. vkd3d: Mention the correct mutex in a comment. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/94

4 11

[PATCH 0/1] MR2297: winex11: Assume that Xkb extension is available.
by Rémi Bernon Feb. 27, 2023

Feb. 27, 2023

The extension is now part of Xlib. It might be disabled through the `XKB_DISABLE=1` environment variable (https://gitlab.freedesktop.org/xorg/lib/libx11/-/blob/master/src/xkb/XKBUse…) but I don't see why we have to support that case. I think assuming that it is always usable will make the keyboard code simpler, though I have no idea if it exists some environment without it nowadays. All recent desktop environment rely on Xkb to support keyboard layouts, especially when multiple layouts are configured (which are grouped four by four in a single X keyboard mapping, using Xkb groups). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2297

2 2

[PATCH v2 0/1] MR108: vkd3d: Do not pass client-given strings as printf()-style format strings.
by Giovanni Mascellani (＠giomasce) Feb. 27, 2023

Feb. 27, 2023

-- v2: vkd3d-shader: Do not pass client-given strings as printf()-style format strings. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/108

3 2

[PATCH v2 0/6] MR102: hlsl: Matrix majority, 2023 edition, part 2/2.
by Zebediah Figura (＠zfigura) Feb. 27, 2023

Feb. 27, 2023

-- v2: vkd3d-shader/hlsl: Get rid of the check_invalid_matrix_modifiers() helper. vkd3d-shader/hlsl: Apply latent majority modifiers to typedefs as well. vkd3d-shader/hlsl: Do not set an initial latent matrix majority. vkd3d-shader/hlsl: Store the matrix majority as a type modifiers bitmask. vkd3d-shader/hlsl: Apply latent type modifiers to matrix array typedefs. tests: Add more tests for pack_matrix pragmas. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/102

4 10

[PATCH 0/1] MR110: vkd3d-shader: Make documentation for "messages" parameters self contained.
by Giovanni Mascellani (＠giomasce) Feb. 27, 2023

Feb. 27, 2023

Otherwise it's not clear which clauses in vkd3d_shader_compile() really apply to other functions. For example, many of the functions currently refering to vkd3d_shader_compile() don't even take a vkd3d_shader_compile_info parameter. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/110

4 3

[PATCH v2 0/1] MR2297: winex11: Assume that Xkb extension is available.
by Rémi Bernon Feb. 27, 2023

Feb. 27, 2023

The extension is now part of Xlib. It might be disabled through the `XKB_DISABLE=1` environment variable (https://gitlab.freedesktop.org/xorg/lib/libx11/-/blob/master/src/xkb/XKBUse…) but I don't see why we have to support that case. I think assuming that it is always usable will make the keyboard code simpler, though I have no idea if it exists some environment without it nowadays. All recent desktop environment rely on Xkb to support keyboard layouts, especially when multiple layouts are configured (which are grouped four by four in a single X keyboard mapping, using Xkb groups). -- v2: winex11: Assume that Xkb extension is availabe. https://gitlab.winehq.org/wine/wine/-/merge_requests/2297

1 1

[PATCH v12 0/1] MR2262: winspool: Check dmSize in IsValidDevmodeW
by Tingzhong Luo (＠tzluo) Feb. 27, 2023

Feb. 27, 2023

When dmSize is zero or greter than size of input buffer, `IsValidDevmodeW()` failed in Windows 10. But current implementation in wine, it will return `true` because there is no check to `dm.dmSize`. -- v12: winspool: Check dmSize in IsValidDevmodeW() https://gitlab.winehq.org/wine/wine/-/merge_requests/2262

2 1

[PATCH 0/5] MR2296: Chianti
by Giovanni Mascellani (＠giomasce) Feb. 27, 2023

Feb. 27, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2296

2 5