February 2023 - Wine-GitLab

[PATCH v14 0/2] MR2100: ntdll: Do not send data to port 0.
by Jason Beetham (＠beef331) Feb. 8, 2023

Feb. 8, 2023

On Windows it seems sending to port 0 does nothing and does not error. Presently sendmsg errors with EINVAL. This works around it, by checking if it's port 0 then skipping the data. -- v14: ntdll: Do not send data to port 0. https://gitlab.winehq.org/wine/wine/-/merge_requests/2100

2 3

Re: [PATCH v13 0/2] MR2100: ntdll: Do not send data to port 0.
by Zebediah Figura (＠zfigura) Feb. 8, 2023

Feb. 8, 2023

> > but we could return it from the send_socket server request > > Where would I look into this I see the 'macro' call inside `sock_send`, but looking at `send_socket_reply` does not seem to have an protocol attached? It's automatically generated. You'd need to edit protocol.def and then run tools/make_requests. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2100#note_23545

1 0

[PATCH v11 0/2] MR2100: ntdll: Do not send data to port 0.
by Jason Beetham (＠beef331) Feb. 8, 2023

Feb. 8, 2023

On Windows it seems sending to port 0 does nothing and does not error. Presently sendmsg errors with EINVAL. This works around it, by checking if it's port 0 then skipping the data. -- v11: ntdll: Do not send data to port 0. https://gitlab.winehq.org/wine/wine/-/merge_requests/2100

3 3

Re: [PATCH v13 0/2] MR2100: ntdll: Do not send data to port 0.
by Jason Beetham (＠beef331) Feb. 8, 2023

Feb. 8, 2023

> but we could return it from the send_socket server request Where would I look into this I see the 'macro' call inside `sock_send`, but looking at `send_socket_reply` does not seem to have an protocol attached? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2100#note_23543

1 0

[PATCH v3 0/3] MR1895: Fixes for NtOpenFile of read-only files with FILE_WRITE_ATTRIBUTES
by Joel Holdsworth (＠jhol) Feb. 8, 2023

Feb. 8, 2023

Previously, the Wine implementation of `NtOpenFile` would fail to open read-only files for `FILE_WRITE_ATTRIBUTES` access in wine-server, because it would attempt to open the file with `O_RDWR` or `O_WRONLY` access. This patch-set adds test cases to highlight the issue, and solves it by only opening the file with write access where necessary. * Wine Bug: [#50771](https://bugs.winehq.org/show_bug.cgi?id=50771) * Related Wine-Staging Patches: * [0002-server-Allow-to-open-files-without-any-permission-bi.patch](https://gi… * [0006-ntdll-tests-Added-tests-for-open-behaviour-on-readon.patch](https://gi… * [0007-server-FILE_WRITE_ATTRIBUTES-should-succeed-for-read.patch](https://gi… -- v3: server: Allow to open read-only files with FILE_WRITE_ATTRIBUTES https://gitlab.winehq.org/wine/wine/-/merge_requests/1895

3 4

[PATCH v10 0/2] MR2100: ntdll: Do not send data to port 0.
by Jason Beetham (＠beef331) Feb. 8, 2023

Feb. 8, 2023

On Windows it seems sending to port 0 does nothing and does not error. Presently sendmsg errors with EINVAL. This works around it, by checking if it's port 0 then skipping the data. -- v10: ntdll: Do not send data to port 0. ws2_32/tests: Check if sending to port 0 succeeds. https://gitlab.winehq.org/wine/wine/-/merge_requests/2100

3 4

[PATCH v12 0/2] MR2100: ntdll: Do not send data to port 0.
by Jason Beetham (＠beef331) Feb. 8, 2023

Feb. 8, 2023

On Windows it seems sending to port 0 does nothing and does not error. Presently sendmsg errors with EINVAL. This works around it, by checking if it's port 0 then skipping the data. -- v12: ntdll: Do not send data to port 0. https://gitlab.winehq.org/wine/wine/-/merge_requests/2100

3 3

[PATCH 0/1] MR2141: vbscript: Fix memory leak in owned safearray iterator
by Jason Millard (＠jsm174) Feb. 8, 2023

Feb. 8, 2023

While running in XCode's profiler, I noticed memory leaks when safearrays were used in `For Each` statements. The following code would leak a safearray allocation: ``` For Each obj In vpDict.Keys : Debug.Print "Key" : Next ``` This following code does not leak: ``` Dim x x = vpDict.Keys For Each obj In x : Debug.Print "Key" : Next ``` Fixes: https://bugs.winehq.org/show_bug.cgi?id=54456 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2141

2 1

Re: [PATCH v2 0/1] MR2128: ntdll/tests: Remove some Vista broken broken(<constant>) calls.
by Michael Stefaniuc (＠mstefani) Feb. 8, 2023

Feb. 8, 2023

On Wed Feb 8 21:41:13 2023 +0000, Alex Henrie wrote: > I thought we still cared about XP and later (that's what the testbot > supports). Has that changed? WTB might support XP and Vista but those aren't part of the default test set. Nor are they shown on https://test.winehq.org/data/ . The winetest/dissect utility though doesn't marks them as prediluvian. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2128#note_23521

1 0

Re: [PATCH v2 0/1] MR2137: msi: Annotate memory allocation functions with __WINE_(DEALLOC|MALLOC). - approved
by Alexandre Julliard (＠julliard) Feb. 8, 2023

Feb. 8, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2137

1 0