March 2023 - Wine-GitLab - list.winehq.org

Re: [PATCH v7 0/3] MR2449: win32u: Add a few device GPU properties. - approved
by Zhiyi Zhang (＠zhiyi) March 29, 2023

March 29, 2023

This merge request was approved by Zhiyi Zhang. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2449

1 0

[PATCH 0/7] MR2528: taskkill: Support terminating child processes.
by Paul Gofman (＠gofman) March 29, 2023

March 29, 2023

Needed for Epic Online Services updater which invokes taskkill with /T flag and fails to replace a file if that didn't actually killed the processes. There is apparently a bit of refactoring on the way, with most notably using toolhelp snapshot instead of EnumProcesses(). That is more convenient for finding child processes (instead of performing a separate query for parent pid), but I also think that is more consistent in general and gets rid of existing separate query for process name. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2528

3 8

[PATCH 0/2] MR2526: Remove redundant NULL checks before free
by Michael Stefaniuc (＠mstefani) March 28, 2023

March 28, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2526

3 3

[PATCH v5 0/2] MR2231: cfgmgr32: Implement CM_MapCrToWin32Err.
by Mohamad Al-Jaf (＠maljaf) March 28, 2023

March 28, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53781 The Matrix Awakens MegaCity Unreal Engine 5.1 demo and Hogwarts Legacy call this. Duplicate Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54513 -- v5: cfgmgr32/tests: Add CM_MapCrToWin32Err tests. cfgmgr32: Implement CM_MapCrToWin32Err. https://gitlab.winehq.org/wine/wine/-/merge_requests/2231

3 10

Re: [PATCH v6 0/5] MR2483: kernelbase: Add full support for shared Software\Classes keys. - approved
by Alexandre Julliard (＠julliard) March 28, 2023

March 28, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2483

1 0

Re: [PATCH v2 0/11] MR2522: wineps: Add support for more spool file records - approved
by Alexandre Julliard (＠julliard) March 28, 2023

March 28, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2522

1 0

Re: [PATCH v6 0/1] MR2429: msvcrt100: Add stub implementation for _UnrealizedChore::CheckTaskCollection - approved
by Alexandre Julliard (＠julliard) March 28, 2023

March 28, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2429

1 0

Re: [PATCH v2 0/10] MR2520: imm32: More tests and being selecting the IME from ImmLockIMC. - approved
by Alexandre Julliard (＠julliard) March 28, 2023

March 28, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2520

1 0

Re: [PATCH v2 0/1] MR2519: wldap32: Stub out setting LDAP_OPT_REFERRAL_HOP_LIMIT. - approved
by Alexandre Julliard (＠julliard) March 28, 2023

March 28, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2519

1 0

Re: [PATCH v2 0/6] MR2518: Fixes and improvements for taskschd:scheduler - approved
by Alexandre Julliard (＠julliard) March 28, 2023

March 28, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2518

1 0

Re: [PATCH v3 0/3] MR2478: wined3d: Make video memory accounting a per-resource flag. - approved
by Alexandre Julliard (＠julliard) March 28, 2023

March 28, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2478

1 0

[PATCH 0/1] MR2525: wip
by Rémi Bernon March 28, 2023

March 28, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2525

1 3

[PATCH 0/4] MR2523: uiautomationcore: Miscellaneous MSAA provider patches.
by Connor McAdams (＠cmcadams) March 28, 2023

March 28, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2523

4 6

Re: [PATCH v21 0/6] MR1148: ntdll: Mark created files beginning with a dot as not hidden.
by Matteo Bruni (＠Mystral) March 28, 2023

March 28, 2023

I left a few comments on the tests. Otherwise, I quite like the patch series. Force-setting the extended attributes on visible-but-starting-with-a-dot files seems like a good compromise to fix the bug at hand without requiring a ton of attribute setting and I couldn't think of any better solution. This won't fix the case of Wine-created dot files when the show_dot_files option is enabled if the user then disables the option, which again seems like a good compromise. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1148#note_28247

1 0

Re: [PATCH v21 0/6] MR1148: ntdll: Mark created files beginning with a dot as not hidden.
by Matteo Bruni (＠Mystral) March 28, 2023

March 28, 2023

Matteo Bruni (@Mystral) commented about dlls/ntdll/tests/file.c: > + > + status = pNtQueryInformationFile( h, &io, &info, sizeof(info), FileBasicInformation ); > + ok( status == STATUS_SUCCESS, "got %#lx\n", status ); > + ok( info.FileAttributes & FILE_ATTRIBUTE_SYSTEM, "got attributes %#lx\n", info.FileAttributes ); > + ok( !(info.FileAttributes & FILE_ATTRIBUTE_HIDDEN), "got attributes %#lx\n", info.FileAttributes ); > + > + CloseHandle( h ); > + > + GetTempPathW( MAX_PATH, temppathW ); > + GetTempFileNameW( temppathW, L"foo", 0, filenameW ); > + h = CreateFileW( filenameW, GENERIC_READ | GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, FILE_FLAG_DELETE_ON_CLOSE, 0 ); > + ok( h != INVALID_HANDLE_VALUE, "failed to create temp file\n" ); > + if (h == INVALID_HANDLE_VALUE) return; > + > + GetTempFileNameW( temppathW, L".foo", 0, filenameW ); > + if (!rename_file( h, filenameW )) return; ```suggestion:-0+0 winetest_push_context("foo -> .foo"); rename_file( h, filenameW ); winetest_pop_context(); ``` Or something like that. Similarly for the other rename_file() call below. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1148#note_28246

1 0

Re: [PATCH v21 0/6] MR1148: ntdll: Mark created files beginning with a dot as not hidden.
by Matteo Bruni (＠Mystral) March 28, 2023

March 28, 2023

Matteo Bruni (@Mystral) commented about dlls/ntdll/tests/file.c: > + if (!ret) return FALSE; > + > + size = offsetof( FILE_RENAME_INFORMATION, FileName ) + ntpath.Length; > + fri = HeapAlloc( GetProcessHeap(), 0, size ); > + lok( fri != NULL, "HeapAlloc failed\n" ); > + if (!fri) return FALSE; > + fri->ReplaceIfExists = TRUE; > + fri->RootDirectory = NULL; > + fri->FileNameLength = ntpath.Length; > + memcpy( fri->FileName, ntpath.Buffer, ntpath.Length ); > + pRtlFreeUnicodeString( &ntpath ); > + > + status = pNtSetInformationFile( h, &io, fri, size, FileRenameInformation ); > + HeapFree( GetProcessHeap(), 0, fri ); > + lok( status == STATUS_SUCCESS, "got %#lx\n", status ); > + return status == STATUS_SUCCESS; Let's get rid of the return and make the function void. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1148#note_28245

1 0

Re: [PATCH v21 0/6] MR1148: ntdll: Mark created files beginning with a dot as not hidden.
by Matteo Bruni (＠Mystral) March 28, 2023

March 28, 2023

Matteo Bruni (@Mystral) commented about dlls/ntdll/tests/file.c: > + ok( status == STATUS_SUCCESS, "got %#lx\n", status ); > + ok( attrs & FILE_ATTRIBUTE_SYSTEM, "got attributes %#lx\n", attrs ); > + todo_wine ok( !(attrs & FILE_ATTRIBUTE_HIDDEN), "got attributes %#lx\n", attrs ); > + > + status = pNtQueryInformationFile( h, &io, &info, sizeof(info), FileBasicInformation ); > + ok( status == STATUS_SUCCESS, "got %#lx\n", status ); > + ok( info.FileAttributes & FILE_ATTRIBUTE_SYSTEM, "got attributes %#lx\n", info.FileAttributes ); > + ok( !(info.FileAttributes & FILE_ATTRIBUTE_HIDDEN), "got attributes %#lx\n", info.FileAttributes ); > + > + CloseHandle( h ); > + > + GetTempPathW( MAX_PATH, temppathW ); > + GetTempFileNameW( temppathW, L"foo", 0, filenameW ); > + h = CreateFileW( filenameW, GENERIC_READ | GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, FILE_FLAG_DELETE_ON_CLOSE, 0 ); > + ok( h != INVALID_HANDLE_VALUE, "failed to create temp file\n" ); > + if (h == INVALID_HANDLE_VALUE) return; Similarly here, better to get rid of the return entirely. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1148#note_28244

1 0

Re: [PATCH v21 0/6] MR1148: ntdll: Mark created files beginning with a dot as not hidden.
by Matteo Bruni (＠Mystral) March 28, 2023

March 28, 2023

Matteo Bruni (@Mystral) commented about dlls/ntdll/tests/file.c: > +{ > + FILE_RENAME_INFORMATION *fri; > + UNICODE_STRING ntpath; > + IO_STATUS_BLOCK io; > + NTSTATUS status; > + BOOLEAN ret; > + ULONG size; > + > + ret = pRtlDosPathNameToNtPathName_U( filename, &ntpath, NULL, NULL ); > + lok( ret, "RtlDosPathNameToNtPathName_U failed\n" ); > + if (!ret) return FALSE; > + > + size = offsetof( FILE_RENAME_INFORMATION, FileName ) + ntpath.Length; > + fri = HeapAlloc( GetProcessHeap(), 0, size ); > + lok( fri != NULL, "HeapAlloc failed\n" ); > + if (!fri) return FALSE; Same here for this HeapAlloc() call with very small size. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1148#note_28243

1 0

Re: [PATCH v21 0/6] MR1148: ntdll: Mark created files beginning with a dot as not hidden.
by Matteo Bruni (＠Mystral) March 28, 2023

March 28, 2023

Matteo Bruni (@Mystral) commented about dlls/ntdll/tests/file.c: > } > > +#define lok ok_(__FILE__, line) > +#define rename_file(h,f) rename_file_(__LINE__,(h),(f)) > +static BOOL rename_file_( int line, HANDLE h, const WCHAR *filename ) > +{ > + FILE_RENAME_INFORMATION *fri; > + UNICODE_STRING ntpath; > + IO_STATUS_BLOCK io; > + NTSTATUS status; > + BOOLEAN ret; > + ULONG size; > + > + ret = pRtlDosPathNameToNtPathName_U( filename, &ntpath, NULL, NULL ); > + lok( ret, "RtlDosPathNameToNtPathName_U failed\n" ); > + if (!ret) return FALSE; Please get rid of the ok() and if() {}, we can just assume that the RtlDosPathNameToNtPathName_U() call works correctly (i.e. if it fails we have bigger problems and arguably crashing and burning is better than reporting a failure and silently skipping the test). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1148#note_28242

1 0

Re: [PATCH v21 0/6] MR1148: ntdll: Mark created files beginning with a dot as not hidden.
by Matteo Bruni (＠Mystral) March 28, 2023

March 28, 2023

Matteo Bruni (@Mystral) commented about dlls/ntdll/tests/file.c: > CloseHandle( h ); > } > > +#define lok ok_(__FILE__, line) > +#define rename_file(h,f) rename_file_(__LINE__,(h),(f)) > +static BOOL rename_file_( int line, HANDLE h, const WCHAR *filename ) I'd avoid these line shenanigans, we now have test contexts to disambiguate ok() calls from different tests. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1148#note_28241

1 0

[PATCH 0/5] MR2524: msvcrt: _StructuredTaskCollection cancelling
by Torge Matthies (＠tmatthies) March 28, 2023

March 28, 2023

Some refactoring + implementation of `_StructuredTaskCollection::_Cancel` and `_StructuredTaskCollection::_IsCanceling`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2524

2 6

[PATCH v2 0/8] MR1979: msvcrt: Remaining implementations and stubs for cm3
by Torge Matthies (＠tmatthies) March 28, 2023

March 28, 2023

Based on !2524. This adds the remaining stubs needed for Crazy Machines 3 to work and decode preview images correctly in online mode. -- v2: msvcr110: Add _Context::_IsSynchronouslyBlocked stub. msvcr110: Add _Cancellation_beacon::_Cancellation_beacon_dtor stub. msvcr110: Add _Cancellation_beacon::_Cancellation_beacon_ctor stub. msvcr100: Implement _StructuredTaskCollection::_IsCanceling. msvcr100: Implement _StructuredTaskCollection canceling. msvcr100: Use enum for _StructuredTaskCollection status bits. msvcr100: Use enum for _StructuredTaskCollection return value. msvcr100: Only wake task collection waiters when finished >= count. https://gitlab.winehq.org/wine/wine/-/merge_requests/1979

2 8

[PATCH 0/5] MR1979: msvcrt: Remaining implementations and stubs for cm3
by Torge Matthies (＠tmatthies) March 28, 2023

March 28, 2023

This adds the remaining `_StructuredTaskCollection` functions and other stubs needed for Crazy Machines 3 to work and decode preview images correctly in online mode. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1979

3 15

[PATCH v6 0/3] MR2449: win32u: Add a few device GPU properties.
by Paul Gofman (＠gofman) March 28, 2023

March 28, 2023

Diablo IV (closed beta) depends on DEVPKEY_Device_MatchingDeviceId being present for GPUs (once it is able to match GPU luid to the one obtained from dxgi). It also depends on the MatchingDeviceId conating "ven_" and "dev_" substrings. Without those it doesn't consider the gpu as valid, which currently results in the game complaining about no GPUs found. I guess that maybe it is trying to filter out software GPUs and such this way. As far as my testing goes, DEVPKEY_Device_MatchingDeviceId has this form with hardware GPUs only and maybe with the recent enough Win10 or Win11. The other two device properties being added are also queried by the game although they are not strictly needed for it. -- v6: win32u: Set DEVPKEY_Device_RemovalPolicy for GPUs. win32u: Set DEVPKEY_Device_BusNumber for GPUs. win32u: Set DEVPKEY_Device_MatchingDeviceId for GPUs. https://gitlab.winehq.org/wine/wine/-/merge_requests/2449

3 6

[PATCH v5 0/5] MR2483: kernelbase: Add full support for shared Software\Classes keys.
by Sven Baars (＠sbaars) March 28, 2023

March 28, 2023

I initially wanted to do the refactoring in a separate merge request, but since my merge request yesterday broke the tests, I decided to add the implementation into this commit as well. -- v5: kernelbase: Recursively obtain the Wow6432Node parent. kernelbase: Add support for shared registry keys. kernelbase: Call create_key() from create_subkey(). kernelbase: Factor creating a subkey out of create_key(). kernelbase: Don't open Wow6432nodes from create_key(). https://gitlab.winehq.org/wine/wine/-/merge_requests/2483

2 6

[PATCH v7 0/3] MR1895: Fixes for NtOpenFile of read-only files with FILE_WRITE_ATTRIBUTES
by Joel Holdsworth (＠jhol) March 28, 2023

March 28, 2023

Previously, the Wine implementation of `NtOpenFile` would fail to open read-only files for `FILE_WRITE_ATTRIBUTES` access in wine-server, because it would attempt to open the file with `O_RDWR` or `O_WRONLY` access. This patch-set adds test cases to highlight the issue, and solves it by ~~only opening the file with write access where necessary~~ temporarily modifying file access permisions to allow the file to be opened. * Wine Bug: [#50771](https://bugs.winehq.org/show_bug.cgi?id=50771) * Related Wine-Staging Patches: * [0002-server-Allow-to-open-files-without-any-permission-bi.patch](https://gi… * [0006-ntdll-tests-Added-tests-for-open-behaviour-on-readon.patch](https://gi… * [0007-server-FILE_WRITE_ATTRIBUTES-should-succeed-for-read.patch](https://gi… -- v7: server: Allow to open files without permission bits. https://gitlab.winehq.org/wine/wine/-/merge_requests/1895

3 5

[PATCH 0/11] MR2522: wineps: Add support for more spool file records
by Piotr Caban (＠piotr) March 28, 2023

March 28, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2522

3 12

[PATCH v5 0/1] MR2429: msvcrt100: Add stub implementation for _UnrealizedChore::CheckTaskCollection
by Vijay Kiran Kamuju (＠infyquest) March 28, 2023

March 28, 2023

Add stub implementation for _UnrealizedChore::CheckTaskCollection https://bugs.winehq.org/show_bug.cgi?id=53794 -- v5: msvcr100: Add _UnrealizedChore::_CheckTaskCollection stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/2429

3 3

[PATCH v3 0/1] MR2482: dwrite: Use cache when font transform matrix contains only translation offsets.
by Zhiyi Zhang (＠zhiyi) March 28, 2023

March 28, 2023

Word 2016 queries a lot of font glyph bounding boxes and bitmaps with translation matrices. The result of these queries is not cached because the transform matrix is not the identity matrix. However, the translation offsets don't affect FreeType font operations at all, which can be verified in ft_matrix_from_dwrite_matrix() called by get_glyph_transform(). So these results with translation matrices can be cached as well. With this patch, Word 2016 stuttering is reduced significantly. -- v3: dwrite: Use cache when font transform matrix contains only translation offsets. https://gitlab.winehq.org/wine/wine/-/merge_requests/2482

3 3

[PATCH 0/10] MR2520: imm32: More tests and being selecting the IME from ImmLockIMC.
by Rémi Bernon March 28, 2023

March 28, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2520

3 14

[PATCH v6 0/4] MR1895: Fixes for NtOpenFile of read-only files with FILE_WRITE_ATTRIBUTES
by Joel Holdsworth (＠jhol) March 28, 2023

March 28, 2023

Previously, the Wine implementation of `NtOpenFile` would fail to open read-only files for `FILE_WRITE_ATTRIBUTES` access in wine-server, because it would attempt to open the file with `O_RDWR` or `O_WRONLY` access. This patch-set adds test cases to highlight the issue, and solves it by only opening the file with write access where necessary. * Wine Bug: [#50771](https://bugs.winehq.org/show_bug.cgi?id=50771) * Related Wine-Staging Patches: * [0002-server-Allow-to-open-files-without-any-permission-bi.patch](https://gi… * [0006-ntdll-tests-Added-tests-for-open-behaviour-on-readon.patch](https://gi… * [0007-server-FILE_WRITE_ATTRIBUTES-should-succeed-for-read.patch](https://gi… -- v6: server: Allow to open read-only files with FILE_WRITE_ATTRIBUTES server: Open files for writing with O_WRONLY not O_RDWR if FILE_READ_ATTRIBUTES is also requested https://gitlab.winehq.org/wine/wine/-/merge_requests/1895

4 9

[PATCH v10 0/3] MR741: ntdll: Implement NtFlushProcessWriteBuffers.
by Torge Matthies (＠tmatthies) March 28, 2023

March 28, 2023

Based on [a patch](https://www.winehq.org/mailman3/hyperkitty/list/wine-devel(a)winehq.… by Jinoh Kang (@iamahuman) from February 2022. I removed the need for the event object and implemented fast paths for Linux. On macOS 10.14+ `thread_get_register_pointer_values` is called on every thread of the process. On Linux 4.14+ `membarrier(MEMBARRIER_CMD_GLOBAL_EXPEDITED, ...)` is used. On x86 Linux <= 4.13 and on other platforms `madvise(..., MADV_DONTNEED)` is used, which sends IPIs to all cores causing them to do a memory barrier. -- v10: ntdll: Add thread_get_register_pointer_values-based implementation of NtFlushProcessWriteBuffers. ntdll: Add sys_membarrier-based implementation of NtFlushProcessWriteBuffers. ntdll: Add MADV_DONTNEED-based implementation of NtFlushProcessWriteBuffers. https://gitlab.winehq.org/wine/wine/-/merge_requests/741

2 3

[PATCH 0/1] MR2418: ucrtbase: adding CxxFrameHandler4 to spec
by James McDonnell (＠ElementalWarrior) March 28, 2023

March 28, 2023

Add missing function to spec for affinity photo -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2418

3 4

[PATCH 0/1] MR2519: wldap32: Stub out setting LDAP_OPT_REFERRAL_HOP_LIMIT.
by Alex Henrie (＠alexhenrie) March 28, 2023

March 28, 2023

https://bugs.winehq.org/show_bug.cgi?id=54727 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2519

3 2

[PATCH 0/1] MR2521: msado15: Handle DBTYPE_STR type when loading recordset data
by Alistair Leslie-Hughes (＠alesliehughes) March 28, 2023

March 28, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2521

3 2

[PATCH v2 0/7] MR2476: winewayland.drv: part 2: Display configuration enhancements
by Alexandros Frantzis (＠afrantzis) March 28, 2023

March 28, 2023

This second MR in the Wayland series adds display configuration related enhancements, including providing more display information (like a proper/consistent name and position) to Wine and implementing GetCurrentDisplaySettings. To get additional information from the Wayland compositor we need to use a protocol from the wayland-protocols collection, so we introduce support in the build system for protocol .xml files. These changes are introduced on their own in the first commit in the series, but we can squash it with the next commit, where the functionality is first used, if preferred. To be able to provide a consistent view of the display settings across all processes, this MR adds a shared memory region containing an authoritative version of the Wayland output information (see the "winewayland.drv: Implement GetCurrentDisplaySettings." commit for more details). Thanks! -- v2: winewayland.drv: Update desktop window size on display changes. winewayland.drv: Update registry settings after monitor changes. winewayland.drv: Infer and report Windows monitor positions. winewayland.drv: Handle wl_output objects only in the desktop process. winewayland.drv: Implement GetCurrentDisplaySettings. winewayland.drv: Use the output name reported by the compositor. tools: Support building Wayland protocol source files. https://gitlab.winehq.org/wine/wine/-/merge_requests/2476

5 20

[PATCH v2 0/1] MR2521: msado15: Handle DBTYPE_STR type when loading recordset data
by Alistair Leslie-Hughes (＠alesliehughes) March 28, 2023

March 28, 2023

-- v2: msado15: Handle DBTYPE_STR type when loading recordset data https://gitlab.winehq.org/wine/wine/-/merge_requests/2521

2 1

[PATCH v11 0/1] MR2183: winecfg: Add an option to set WinRT app dark theme.
by Mohamad Al-Jaf (＠maljaf) March 28, 2023

March 28, 2023

This is what it looks like: ![Screenshot_20230310_015941](/uploads/99b3d279bcddbd40212808a045444a7b/Screenshot_20230310_015941.png) -- v11: winecfg: Add an option to set WinRT app dark theme. https://gitlab.winehq.org/wine/wine/-/merge_requests/2183

2 2

[PATCH v4 0/4] MR2387: winegstreamer: Use codec format in stream_props_GetMediaType.
by Ziqing Hui (＠zhui) March 28, 2023

March 28, 2023

According to the tests in 23b72ad, when we are reading a compressed stream, the type returned by `stream_props_GetMediaType()` should reflect compressed format even if we finnally output uncomressed data. For example, if we use wmvcore reader to read a WMV3 stream and output RGB24, the format information returned by `stream_props_GetMediaType()` should be WMV3, not RGB24. This patch set is marked as draft now, because PATCH 2 and PATCH 3 is affected by 3e8936a2 in MR !2258. So I'll submit a newer version of this after !2258 get merged. -- v4: winegstreamer: Use codec format in stream_props_GetMediaType. winegstreamer: Implement amt_from_wg_format_video_wmv. winegstreamer: Implement wg_format_from_caps_video_wmv. winegstreamer: Implement wg_parser_stream_get_codec_format. https://gitlab.winehq.org/wine/wine/-/merge_requests/2387

3 5

[PATCH 0/6] MR2518: Fixes and improvements for taskschd:scheduler
by Francois Gouget (＠fgouget) March 28, 2023

March 28, 2023

* Deleting tasks & folders requires elevated privileges on Windows 7. * Elevated privileges are needed to connect using a hostname. * Use a winetest context in the scheduler loops. * Use wide character string literals in scheduler.c. * Store the xml definitions as wide string literals in scheduler.c. * Use __HRESULT_FROM_WIN32() to initialize constants. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2518

2 6

[PATCH v5 0/3] MR2449: win32u: Add a few device GPU properties.
by Paul Gofman (＠gofman) March 28, 2023

March 28, 2023

Diablo IV (closed beta) depends on DEVPKEY_Device_MatchingDeviceId being present for GPUs (once it is able to match GPU luid to the one obtained from dxgi). It also depends on the MatchingDeviceId conating "ven_" and "dev_" substrings. Without those it doesn't consider the gpu as valid, which currently results in the game complaining about no GPUs found. I guess that maybe it is trying to filter out software GPUs and such this way. As far as my testing goes, DEVPKEY_Device_MatchingDeviceId has this form with hardware GPUs only and maybe with the recent enough Win10 or Win11. The other two device properties being added are also queried by the game although they are not strictly needed for it. -- v5: win32u: Set DEVPKEY_Device_RemovalPolicy for GPUs. win32u: Set DEVPKEY_Device_BusNumber for GPUs. https://gitlab.winehq.org/wine/wine/-/merge_requests/2449

3 4

[PATCH v2 0/3] MR2478: wined3d: Make video memory accounting a per-resource flag.
by Stefan Dösinger March 27, 2023

March 27, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54701 --- The private draw texture did not get evicted on reset(), causing us to try to read from a non-existent texture with the new contest. For more details see comment 9 on the bug. -- v2: ddraw/tests: Show that SYSMEM | 3DDEVICE surfaces don't consume vidmem. ddraw/tests: Native 64 bit ddraw has a video memory leak. wined3d: Make video memory accounting a per-resource flag. https://gitlab.winehq.org/wine/wine/-/merge_requests/2478

3 7

[PATCH v6 0/10] MR124: vkd3d-shader/hlsl: Introduce hlsl_ir_index, part 1/2.
by Francisco Casas (＠fcasas) March 27, 2023

March 27, 2023

This node type is intended for use during parse-time. While we parse an indexing expression such as `a[3]`, we don't know if it will end up as part of an expression (in which case it must be folded into a load) or it is for the lhs of a store (in which case it must be folded into the store's deref). This node type is used to represent these accesses and no longer rely on building an `hlsl_ir_load` for each array index or struct record access. `hlsl_ir_index` chains are lowered into derefs when (and if) they are used to specify the lhs of an assignment. All `hlsl_ir_index`es are lowered into `hlsl_ir_load`s with a compilation pass. The changes introduced in these series allow to solve the problem with the return variable of function calls presented in !93, and to properly support assignment to matrix indexes, which is something we are not doing correctly. Further patches (in my [index node](https://gitlab.winehq.org/fcasas/vkd3d/-/commits/index_node) branch) add support for indexing non-load expressions, such as `(a + b)[1]` and allowing to represent resource loads through `hlsl_ir_index`, so that `hlsl_ir_resource_store`s don't have to rely on `hlsl_ir_resource_load`s. -- v6: vkd3d-shader/hlsl: Evaluate index before array. vkd3d-shader/hlsl: Support column-major matrix indexing in the lhs. vkd3d-shader/hlsl: Always load from a synthetic copy in add_load_component(). vkd3d-shader/hlsl: Remove add_load_index(). vkd3d-shader/hlsl: Use hlsl_ir_index for array and record access. vkd3d-shader/hlsl: Introduce hlsl_ir_index. tests: Test indexing of non-loads. tests: Test side effects on indexes. tests: Test matrix indexing on the lhs. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/124

4 12

[PATCH v14 0/6] MR1145: kernel32: Implement various transacted file APIs.
by Etaash Mathamsetty (＠etaash.mathamsetty) March 27, 2023

March 27, 2023

a hotfix for the recent release of Persona 5 Royal. -- v14: kernel32: Add semi-stub for RemoveDirectoryTransactedA/W(). kernel32: Add semi-stub for GetFileAttributesTransactedA/W(). kernel32: Add semi-stub for FindFirstFileTransactedA/W(). kernel32: Add semi-stub for DeleteFileTransactedA/W(). kernel32: Add semi-stub for CreateDirectoryTransactedA/W(). kernel32: Add semi-stub for CreateFileTransactedA/W(). https://gitlab.winehq.org/wine/wine/-/merge_requests/1145

2 6

[PATCH 0/1] MR2498: msado15: Implement _Recordset Find
by Alistair Leslie-Hughes (＠alesliehughes) March 27, 2023

March 27, 2023

Find only supports one Column to filter on. The parser for this will be the same for both Find/Filter with the only different is the Filter supports multiple columns. In trying to keep this patch small, only WSTR/BSTR/Integer have been supported. (The Common cases). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2498

3 22

Re: [PATCH v4 0/7] MR2511: dinput: More tests and fixes for BuildActionMap and EnumDevicesBySemantics. - approved
by Alexandre Julliard (＠julliard) March 27, 2023

March 27, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2511

1 0

Re: [PATCH v3 0/4] MR2470: uiautomationcore: Fix/extend some tests, implement UIA_ProviderDescriptionPropertyId. - approved
by Alexandre Julliard (＠julliard) March 27, 2023

March 27, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2470

1 0

Re: [PATCH v3 0/1] MR2508: wldap32: Implement setting LDAP_OPT_SSL and add tests. - approved
by Alexandre Julliard (＠julliard) March 27, 2023

March 27, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2508

1 0

Re: [PATCH v2 0/5] MR2516: Fixes and improvements for schedsvc:rpcapi - approved
by Alexandre Julliard (＠julliard) March 27, 2023

March 27, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2516

1 0

Re: [PATCH v2 0/2] MR2517: schtasks/tests: Deleting folders requires elevated privileges on Windows 7 & 8. - approved
by Alexandre Julliard (＠julliard) March 27, 2023

March 27, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2517

1 0

Re: [PATCH v2 0/1] MR2513: win32u: Fix printf format warnings. - approved
by Alexandre Julliard (＠julliard) March 27, 2023

March 27, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2513

1 0

Re: [PATCH v2 0/1] MR2514: widl: error_loc() messages must have a trailing linefeed. - approved
by Alexandre Julliard (＠julliard) March 27, 2023

March 27, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2514

1 0

Re: [PATCH v2 0/1] MR2515: imm32/tests: Document the WINE_LANGID value. - approved
by Alexandre Julliard (＠julliard) March 27, 2023

March 27, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2515

1 0

Re: [PATCH v2 0/1] MR2503: windows.media.speech/tests: Allow recognizer state to be idle during active recognition session. - approved
by Alexandre Julliard (＠julliard) March 27, 2023

March 27, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2503

1 0

Re: [PATCH v4 0/1] MR2502: wine.inf.in: Add EditionID to HKEY_LOCAL_MACHINE\Software\Microsoft\Windows NT\CurrentVersion - approved
by Alexandre Julliard (＠julliard) March 27, 2023

March 27, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2502

1 0

Re: [PATCH v3 0/1] MR2505: iphlpapi: Return FALSE for bad handles in IcmpCloseHandle - approved
by Alexandre Julliard (＠julliard) March 27, 2023

March 27, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2505

1 0

Re: [PATCH v2 0/1] MR2510: widl: Define PARSER_LTYPE instead of api.location.type. - approved
by Alexandre Julliard (＠julliard) March 27, 2023

March 27, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2510

1 0

Re: [PATCH v2 0/1] MR2499: hidparse.sys: Include zero-count reports in cap count - approved
by Alexandre Julliard (＠julliard) March 27, 2023

March 27, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2499

1 0

Re: [PATCH v3 0/5] MR2490: graphicscapture: Partially implement IGraphicsCaptureSessionStatics::IsSupported(). - approved
by Alexandre Julliard (＠julliard) March 27, 2023

March 27, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2490

1 0

Re: [PATCH v2 0/1] MR2509: include: Fix c++ compiler error with msxml2.idl. - approved
by Alexandre Julliard (＠julliard) March 27, 2023

March 27, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2509

1 0

Re: [PATCH v2 0/13] MR2504: wineps: Support more drawing primitives in print processor. - approved
by Alexandre Julliard (＠julliard) March 27, 2023

March 27, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2504

1 0

Re: [PATCH v2 0/1] MR2506: ucrtbase: Add __CxxFrameHandler4 implementation. - approved
by Alexandre Julliard (＠julliard) March 27, 2023

March 27, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2506

1 0

[PATCH v2 0/2] MR93: Draft: vkd3d-shader/hlsl: Fix assumptions in add_load_index() and add_load_component().
by Francisco Casas (＠fcasas) March 27, 2023

March 27, 2023

Currently, we can't use `add_load_index()` or `add_load_component()` on the loads to the `"retval"` variables that come from `add_call()` because these functions assume that the loaded value (`var_instr`) won't change between its location and the location and the new load to be created. We can't get rid of this assumptions either, because, at least `add_load_index()` may be used in the lhs of an assignment, and in that case we can't store to the "deref" synthetic: ``` x[0] = 20; ``` Here I implemented the alternative solution of copying `"retval"` into a synthetic variable after each function call, but we may want to discuss this approach. -- v2: https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/93

3 10

Re: [PATCH v4 0/108] MR2402: Release 7.0.2 - approved
by Alexandre Julliard (＠julliard) March 27, 2023

March 27, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2402

1 0

[PATCH v3 0/108] MR2402: Release 7.0.2
by Michael Stefaniuc (＠mstefani) March 27, 2023

March 27, 2023

-- v3: Release 7.0.2. gitlab: Add workaround for more strict git ownership check. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/2402

1 1

[PATCH v5 0/10] MR124: vkd3d-shader/hlsl: Introduce hlsl_ir_index, part 1/2.
by Francisco Casas (＠fcasas) March 27, 2023

March 27, 2023

This node type is intended for use during parse-time. While we parse an indexing expression such as `a[3]`, we don't know if it will end up as part of an expression (in which case it must be folded into a load) or it is for the lhs of a store (in which case it must be folded into the store's deref). This node type is used to represent these accesses and no longer rely on building an `hlsl_ir_load` for each array index or struct record access. `hlsl_ir_index` chains are lowered into derefs when (and if) they are used to specify the lhs of an assignment. All `hlsl_ir_index`es are lowered into `hlsl_ir_load`s with a compilation pass. The changes introduced in these series allow to solve the problem with the return variable of function calls presented in !93, and to properly support assignment to matrix indexes, which is something we are not doing correctly. Further patches (in my [index node](https://gitlab.winehq.org/fcasas/vkd3d/-/commits/index_node) branch) add support for indexing non-load expressions, such as `(a + b)[1]` and allowing to represent resource loads through `hlsl_ir_index`, so that `hlsl_ir_resource_store`s don't have to rely on `hlsl_ir_resource_load`s. -- v5: vkd3d-shader/hlsl: Evaluate index before array. vkd3d-shader/hlsl: Support column-major matrix indexing in the lhs. vkd3d-shader/hlsl: Always load from a synthetic copy in add_load_component(). vkd3d-shader/hlsl: Remove add_load_index(). vkd3d-shader/hlsl: Use hlsl_ir_index for array and record access. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/124

4 13

Re: [PATCH v4 0/5] MR2483: kernelbase: Add full support for shared Software\Classes keys.
by Alexandre Julliard (＠julliard) March 27, 2023

March 27, 2023

Alexandre Julliard (@julliard) commented about dlls/kernelbase/registry.c: > return (len >= 11 && !wcsnicmp( name->Buffer, L"Wow6432Node\\", min( len, 12 ) )); > } > > -/* open the Wow6432Node subkey of the specified key */ > +static BOOL is_classes_root( const UNICODE_STRING *name ) > +{ > + return (name->Length >= wcslen(root_key_names[0]) * sizeof(WCHAR) && !wcsnicmp( name->Buffer, root_key_names[0], wcslen(root_key_names[0]) )); You again have to check the string terminator, matching a substring is not sufficient. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2483#note_27986

1 0

[PATCH v2 0/4] MR2470: uiautomationcore: Fix/extend some tests, implement UIA_ProviderDescriptionPropertyId.
by Connor McAdams (＠cmcadams) March 27, 2023

March 27, 2023

This should lower the test todo count substantially. -- v2: uiautomationcore: Add support for UIA_ProviderDescriptionPropertyId. https://gitlab.winehq.org/wine/wine/-/merge_requests/2470

3 6

[PATCH v2 0/1] MR2508: wldap32: Implement setting LDAP_OPT_SSL and add tests.
by Alex Henrie (＠alexhenrie) March 27, 2023

March 27, 2023

Windows has the LDAP_OPT_SSL option to turn SSL on or off after calling ldap_init but before connecting to the server. OpenLDAP doesn't have that option and instead expects a fully SSL connection to be requested by passing one or more "ldaps://" URIs to ldap_init. However, OpenLDAP also has an LDAP_OPT_URI option, which Windows does not have, that can be used to change the URIs before connecting. And OpenLDAP already takes care of converting "ldap://" or "ldaps://" to lowercase, so all we have to do is find and replace that exact string in each URI in the list. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54727 -- v2: wldap32: Implement setting LDAP_OPT_SSL and add tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/2508

4 3

[PATCH 0/1] MR2513: win32u: Fix printf format warnings.
by Huw Davies (＠huw) March 27, 2023

March 27, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2513

3 2

[PATCH 0/1] MR2514: widl: error_loc() messages must have a trailing linefeed.
by Francois Gouget (＠fgouget) March 27, 2023

March 27, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2514

3 2

[PATCH 0/1] MR2515: imm32/tests: Document the WINE_LANGID value.
by Francois Gouget (＠fgouget) March 27, 2023

March 27, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2515

3 2

[PATCH 0/2] MR2517: schtasks/tests: Deleting folders requires elevated privileges on Windows 7 & 8.
by Francois Gouget (＠fgouget) March 27, 2023

March 27, 2023

This means skipping any test that requires creating a task as the test would be unable to clean up after itself. Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=52193 Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=54634 ---- taskschd:scheduler is able to delete folders without elevated privileges on Windows 8 but apparently not schtasks.exe:schtasks. There must be something different but I don't know what :-( I guess we don't care much about this special case so this patch just skips bluntly. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2517

2 2

[PATCH 0/5] MR2516: Fixes and improvements for schedsvc:rpcapi
by Francois Gouget (＠fgouget) March 27, 2023

March 27, 2023

* Deleting tasks & folders requires elevated privileges on Windows 7. * Document SchRpcGetTaskInfo() calls that crash on Windows. * Use a winetest context in the rpcapi loops. * Use wide character string literals in rpcapi.c. * Use __HRESULT_FROM_WIN32() to initialize constants. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2516

2 5

[PATCH v3 0/7] MR2511: dinput: More tests and fixes for BuildActionMap and EnumDevicesBySemantics.
by Rémi Bernon March 27, 2023

March 27, 2023

-- v3: dinput: Rewrite IDirectInput8_EnumDevicesBySemantics. dinput: Implement DIDBAM_PRESERVE BuildActionMap flag. dinput: Check device type in BuildActionMap for specific semantics. dinput: Load action map from registry before resetting guid. dinput: Trace formats in (Build|Set)ActionMap and EnumDevicesBySemantics. dinput/tests: Add more IDirectInput8_EnumDevicesBySemantics tests. dinput/tests: Test BuildActionMap cases with multiple devices. https://gitlab.winehq.org/wine/wine/-/merge_requests/2511

2 9

[PATCH 0/8] MR2455: Draft: wined3d: Avoid VK_IMAGE_LAYOUT_GENERAL.
by Stefan Dösinger March 27, 2023

March 27, 2023

This series aims to improve GPU-side performance by avoiding VK_IMAGE_LAYOUT_GENERAL for textures that are used as render target and shader resource view. To do so, we have to transition them between VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL and VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL depending on use (and likewise for depth stencils). It improves performance of Rocket League from 80 fps to 100 fps in a GPU limited configuration on my Radeon Polaris GPU. This MR is marked as draft for now because I am not convinced by patch 3 yet. For actual submission I think I'll create separate MRs for patches 1-3 and 4-8. Patch 2 introduces a validation layer error in the d3d11 tests that gets fixed in patch 3. No new test failures are introduced, although none of the existing ones are fixed either. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2455

2 15

[PATCH v2 0/7] MR2511: dinput: More tests and fixes for BuildActionMap and EnumDevicesBySemantics.
by Rémi Bernon March 27, 2023

March 27, 2023

-- v2: dinput: Rewrite IDirectInput8_EnumDevicesBySemantics. dinput: Implement DIDBAM_PRESERVE BuildActionMap flag. dinput: Check device type in BuildActionMap for specific semantics. dinput: Load action map from registry before resetting guid. dinput: Trace formats in (Build|Set)ActionMap and EnumDevicesBySemantics. dinput/tests: Add more IDirectInput8_EnumDevicesBySemantics tests. dinput/tests: Test BuildActionMap cases with multiple devices. https://gitlab.winehq.org/wine/wine/-/merge_requests/2511

2 9

[PATCH 0/7] MR2511: dinput: More tests and fixes for BuildActionMap and EnumDevicesBySemantics.
by Rémi Bernon March 27, 2023

March 27, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2511

2 8

[PATCH v2 0/1] MR2505: iphlpapi: Return FALSE for bad handles in IcmpCloseHandle
by Marc-Aurel Zent (＠marzent) March 27, 2023

March 27, 2023

Passing `NULL` or `INVALID_HANDLE_VALUE` into `IcmpCloseHandle` currently causes a segfault on wine, whereas it returns `FALSE` on windows. It seems FFXIV occasionally does this. -- v2: iphlpapi: Return FALSE for bad handles in IcmpCloseHandle https://gitlab.winehq.org/wine/wine/-/merge_requests/2505

3 2

[PATCH v2 0/2] MR131: vkd3d: Persistently map host-visible heaps on creation.
by Zebediah Figura (＠zfigura) March 27, 2023

March 27, 2023

-- v2: tests: Add a test for readback map stability. vkd3d: Persistently map host-visible heaps on creation. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/131

4 4

[PATCH 0/1] MR2508: wldap32: Implement setting LDAP_OPT_SSL and add tests.
by Alex Henrie (＠alexhenrie) March 27, 2023

March 27, 2023

Windows has the LDAP_OPT_SSL option to turn SSL on or off after calling ldap_init but before connecting to the server. OpenLDAP doesn't have that option and instead expects a fully SSL connection to be requested by passing one or more "ldaps://" URIs to ldap_init. However, OpenLDAP also has an LDAP_OPT_URI option, which Windows does not have, that can be used to change the URIs before connecting. And OpenLDAP already takes care of converting "ldap://" or "ldaps://" to lowercase, so all we have to do is find and replace that exact string in each URI in the list. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54727 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2508

4 3

[PATCH 0/1] MR2510: widl: Define PARSER_LTYPE instead of api.location.type.
by Rémi Bernon March 27, 2023

March 27, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54729 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2510

1 1

[PATCH 0/1] MR2499: hidparse.sys: Include zero-count reports in cap count
by Vicki Pfau (＠endrift) March 27, 2023

March 27, 2023

This fixes two wine_todo-marked tests. However, I'm not entirely sure this is correct. The behavior of Report Count == 0 isn't entirely clear to me, but it does pass the test now. Some more tests might be needed. cc @rbernon -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2499

3 3

[PATCH v2 0/5] MR2490: graphicscapture: Partially implement IGraphicsCaptureSessionStatics::IsSupported().
by Mohamad Al-Jaf (＠maljaf) March 27, 2023

March 27, 2023

Needed to prevent VR games from crashing when the user attempts to capture the desktop. The reference count seems to start at 0, which I've never encountered before. Not sure if my code is incorrect. -- v2: graphicscapture: Partially implement IGraphicsCaptureSessionStatics::IsSupported(). graphicscapture/tests: Add IGraphicsCaptureSessionStatics::IsSupported() tests. graphicscapture: Add IGraphicsCaptureSessionStatics stub interface. graphicscapture: Add stub DLL. include: Add windows.graphics.capture.idl file. https://gitlab.winehq.org/wine/wine/-/merge_requests/2490

4 11

[PATCH 0/1] MR2509: include: Fix c++ compiler error with msxml2.idl.
by Biswapriyo Nath (＠Biswa96) March 27, 2023

March 27, 2023

include: Fix c++ compiler error with msxml2.idl This moves ISAXXMLFilter declaration after its base class ISAXXMLReader. Otherwise the following error is shown in C++ mode $ wineg++ test-msxml2.cpp In file included from test-msxml2.cpp:1: /usr/include/wine/windows/msxml2.h:16199:24: error: invalid use of incomplete type ‘struct ISAXXMLReader’ 16199 | ISAXXMLFilter : public ISAXXMLReader | ^~~~~~~~~~~~~ /usr/include/wine/windows/msxml2.h:644:19: note: forward declaration of ‘struct ISAXXMLReader’ 644 | typedef interface ISAXXMLReader ISAXXMLReader; | ^~~~~~~~~~~~~ winegcc: /usr/bin/g++ failed Signed-off-by: Biswapriyo Nath <nathbappai(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2509

2 2

[PATCH v2 0/1] MR2482: dwrite: Use cache when font transform matrix contains only translation offsets.
by Zhiyi Zhang (＠zhiyi) March 27, 2023

March 27, 2023

Word 2016 queries a lot of font glyph bounding boxes and bitmaps with translation matrices. The result of these queries is not cached because the transform matrix is not the identity matrix. However, the translation offsets don't affect FreeType font operations at all, which can be verified in ft_matrix_from_dwrite_matrix() called by get_glyph_transform(). So these results with translation matrices can be cached as well. With this patch, Word 2016 stuttering is reduced significantly. -- v2: dwrite: Use cache when font transform matrix contains only translation offsets. https://gitlab.winehq.org/wine/wine/-/merge_requests/2482

3 2

[PATCH 0/13] MR2504: wineps: Support more drawing primitives in print processor.
by Piotr Caban (＠piotr) March 26, 2023

March 26, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2504

3 14

[PATCH 0/1] MR2506: ucrtbase: Add __CxxFrameHandler4 implementation.
by Piotr Caban (＠piotr) March 26, 2023

March 26, 2023

This MR implements changes suggested in !2418. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2506

2 1

[PATCH 0/1] MR2505: iphlpapi: Return FALSE for bad handles in IcmpCloseHandle
by Marc-Aurel Zent (＠marzent) March 26, 2023

March 26, 2023

Passing `NULL` or `INVALID_HANDLE_VALUE` into `IcmpCloseHandle` currently causes a segfault on wine, whereas it returns `FALSE` on windows. It seems FFXIV occasionally does this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2505

2 1

Re: [PATCH v4 0/1] MR1418: msvcm: add stubs to avoid Athenas ASS and IL-DSP crash. - closed
by Piotr Caban (＠piotr) March 26, 2023

March 26, 2023

This merge request was closed by Piotr Caban. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1418

1 0

Re: [PATCH v4 0/1] MR1418: msvcm: add stubs to avoid Athenas ASS and IL-DSP crash.
by Piotr Caban (＠piotr) March 26, 2023

March 26, 2023

Closing since there's no activity on the MR. Please reopen or create a new one if you're still planning to work on it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1418#note_27881

1 0

Re: [PATCH v3 0/1] MR2502: wine.inf.in: Add EditionID to HKEY_LOCAL_MACHINE\Software\Microsoft\Windows NT\CurrentVersion - approved
by Hans Leidekker (＠hans) March 26, 2023

March 26, 2023

This merge request was approved by Hans Leidekker. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2502

1 0

Re: [PATCH v3 0/1] MR2502: wine.inf.in: Add EditionID to HKEY_LOCAL_MACHINE\Software\Microsoft\Windows NT\CurrentVersion - approved
by Etaash Mathamsetty (＠etaash.mathamsetty) March 26, 2023

March 26, 2023

This merge request was approved by Etaash Mathamsetty. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2502

1 0

[PATCH 0/1] MR2503: windows.media.speech/tests: Allow recognizer state to be idle during active recognition session.
by Bernhard Kölbl March 25, 2023

March 25, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54441 Signed-off-by: Bernhard Kölbl <besentv(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2503

1 2

Re: [PATCH v2 0/2] MR2501: wine.inf.in: Add EditionID to HKEY_LOCAL_MACHINE\Software\Microsoft\Windows NT\CurrentVersion - closed
by Louis Lenders (＠xe) March 25, 2023

March 25, 2023

This merge request was closed by Louis Lenders. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2501

1 0

Re: [PATCH v2 0/2] MR2501: wine.inf.in: Add EditionID to HKEY_LOCAL_MACHINE\Software\Microsoft\Windows NT\CurrentVersion - closed
by Louis Lenders (＠xe) March 25, 2023

March 25, 2023

This merge request was closed by Louis Lenders. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2501

1 0

[PATCH 0/1] MR2502: wine.inf.in: Add EditionID to HKEY_LOCAL_MACHINE\Software\Microsoft\Windows NT\CurrentVersion
by Louis Lenders (＠xe) March 25, 2023

March 25, 2023

https://bugs.winehq.org/show_bug.cgi?id=54675 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2502

2 1

[PATCH 0/2] MR2501: wine.inf.in: Add EditionID to HKEY_LOCAL_MACHINE\Software\Microsoft\Windows NT\CurrentVersion
by Louis Lenders (＠xe) March 25, 2023

March 25, 2023

https://bugs.winehq.org/show_bug.cgi?id=54675 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2501

3 3

Re: [PATCH v2 0/2] MR2442: wine.inf.in: Add EditionID to HKEY_LOCAL_MACHINE\Software\Microsoft\Windows NT\CurrentVersion - closed
by Louis Lenders (＠xe) March 25, 2023

March 25, 2023

This merge request was closed by Louis Lenders. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2442

1 0

[PATCH 0/2] MR2478: wined3d: Make video memory accounting a per-resource flag.
by Stefan Dösinger March 25, 2023

March 25, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54701 --- The private draw texture did not get evicted on reset(), causing us to try to read from a non-existent texture with the new contest. For more details see comment 9 on the bug. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2478

3 8