March 2023 - Wine-GitLab - list.winehq.org

[PATCH 0/5] MR2494: imm32: Make a few tests pass and test ImmActivateLayout.
by Rémi Bernon March 25, 2023

March 25, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2494

2 6

[PATCH v4 0/10] MR124: vkd3d-shader/hlsl: Introduce hlsl_ir_index, part 1/2.
by Francisco Casas (＠fcasas) March 24, 2023

March 24, 2023

This node type is intended for use during parse-time. While we parse an indexing expression such as `a[3]`, we don't know if it will end up as part of an expression (in which case it must be folded into a load) or it is for the lhs of a store (in which case it must be folded into the store's deref). This node type is used to represent these accesses and no longer rely on building an `hlsl_ir_load` for each array index or struct record access. `hlsl_ir_index` chains are lowered into derefs when (and if) they are used to specify the lhs of an assignment. All `hlsl_ir_index`es are lowered into `hlsl_ir_load`s with a compilation pass. The changes introduced in these series allow to solve the problem with the return variable of function calls presented in !93, and to properly support assignment to matrix indexes, which is something we are not doing correctly. Further patches (in my [index node](https://gitlab.winehq.org/fcasas/vkd3d/-/commits/index_node) branch) add support for indexing non-load expressions, such as `(a + b)[1]` and allowing to represent resource loads through `hlsl_ir_index`, so that `hlsl_ir_resource_store`s don't have to rely on `hlsl_ir_resource_load`s. -- v4: vkd3d-shader/hlsl: Evaluate index before array. vkd3d-shader/hlsl: Support column-major matrix indexing in the lhs. vkd3d-shader/hlsl: Always load from a synthetic copy in add_load_component(). vkd3d-shader/hlsl: Remove add_load_index(). vkd3d-shader/hlsl: Use hlsl_ir_index for array and record access. vkd3d-shader/hlsl: Introduce hlsl_ir_index. tests: Test indexing of non-loads. tests: Test side effects on indexes. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/124

3 11

[PATCH v20 0/6] MR1148: ntdll: Mark created files beginning with a dot as not hidden.
by Torge Matthies (＠tmatthies) March 24, 2023

March 24, 2023

Fixes bug [53826](https://bugs.winehq.org/show_bug.cgi?id=53826). -- v20: ntdll/tests: Increase margins in timer merging tests. ntdll: Set xattr in NtCreateFile if inferred and requested attributes don't match. ntdll: Only infer hidden attribute from file name if xattr is not present. ntdll: Handle hidden file names inside get_file_info instead of after it. ntdll: Do not open-code hidden file handling in get_dir_data_entry. ntdll/tests: Add test for file attributes of files with names beginning with a dot. https://gitlab.winehq.org/wine/wine/-/merge_requests/1148

3 8

[PATCH 0/2] MR131: vkd3d: Persistently map host-visible heaps on creation.
by Zebediah Figura (＠zfigura) March 24, 2023

March 24, 2023

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/131

5 12

Re: [PATCH v2 0/6] MR2495: widl: Add source location information to attributes. - approved
by Alexandre Julliard (＠julliard) March 24, 2023

March 24, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2495

1 0

Re: [PATCH v5 0/2] MR2481: wldap32: Handle null DN or null message in ldap_delete* and add tests. - approved
by Alexandre Julliard (＠julliard) March 24, 2023

March 24, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2481

1 0

Re: [PATCH v9 0/5] MR2258: winegstreamer: Support WMV DMO decoder. - approved
by Alexandre Julliard (＠julliard) March 24, 2023

March 24, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2258

1 0

Re: [PATCH v2 0/5] MR2494: imm32: Make a few tests pass and test ImmActivateLayout. - approved
by Alexandre Julliard (＠julliard) March 24, 2023

March 24, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2494

1 0

Re: [PATCH v3 0/5] MR2488: crypt32: Optimize root certificates loading from host. - approved
by Alexandre Julliard (＠julliard) March 24, 2023

March 24, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2488

1 0

Re: [PATCH v2 0/1] MR2493: ldap: Return an error when the server doesn't respond to the SSL handshake. - approved
by Alexandre Julliard (＠julliard) March 24, 2023

March 24, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2493

1 0

Re: [PATCH v5 0/5] MR2469: wined3d: move stubs out of state tables - approved
by Alexandre Julliard (＠julliard) March 24, 2023

March 24, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2469

1 0

Re: [PATCH v2 0/1] MR2491: include: Add windows.graphics.effects.idl file. - approved
by Alexandre Julliard (＠julliard) March 24, 2023

March 24, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2491

1 0

Re: [PATCH v7 0/4] MR2465: windows.ui: Add Stubbed interface IUISettings - approved
by Alexandre Julliard (＠julliard) March 24, 2023

March 24, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2465

1 0

Re: [PATCH v2 0/13] MR2492: wineps: Support pattern brushes, world transform and more drawing primitives in print processor - approved
by Alexandre Julliard (＠julliard) March 24, 2023

March 24, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2492

1 0

[PATCH 0/4] MR2470: uiautomationcore: Fix/extend some tests, implement UIA_ProviderDescriptionPropertyId.
by Connor McAdams (＠cmcadams) March 24, 2023

March 24, 2023

This should lower the test todo count substantially. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2470

3 9

[PATCH 0/6] MR2495: widl: Add source location information to attributes.
by Rémi Bernon March 24, 2023

March 24, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2495

2 7

[PATCH v5 0/4] MR89: vkd3d-shader/hlsl: Improve support for logarithmic functions.
by Nikolay Sivov (＠nsivov) March 24, 2023

March 24, 2023

-- v5: vkd3d-shader/hlsl: Support log() intrinsic. vkd3d-shader/hlsl: Support log10() intrinsic. vkd3d-shader/hlsl: Support log2() intrinsic. vkd3d-shader/hlsl: Write 'log' instruction for SM1. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/89

2 4

[PATCH v4 0/2] MR2481: wldap32: Handle null DN or null message in ldap_delete* and add tests.
by Alex Henrie (＠alexhenrie) March 24, 2023

March 24, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54702 -- v4: wldap32: Handle null DN or null message in ldap_delete* and add tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/2481

3 4

[PATCH v2 0/5] MR2469: wined3d: move stubs out of state tables
by Max Figura (＠maxfigura) March 24, 2023

March 24, 2023

Removing WINED3D_RS entries from state tables and moving stubs to wined3d_device_apply_stateblock. -- v2: wined3d: Move the WINED3D_RS_ENABLEADAPTIVETESSELLATION stub to wined3d_device_apply_stateblock. wined3d: Move the WINED3D_RS_ADAPTIVETESS_W stub to wined3d_device_apply_stateblock. wined3d: Move the WINED3D_RS_ADAPTIVETESS_Z stub to wined3d_device_apply_stateblock. wined3d: Move the WINED3D_RS_ADAPTIVETESS_Y stub to wined3d_device_apply_stateblock. wined3d: Move the WINED3D_RS_ADAPTIVETESS_X stub to wined3d_device_apply_stateblock. https://gitlab.winehq.org/wine/wine/-/merge_requests/2469

3 6

[PATCH 0/5] MR2486: D3D12 swapchain latency semaphore fixes
by Giovanni Mascellani (＠giomasce) March 24, 2023

March 24, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2486

4 10

[PATCH 0/1] MR2482: dwrite: Use cache when font transform matrix contains only translation offsets.
by Zhiyi Zhang (＠zhiyi) March 24, 2023

March 24, 2023

Word 2016 queries a lot of font glyph bounding boxes and bitmaps with translation matrices. The result of these queries is not cached because the transform matrix is not the identity matrix. However, the translation offsets don't affect FreeType font operations at all, which can be verified in ft_matrix_from_dwrite_matrix() called by get_glyph_transform(). So these results with translation matrices can be cached as well. With this patch, Word 2016 stuttering is reduced significantly. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2482

3 2

[PATCH 0/2] MR2496: Draft: Fix hang when a program calls IMFMediaSession_Start with an invalid source.
by Santino Mazza (＠tati1454) March 24, 2023

March 24, 2023

This fixes a bug when the session topology contains an invalid source, which makes the session thread to hang and stop executing commands. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2496

3 3

[PATCH 0/6] MR2485: d3d10/effect: Add support for more instructions.
by Nikolay Sivov (＠nsivov) March 24, 2023

March 24, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2485

3 7

[PATCH v2 0/5] MR2483: kernelbase: Add full support for shared Software\Classes keys.
by Sven Baars (＠sbaars) March 24, 2023

March 24, 2023

I initially wanted to do the refactoring in a separate merge request, but since my merge request yesterday broke the tests, I decided to add the implementation into this commit as well. -- v2: kernelbase: Recursively obtain the Wow6432Node parent. kernelbase: Add support for shared registry keys. https://gitlab.winehq.org/wine/wine/-/merge_requests/2483

3 6

[PATCH v2 0/6] MR2456: widl: Improve error messages source location.
by Rémi Bernon March 24, 2023

March 24, 2023

-- v2: widl: Print the import stack and context in messages. widl: Improve accuracy of error messages location. widl: Enable bison locations option. widl: Move diagnostic and location functions to parser.l. widl: Allow source location to span over multiple lines. widl: Rename (error|warning)_loc_info to (error|warning)_at. https://gitlab.winehq.org/wine/wine/-/merge_requests/2456

2 8

[PATCH v2 0/11] MR2484: wineps: Initial work on writing ps data in print processor
by Piotr Caban (＠piotr) March 24, 2023

March 24, 2023

-- v2: wineps: Handle EMR_LINETO record in spool files. wineps: Handle EMR_MOVETOEX record in spool files. wineps: Handle EMR_RECTANGLE record in spool files. wineps: Handle pen selection in spool files. wineps: Handle brush selection in spool files. wineps: Handle EMR_EOF record in spool files. wineps: Handle EMR_HEADER record in spool files. wineps: Write document header and footer in PrintDocumentOnPrintProcessor. https://gitlab.winehq.org/wine/wine/-/merge_requests/2484

3 13

[PATCH v3 0/5] MR2483: kernelbase: Add full support for shared Software\Classes keys.
by Sven Baars (＠sbaars) March 24, 2023

March 24, 2023

I initially wanted to do the refactoring in a separate merge request, but since my merge request yesterday broke the tests, I decided to add the implementation into this commit as well. -- v3: kernelbase: Recursively obtain the Wow6432Node parent. kernelbase: Add support for shared registry keys. https://gitlab.winehq.org/wine/wine/-/merge_requests/2483

2 6

Re: [PATCH v3 0/1] MR132: Release 1.7. - approved
by Alexandre Julliard (＠julliard) March 24, 2023

March 24, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/132

1 0

Re: [PATCH v4 0/5] MR2483: kernelbase: Add full support for shared Software\Classes keys.
by Sven Baars (＠sbaars) March 24, 2023

March 24, 2023

I rebased my patches and the remaining failures seem to be unrelated to my patches. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2483#note_27771

1 0

[PATCH 0/5] MR2490: graphicscapture: Partially implement IGraphicsCaptureSessionStatics::IsSupported().
by Mohamad Al-Jaf (＠maljaf) March 24, 2023

March 24, 2023

Needed to prevent VR games from crashing when the user attempts to capture the desktop. The reference count seems to start at 0, which I've never encountered before. Not sure if my code is incorrect. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2490

4 8

Re: [PATCH v2 0/5] MR2488: crypt32: Optimize root certificates loading from host. - approved
by Hans Leidekker (＠hans) March 24, 2023

March 24, 2023

This merge request was approved by Hans Leidekker. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2488

1 0

[PATCH 0/13] MR2492: wineps: Support pattern brushes, world transform and more drawing primitives in print processor
by Piotr Caban (＠piotr) March 24, 2023

March 24, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2492

3 15

[PATCH 0/1] MR2493: ldap: Return an error when the server doesn't respond to the SSL handshake.
by Hans Leidekker (＠hans) March 24, 2023

March 24, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54724 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2493

2 1

[PATCH v3 0/2] MR2481: wldap32: Handle null DN or null message in ldap_delete* and add tests.
by Alex Henrie (＠alexhenrie) March 24, 2023

March 24, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54702 -- v3: wldap32: Handle null DN or null message in ldap_delete* and add tests. wldap32/tests: Use the same context in test_ldap_(add|modify_compare). https://gitlab.winehq.org/wine/wine/-/merge_requests/2481

3 4

[PATCH v6 0/4] MR2465: windows.ui: Add Stubbed interface IUISettings
by Alistair Leslie-Hughes (＠alesliehughes) March 24, 2023

March 24, 2023

This corrects what interface should be returned, there isn't a hierarchy with these IUISettings at all. It should return IUISettings and then QI for any others that it requires. -- v6: windows.ui: Use DEFINE_IINSPECTABLE for IUISettings3 windows.ui: Add IUISettings2 stub interface windows.ui: Add Stubbed interface IUISettings include: Add Missing IUISettings interfaces. https://gitlab.winehq.org/wine/wine/-/merge_requests/2465

3 5

[PATCH v5 0/4] MR2465: windows.ui: Add Stubbed interface IUISettings
by Alistair Leslie-Hughes (＠alesliehughes) March 24, 2023

March 24, 2023

This corrects what interface should be returned, there isn't a hierarchy with these IUISettings at all. It should return IUISettings and then QI for any others that it requires. -- v5: windows.ui: Use DEFINE_IINSPECTABLE for IUISettings3 windows.ui: Add IUISettings2 stub interface windows.ui: Add Stubbed interface IUISettings include: Add Missing IUISettings interfaces. https://gitlab.winehq.org/wine/wine/-/merge_requests/2465

3 5

[PATCH v2 0/2] MR2489: include: Add Windows.System.DispatcherQueue definition.
by Biswapriyo Nath (＠Biswa96) March 24, 2023

March 24, 2023

-- v2: include: Add Windows.System.DispatcherQueue definition. https://gitlab.winehq.org/wine/wine/-/merge_requests/2489

2 5

[PATCH 0/1] MR2491: include: Add windows.graphics.effects.idl file.
by Mohamad Al-Jaf (＠maljaf) March 24, 2023

March 24, 2023

Needed for mingw Firefox build. Fairly small file. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2491

3 2

[PATCH v4 0/4] MR2465: windows.ui: Add Stubbed interface IUISettings
by Alistair Leslie-Hughes (＠alesliehughes) March 24, 2023

March 24, 2023

This corrects what interface should be returned, there isn't a hierarchy with these IUISettings at all. It should return IUISettings and then QI for any others that it requires. -- v4: windows.ui: Use DEFINE_IINSPECTABLE for IUISettings3 windows.ui: Add IUISettings2 stub interface windows.ui: Add Stubbed interface IUISettings include: Add Missing IUISettings interfaces. https://gitlab.winehq.org/wine/wine/-/merge_requests/2465

3 6

[PATCH 0/2] MR2489: include: Add Windows.System.DispatcherQueue declaration.
by Biswapriyo Nath (＠Biswa96) March 24, 2023

March 24, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2489

4 8

[PATCH 0/5] MR2488: crypt32: Optimize root certificates loading from host.
by Paul Gofman (＠gofman) March 24, 2023

March 24, 2023

CertOpenStore(CERT_STORE_PROV_SYSTEM_REGISTRY_, ..., "Root") is taking 80-250ms here when executed first time in a process. That triggers a race condition in some CEF / NWJS games (Purgo box is an example), where NWJS seems to depend on main thread initialization going faster than 3d initialization in the other thread (otherwise it crashes). The main hitter is the mentioned CertOpenStore(). Probably more important is that the delay is always there upon first time reading root certs per process start which happens, e. g., any time an app wants to establish a seure connection to public server. The major hitter is rootstore.c:check_and_store_certs() which validates certificate chains as a part of host certificate import which is always done fully. The idea is that we can persist registry cache (which load is relatively quick) only adding a new certificates, also making sure that none of the previously root certs was deleted. In the latter case the patches fallback to full reimport to guarantee that the chain validation is not affected. The patchset brings CertOpenStore(CERT_STORE_PROV_SYSTEM_REGISTRY_, ..., "Root") time from 80-250ms to 5-10ms here after the registry cache was filled once and no cert was deleted on host. The full reinitialization time (on clean prefix or when a cert was deleted) stays nearly the same. Patch 2 introduces a relatively small independent optimization (which avoids searching for certificate in store when it was needed). It has much lesser impact on the overall process (a few ms here) but is also much simplier. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2488

3 6

Re: [PATCH v5 0/1] MR2413: comctl32: Fix the problem that listview cannot display all files.
by Zhao Yi (＠Zhaoyi) March 24, 2023

March 24, 2023

On Fri Mar 24 02:49:18 2023 +0000, Nikolay Sivov wrote: > For commit message it's better to have some description message, and not > duplicating what code actually does. I have just updated my commit message and you can review it again. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2413#note_27721

1 0

[PATCH v4 0/5] MR2469: wined3d: move stubs out of state tables
by Max Figura (＠maxfigura) March 24, 2023

March 24, 2023

Removing WINED3D_RS entries from state tables and moving stubs to wined3d_device_apply_stateblock. -- v4: wined3d: Move the WINED3D_RS_ENABLEADAPTIVETESSELLATION stub to wined3d_device_apply_stateblock. wined3d: Move the WINED3D_RS_ADAPTIVETESS_W stub to wined3d_device_apply_stateblock. wined3d: Move the WINED3D_RS_ADAPTIVETESS_Z stub to wined3d_device_apply_stateblock. wined3d: Move the WINED3D_RS_ADAPTIVETESS_Y stub to wined3d_device_apply_stateblock. wined3d: Move the WINED3D_RS_ADAPTIVETESS_X stub to wined3d_device_apply_stateblock. https://gitlab.winehq.org/wine/wine/-/merge_requests/2469

3 6

[PATCH v5 0/1] MR2126: ntdll: Print an error if we receive a signal not on the signal stack.
by Zebediah Figura (＠zfigura) March 24, 2023

March 24, 2023

Without this patch the process will silently die. I managed to trigger this while trying to trace Child of Light with Renderdoc, the latter of which crashed in its own "TargetControlServerThread". This, confusingly, manifested in the game restarting itself without the Ubisoft overlay; apparently the game or one of its launchers was capable of recognizing when the process had died and restarting it, but would not try to inject the overlay a second time. I have not investigated the cause of the crash; it is not unlikely that it resulted from the overlay injection (despite the fact that that should only directly affect PE code.) -- v5: ntdll: Print an error if we receive a signal not on the signal stack. https://gitlab.winehq.org/wine/wine/-/merge_requests/2126

3 4

Re: [PATCH v10 0/1] MR2183: winecfg: Add an option to set WinRT app dark theme.
by Mohamad Al-Jaf (＠maljaf) March 23, 2023

March 23, 2023

> Only if you accept that it overflows above the install button, I'm not sure that's better. You're right, it does overflow with some of the translations. This seems like the safest way to add it: ![Screenshot_20230323_190837](/uploads/65da20f990348341c9331a98709a37db/Screenshot_20230323_190837.png) I checked the longest `Install theme` translation, which is Lithuanian, and it doesn't overflow: ![Screenshot_20230323_190610](/uploads/c0af96e1db89d0b9082a77fb778bfad4/Screenshot_20230323_190610.png) Alternatively, the `Color` combo box could be moved to the first row like so: ![Screenshot_20230323_193447](/uploads/8e75a18414ba4f1f29b81bc9a2a4e7f7/Screenshot_20230323_193447.png) Which of these would be most preferable? I'm leaning towards the second one. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2183#note_27712

1 0

[PATCH v5 0/3] MR1895: Fixes for NtOpenFile of read-only files with FILE_WRITE_ATTRIBUTES
by Joel Holdsworth (＠jhol) March 23, 2023

March 23, 2023

Previously, the Wine implementation of `NtOpenFile` would fail to open read-only files for `FILE_WRITE_ATTRIBUTES` access in wine-server, because it would attempt to open the file with `O_RDWR` or `O_WRONLY` access. This patch-set adds test cases to highlight the issue, and solves it by only opening the file with write access where necessary. * Wine Bug: [#50771](https://bugs.winehq.org/show_bug.cgi?id=50771) * Related Wine-Staging Patches: * [0002-server-Allow-to-open-files-without-any-permission-bi.patch](https://gi… * [0006-ntdll-tests-Added-tests-for-open-behaviour-on-readon.patch](https://gi… * [0007-server-FILE_WRITE_ATTRIBUTES-should-succeed-for-read.patch](https://gi… -- v5: server: Allow to open read-only files with FILE_WRITE_ATTRIBUTES https://gitlab.winehq.org/wine/wine/-/merge_requests/1895

3 7

[PATCH v3 0/10] MR124: vkd3d-shader/hlsl: Introduce hlsl_ir_index, part 1/2.
by Francisco Casas (＠fcasas) March 23, 2023

March 23, 2023

This node type is intended for use during parse-time. While we parse an indexing expression such as `a[3]`, we don't know if it will end up as part of an expression (in which case it must be folded into a load) or it is for the lhs of a store (in which case it must be folded into the store's deref). This node type is used to represent these accesses and no longer rely on building an `hlsl_ir_load` for each array index or struct record access. `hlsl_ir_index` chains are lowered into derefs when (and if) they are used to specify the lhs of an assignment. All `hlsl_ir_index`es are lowered into `hlsl_ir_load`s with a compilation pass. The changes introduced in these series allow to solve the problem with the return variable of function calls presented in !93, and to properly support assignment to matrix indexes, which is something we are not doing correctly. Further patches (in my [index node](https://gitlab.winehq.org/fcasas/vkd3d/-/commits/index_node) branch) add support for indexing non-load expressions, such as `(a + b)[1]` and allowing to represent resource loads through `hlsl_ir_index`, so that `hlsl_ir_resource_store`s don't have to rely on `hlsl_ir_resource_load`s. -- v3: vkd3d-shader/hlsl: Copy index chain values into synthetic vars. tests: Test indexing of non-loads. vkd3d-shader/hlsl: Support column-major matrix indexing in the lhs. vkd3d-shader/hlsl: Always load from a synthetic copy in add_load_component(). vkd3d-shader/hlsl: Remove add_load_index(). vkd3d-shader/hlsl: Use hlsl_ir_index for array and record access. vkd3d-shader/hlsl: Introduce hlsl_ir_index. tests: Test side effects on indexes. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/124

3 17

[PATCH v8 0/5] MR2258: winegstreamer: Support WMV DMO decoder.
by Ziqing Hui (＠zhui) March 23, 2023

March 23, 2023

-- v8: winegstreamer: Implement ProcessInput and ProcessOutput for WMV decoder DMO. winegstreamer: Create wg_transform for WMV decoder. winegstreamer: Ignore framerate of media type for WMV decoder DMO. winegstreamer: Add format field to wmv wg_format. mf/tests: Test time length returned by ProcessOutput. https://gitlab.winehq.org/wine/wine/-/merge_requests/2258

3 6

Re: [PATCH v3 0/6] MR2456: widl: Improve error messages source location. - approved
by Alexandre Julliard (＠julliard) March 23, 2023

March 23, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2456

1 0

Re: [PATCH v2 0/1] MR2474: include: Add D3D10CalcSubresource(). - approved
by Alexandre Julliard (＠julliard) March 23, 2023

March 23, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2474

1 0

Re: [PATCH v2 0/1] MR2477: include: Use hexadecimal constants for XAudio flags. - approved
by Alexandre Julliard (＠julliard) March 23, 2023

March 23, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2477

1 0

Re: [PATCH v3 0/1] MR2479: ntdll: Print correct thread rename trace when using current thread ID with exception method. - approved
by Alexandre Julliard (＠julliard) March 23, 2023

March 23, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2479

1 0

Re: [PATCH v3 0/11] MR2484: wineps: Initial work on writing ps data in print processor - approved
by Alexandre Julliard (＠julliard) March 23, 2023

March 23, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2484

1 0

Re: [PATCH v3 0/5] MR2452: imm32: Implement ImmEnumInputContext. - approved
by Alexandre Julliard (＠julliard) March 23, 2023

March 23, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2452

1 0

[PATCH v2 0/7] MR124: vkd3d-shader/hlsl: Introduce hlsl_ir_index, part 1/2.
by Francisco Casas (＠fcasas) March 23, 2023

March 23, 2023

This node type is intended for use during parse-time. While we parse an indexing expression such as `a[3]`, we don't know if it will end up as part of an expression (in which case it must be folded into a load) or it is for the lhs of a store (in which case it must be folded into the store's deref). This node type is used to represent these accesses and no longer rely on building an `hlsl_ir_load` for each array index or struct record access. `hlsl_ir_index` chains are lowered into derefs when (and if) they are used to specify the lhs of an assignment. All `hlsl_ir_index`es are lowered into `hlsl_ir_load`s with a compilation pass. The changes introduced in these series allow to solve the problem with the return variable of function calls presented in !93, and to properly support assignment to matrix indexes, which is something we are not doing correctly. Further patches (in my [index node](https://gitlab.winehq.org/fcasas/vkd3d/-/commits/index_node) branch) add support for indexing non-load expressions, such as `(a + b)[1]` and allowing to represent resource loads through `hlsl_ir_index`, so that `hlsl_ir_resource_store`s don't have to rely on `hlsl_ir_resource_load`s. -- v2: vkd3d-shader/hlsl: Support matrix indexing in the lhs. vkd3d-shader/hlsl: Always load from a synthetic copy in add_load_component(). vkd3d-shader/hlsl: Remove add_load_index(). vkd3d-shader/hlsl: Use hlsl_ir_index for array and record access. vkd3d-shader/hlsl: Introduce hlsl_ir_index. tests: Test matrix indexing on the lhs. tests: Test multiple calls to the same function in initializers. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/124

3 25

[PATCH v2 0/3] MR2480: ddraw: SetSurfaceDesc() refactoring, part 6.
by Zebediah Figura (＠zfigura) March 23, 2023

March 23, 2023

This concludes the series. -- v2: ddraw: Reimplement SetSurfaceDesc() by recreating the wined3d texture(s). wined3d: Pass parent ops to wined3d_rendertarget_view_set_parent(). ddraw/tests: Add some tests for creating surfaces with user memory. https://gitlab.winehq.org/wine/wine/-/merge_requests/2480

3 5

Re: [PATCH v10 0/1] MR2183: winecfg: Add an option to set WinRT app dark theme.
by Alexandre Julliard (＠julliard) March 23, 2023

March 23, 2023

> I'm open to suggestions. However, a drop-down eliminates the overflow issue altogether. Only if you accept that it overflows above the install button, I'm not sure that's better. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2183#note_27667

1 0

[PATCH v2 0/107] MR2402: Release 7.0.2
by Michael Stefaniuc (＠mstefani) March 23, 2023

March 23, 2023

-- v2: This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/2402

1 1

[PATCH v19 0/5] MR1148: ntdll: Mark created files beginning with a dot as not hidden.
by Torge Matthies (＠tmatthies) March 23, 2023

March 23, 2023

Fixes bug [53826](https://bugs.winehq.org/show_bug.cgi?id=53826). -- v19: ntdll: Set xattr in NtCreateFile if inferred and requested attributes don't match. ntdll: Only infer hidden attribute from file name if xattr is not present. ntdll: Handle hidden file names inside get_file_info instead of after it. ntdll: Do not open-code hidden file handling in get_dir_data_entry. ntdll/tests: Add test for file attributes of files with names beginning with a dot. https://gitlab.winehq.org/wine/wine/-/merge_requests/1148

2 5

[PATCH v3 0/5] MR2469: wined3d: move stubs out of state tables
by Max Figura (＠maxfigura) March 23, 2023

March 23, 2023

Removing WINED3D_RS entries from state tables and moving stubs to wined3d_device_apply_stateblock. -- v3: wined3d: Move the WINED3D_RS_ENABLEADAPTIVETESSELLATION stub to wined3d_device_apply_stateblock. wined3d: Move the WINED3D_RS_ADAPTIVETESS_W stub to wined3d_device_apply_stateblock. wined3d: Move the WINED3D_RS_ADAPTIVETESS_Z stub to wined3d_device_apply_stateblock. wined3d: Move the WINED3D_RS_ADAPTIVETESS_Y stub to wined3d_device_apply_stateblock. wined3d: Move the WINED3D_RS_ADAPTIVETESS_X stub to wined3d_device_apply_stateblock. https://gitlab.winehq.org/wine/wine/-/merge_requests/2469

2 5

Re: [PATCH v10 0/1] MR2183: winecfg: Add an option to set WinRT app dark theme.
by Mohamad Al-Jaf (＠maljaf) March 23, 2023

March 23, 2023

On Thu Mar 23 19:32:06 2023 +0000, Brendan Shanks wrote: > I suggested the drop-down, a future third option would be to use the > host system's light/dark mode setting Yeah, a check mark was what I initially went with, but there's concern about the translations. Some of them can be quite long and would likely overflow into other elements. The text has to be explicit enough to not confuse the user, something like `Enable WinRT app dark theme`, which is quite long as it is. But in other languages, it can be even longer. For instance, in French, this can translate to `Activer le thème sombre de l'application WinRT`. In Greek, `Ενεργοποιήστε το σκοτεινό θέμα της εφαρμογής WinRT`. The Greek translation would most likely overflow. The check mark would need to be on its own row to prevent this issue, but there doesn't seem to be enough space to add one. I'm open to suggestions. However, a drop-down eliminates the overflow issue altogether. Also, some people want an option to use the host system's mode, but I don't know if this is something that Wine would support. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2183#note_27659

1 0

Re: [PATCH v10 0/1] MR2183: winecfg: Add an option to set WinRT app dark theme.
by Brendan Shanks (＠bshanks) March 23, 2023

March 23, 2023

On Thu Mar 23 19:32:06 2023 +0000, Alexandre Julliard wrote: > > How's this? > > > > Thanks for the review! :smiley: > Actually thinking some more about this, a simple check mark may be > better than a drop-down. It's not like there would be other possible options. I suggested the drop-down, a future third option would be to use the host system's light/dark mode setting -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2183#note_27658

1 0

[PATCH 0/7] MR2476: winewayland.drv: part 2: Display configuration enhancements
by Alexandros Frantzis (＠afrantzis) March 23, 2023

March 23, 2023

This second MR in the Wayland series adds display configuration related enhancements, including providing more display information (like a proper/consistent name and position) to Wine and implementing GetCurrentDisplaySettings. To get additional information from the Wayland compositor we need to use a protocol from the wayland-protocols collection, so we introduce support in the build system for protocol .xml files, and also makedep changes to gracefully handle the case these external sources are missing when the driver is disabled. These changes are introduced on their own in the first commit in the series, but we can squash it with the next commit, where the functionality is first used, if preferred. To be able to provide a consistent view of the display settings across all processes, this MR adds a shared memory region containing an authoritative version of the Wayland output information (see the "winewayland.drv: Implement GetCurrentDisplaySettings." commit for more details). **Important note:** This MR requires the wayland-protocols package in the CI docker image. Without it the Wayland driver build will be disabled, so any build results are not going to be representative of the Wayland driver code changes in this branch. Thanks! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2476

5 12

[PATCH 0/1] MR2472: CommandLineToArgvW: fixed vulnerability by incorrect parsing
by Sergey G. Brester (＠sebres) March 23, 2023

March 23, 2023

### Merge request This fixes a vulnerability by incorrect parsing of command line arguments. The way how a triple quote chars (or double quote chars inside a quoted string) will be currently parsed in `CommandLineToArgvW` of wine is wrong, therefore opens an attack vector (using artificially created command line validated with different rules matching default parsing mechanism of Windows), so could be even considered as a vulnerability. ## Proposed changes `CommandLineToArgvW` will parse command line arguments correct and more similar to Windows. Here is the diff illustrating wrong behavior: ```diff ## # test is an alias for ## # python.exe -c "from sys import argv; del argv[0]; print(str(len(argv)) + ' | ' + ' | '.join(argv))" - # Wine + # Windows (and fixed variant) ## double in quoted string: > test "abc""def" ghi" xxx - 2 | abc"def ghi | xxx + 2 | abc"def | ghi xxx > test "abc"""def" ghi" xxx - 3 | abc"def | ghi" xxx + 2 | abc"def ghi | xxx ## triple in unquoted string: > test abc"""def" ghi" xxx - 2 | abc"def ghi | xxx + 2 | abc"def | ghi xxx > test abc""""def" ghi" xxx - 2 | abc"def | ghi xxx + 2 | abc"def ghi | xxx ``` As a consequence: - the arguments can be parsed incorrectly (compared to default behavior of Windows parser) in the way that parts of quoted arguments may become unquoted and vice versa, as well as swim between different args; - an attacker may create artificial command line that pass validation rules of nominal condition of Windows, but vulnerable here (inject, data steal, etc), because the arguments would deviate between validation and execution phase - special tokens like pipe `|`, ampersand `&` or redirecting tokens like `>` that normally included in quoted string (and validated as a string) could abrupt get different meaning and used for piping, redirecting etc, that beside the injection possibility opens still worse attacking vector that can even cause RCE or used to create persistent exploits. <details><summary>Here is the nominal condition how arguments will be parsed in Windows...</summary> cmd line|arg1|arg2 ---|---|--- abc" "def|abc def| abc\\" \\"def|abc"|"def "abc\\" \\"def"|abc" "def| "abc"" ""def"|abc" "def| abc"" ""def|abc|def abc""" """def|abc" "def| abc\\""" \\"""def|abc"|"def abc\\\\""" \\\\"""def|abc\\" \\"def "abc"""def" ghi"|abc"def ghi| "abc"""def" ghi * missing close qoute at end|abc"def ghi| "abc""def" ghi|abc"def|ghi "abc\\"""def" ghi|abc""def|ghi "abc\\\\"""def" ghi"|abc\\"def ghi| "abc\\\\\\"""def" ghi|abc\\""def|ghi "abc\\\\\\\\"""def" ghi"|abc\\\\"def ghi| </details> For PoC one could use any lang like tcl, python, etc, or even a self-written executable getting the argc/argv from main. The above diff and nominal condition was generated using this python script on Windows box: ```python from sys import argv; del argv[0]; print(str(len(argv)) + ' | ' + ' | '.join(argv)) ``` ## References [Related PR](https://github.com/reactos/reactos/pull/5186) with fix for ReactOS. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2472

3 6

[PATCH v2 0/1] MR2481: wldap32: Handle null DN or null message in ldap_delete* and add tests.
by Alex Henrie (＠alexhenrie) March 23, 2023

March 23, 2023

On Windows, ldap_delete_(ext_)s returns LDAP_UNWILLING_TO_PERFORM when trying to delete an entry that cannot be deleted. On Unix, LDAP_SERVER_DOWN is returned instead. Unix also returns LDAP_SERVER_DOWN immediately from ldap_delete_ext if the entry cannot be deleted, whereas Windows queues an asynchronous operation and returns LDAP_SUCCESS. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54702 -- v2: wldap32: Handle null DN or null message in ldap_delete* and add tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/2481

3 5

[PATCH 0/11] MR2484: wineps: Initial work on writing ps data in print processor
by Piotr Caban (＠piotr) March 23, 2023

March 23, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2484

2 12

[PATCH v4 0/3] MR1895: Fixes for NtOpenFile of read-only files with FILE_WRITE_ATTRIBUTES
by Joel Holdsworth (＠jhol) March 23, 2023

March 23, 2023

Previously, the Wine implementation of `NtOpenFile` would fail to open read-only files for `FILE_WRITE_ATTRIBUTES` access in wine-server, because it would attempt to open the file with `O_RDWR` or `O_WRONLY` access. This patch-set adds test cases to highlight the issue, and solves it by only opening the file with write access where necessary. * Wine Bug: [#50771](https://bugs.winehq.org/show_bug.cgi?id=50771) * Related Wine-Staging Patches: * [0002-server-Allow-to-open-files-without-any-permission-bi.patch](https://gi… * [0006-ntdll-tests-Added-tests-for-open-behaviour-on-readon.patch](https://gi… * [0007-server-FILE_WRITE_ATTRIBUTES-should-succeed-for-read.patch](https://gi… -- v4: server: Allow to open read-only files with FILE_WRITE_ATTRIBUTES server: Open code FILE_UNIX_{READ,WRITE}_ACCESS ntdll/tests: Added tests for attributes access on read-only files. https://gitlab.winehq.org/wine/wine/-/merge_requests/1895

2 3

Re: [PATCH v10 0/1] MR2183: winecfg: Add an option to set WinRT app dark theme.
by Alexandre Julliard (＠julliard) March 23, 2023

March 23, 2023

> How's this? > > Thanks for the review! :smiley: Actually thinking some more about this, a simple check mark may be better than a drop-down. It's not like there would be other possible options. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2183#note_27620

1 0

[PATCH 0/3] MR2483: kernelbase: Refactor create_key() in the same way as open_key().
by Sven Baars (＠sbaars) March 23, 2023

March 23, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2483

2 3

[PATCH v2 0/5] MR2452: imm32: Implement ImmEnumInputContext.
by Rémi Bernon March 23, 2023

March 23, 2023

-- v2: imm32: Rename InputContextData to struct imc. imm32: Use NtUserQueryInputContext to check cross-thread access. imm32: Remove unused IMM_IsCrossThreadAccess hwnd parameter. imm32: Remove unnecessary threadDefault InputContextData member. imm32: Implement ImmEnumInputContext. https://gitlab.winehq.org/wine/wine/-/merge_requests/2452

1 6

Re: [PATCH v2 0/4] MR2364: wine{alsa,coreaudio,oss,pulse}: Use GetModuleFileName() instead of hardcoded module filename for registry key.
by Huw Davies (＠huw) March 23, 2023

March 23, 2023

On Thu Mar 23 03:02:29 2023 +0000, Davide Beatrici wrote: > How should we proceed then? Well, let's leave the default endpoints in pulse for now, but don't add them to any other drivers. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2364#note_27609

1 0

Re: [PATCH v10 0/1] MR2183: winecfg: Add an option to set WinRT app dark theme.
by Mohamad Al-Jaf (＠maljaf) March 23, 2023

March 23, 2023

On Wed Mar 22 08:48:00 2023 +0000, Alexandre Julliard wrote: > These strings should be translatable. How's this? Thanks for the review! :smiley: -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2183#note_27604

1 0

Re: [PATCH v10 0/1] MR2183: winecfg: Add an option to set WinRT app dark theme.
by Mohamad Al-Jaf (＠maljaf) March 23, 2023

March 23, 2023

On Wed Mar 22 08:48:00 2023 +0000, Alexandre Julliard wrote: > It's a dword key, treating it as a string is ugly. I agree. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2183#note_27603

1 0

Re: [PATCH v10 0/1] MR2183: winecfg: Add an option to set WinRT app dark theme.
by Mohamad Al-Jaf (＠maljaf) March 23, 2023

March 23, 2023

On Wed Mar 22 08:47:59 2023 +0000, Alexandre Julliard wrote: > This shouldn't be necessary, unless there's an app that explicitly > checks the value. None that I know of, removed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2183#note_27602

1 0

[PATCH v9 0/1] MR2183: winecfg: Add an option to set WinRT app dark theme.
by Mohamad Al-Jaf (＠maljaf) March 23, 2023

March 23, 2023

This is what it looks like: ![Screenshot_20230310_015941](/uploads/99b3d279bcddbd40212808a045444a7b/Screenshot_20230310_015941.png) -- v9: winecfg: Add an option to set WinRT app dark theme. https://gitlab.winehq.org/wine/wine/-/merge_requests/2183

2 1

[PATCH v3 0/4] MR2465: windows.ui: Add Stubbed interface IUISettings
by Alistair Leslie-Hughes (＠alesliehughes) March 23, 2023

March 23, 2023

This corrects what interface should be returned, there isn't a hierarchy with these IUISettings at all. It should return IUISettings and then QI for any others that it requires. -- v3: windows.ui: Use DEFINE_IINSPECTABLE for IUISettings3 windows.ui: Add IUISettings2 stub interface windows.ui: Add Stubbed interface IUISettings include: Add Missing IUISettings interfaces. https://gitlab.winehq.org/wine/wine/-/merge_requests/2465

3 8

[PATCH 0/1] MR2481: wldap32: Handle null DN or null message in ldap_delete* and add tests.
by Alex Henrie (＠alexhenrie) March 23, 2023

March 23, 2023

On Windows, ldap_delete_(ext_)s returns LDAP_UNWILLING_TO_PERFORM when trying to delete an entry that cannot be deleted. On Unix, LDAP_SERVER_DOWN is returned instead. Unix also returns LDAP_SERVER_DOWN immediately from ldap_delete_ext if the entry cannot be deleted, whereas Windows queues an asynchronous operation and returns LDAP_SUCCESS. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54702 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2481

3 2

[PATCH v7 0/5] MR2258: winegstreamer: Support WMV DMO decoder.
by Ziqing Hui (＠zhui) March 23, 2023

March 23, 2023

-- v7: winegstreamer: Implement ProcessInput and ProcessOutput for WMV decoder DMO. winegstreamer: Create wg_transform for WMV decoder. winegstreamer: Better handle framerate. winegstreamer: Add format field to wmv wg_format. mf/tests: Test time length returned by ProcessOutput. https://gitlab.winehq.org/wine/wine/-/merge_requests/2258

4 12

[PATCH 0/3] MR2480: ddraw: SetSurfaceDesc() refactoring, part 6.
by Zebediah Figura (＠zfigura) March 23, 2023

March 23, 2023

This concludes the series. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2480

3 4

Re: [PATCH v2 0/4] MR2364: wine{alsa,coreaudio,oss,pulse}: Use GetModuleFileName() instead of hardcoded module filename for registry key.
by Davide Beatrici (＠davidebeatrici) March 23, 2023

March 23, 2023

On Thu Mar 16 16:04:48 2023 +0000, Gabriel Ivăncescu wrote: > I think they're still useful, since they're the only "movable" devices > (in PA Volume Control for example). They use the largest channel mask > out of all the sources/sinks, so it's not a problem to have them movable > with no notifications to the app, unlike the others. How should we proceed then? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2364#note_27595

1 0

[PATCH 0/3] MR2456: widl: Improve error messages source location.
by Rémi Bernon March 23, 2023

March 23, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2456

3 5

Re: [PATCH v3 0/1] MR2150: include: Allow multiple definitions on GCC with DECLSPEC_SELECTANY. - approved
by Alexandre Julliard (＠julliard) March 22, 2023

March 22, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2150

1 0

Re: [PATCH v2 0/1] MR2464: include: Add missing TS_STATUS constants in textstor.idl. - approved
by Alexandre Julliard (＠julliard) March 22, 2023

March 22, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2464

1 0

Re: [PATCH v4 0/5] MR2445: kernelbase: Some more open_key() and create_key() refactoring. - approved
by Alexandre Julliard (＠julliard) March 22, 2023

March 22, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2445

1 0

Re: [PATCH v4 0/2] MR2240: Winedbg to load 64bit modules for a wow64 debuggee in multi-arch config. - approved
by Alexandre Julliard (＠julliard) March 22, 2023

March 22, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2240

1 0

Re: [PATCH v3 0/5] MR2432: ddraw: SetSurfaceDesc() and ddraw_surface_create() refactoring, part 5. - approved
by Alexandre Julliard (＠julliard) March 22, 2023

March 22, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2432

1 0

Re: [PATCH v2 0/9] MR2466: dinput: Fix IDirectInputDevice8_SetActionMap. - approved
by Alexandre Julliard (＠julliard) March 22, 2023

March 22, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2466

1 0

Re: [PATCH v3 0/1] MR2462: wldap32: Handle null DN or null attr in ldap_compare* and add tests. - approved
by Alexandre Julliard (＠julliard) March 22, 2023

March 22, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2462

1 0

Re: [PATCH v2 0/1] MR2461: wldap32: Annotate allocation functions with __WINE_(DEALLOC|MALLOC). - approved
by Alexandre Julliard (＠julliard) March 22, 2023

March 22, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2461

1 0

Re: [PATCH v2 0/1] MR2460: include: Annotate ldap_(*_attribute|get_dn)* with __WINE_(DEALLOC|MALLOC). - approved
by Alexandre Julliard (＠julliard) March 22, 2023

March 22, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2460

1 0

Re: [PATCH v2 0/1] MR2459: winemac: Fix memory leak in UpdateDisplayDevices. - approved
by Alexandre Julliard (＠julliard) March 22, 2023

March 22, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2459

1 0

Re: [PATCH v8 0/2] MR2306: msado15: Implement _Recordset Open - approved
by Alexandre Julliard (＠julliard) March 22, 2023

March 22, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2306

1 0

Re: [PATCH v3 0/4] MR2436: d3dcompiler: Always initialize output shader blob pointer in D3DCompile2(). - approved
by Alexandre Julliard (＠julliard) March 22, 2023

March 22, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2436

1 0

[PATCH 0/1] MR2477: include: Use hexadecimal constants for XAudio flags.
by Zebediah Figura (＠zfigura) March 22, 2023

March 22, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2477

2 1

[PATCH 0/1] MR2471: winegstreamer: In video_processor, activate a videoflip converter.
by eric pouech (＠epo) March 22, 2023

March 22, 2023

The app I'm considering opens a video_processor on its own, with a NV12 format on input and a ARGB32 format on output. Tested on Windows: the samples are flipped vertically. While Wine keeps them untouched. So added a videoflip in the video processor to be activated when needed. Current activation is based on RGB vs non RGB input/output formats. Set as draft as if somehow related to MR!2159. Comments welcomed. Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2471

4 3

[PATCH 0/1] MR2474: include: Add D3D10CalcSubresource().
by Zebediah Figura (＠zfigura) March 22, 2023

March 22, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2474

2 1

[PATCH v2 0/1] MR2463: dwmapi: Sleep in DwmFlush().
by Paul Gofman (＠gofman) March 22, 2023

March 22, 2023

wine-gecko started calling dwmapi since dwmapi stubs were improved between Wine 7 and 8. It loops in gfxWindowsPlatform.cpp:VBlankLoop() in a tight loop now because DwmFlush() is a no-op. Besides unneeded CPU load that also causes hangs on exit in Final Fantasy XIV launcher. The launcher can't get WM_QUIT message in its message loop because it constantly gets the messages queued from VBlankLoop() while processing previous "nsAppShell:EventID" message. DwmFlush() is supposed to wait until next VBlank. My supplied test only tests that the wait is not alertable, but I also ad-hoc tested that the delay time introduced by DmwFlush() is between 0 and display refresh frequency. -- v2: dwmapi: Sleep in DwmFlush(). https://gitlab.winehq.org/wine/wine/-/merge_requests/2463

2 1

[PATCH 0/1] MR2463: dwmapi: Sleep in DwmFlush().
by Paul Gofman (＠gofman) March 22, 2023

March 22, 2023

wine-gecko started calling dwmapi since dwmapi stubs were improved between Wine 7 and 8. It loops in gfxWindowsPlatform.cpp:VBlankLoop() in a tight loop now because DwmFlush() is a no-op. Besides unneeded CPU load that also causes hangs on exit in Final Fantasy XIV launcher. The launcher can't get WM_QUIT message in its message loop because it constantly gets the messages queued from VBlankLoop() while processing previous "nsAppShell:EventID" message. DwmFlush() is supposed to wait until next VBlank. My supplied test only tests that the wait is not alertable, but I also ad-hoc tested that the delay time introduced by DmwFlush() is between 0 and display refresh frequency. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2463

3 4

[PATCH 0/5] MR2469: wined3d: move stubs out of state tables
by Max Figura (＠maxfigura) March 22, 2023

March 22, 2023

Removing WINED3D_RS entries from state tables and moving stubs to wined3d_device_apply_stateblock. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2469

4 7

[PATCH 0/5] MR2452: imm32: Implement ImmEnumInputContext.
by Rémi Bernon March 22, 2023

March 22, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2452

2 9