March 2023 - Wine-GitLab - list.winehq.org

[PATCH v4 0/3] MR2449: win32u: Add a few device GPU properties.
by Paul Gofman (＠gofman) March 22, 2023

March 22, 2023

Diablo IV (closed beta) depends on DEVPKEY_Device_MatchingDeviceId being present for GPUs (once it is able to match GPU luid to the one obtained from dxgi). It also depends on the MatchingDeviceId conating "ven_" and "dev_" substrings. Without those it doesn't consider the gpu as valid, which currently results in the game complaining about no GPUs found. I guess that maybe it is trying to filter out software GPUs and such this way. As far as my testing goes, DEVPKEY_Device_MatchingDeviceId has this form with hardware GPUs only and maybe with the recent enough Win10 or Win11. The other two device properties being added are also queried by the game although they are not strictly needed for it. -- v4: win32u: Set DEVPKEY_Device_RemovalPolicy for GPUs. win32u: Set DEVPKEY_Device_BusNumber for GPUs. win32u: Set DEVPKEY_Device_MatchingDeviceId for GPUs. https://gitlab.winehq.org/wine/wine/-/merge_requests/2449

2 4

[PATCH v2 0/2] MR109: vkd3d-shader/hlsl: Improve handling of builtin aliases "matrix" and "vector".
by Nikolay Sivov (＠nsivov) March 22, 2023

March 22, 2023

-- v2: vkd3d-shader/hlsl: Improve handling of builtin alias type "vector". https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/109

4 6

[PATCH v2 0/1] MR132: Release 1.7.
by Henri Verbeet (＠hverbeet) March 22, 2023

March 22, 2023

-- v2: Release 1.7. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/132

2 1

[PATCH 0/1] MR132: Release 1.7.
by Henri Verbeet (＠hverbeet) March 22, 2023

March 22, 2023

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/132

2 1

[PATCH v2 0/5] MR2432: ddraw: SetSurfaceDesc() and ddraw_surface_create() refactoring, part 5.
by Zebediah Figura (＠zfigura) March 22, 2023

March 22, 2023

Out of what will probably end up being 6 total parts. -- v2: ddraw: Make ddraw_surface_init() static. ddraw: Move sub-resource surface creation to ddraw_texture_init(). https://gitlab.winehq.org/wine/wine/-/merge_requests/2432

3 7

[PATCH v2 0/4] MR2465: windows.ui: Add Stubbed interface IUISettings
by Alistair Leslie-Hughes (＠alesliehughes) March 22, 2023

March 22, 2023

This corrects what interface should be returned, there isn't a hierarchy with these IUISettings at all. It should return IUISettings and then QI for any others that it requires. -- v2: windows.ui: Use DEFINE_IINSPECTABLE for IUISettings3 windows.ui: Add IUISettings2 stub interface windows.ui: Add Stubbed interface IUISettings include: Add Missing IUISettings interfaces. https://gitlab.winehq.org/wine/wine/-/merge_requests/2465

3 5

[PATCH v2 0/1] MR2462: wldap32: Handle null DN or null attr in ldap_compare* and add tests.
by Alex Henrie (＠alexhenrie) March 22, 2023

March 22, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54702 -- v2: wldap32: Handle null DN or null attr in ldap_compare* and add tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/2462

3 2

[PATCH 0/1] MR2461: wldap32: Annotate allocation functions with __WINE_(DEALLOC|MALLOC).
by Alex Henrie (＠alexhenrie) March 22, 2023

March 22, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2461

3 2

[PATCH 0/1] MR2460: include: Annotate ldap_(*_attribute|get_dn)* with __WINE_(DEALLOC|MALLOC).
by Alex Henrie (＠alexhenrie) March 22, 2023

March 22, 2023

I missed these in commit fd99bd4e247a879e8cb186212d1dc66268aa0888, sorry. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2460

3 2

[PATCH v8 0/2] MR2183: winecfg: Add an option to set WinRT app dark theme.
by Mohamad Al-Jaf (＠maljaf) March 22, 2023

March 22, 2023

This is what it looks like: ![Screenshot_20230310_015941](/uploads/99b3d279bcddbd40212808a045444a7b/Screenshot_20230310_015941.png) -- v8: winecfg: Add an option to set WinRT app dark theme. wine.inf: Add AppsUseLightTheme key. https://gitlab.winehq.org/wine/wine/-/merge_requests/2183

3 6

[PATCH 0/9] MR2466: dinput: Fix IDirectInputDevice8_SetActionMap.
by Rémi Bernon March 22, 2023

March 22, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2466

1 9

[PATCH v3 0/5] MR2445: kernelbase: Some more open_key() and create_key() refactoring.
by Sven Baars (＠sbaars) March 22, 2023

March 22, 2023

There is one more patch series of refactoring create_key() after this one, then I can start implementing things. -- v3: kernelbase: Return the last existing key from open_key() when it's called from create_key(). kernelbase: Pass a name pointer to open_key(). kernelbase: Use open_key() to obtain any existing Wow6432node in create_key(). kernelbase: Call open_key() from open_subkey(). https://gitlab.winehq.org/wine/wine/-/merge_requests/2445

2 5

[PATCH v4 0/2] MR2429: msvcrt100: Add stub implementation for _UnrealizedChore::CheckTaskCollection
by Vijay Kiran Kamuju (＠infyquest) March 22, 2023

March 22, 2023

Add stub implementation for _UnrealizedChore::CheckTaskCollection https://bugs.winehq.org/show_bug.cgi?id=53794 -- v4: Update dlls/concrt140/concrt140.spec, dlls/msvcr100/msvcr100.spec, dlls/msvcr110/msvcr110.spec, dlls/msvcr120/msvcr120.spec, dlls/msvcr120_app/msvcr120_app.spec https://gitlab.winehq.org/wine/wine/-/merge_requests/2429

3 3

[PATCH 0/3] MR2465: windows.ui: Add Stubbed interface IUISettings
by Alistair Leslie-Hughes (＠alesliehughes) March 22, 2023

March 22, 2023

This corrects what interface should be returned, there isn't a hierarchy with these IUISettings at all. It should return IUISettings and then QI for any others that it requires. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2465

3 13

[PATCH 0/1] MR2464: include: Add missing TS_STATUS constants in textstor.idl.
by Biswapriyo Nath (＠Biswa96) March 22, 2023

March 22, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2464

2 1

[PATCH v3 0/3] MR2449: win32u: Add a few device GPU properties.
by Paul Gofman (＠gofman) March 22, 2023

March 22, 2023

Diablo IV (closed beta) depends on DEVPKEY_Device_MatchingDeviceId being present for GPUs (once it is able to match GPU luid to the one obtained from dxgi). It also depends on the MatchingDeviceId conating "ven_" and "dev_" substrings. Without those it doesn't consider the gpu as valid, which currently results in the game complaining about no GPUs found. I guess that maybe it is trying to filter out software GPUs and such this way. As far as my testing goes, DEVPKEY_Device_MatchingDeviceId has this form with hardware GPUs only and maybe with the recent enough Win10 or Win11. The other two device properties being added are also queried by the game although they are not strictly needed for it. -- v3: win32u: Set DEVPKEY_Device_RemovalPolicy for GPUs. win32u: Set DEVPKEY_Device_BusNumber for GPUs. win32u: Set DEVPKEY_Device_MatchingDeviceId for GPUs. https://gitlab.winehq.org/wine/wine/-/merge_requests/2449

4 13

[PATCH 0/1] MR2462: wldap32: Handle null DN or null attr in ldap_compare* and add tests.
by Alex Henrie (＠alexhenrie) March 22, 2023

March 22, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54702 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2462

3 2

[PATCH v2 0/4] MR2436: d3dcompiler: Always initialize output shader blob pointer in D3DCompile2().
by Nikolay Sivov (＠nsivov) March 21, 2023

March 21, 2023

-- v2: d3dcompiler: Fix bytecode buffer leaks in D3DCompile2(). d3dcompiler: Always free messages string in D3DCompile2(). d3dcompiler: Allow D3DCompile2() to succeed with null output shader blob pointer. d3dcompiler: Always initialize output shader blob pointer in D3DCompile2(). https://gitlab.winehq.org/wine/wine/-/merge_requests/2436

3 8

[PATCH 0/1] MR2459: winemac: Fix memory leak in UpdateDisplayDevices.
by Brendan Shanks (＠bshanks) March 21, 2023

March 21, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2459

2 1

Re: [PATCH v2 0/5] MR2430: wined3d: move stubs out of state tables - approved
by Alexandre Julliard (＠julliard) March 21, 2023

March 21, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2430

1 0

Re: [PATCH v3 0/6] MR2453: dinput: Always create device object properties. - approved
by Alexandre Julliard (＠julliard) March 21, 2023

March 21, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2453

1 0

Re: [PATCH v2 0/2] MR2454: imm32/tests: Fix some test failures on Windows with Korean locale. - approved
by Alexandre Julliard (＠julliard) March 21, 2023

March 21, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2454

1 0

Re: [PATCH v2 0/1] MR2457: dinput/tests: Flush messages after creating the test_mouse_keyboard window. - approved
by Alexandre Julliard (＠julliard) March 21, 2023

March 21, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2457

1 0

Re: [PATCH v2 0/2] MR2450: wldap32: Handle null DN or null message in ldap_add* and ldap_modify* and add tests. - approved
by Alexandre Julliard (＠julliard) March 21, 2023

March 21, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2450

1 0

Re: [PATCH v4 0/1] MR2380: quartz: Set filter sync source in FilterGraph2_AddFilter. - approved
by Alexandre Julliard (＠julliard) March 21, 2023

March 21, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2380

1 0

Re: [PATCH v2 0/1] MR2451: include: Add IDirectManipulationInteractionEventHandler declaration in directmanipulation.idl. - approved
by Alexandre Julliard (＠julliard) March 21, 2023

March 21, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2451

1 0

[PATCH 0/5] MR2430: wined3d: move stubs out of state tables
by Max Figura (＠maxfigura) March 21, 2023

March 21, 2023

Removing WINED3D_RS entries from state tables and moving stubs to wined3d_device_apply_stateblock. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2430

4 7

Re: [PATCH v4 0/1] MR2413: comctl32: Fix the problem that listview cannot display all files.
by Nikolay Sivov (＠nsivov) March 21, 2023

March 21, 2023

For commit message it's better to have some description message, and not duplicating what code actually does. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2413#note_27434

1 0

[PATCH 0/6] MR2458: uiautomationcore: Test fixes, cache normalization, and root element retrieval functions.
by Connor McAdams (＠cmcadams) March 21, 2023

March 21, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2458

3 10

[PATCH v4 0/1] MR129: tests: Read integer uniforms with strtol() and strtoul().
by Giovanni Mascellani (＠giomasce) March 21, 2023

March 21, 2023

Because %i sscanf() converters are deprecated, and in practice clamp to [-2^31, 2^31) on 32 bit. -- v4: tests: Read integer uniforms with strtol() and strtoul(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/129

4 3

[PATCH v2 0/5] MR2445: kernelbase: Some more open_key() and create_key() refactoring.
by Sven Baars (＠sbaars) March 21, 2023

March 21, 2023

There is one more patch series of refactoring create_key() after this one, then I can start implementing things. -- v2: kernelbase: Return the last existing key from open_key() when it's called from create_key(). kernelbase: Pass a name pointer to open_key(). kernelbase: Use open_key() to obtain any existing Wow6432node in create_key(). kernelbase: Call open_key() from open_subkey(). advapi32/tests: Copy Software\Classes tests from ntdll. https://gitlab.winehq.org/wine/wine/-/merge_requests/2445

3 10

[PATCH v3 0/1] MR129: tests: Read integer uniforms with strtol() and strtoul().
by Giovanni Mascellani (＠giomasce) March 21, 2023

March 21, 2023

Because %i sscanf() converters are deprecated, and in practice clamp to [-2^31, 2^31) on 32 bit. -- v3: tests: Read integer uniforms with strtol() and strtoul(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/129

3 5

[PATCH v2 0/6] MR2453: dinput: Always create device object properties.
by Rémi Bernon March 21, 2023

March 21, 2023

In preparation to keep action map app data in there, for `SetActionMap`. -- v2: dinput: Always set the DIPROP_BUFFERSIZE property in SetActionMap. dinput: Initialize SetActionMap variables in their declarations. dinput: Always allocate and initialize the object_properties. dinput: Move mouse_create_device function around. dinput: Initialize device object format when creating devices. dinput: Count the actual number of object formats in SetActionMap. https://gitlab.winehq.org/wine/wine/-/merge_requests/2453

1 7

[PATCH 0/1] MR2434: include: Add memory clobber to GCC asm statement in NtCurrentTeb().
by Jinoh Kang (＠iamahuman) March 21, 2023

March 21, 2023

Today, NtCurrentTeb() has a single asm statement when compiling for the i386, x86-64, or ARM architecture with GCC. This single asm statement has neither the "volatile" qualifier nor the "memory" clobber. This can provoke undefined behavior if the current TEB changes between NtCurrentTeb() calls. This is because GCC assumes that the asm statement does not depend on memory or the thread-local register. In fact, given the same address of the "teb" variable, GCC assumes that the asm statement produces exactly the same value on every invocaton. This primarily causes issues when switching to another fiber from a thread that is different from the thread on which the fiber was last executed. Theoretically, however, this may also cause issues when the optimizer aliases the "teb" variable to another variable that is shared between threads, and perform global optimization that can work across multiple threads in runtime (if any). Fix this by adding the "memory" clobber to the asm statements that computes the current TEB address. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2434

4 9

[PATCH 0/1] MR2457: dinput/tests: Flush messages after creating the test_mouse_keyboard window.
by Rémi Bernon March 21, 2023

March 21, 2023

Preventing spurious failures on some Windows 7 VMs. Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=54713 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2457

1 1

Re: [PATCH v2 0/1] MR2429: msvcrt100: Add stub implementation for _UnrealizedChore::CheckTaskCollection
by Piotr Caban (＠piotr) March 21, 2023

March 21, 2023

Piotr Caban (@piotr) commented about dlls/concrt140/concrt140.spec: > @ stub -arch=arm ?_Cancel(a)_TaskCollection@details(a)Concurrency@@QAAXXZ > @ stub -arch=i386 ?_Cancel(a)_TaskCollection@details(a)Concurrency@@QAEXXZ > @ stub -arch=win64 ?_Cancel(a)_TaskCollection@details(a)Concurrency@@QEAAXXZ > -@ stub -arch=arm ?_CheckTaskCollection(a)_UnrealizedChore@details(a)Concurrency@@IAAXXZ > -@ stub -arch=i386 ?_CheckTaskCollection(a)_UnrealizedChore@details(a)Concurrency@@IAEXXZ > -@ stub -arch=win64 ?_CheckTaskCollection(a)_UnrealizedChore@details(a)Concurrency@@IEAAXXZ > +@ cdecl -arch=arm ?_CheckTaskCollection(a)_UnrealizedChore@details(a)Concurrency@@IAAXXZ() UnrealizedChore_CheckTaskCollection > +@ cdecl -arch=i386 ?_CheckTaskCollection(a)_UnrealizedChore@details(a)Concurrency@@IAEXXZ() UnrealizedChore_CheckTaskCollection > +@ cdecl -arch=win64 ?_CheckTaskCollection(a)_UnrealizedChore@details(a)Concurrency@@IEAAXXZ() UnrealizedChore_CheckTaskCollection The function uses `thiscall` calling convention. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2429#note_27393

1 0

[PATCH 0/2] MR2454: imm32/tests: Fix some test failures on Windows with Korean locale.
by Rémi Bernon March 21, 2023

March 21, 2023

Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=54710 Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=54711 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2454

1 2

[PATCH 0/5] MR2453: dinput: Always create device object properties.
by Rémi Bernon March 21, 2023

March 21, 2023

In preparation to keep action map app data in there, for `SetActionMap`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2453

1 5

[PATCH 0/2] MR2450: wldap32: Handle null DN or null message in ldap_add* and ldap_modify* and add tests.
by Alex Henrie (＠alexhenrie) March 21, 2023

March 21, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54702 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2450

3 3

[PATCH 0/1] MR2451: include: Add IDirectManipulationInteractionEventHandler declaration in directmanipulation.idl.
by Biswapriyo Nath (＠Biswa96) March 21, 2023

March 21, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2451

2 1

[PATCH v2 0/3] MR2449: win32u: Add a few device GPU properties.
by Paul Gofman (＠gofman) March 20, 2023

March 20, 2023

Diablo IV (closed beta) depends on DEVPKEY_Device_MatchingDeviceId being present for GPUs (once it is able to match GPU luid to the one obtained from dxgi). It also depends on the MatchingDeviceId conating "ven_" and "dev_" substrings. Without those it doesn't consider the gpu as valid, which currently results in the game complaining about no GPUs found. I guess that maybe it is trying to filter out software GPUs and such this way. As far as my testing goes, DEVPKEY_Device_MatchingDeviceId has this form with hardware GPUs only and maybe with the recent enough Win10 or Win11. The other two device properties being added are also queried by the game although they are not strictly needed for it. -- v2: win32u: Set DEVPKEY_Device_RemovalPolicy for GPUs. https://gitlab.winehq.org/wine/wine/-/merge_requests/2449

3 5

[PATCH 0/3] MR2449: win32u: Add a few device GPU properties.
by Paul Gofman (＠gofman) March 20, 2023

March 20, 2023

Diablo IV (closed beta) depends on DEVPKEY_Device_MatchingDeviceId being present for GPUs (once it is able to match GPU luid to the one obtained from dxgi). It also depends on the MatchingDeviceId conating "ven_" and "dev_" substrings. Without those it doesn't consider the gpu as valid, which currently results in the game complaining about no GPUs found. I guess that maybe it is trying to filter out software GPUs and such this way. As far as my testing goes, DEVPKEY_Device_MatchingDeviceId has this form with hardware GPUs only and maybe with the recent enough Win10 or Win11. The other two device properties being added are also queried by the game although they are not strictly needed for it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2449

4 5

Re: [PATCH v3 0/1] MR2443: include: Annotate LDAP allocation functions with __WINE_(DEALLOC|MALLOC). - approved
by Alexandre Julliard (＠julliard) March 20, 2023

March 20, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2443

1 0

Re: [PATCH v2 0/5] MR2448: mshtml: Ref leak fixes. - approved
by Alexandre Julliard (＠julliard) March 20, 2023

March 20, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2448

1 0

[PATCH v3 0/1] MR2390: winegstreamer: Cache wg_parser input data.
by Derek Lesho (＠dlesho) March 20, 2023

March 20, 2023

On my Steam Deck, this reduces the time it takes to initialize the wg_parser radically (by around 1 second). This helps in the game WILD HEARTS, which doesn't present while loading help videos during gameplay, causing large stutters. Because GStreamer can randomly access the file with no known pattern on our side, I opted to implement this by buffering 4 chunks so that interleaved reads to different areas of the file don't cause us to discard and reload cached data more than we need to. -- v3: winegstreamer: Cache wg_parser input data. https://gitlab.winehq.org/wine/wine/-/merge_requests/2390

3 5

Re: [PATCH v4 0/5] MR2444: widl: More lexer simplification. - approved
by Alexandre Julliard (＠julliard) March 20, 2023

March 20, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2444

1 0

Re: [PATCH v2 0/5] MR2447: dinput: Fix IDirectInputDevice8_BuildActionFormat. - approved
by Alexandre Julliard (＠julliard) March 20, 2023

March 20, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2447

1 0

Re: [PATCH v2 0/1] MR2446: mscoree/tests: Avoid temporary directory name collisions. - approved
by Alexandre Julliard (＠julliard) March 20, 2023

March 20, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2446

1 0

Re: [PATCH v2 0/4] MR2437: d3d10/effect: Add support for a few more instructions in preshaders - approved
by Alexandre Julliard (＠julliard) March 20, 2023

March 20, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2437

1 0

Re: [PATCH v2 0/2] MR2433: ntdll: Open application manifest files with FILE_SHARE_DELETE. - approved
by Alexandre Julliard (＠julliard) March 20, 2023

March 20, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2433

1 0

Re: [PATCH v6 0/3] MR2403: crypt32: Add some CertGetNameStringW fallback cases - approved
by Alexandre Julliard (＠julliard) March 20, 2023

March 20, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2403

1 0

Re: [PATCH v5 0/5] MR2422: win32u: Implement NtUserBuildHimcList syscall. - approved
by Alexandre Julliard (＠julliard) March 20, 2023

March 20, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2422

1 0

Re: [PATCH v2 0/4] MR2427: uiautomationcore: IUIAutomationTreeWalker implementation. - approved
by Alexandre Julliard (＠julliard) March 20, 2023

March 20, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2427

1 0

Re: [PATCH v2 0/1] MR2440: adsldp/tests: Fix test failures. - approved
by Alexandre Julliard (＠julliard) March 20, 2023

March 20, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2440

1 0

Re: [PATCH v2 0/1] MR130: vkd3d-shader: VKD3D_SHADER_COMPILE_OPTION_WRITE_TESS_GEOM_POINT_SIZE was introduced in vkd3d 1.7. - approved
by Alexandre Julliard (＠julliard) March 20, 2023

March 20, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/130

1 0

Re: [PATCH v3 0/1] MR2380: quartz: Set filter sync source in FilterGraph2_AddFilter. - approved
by Zebediah Figura (＠zfigura) March 20, 2023

March 20, 2023

This merge request was approved by Zebediah Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2380

1 0

[PATCH v20 0/4] MR2105: ddraw: Add local buffer in d3d_device7_DrawPrimitive()
by Steve Schnepp (＠steveschnepp) March 20, 2023

March 20, 2023

Convert all consecutive calls to d7_DrawPrimitive(TRIANGLE_FAN) into a single call to d7_DrawPrimitive(TRIANGLE_LIST) with all the vertices. Note, it *increase* the number of vertices, but bandwith is much less costly than multiple calls. Note, only a very precise subset of the calls get buffered in order to ensure that the disruption is minimal. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=33814 -- v20: ddraw: Increasing the vertex batch size on demand https://gitlab.winehq.org/wine/wine/-/merge_requests/2105

2 4

[PATCH v2 0/1] MR2443: include: Annotate LDAP allocation functions with __WINE_(DEALLOC|MALLOC).
by Alex Henrie (＠alexhenrie) March 20, 2023

March 20, 2023

-- v2: https://gitlab.winehq.org/wine/wine/-/merge_requests/2443

3 2

[PATCH 0/5] MR2448: mshtml: Ref leak fixes.
by Gabriel Ivăncescu March 20, 2023

March 20, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2448

2 6

[PATCH 0/1] MR130: vkd3d-shader: VKD3D_SHADER_COMPILE_OPTION_WRITE_TESS_GEOM_POINT_SIZE was introduced in vkd3d 1.7.
by Henri Verbeet (＠hverbeet) March 20, 2023

March 20, 2023

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/130

2 1

[PATCH v3 0/5] MR2444: widl: More lexer simplification.
by Rémi Bernon March 20, 2023

March 20, 2023

-- v3: widl: Lex calling convention variations toghether. widl: Simplify reserved keywords lexing. widl: Simplify preprocessor directive lexing. widl: Remove unused lexer aliases. widl: Simplify uuid literals lexing. https://gitlab.winehq.org/wine/wine/-/merge_requests/2444

2 7

[PATCH v2 0/5] MR2444: widl: More lexer simplification.
by Rémi Bernon March 20, 2023

March 20, 2023

-- v2: widl: Lex calling convention variations toghether. widl: Simplify reserved keywords lexing. widl: Simplify preprocessor directive lexing. widl: Remove unused lexer aliases. widl: Simplify uuid literals lexing. https://gitlab.winehq.org/wine/wine/-/merge_requests/2444

2 9

[PATCH v2 0/1] MR2390: winegstreamer: Cache wg_parser input data.
by Derek Lesho (＠dlesho) March 20, 2023

March 20, 2023

On my Steam Deck, this reduces the time it takes to initialize the wg_parser radically (by around 1 second). This helps in the game WILD HEARTS, which doesn't present while loading help videos during gameplay, causing large stutters. Because GStreamer can randomly access the file with no known pattern on our side, I opted to implement this by buffering 4 chunks so that interleaved reads to different areas of the file don't cause us to discard and reload cached data more than we need to. -- v2: winegstreamer: Cache wg_parser input data. https://gitlab.winehq.org/wine/wine/-/merge_requests/2390

3 3

[PATCH 0/5] MR2445: kernelbase: Some more open_key() and create_key() refactoring.
by Sven Baars (＠sbaars) March 20, 2023

March 20, 2023

There is one more patch series of refactoring create_key() after this one, then I can start implementing things. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2445

3 6

[PATCH 0/1] MR2446: mscoree/tests: Avoid temporary directory name collisions.
by Francois Gouget (＠fgouget) March 20, 2023

March 20, 2023

test_loadpaths_execute() was sometimes getting ERROR_ALREADY_EXISTS when creating its temporary directoryi. That was probably because GetTempFileNameW() only uses the low 16-bits of the 'random' LUID which goes over a wider range, potentially leading to collisions in the lower 16-bits. Avoid AllocateLocallyUniqueId() entirely and add a helper function to create a guaranteed new directory. Also try to use the current directory first as it is assumed to have been configured to ward off anti-virus programs (specifically Microsoft Defender) which is especially important when writing executables to that location. Only switch to the system's temporary directory if the current directory is not a writable location. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54560 --- There are a few other tests where I suspect occasional anti-virus interference. It may make sense to reuse this function in those. That said create_new_dir() uses entirely predictable sequenitial numbers which would be bad if attempting to create a secure directory. But the new directory does not even have special permissions and this type of attack shouldn't be an issue for the tests. Still, don't reuse this code in contexts where security matters. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2446

3 2

[PATCH 0/2] MR2443: include: Fix constness of arguments to LDAP functions and annotate with __WINE_(DEALLOC|MALLOC).
by Alex Henrie (＠alexhenrie) March 20, 2023

March 20, 2023

I need the header to be correct before I start writing tests. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2443

4 5

[PATCH 0/5] MR2447: dinput: Fix IDirectInputDevice8_BuildActionFormat.
by Rémi Bernon March 20, 2023

March 20, 2023

And begin some refactoring for `SetActionFormat`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2447

1 5

[PATCH 0/2] MR2436: d3dcompiler: Always initialize output shader blob pointer in D3DCompile2().
by Nikolay Sivov (＠nsivov) March 20, 2023

March 20, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2436

3 3

[PATCH 0/5] MR2444: widl: More lexer simplification.
by Rémi Bernon March 20, 2023

March 20, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2444

2 6

[PATCH 0/4] MR2437: d3d10/effect: Add support for a few more instructions in preshaders
by Nikolay Sivov (＠nsivov) March 20, 2023

March 20, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2437

3 6

[PATCH 0/2] MR2433: ntdll: Open application manifest files with FILE_SHARE_DELETE.
by Jinoh Kang (＠iamahuman) March 20, 2023

March 20, 2023

Today, RtlCreateActivationContext (CreateActCtxW) opens the source manifest file via NtOpenFile without the FILE_SHARE_DELETE sharing mode. This causes CreateActCtxW to fail if the source manifest file was created with the FILE_DELETE_ON_CLOSE flag. FILE_DELETE_ON_CLOSE is often used for temporary files that should be automatically deleted after use, even if the creator process crashes. Fix this by specifying FILE_SHARE_DELETE for sharing mode when opening the source manifest or module file. This allows the source manifest or module file to be marked as deleted while it is open. Note that concurrent deletion is not an issue for the following reasons: - The ability to read from an open file handle is unaffected by deletion of the corresponding file's name. - RtlCreateActivationContext does not open the source manifest or module file by the given filename (lpSource) more than once. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2433

4 4

[PATCH v2 0/1] MR129: tests: Read integer uniforms with strtol() and strtoul().
by Giovanni Mascellani (＠giomasce) March 20, 2023

March 20, 2023

Because %i sscanf() converters are deprecated, and in practice clamp to [-2^31, 2^31) on 32 bit. -- v2: tests: Read integer uniforms with strtol() and strtoul(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/129

3 2

[PATCH v2 0/1] MR127: vkd3d: Add an internal reference to a heap when a resource is placed there.
by Conor McCarthy (＠cmccarthy) March 20, 2023

March 20, 2023

Fixes a crash on exit in Horizon Zero Dawn (with SM 6.0 support added). The docs state it is required: https://learn.microsoft.com/en-us/windows/win32/api/d3d12/nf-d3d12-id3d12de… -- v2: vkd3d: Add an internal reference to a heap when a resource is placed there. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/127

4 4

[PATCH 0/6] MR2435: Draft: Fix activation context switching from SwitchToFiber().
by Jinoh Kang (＠iamahuman) March 20, 2023

March 20, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2435

3 7

[PATCH v5 0/3] MR2403: crypt32: Add some CertGetNameStringW fallback cases
by Tyson Whitehead (＠twhitehead) March 20, 2023

March 20, 2023

When called with CERT_NAME_ATTR_TYPE and pvTypePara=NULL, Windows did the first of email, CN, OU, or O while Wine just did email. This closes https://bugs.winehq.org/show_bug.cgi?id=54687. -- v5: crypt32: Document fields in original test certificate crypt32: Test for CertGetNameStringW fallback cases https://gitlab.winehq.org/wine/wine/-/merge_requests/2403

3 6

Re: [PATCH 0/2] MR2438: wine.inf.in: Add EditionID to HKEY_LOCAL_MACHINE\Software\Microsoft\Windows NT\CurrentVersion
by Hans Leidekker (＠hans) March 20, 2023

March 20, 2023

Hans Leidekker (@hans) commented about loader/wine.inf.in: > 00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,\ > 00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,\ > 00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00 > +HKLM,%CurrentVersionNT%,"EditionId",2,"Core" > HKLM,%CurrentVersionNT%,"ProductName",2,"Windows 10 Pro" Why "Core"? It seems to me that "Professional" would make more sense given that ProductName is "Windows 10 Pro". -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2438#note_27258

1 0

Re: [PATCH v7 0/3] MR2377: sppc: Add stubs for MS Office.
by Daniel Tang (＠danielzgtg) March 20, 2023

March 20, 2023

After today's rebase, I found a workaround for creating new documents. You can open an existing document, then click on the home tab, and create a new document in one of the tabs. There seems to a bit of UB left, but it's better than nothing. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2377#note_27257

1 0

[PATCH 0/108] MR2402: Draft: Release 7.0.2
by Michael Stefaniuc (＠mstefani) March 20, 2023

March 20, 2023

-- This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/2402

10 9

[PATCH 0/1] MR2371: ntdll: Update system_path to search for .sys files
by Tareque Md Hanif (＠tmdh) March 20, 2023

March 20, 2023

vgk.sys from Valorant wants to load cng.sys. But it fails. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2371

4 6

[PATCH 0/4] MR2427: uiautomationcore: IUIAutomationTreeWalker implementation.
by Connor McAdams (＠cmcadams) March 20, 2023

March 20, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2427

4 7

[PATCH 0/1] MR671: include: Add dxcore.idl
by Biswapriyo Nath (＠Biswa96) March 20, 2023

March 20, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/671

3 5

Re: [PATCH v4 0/1] MR2413: comctl32: Fix the problem that listview cannot display all files. - approved
by Zhiyi Zhang (＠zhiyi) March 20, 2023

March 20, 2023

This merge request was approved by Zhiyi Zhang. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2413

1 0

[PATCH 0/1] MR771: include: Add D3D10CalcSubresource definition in d3d10.idl.
by Biswapriyo Nath (＠Biswa96) March 20, 2023

March 20, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/771

3 4

[PATCH v2 0/1] MR2380: quartz: Set filter sync source in FilterGraph2_AddFilter.
by Shaun Ren (＠shaunren) March 20, 2023

March 20, 2023

This fixes a bug in the game "Nioh: The Complete Edition", where the videos after the first video are played too quickly. -- v2: quartz: Set filter sync source in FilterGraph2_AddFilter. https://gitlab.winehq.org/wine/wine/-/merge_requests/2380

2 2

[PATCH 0/1] MR2380: quartz: Set filter sync source in FilterGraph2_AddFilter.
by Shaun Ren (＠shaunren) March 20, 2023

March 20, 2023

This fixes a bug in the game "Nioh: The Complete Edition", where the videos after the first video are played too quickly. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2380

3 2

Re: [PATCH v2 0/7] MR2431: Fix the advapi32:service tests - approved
by Alexandre Julliard (＠julliard) March 20, 2023

March 20, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2431

1 0

Re: [PATCH v3 0/1] MR2426: widl: Avoid freeing input_name in pop_import. - approved
by Alexandre Julliard (＠julliard) March 20, 2023

March 20, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2426

1 0

Re: [PATCH v2 0/5] MR2424: widl: Cleanup lexer a bit and simplify string lexing. - approved
by Alexandre Julliard (＠julliard) March 20, 2023

March 20, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2424

1 0

Re: [PATCH v3 0/2] MR2425: kernelbase: Also call NtOpenKeyEx() on empty key names. - approved
by Alexandre Julliard (＠julliard) March 20, 2023

March 20, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2425

1 0

Re: [PATCH v2 0/1] MR2428: winedump: Fix printf format warning. - approved
by Alexandre Julliard (＠julliard) March 20, 2023

March 20, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2428

1 0

Re: [PATCH v4 0/12] MR2386: windows.perception.stub: Implement IHolographicSpaceStatics2/3 interfaces. - approved
by Alexandre Julliard (＠julliard) March 20, 2023

March 20, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2386

1 0

Re: [PATCH v2 0/3] MR2406: win32u: Give full access rights to the process window station. - approved
by Alexandre Julliard (＠julliard) March 20, 2023

March 20, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2406

1 0

Re: [PATCH v5 0/1] MR2367: comctl32/treeview: Ignore the lParam to WM_PRINTCLIENT and add tests. - approved
by Alexandre Julliard (＠julliard) March 20, 2023

March 20, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2367

1 0

Re: [PATCH v2 0/1] MR2423: adsldp/tests: Skip all remaining tests when the server is down. - approved
by Alexandre Julliard (＠julliard) March 20, 2023

March 20, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2423

1 0

[PATCH v19 0/4] MR2105: ddraw: Add local buffer in d3d_device7_DrawPrimitive()
by Steve Schnepp (＠steveschnepp) March 20, 2023

March 20, 2023

Convert all consecutive calls to d7_DrawPrimitive(TRIANGLE_FAN) into a single call to d7_DrawPrimitive(TRIANGLE_LIST) with all the vertices. Note, it *increase* the number of vertices, but bandwith is much less costly than multiple calls. Note, only a very precise subset of the calls get buffered in order to ensure that the disruption is minimal. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=33814 -- v19: ddraw: Increasing the vertex batch size on demand ddraw: add d3d_perf statistics on buffering wined3d: Add a TRACE in wined3d_streaming_buffer_unmap() ddraw: Add a local buffer in d3d_device7_DrawPrimitive() https://gitlab.winehq.org/wine/wine/-/merge_requests/2105

2 4

[PATCH v6 0/2] MR2306: msado15: Implement _Recordset Open
by Alistair Leslie-Hughes (＠alesliehughes) March 20, 2023

March 20, 2023

-- v6: msado15: Store all data from provider msado15: Bind fields in _Recordset Open https://gitlab.winehq.org/wine/wine/-/merge_requests/2306

2 2

Re: [PATCH v4 0/12] MR2386: windows.perception.stub: Implement IHolographicSpaceStatics2/3 interfaces.
by Mohamad Al-Jaf (＠maljaf) March 20, 2023

March 20, 2023

On Fri Mar 17 10:14:05 2023 +0000, Rémi Bernon wrote: > Yes, thanks a lot. > > Yeah, it might be useful to keep them around. I spent a long time > working on it so it would be nice to keep it, but perhaps I should first > split it up into smaller additions for easier review. In any case, > here's a branch of the headers in case you need it in the future: https://gitlab.winehq.org/maljaf/wine/-/commits/WinRT-Core > I can only imagine the time your spent, and thanks for doing that. It > may be arguably useful to have them in Wine, but at the same time it's > also a lot of additions. > The amount of code that is in the SDK IDL files is quite overwhelming, I > don't know if there's any saner way to have them than rewriting > everything by hand. They are actually generated from some binary > metadata, so maybe we could do that too (but then where to source this > metadata is a good question). > An alternative which I thought about was to implement IDL 3.0 syntax, > which I believe allows much terser interface / runtimeclass declaration, > and would generate the same header output. > Or, somehow, we could make WIDL compatible with the SDK IDL files, and > use them directly, but here like with the .winmd metadata, there's the > question of how to source it properly. > In any case I'm really not looking forward the time where we'll need to > stub or implement all these new interfaces... No problem, anything to make review easier for you. Yeah, it is a lot of additions. Maybe I'll wait for an application to need it before submitting it again, even if it's just for compilation like FireFox mingw. Interesting, I did notice the Windows SDK idl files say they are autogenerated at the top. Sourcing the metadata is indeed the main problem. There are some in C:\Windows\System32\WinMetadata and you could use the tool Ildasm.exe to disassemble them, but this seems like a grey area around clean room design and might be best to avoid it. Another option would be trial-and-error, just writing and rewriting binary metadata until it generates a similar idl file to the Windows SDK one. Though, I'm not sure if it's worth the effort. I took a look at the IDL 3.0 syntax and you're right, it's much more concise and would help with the bigger idl files like `windows.ui.core.idl`. The documentation is thorough: https://learn.microsoft.com/en-us/uwp/midl-3/intro I wouldn't mind stubbing the interfaces, though for windows.ui.core.idl there's definitely too many functions in the `ICoreWindow` interface alone. Implementing them is another issue, hopefully they're not too complex. Also, thanks for the review! :slight_smile: -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2386#note_27267

1 0

[PATCH 0/2] MR2442: wine.inf.in: Add EditionID to HKEY_LOCAL_MACHINE\Software\Microsoft\Windows NT\CurrentVersion
by Louis Lenders (＠xe) March 19, 2023

March 19, 2023

https://bugs.winehq.org/show_bug.cgi?id=54675 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2442

2 2

[PATCH v2 0/2] MR2438: wine.inf.in: Add EditionID to HKEY_LOCAL_MACHINE\Software\Microsoft\Windows NT\CurrentVersion
by Louis Lenders (＠xe) March 19, 2023

March 19, 2023

https://bugs.winehq.org/show_bug.cgi?id=54675 -- v2: wine.inf.in: Add EditionID to HKEY_LOCAL_MACHINE\Software\Microsoft\Windows NT\CurrentVersion (v2) https://gitlab.winehq.org/wine/wine/-/merge_requests/2438

3 7

[PATCH 0/2] MR2441: wine.inf.in: Add EditionID to HKEY_LOCAL_MACHINE\Software\Microsoft\Windows NT\CurrentVersion
by Louis Lenders (＠xe) March 19, 2023

March 19, 2023

https://bugs.winehq.org/show_bug.cgi?id=54675 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2441

2 3