March 2023 - Wine-GitLab - list.winehq.org

[PATCH v9 0/6] MR2275: winewayland.drv: part 1: Introduce the Wayland driver
by Alexandros Frantzis (＠afrantzis) March 14, 2023

March 14, 2023

Introduction ------------ This is the first of (many) parts in the upstreaming of the Wayland driver for Wine. Since the amount of code and commits is large, my approach is to upstream the driver in multiple parts in a serial fashion, with each part being a cohesive (to the degree possible) set of not too many commits. When each part is reviewed and merged, I will move on to proposing the next part. My main goal with this approach is to make reviewing easier and more focused. If you have other ideas about how to improve this process for the reviewers, please let me know. A lot of pieces need to fall into place before the driver becomes even remotely functional, so, some MRs (especially the initial ones) will be a bit more preparatory in nature. To aid in the understanding of and justification for some of the code introduced in such MRs, all the remaining driver commits are always going to be available at https://gitlab.winehq.org/afrantzis/wine/-/tree/wayland. Part 1 ------- ~~This MR introduces the Wayland driver PE and unixlib components with some basic code, and prepares the makedep tool to be able to handle Wayland protocol files.~~ This MR introduces the Wayland driver PE and unixlib components with some basic code, and reports some basic monitor information to Wine. Please see the individual commit message for more details. Some questions I would appreciate some feedback on in the context of this MR: 1. Should the Wayland driver build be enabled by default at this point? (currently it's explicitly opt-in with --with-wayland) 2. How should the Wayland driver build be integrated with CI? (currently piggybacking on gitlab/build-linux by adding --with-wayland) Note that building the Wayland driver should not affect running/testing on X11/Xwayland etc, since it's placed lower in the driver priority list. ~~Part 2 preview: We will handle basic Wayland wl_output (i.e., display) events and populate the Wine monitor information.~~ Part 2 preview: We will report more monitor information and implement GetCurrentDisplaySettings. -- v9: winewayland.drv: Report all advertised monitor modes to Wine. winewayland.drv: Report basic monitor information. win32u: Allow drivers to set the null user driver. winewayland.drv: Perform basic per-process Wayland initialization. winewayland.drv: Add initial unixlib stub. winewayland.drv: Add initial driver stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/2275

3 8

[PATCH 0/1] MR2393: d3d8/tests: Remove an unused call to IDirect3D8_GetAdapterDisplayMode().
by Francois Gouget (＠fgouget) March 14, 2023

March 14, 2023

It is no longer used now that test_fpu_setup() uses create_device(). Note that there is no such call in d3d9:device so no patch is needed on that side. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2393

4 3

[PATCH 0/1] MR2400: wined3d: Sort the exports.
by Henri Verbeet (＠hverbeet) March 14, 2023

March 14, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2400

3 2

[PATCH 0/1] MR2399: d3d11: Get rid of the DXBC tag definitions.
by Henri Verbeet (＠hverbeet) March 14, 2023

March 14, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2399

3 3

[PATCH v3 0/1] MR2376: wintypes: Stub RoIsApiContractMajorVersionPresent().
by Daniel Tang (＠danielzgtg) March 14, 2023

March 14, 2023

This is one of the stubs required for MS Office 365. -- v3: wintypes: Stub RoIsApiContractMajorVersionPresent(). https://gitlab.winehq.org/wine/wine/-/merge_requests/2376

4 6

[PATCH 0/1] MR2157: ntdll/unix: Init the trap handler.
by eric pouech (＠epo) March 14, 2023

March 14, 2023

Otherwise we get nested exceptions on linux on any breakpoint in a multi-arch wow64 (AMD64) configuration, running a 32bit debuggee. With this patch, winetest kernel32:debugger runs to the end (it times out without), yet spitting a couple of failures (that don't exist in old wow64 configuration). Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2157

2 4

[PATCH 0/6] MR2389: wined3d: Deduplicate the different get_line() variants.
by Henri Verbeet (＠hverbeet) March 14, 2023

March 14, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2389

4 8

[PATCH 0/5] MR2360: wined3d: move stubs out of state tables
by Max Figura (＠maxfigura) March 14, 2023

March 14, 2023

Removing WINED3D_RS entries from state tables and moving stubs to wined3d_device_apply_stateblock. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2360

4 7

[PATCH 0/5] MR2353: ddraw: SetSurfaceDesc() refactoring, part 3.
by Zebediah Figura (＠zfigura) March 14, 2023

March 14, 2023

In truth this part is actually just ddraw_surface_create() refactoring, but it came about while working on SetSurfaceDesc()... -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2353

4 8

[PATCH 0/1] MR2390: winegstreamer: Cache wg_parser input data.
by Derek Lesho (＠dlesho) March 14, 2023

March 14, 2023

On my Steam Deck, this reduces the time it takes to initialize the wg_parser radically (by around 1 second). This helps in the game WILD HEARTS, which doesn't present while loading help videos during gameplay, causing large stutters. Because GStreamer can randomly access the file with no known pattern on our side, I opted to implement this by buffering 4 chunks so that interleaved reads to different areas of the file don't cause us to discard and reload cached data more than we need to. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2390

3 3

Re: [PATCH v2 0/16] MR2386: windows.perception.stub: Implement IHolographicSpaceStatics2/3 interfaces.
by Rémi Bernon March 14, 2023

March 14, 2023

Rémi Bernon (@rbernon) commented about include/windows.graphics.holographic.idl: > +import "windows.graphics.directx.direct3d11.idl"; > +import "windows.perception.idl"; > +import "windows.perception.spatial.idl"; > +import "windows.ui.core.idl"; > + > +namespace Windows.Graphics.Holographic { > + typedef enum HolographicFramePresentResult HolographicFramePresentResult; > + typedef enum HolographicFramePresentWaitBehavior HolographicFramePresentWaitBehavior; > + typedef struct HolographicAdapterId HolographicAdapterId; > + typedef struct HolographicStereoTransform HolographicStereoTransform; > + > + interface IHolographicCameraPose; > + interface IHolographicCameraRenderingParameters; > + interface IHolographicFrame; > + interface IHolographicFramePrediction; > + interface IHolographicSpaceStatics2; If you only forward declare `IHolographicSpaceStatics` here, you don't need its definition later in the file, as you also don't implement it. This then makes 5ec7b6eecc89f2e88df836e1e68c9d59fa640816 ad31506143de193058129e2981818b6e7fc5c252 8fbfa09fd86eb7306688e0914c44964860165a0d 2e1f8bd100e040e8025c5801cecdf7636187582c aaeb3ffc5ce074ddea6a16e5b28788f73b1fd12c also unnecessary, which to be honest, seems appealing to me at least from a review perspective, given the number of new classes and interfaces. Of course, we might need them later and could be useful to keep them around, but then it would be nice to have it done more gradually if possible. Regarding 04ee932ff5e261b9aceee47542f91aa6b4f115c1, and for similar changes, it'd be nice to make smaller additions, for instance adding one interface definition at a time (and its dependencies if they aren't too much, or add them beforehand), so that reviewing what needs what is easier. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2386#note_26841

1 0

[PATCH v2 0/1] MR2367: comctl32/treeview: Ignore the lParam to WM_PRINTCLIENT and add tests.
by Alex Henrie (＠alexhenrie) March 14, 2023

March 14, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54640 -- v2: comctl32/treeview: Ignore the lParam to WM_PRINTCLIENT and add tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/2367

3 2

[PATCH v4 0/4] MR2355: win32u: Keep the current user locale when enumerating layouts.
by Rémi Bernon March 14, 2023

March 14, 2023

-- v4: winex11: Remove now unnecessary user locale change checks. win32u: Prevent user locale change in NtUserActivateKeyboardLayout. win32u: Keep the current user locale when loading layout. win32u: Keep the current user locale when enumerating layouts. https://gitlab.winehq.org/wine/wine/-/merge_requests/2355

1 5

[PATCH 0/4] MR2395: imm32: Implement ImmLoadIME and ImmFreeLayout.
by Rémi Bernon March 14, 2023

March 14, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2395

1 4

[PATCH v5 0/3] MR2377: sppc: Add stubs for MS Office.
by Daniel Tang (＠danielzgtg) March 14, 2023

March 14, 2023

After this and the related MRs, MS Office 365 finally loads. We see the fancy start screen, and we need modify the options to trust the folder we have our Word documents in. This works for `WINWORD.EXE`, `EXCEL.EXE` and `POWERPNT.exe`. I am able to open an existing file and view it. This MR is limited to showing the first page or so of the Word document. It freezes with the Wine crash dialog basically the moment right after the screen is rendered. There is no backtrace in the dialog, but winedbg points to `v8jsi.dll` and so does the console output without winedbg. Creating new documents is not achieved by this MR either. -- v5: Sleep forever in SLOpen. Add SLGetApplicationPolicy stub. Add SLLoadApplicationPolicies stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/2377

4 8

[PATCH v2 0/1] MR2375: wofutil: Stub WofIsExternalFile().
by Daniel Tang (＠danielzgtg) March 14, 2023

March 14, 2023

This fixes a crash in `OneDriveSetup.exe`. It still doesn't install with "A supported version of Windows 10 or Windows 11 is required to proceed," but at least it doesn't crash. After this patch, we can now see the OneDrive logo, the progress bar, and the "Installing OneDrive" label. -- v2: wofutil: Stub WofIsExternalFile(). https://gitlab.winehq.org/wine/wine/-/merge_requests/2375

4 6

[PATCH v4 0/1] MR2377: sppc: Add stubs for MS Office.
by Daniel Tang (＠danielzgtg) March 14, 2023

March 14, 2023

After this and the related MRs, MS Office 365 finally loads. We see the fancy start screen, and we need modify the options to trust the folder we have our Word documents in. This works for `WINWORD.EXE`, `EXCEL.EXE` and `POWERPNT.exe`. I am able to open an existing file and view it. This MR is limited to showing the first page or so of the Word document. It freezes with the Wine crash dialog basically the moment right after the screen is rendered. There is no backtrace in the dialog, but winedbg points to `v8jsi.dll` and so does the console output without winedbg. Creating new documents is not achieved by this MR either. -- v4: sppc: Add stubs for MS Office. https://gitlab.winehq.org/wine/wine/-/merge_requests/2377

4 5

[PATCH v2 0/1] MR2379: windows.networking: Stub DllGetActivationFactory().
by Daniel Tang (＠danielzgtg) March 14, 2023

March 14, 2023

With this MR, now I can create documents in Word. Applied together with my other patches, we will have the 3 main apps of Microsoft Office working! -- v2: windows.networking: Stub DllGetActivationFactory(). https://gitlab.winehq.org/wine/wine/-/merge_requests/2379

2 2

[PATCH v2 0/1] MR2376: wintypes: Stub RoIsApiContractMajorVersionPresent().
by Daniel Tang (＠danielzgtg) March 14, 2023

March 14, 2023

This is one of the stubs required for MS Office 365. -- v2: wintypes: Stub RoIsApiContractMajorVersionPresent(). https://gitlab.winehq.org/wine/wine/-/merge_requests/2376

4 5

Re: [PATCH v2 0/1] MR2392: winedump: Print static lib EC symbols. - approved
by Alexandre Julliard (＠julliard) March 13, 2023

March 13, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2392

1 0

Re: [PATCH v2 0/1] MR2391: jscript: Fix jsstr leak after changing variant type to BSTR. - approved
by Alexandre Julliard (＠julliard) March 13, 2023

March 13, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2391

1 0

Re: [PATCH v4 0/1] MR2369: comdlg32/tests: Fix itemdlg tests on Windows. - approved
by Alexandre Julliard (＠julliard) March 13, 2023

March 13, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2369

1 0

Re: [PATCH v2 0/1] MR2384: vbscript/tests: Fix the testChrError() tests in the mixed locale case. - approved
by Alexandre Julliard (＠julliard) March 13, 2023

March 13, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2384

1 0

Re: [PATCH v2 0/5] MR2388: imm32: Cleanup in preparation for ImmLoadIME / ImmFreeLayout implementation. - approved
by Alexandre Julliard (＠julliard) March 13, 2023

March 13, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2388

1 0

Re: [PATCH v2 0/1] MR2381: wldap32: Add ldap_set_dbg_flags stub. - approved
by Alexandre Julliard (＠julliard) March 13, 2023

March 13, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2381

1 0

Re: [PATCH v5 0/1] MR2372: kernel32/tests: Fix tls callback tests on Windows 7 - approved
by Alexandre Julliard (＠julliard) March 13, 2023

March 13, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2372

1 0

Re: [PATCH v2 0/1] MR2370: wow64: fix missing conversion of ThreadWineNativeThreadName in wow64_NtSetInformationThread - approved
by Alexandre Julliard (＠julliard) March 13, 2023

March 13, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2370

1 0

Re: [PATCH v3 0/5] MR2352: uiautomationcore: Miscellaneous COM API patches. - approved
by Alexandre Julliard (＠julliard) March 13, 2023

March 13, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2352

1 0

Re: [PATCH v2 0/2] MR123: vkd3d-shader: Location information fixes after the introduction of instruction arrays. - approved
by Alexandre Julliard (＠julliard) March 13, 2023

March 13, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/123

1 0

Re: [PATCH v2 0/2] MR122: vkd3d-shader/sm4: Set "dst_count" to 0 when we clear "dst" in shader_sm4_read_instruction(). - approved
by Alexandre Julliard (＠julliard) March 13, 2023

March 13, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/122

1 0

[PATCH 0/1] MR2391: jscript: Fix jsstr leak after changing variant type to BSTR.
by Gabriel Ivăncescu March 13, 2023

March 13, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2391

2 2

[PATCH 0/1] MR2392: winedump: Print static lib EC symbols.
by Jacek Caban (＠jacek) March 13, 2023

March 13, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2392

2 1

[PATCH v3 0/1] MR2369: comdlg32/tests: Fix itemdlg tests on Windows.
by Florian Will (＠w-flo) March 13, 2023

March 13, 2023

I'm not sure if the GetTempPathW() dir is okay for this. d3dx11 seems to do the same in tests, so I copied that approach. Commit message: The wine testbot runs tests with C:\Users\Public\Documents as the working directory. Itemdlg tests create test files in the working directory and then try to select them for opening in an IFileOpenDialog. The dialog has its SetFolder method called to point it to the current working directory before showing the dialog, in order for the test code to find the test files it had created there just before opening the dialog. On Windows, this failed because calling the dialog's SetFolder method with C:\Users\Public\Documents doesn't work as expected. The dialog points to the C:\Users\\[CURRENT_USER]\Documents directory instead. Subsequently, the test would be unable to select the test file because it doesn't exist in that directory. So the dialog wouldn't accept the file and close itself to finish the test, but show an error message instead, resulting in a test timeout. To fix this, set the current working directory to the temporary directory before calling individual itemdlg test_* functions. Switch back to the previous working directory after tests finish. -- v3: comdlg32/tests: Fix itemdlg tests on Windows. https://gitlab.winehq.org/wine/wine/-/merge_requests/2369

3 2

[PATCH 0/2] MR123: vkd3d-shader: Location information fixes after the introduction of instruction arrays.
by Henri Verbeet (＠hverbeet) March 13, 2023

March 13, 2023

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/123

2 2

[PATCH 0/2] MR122: vkd3d-shader/sm4: Set "dst_count" to 0 when we clear "dst" in shader_sm4_read_instruction().
by Henri Verbeet (＠hverbeet) March 13, 2023

March 13, 2023

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/122

2 2

[PATCH v8 0/6] MR2275: winewayland.drv: part 1: Introduce the Wayland driver
by Alexandros Frantzis (＠afrantzis) March 13, 2023

March 13, 2023

Introduction ------------ This is the first of (many) parts in the upstreaming of the Wayland driver for Wine. Since the amount of code and commits is large, my approach is to upstream the driver in multiple parts in a serial fashion, with each part being a cohesive (to the degree possible) set of not too many commits. When each part is reviewed and merged, I will move on to proposing the next part. My main goal with this approach is to make reviewing easier and more focused. If you have other ideas about how to improve this process for the reviewers, please let me know. A lot of pieces need to fall into place before the driver becomes even remotely functional, so, some MRs (especially the initial ones) will be a bit more preparatory in nature. To aid in the understanding of and justification for some of the code introduced in such MRs, all the remaining driver commits are always going to be available at https://gitlab.winehq.org/afrantzis/wine/-/tree/wayland. Part 1 ------- ~~This MR introduces the Wayland driver PE and unixlib components with some basic code, and prepares the makedep tool to be able to handle Wayland protocol files.~~ This MR introduces the Wayland driver PE and unixlib components with some basic code, and reports some basic monitor information to Wine. Please see the individual commit message for more details. Some questions I would appreciate some feedback on in the context of this MR: 1. Should the Wayland driver build be enabled by default at this point? (currently it's explicitly opt-in with --with-wayland) 2. How should the Wayland driver build be integrated with CI? (currently piggybacking on gitlab/build-linux by adding --with-wayland) Note that building the Wayland driver should not affect running/testing on X11/Xwayland etc, since it's placed lower in the driver priority list. ~~Part 2 preview: We will handle basic Wayland wl_output (i.e., display) events and populate the Wine monitor information.~~ Part 2 preview: We will report more monitor information and implement GetCurrentDisplaySettings. -- v8: winewayland.drv: Report all advertised monitor modes to Wine. winewayland.drv: Report basic monitor information. https://gitlab.winehq.org/wine/wine/-/merge_requests/2275

3 7

[PATCH 0/1] MR2384: vbscript/tests: Fix the testChrError() tests in the mixed locale case.
by Francois Gouget (＠fgouget) March 13, 2023

March 13, 2023

VBscript actually uses the default code page of the user default locale which may not be the same as CP_THREAD_ACP. Also for locales that don't have an ANSI code page, such as Hindi, it falls back to UTF-8. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54003 --- Not sure how I missed the mixed locales case before. This time I made sure to run it in all of the TestBot's supported locales and it looks all good: https://testbot.winehq.org/JobDetails.pl?Key=130549 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2384

3 2

[PATCH 0/5] MR2388: imm32: Cleanup in preparation for ImmLoadIME / ImmFreeLayout implementation.
by Rémi Bernon March 13, 2023

March 13, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2388

1 5

[PATCH 0/1] MR2381: wldap32: Add ldap_set_dbg_flags stub.
by Alex Henrie (＠alexhenrie) March 13, 2023

March 13, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54663 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2381

3 2

[PATCH v2 0/4] MR2387: Draft: winegstreamer: Use codec format in stream_props_GetMediaType.
by Ziqing Hui (＠zhui) March 13, 2023

March 13, 2023

According to the tests in 23b72ad, when we are reading a compressed stream, the type returned by `stream_props_GetMediaType()` should reflect compressed format even if we finnally output uncomressed data. For example, if we use wmvcore reader to read a WMV3 stream and output RGB24, the format information returned by `stream_props_GetMediaType()` should be WMV3, not RGB24. This patch set is marked as draft now, because PATCH 2 and PATCH 3 is affected by 3e8936a2 in MR !2258. So I'll submit a newer version of this after !2258 get merged. -- v2: winegstreamer: Use codec format in stream_props_GetMediaType. winegstreamer: Implement amt_from_wg_format_video_wmv. winegstreamer: Implement wg_format_from_caps_video_wmv. winegstreamer: Implement wg_parser_stream_get_codec_format. https://gitlab.winehq.org/wine/wine/-/merge_requests/2387

2 4

[PATCH 0/4] MR2387: Draft: winegstreamer: Use codec format in stream_props_GetMediaType.
by Ziqing Hui (＠zhui) March 13, 2023

March 13, 2023

According to the tests in 23b72ad, when we are reading a compressed stream, the type returned by `stream_props_GetMediaType()` should reflect compressed format even if we finnally output uncomressed data. For example, if we use wmvcore reader to read a WMV3 stream and output RGB24, the format information returned by `stream_props_GetMediaType()` should be WMV3, not RGB24. This patch set is marked as draft now, because PATCH 2 and PATCH 3 is affected by 3e8936a2 in MR !2258. So I'll submit a newer version of this after !2258 get merged. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2387

2 4

[PATCH 0/1] MR1945: Draft: winegstreamer: Return correct format in stream_props_GetMediaType.
by Ziqing Hui (＠zhui) March 13, 2023

March 13, 2023

This patch doesn't work now. Zebediah, I think I need your help. My goal is to get the original stream format in `stream_props_GetMediaType()`. For example, if I use wmreader to open a WMV3 stream, then this function should return WMV3 format as its result. I expect preferred_format to hold the format I need. But test shows that preferred_format is always RGB24 even if I open a WMV stream. I found that preferred_format is written in `wg_parser.c: sink_event_cb(): case GST_EVENT_CAPS`. So it means that the caps here is "video/x-raw", not "video/x-wmv" as I expected. So how could I get the stream format I want when I open a compressed stream using wmreader? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1945

3 9

[PATCH 0/16] MR2386: windows.perception.stub: Implement IHolographicSpaceStatics2/3 interfaces.
by Mohamad Al-Jaf (＠maljaf) March 13, 2023

March 13, 2023

Needed by the VR game Desperate: Vladivostok. `IHolographicSpaceStatics2::get_IsSupported()` only returns `FALSE` on 32-bit Windows 10, but the VMs are 64-bit. -- This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/2386

1 0

[PATCH 0/1] MR2385: openssh installer by chocolatey fails to install because of missing regkey.
by Louis Lenders (＠xe) March 12, 2023

March 12, 2023

See https://community.chocolatey.org/packages/openssh#files (tools\chocolateyinstall.ps1) $EditionId = (Get-ItemProperty -Path 'HKLM:\SOFTWARE\Microsoft\Windows NT\CurrentVersion' -Name 'EditionID').EditionId -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2385

3 3

[PATCH v3 0/2] MR2240: Winedbg to load 64bit modules for a wow64 debuggee in multi-arch config.
by eric pouech (＠epo) March 12, 2023

March 12, 2023

This series intent is to let winedbg (and dbghelp) load the 64bit PE modules of a wow64 debuggee. At this stage, all debug info of all modules (PE and ELF) are properly loaded (and displayed with 'info wow share' command). Breakpoint and backtrace in 64bit code of a wow64 debuggee are not available. The serie contains: - extension of tests to show that 64bit load dll events are generated for a wow64 debuggee (for a 64bit debugger, not for a 32bit one) - change for adapting filtering of events I opted for doing it in ntdll and passing the machine of the mapping in request's reply. Please advisde if you'd prefer another approach. -- v3: server,ntdll,wow64: Move filter of (un)load DLL debug events to client side. kernel32/tests: Extend the tests for load/unload debug events on Wow64. https://gitlab.winehq.org/wine/wine/-/merge_requests/2240

2 3

[PATCH v2 0/1] MR2383: shell32: Avoid stack corruption caused by long URLs
by Stefan Rentsch (＠restet) March 12, 2023

March 12, 2023

Previously long URI/URLs (> 1024 characters) would cause a stack corruption and crash Wine. After this MR, Wine will no longer crash but the URL is not opened either primarily due to `SHELL_Argify` limitations. -- v2: shell32: Avoid stack corruption caused by long URLs https://gitlab.winehq.org/wine/wine/-/merge_requests/2383

3 2

[PATCH v4 0/1] MR2372: kernel32/tests: Fix tls callback tests on Windows 7
by Evan Tang (＠etang-cw) March 12, 2023

March 12, 2023

Fixes broken tests introduced in 2203a8564c5faba383a3512f8244dba12d79da16 Looks like on Windows 7, if a dll has no entry point, no tls callbacks are run. On Windows 10, the `DLL_PROCESS_ATTACH` is run but nothing else. By having an entry point, everything is run like you'd expect Also changes the tests to test the full set of process/thread attach/detach -- v4: kernel32/tests: Fix tls callback tests on Windows 7 https://gitlab.winehq.org/wine/wine/-/merge_requests/2372

3 2

[PATCH 0/1] MR2379: windows.networking: Stub DllGetActivationFactory().
by Daniel Tang (＠danielzgtg) March 11, 2023

March 11, 2023

With this MR, now I can create documents in Word. Applied together with my other patches, we will have the 3 main apps of Microsoft Office working! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2379

3 2

[PATCH 0/1] MR2383: shell32: Avoid stack corruption caused by long URLs
by Stefan Rentsch (＠restet) March 11, 2023

March 11, 2023

Previously long URI/URLs (> 1024 characters) would cause a stack corruption and crash Wine. After this MR, Wine will no longer crash but the URL is not opened either primarily due to `SHELL_Argify` limitations. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2383

3 2

[PATCH 0/1] MR2375: wofutil: Stub WofIsExternalFile().
by Daniel Tang (＠danielzgtg) March 11, 2023

March 11, 2023

This fixes a crash in `OneDriveSetup.exe`. It still doesn't install with "A supported version of Windows 10 or Windows 11 is required to proceed," but at least it doesn't crash. After this patch, we can now see the OneDrive logo, the progress bar, and the "Installing OneDrive" label. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2375

3 3

[PATCH v3 0/1] MR2377: sppc: Add stubs for MS Office.
by Daniel Tang (＠danielzgtg) March 11, 2023

March 11, 2023

After this and the related MRs, MS Office 365 finally loads. We see the fancy start screen, and we need modify the options to trust the folder we have our Word documents in. This works for `WINWORD.EXE`, `EXCEL.EXE` and `POWERPNT.exe`. I am able to open an existing file and view it. This MR is limited to showing the first page or so of the Word document. It freezes with the Wine crash dialog basically the moment right after the screen is rendered. There is no backtrace in the dialog, but winedbg points to `v8jsi.dll` and so does the console output without winedbg. Creating new documents is not achieved by this MR either. -- v3: sppc: Add stubs for MS Office. https://gitlab.winehq.org/wine/wine/-/merge_requests/2377

4 4

[PATCH 0/3] MR2382: npptools: Add CreateBlob and DestroyBlob stubs.
by Alex Henrie (＠alexhenrie) March 11, 2023

March 11, 2023

After stubbing the two functions, the program is able to at least print its help text and describe what it can do. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54671 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2382

2 3

[PATCH v2 0/1] MR2369: comdlg32/tests: Fix itemdlg tests on Windows.
by Florian Will (＠w-flo) March 11, 2023

March 11, 2023

I'm not sure if the GetTempPathW() dir is okay for this. d3dx11 seems to do the same in tests, so I copied that approach. Commit message: The wine testbot runs tests with C:\Users\Public\Documents as the working directory. Itemdlg tests create test files in the working directory and then try to select them for opening in an IFileOpenDialog. The dialog has its SetFolder method called to point it to the current working directory before showing the dialog, in order for the test code to find the test files it had created there just before opening the dialog. On Windows, this failed because calling the dialog's SetFolder method with C:\Users\Public\Documents doesn't work as expected. The dialog points to the C:\Users\\[CURRENT_USER]\Documents directory instead. Subsequently, the test would be unable to select the test file because it doesn't exist in that directory. So the dialog wouldn't accept the file and close itself to finish the test, but show an error message instead, resulting in a test timeout. To fix this, set the current working directory to the temporary directory before calling individual itemdlg test_* functions. Switch back to the previous working directory after tests finish. -- v2: comdlg32/tests: Fix itemdlg tests on Windows. https://gitlab.winehq.org/wine/wine/-/merge_requests/2369

2 1

[PATCH 0/1] MR2369: comdlg32/tests: Fix itemdlg tests on Windows.
by Florian Will (＠w-flo) March 11, 2023

March 11, 2023

I'm not sure if the GetTempPathW() dir is okay for this. d3dx11 seems to do the same in tests, so I copied that approach. Commit message: The wine testbot runs tests with C:\Users\Public\Documents as the working directory. Itemdlg tests create test files in the working directory and then try to select them for opening in an IFileOpenDialog. The dialog has its SetFolder method called to point it to the current working directory before showing the dialog, in order for the test code to find the test files it had created there just before opening the dialog. On Windows, this failed because calling the dialog's SetFolder method with C:\Users\Public\Documents doesn't work as expected. The dialog points to the C:\Users\\[CURRENT_USER]\Documents directory instead. Subsequently, the test would be unable to select the test file because it doesn't exist in that directory. So the dialog wouldn't accept the file and close itself to finish the test, but show an error message instead, resulting in a test timeout. To fix this, set the current working directory to the temporary directory before calling individual itemdlg test_* functions. Switch back to the previous working directory after tests finish. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2369

3 3

[PATCH v2 0/1] MR2373: quartz: Update sync source when running or pausing a filter graph.
by Shaun Ren (＠shaunren) March 11, 2023

March 11, 2023

This fixes a bug where after a sync source is assigned to a filter graph, subsequent filters added to the graph are not given the assigned sync source. This behaviour is expected by the game "Nioh: The Complete Edition", where multiple videos are rendered using the same filter graph. -- v2: quartz: Update sync source when running or pausing a filter graph. https://gitlab.winehq.org/wine/wine/-/merge_requests/2373

3 3

Re: [PATCH 0/1] MR45: ntdll: Always prefer native signal restorer over the custom one.
by Olivia/Isabelle Mahadevan (＠doubledge-spec) March 11, 2023

March 11, 2023

Any updates on this, @iamahuman? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/45#note_26726

1 0

[PATCH v5 0/3] MR2374: sppc: Stub SLInstallLicense and SLGetSLIDList
by Daniel Tang (＠danielzgtg) March 11, 2023

March 11, 2023

This allows Microsoft `OfficeSetup.exe` 365 to succeed again. It needs to be used with the revert described in https://bugs.winehq.org/show_bug.cgi?id=54667 . `OneDriveSetup.exe` crashes right after as before, but the Office 365 files get installed into the prefix. -- v5: sppc: Stub SLInstallLicense(). sppc: Stub SLGetSLIDList(). sppc: Declare implemented functions in slpublic.h https://gitlab.winehq.org/wine/wine/-/merge_requests/2374

2 4

[PATCH v2 0/1] MR2377: sppc: Add stubs for MS Office.
by Daniel Tang (＠danielzgtg) March 11, 2023

March 11, 2023

After this and the related MRs, MS Office 365 finally loads. We see the fancy start screen, and we need modify the options to trust the folder we have our Word documents in. This works for `WINWORD.EXE`, `EXCEL.EXE` and `POWERPNT.exe`. I am able to open an existing file and view it. This MR is limited to showing the first page or so of the Word document. It freezes with the Wine crash dialog basically the moment right after the screen is rendered. There is no backtrace in the dialog, but winedbg points to `v8jsi.dll` and so does the console output without winedbg. Creating new documents is not achieved by this MR either. -- v2: sppc: Add stubs for MS Office. https://gitlab.winehq.org/wine/wine/-/merge_requests/2377

2 1

[PATCH 0/1] MR2376: wintypes: Stub RoIsApiContractMajorVersionPresent().
by Daniel Tang (＠danielzgtg) March 11, 2023

March 11, 2023

This is one of the stubs required for MS Office 365. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2376

3 2

[PATCH v4 0/2] MR2374: sppc: Stub SLInstallLicense and SLGetSLIDList
by Daniel Tang (＠danielzgtg) March 11, 2023

March 11, 2023

This allows Microsoft `OfficeSetup.exe` 365 to succeed again. It needs to be used with the revert described in https://bugs.winehq.org/show_bug.cgi?id=54667 . `OneDriveSetup.exe` crashes right after as before, but the Office 365 files get installed into the prefix. -- v4: sppc: Stub SLInstallLicense(). sppc: Stub SLGetSLIDList(). https://gitlab.winehq.org/wine/wine/-/merge_requests/2374

3 5

[PATCH 0/1] MR2378: kernelbase: Trick V8's CHECK(old_protection == PAGE_READWRITE).
by Daniel Tang (＠danielzgtg) March 11, 2023

March 11, 2023

Now I can create spreadsheets in Excel, and presentations in PowerPoint. This is to be used with my other patches. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2378

2 1

[PATCH 0/1] MR2377: sppc: Add stubs for MS Office.
by Daniel Tang (＠danielzgtg) March 11, 2023

March 11, 2023

After this and the related MRs, MS Office 365 finally loads. We see the fancy start screen, and we need modify the options to trust the folder we have our Word documents in. This works for `WINWORD.EXE`, `EXCEL.EXE` and `POWERPNT.exe`. I am able to open an existing file and view it. This MR is limited to showing the first page or so of the Word document. It freezes with the Wine crash dialog basically the moment right after the screen is rendered. There is no backtrace in the dialog, but winedbg points to `v8jsi.dll` and so does the console output without winedbg. Creating new documents is not achieved by this MR either. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2377

3 2

[PATCH v3 0/1] MR2374: sppc: Stub SLInstallLicense and SLGetSLIDList
by Daniel Tang (＠danielzgtg) March 11, 2023

March 11, 2023

This allows Microsoft `OfficeSetup.exe` 365 to succeed again. It needs to be used with the revert described in https://bugs.winehq.org/show_bug.cgi?id=54667 . `OneDriveSetup.exe` crashes right after as before, but the Office 365 files get installed into the prefix. -- v3: sppc: Stub SLGetSLIDList(). https://gitlab.winehq.org/wine/wine/-/merge_requests/2374

2 1

[PATCH v2 0/2] MR2374: sppc: Stub SLInstallLicense and SLGetSLIDList
by Daniel Tang (＠danielzgtg) March 11, 2023

March 11, 2023

This allows Microsoft `OfficeSetup.exe` 365 to succeed again. It needs to be used with the revert described in https://bugs.winehq.org/show_bug.cgi?id=54667 . `OneDriveSetup.exe` crashes right after as before, but the Office 365 files get installed into the prefix. -- v2: sppc: Stub SLInstallLicense() sppc: Stub SLGetSLIDList(). https://gitlab.winehq.org/wine/wine/-/merge_requests/2374

3 4

Re: [PATCH v3 0/5] MR131: wined3d: Introduce wined3d_device_check_format_support().
by Chip Davis (＠cdavis5e) March 11, 2023

March 11, 2023

On Sat Mar 11 09:34:54 2023 +0000, Olivia/Isabelle Mahadevan wrote: > Any updates? Sorry. Between the time I initially submitted this and now, I got a new job, so I haven't been able to work on this much. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/131#note_26707

1 0

[PATCH 0/2] MR2374: sppc: Stub SLInstallLicense and SLGetSLIDList
by Daniel Tang (＠danielzgtg) March 11, 2023

March 11, 2023

This allows Microsoft `OfficeSetup.exe` 365 to succeed again. It needs to be used with the revert described in https://bugs.winehq.org/show_bug.cgi?id=54667 . `OneDriveSetup.exe` crashes right after as before, but the Office 365 files get installed into the prefix. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2374

2 2

[PATCH 0/1] MR2373: quartz: Update sync source when running or pausing a filter graph.
by Shaun Ren (＠shaunren) March 11, 2023

March 11, 2023

This fixes a bug where after a sync source is assigned to a filter graph, subsequent filters added to the graph are not given the assigned sync source. This behaviour is expected by the game "Nioh: The Complete Edition", where multiple videos are rendered using the same filter graph. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2373

3 2

Re: [PATCH v2 0/1] MR842: ntdll: add system32/drivers to dll search path
by Etaash Mathamsetty (＠etaash.mathamsetty) March 11, 2023

March 11, 2023

On Wed Sep 21 04:38:18 2022 +0000, **** wrote: > Zebediah Figura replied on the mailing list: > ``` > On 9/19/22 15:51, Etaash Mathamsetty (@etaash.mathamsetty) wrote: > > On Mon Sep 19 20:51:28 2022 +0000, Alexandre Julliard wrote: > >> This should be handled already by LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR. If > >> that doesn't work in your case you'll need to investigate why, but we > >> can't change the global search path for this. > > as far as I can tell LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR is for > LoadLibrary not the private search_dll_file function in loader.c (which > is where the problem originates from) > > > search_dll_file() is called by LoadLibrary() under normal circumstances. > What call stack are you seeing that's not covered by this case? > ``` the program doesn't actually call LoadLibrary, instead it was linked with cng.sys -- https://gitlab.winehq.org/wine/wine/-/merge_requests/842#note_26702

1 0

[PATCH v3 0/1] MR2372: Draft: kernel32/tests: Fix tls callback tests on Windows 7
by Evan Tang (＠etang-cw) March 11, 2023

March 11, 2023

MR opened for getting Windows 7 testbot runs, will turn into an actual MR when everything is confirmed working. -- v3: kernel32/tests: Fix tls callback tests on Windows 7 https://gitlab.winehq.org/wine/wine/-/merge_requests/2372

2 1

[PATCH 0/1] MR2372: Draft: kernel32/tests: Fix tls callback tests on Windows 7
by Evan Tang (＠etang-cw) March 11, 2023

March 11, 2023

MR opened for getting Windows 7 testbot runs, will turn into an actual MR when everything is confirmed working. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2372

2 1

Re: [PATCH v2 0/4] MR2364: wine{alsa,coreaudio,oss,pulse}: Use GetModuleFileName() instead of hardcoded module filename for registry key.
by Davide Beatrici (＠davidebeatrici) March 11, 2023

March 11, 2023

On Fri Mar 10 19:38:50 2023 +0000, Davide Beatrici wrote: > The idea would be to add a function to the unixlib that returns the > render and capture GUIDs. `mmdevapi` will take care of reading and > writing from/to the registry. Actually, I just realized only `winepulse` defines a GUID for the default render and capture device... Should we do that in the other drivers too? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2364#note_26687

1 0

[PATCH 0/1] MR2370: wow64: fix missing conversion of ThreadWineNativeThreadName in wow64_NtSetInformationThread
by Fan WenJie (＠fanwenjie) March 11, 2023

March 11, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2370

2 1

Re: [PATCH v7 0/0] MR2359: opengl32: fix bug abort missing convert of glUmapBuffer_params from 32bit to 64bit - closed
by Fan WenJie (＠fanwenjie) March 11, 2023

March 11, 2023

This merge request was closed by Fan WenJie. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2359

1 0

[PATCH v2 0/5] MR2352: uiautomationcore: Miscellaneous COM API patches.
by Connor McAdams (＠cmcadams) March 10, 2023

March 10, 2023

Add support for `UIAutomationType_ElementArray` properties in the COM API, and begin adding support for creating elements from cache requests in the COM API. -- v2: uiautomationcore: Implement IUIAutomationElement::BuildUpdatedCache. uiautomationcore/tests: Add tests for IUIAutomationElement caching methods. uiautomationcore: Implement IUIAutomation::CreateCacheRequest. uiautomationcore: Add support for element array properties in IUIAutomationElement::GetCurrentPropertyValueEx. https://gitlab.winehq.org/wine/wine/-/merge_requests/2352

3 7

Re: [PATCH v2 0/2] MR2368: wineps: PSDRV_WriteDIBPatternDict fixes - approved
by Alexandre Julliard (＠julliard) March 10, 2023

March 10, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2368

1 0

Re: [PATCH v2 0/4] MR2364: wine{alsa,coreaudio,oss,pulse}: Use GetModuleFileName() instead of hardcoded module filename for registry key. - approved
by Alexandre Julliard (＠julliard) March 10, 2023

March 10, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2364

1 0

Re: [PATCH v2 0/9] MR2365: imm32: More control flow reordering in preparation for ImmLoadIME implementation. - approved
by Alexandre Julliard (＠julliard) March 10, 2023

March 10, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2365

1 0

Re: [PATCH v2 0/2] MR2366: opengl32: Fix missing conversion of glUnmapBuffer_params from 32bit to 64bit. - approved
by Alexandre Julliard (＠julliard) March 10, 2023

March 10, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2366

1 0

Re: [PATCH v5 0/8] MR1964: dxgi: Catch nested SetFullscreenState invocations. - approved
by Alexandre Julliard (＠julliard) March 10, 2023

March 10, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1964

1 0

Re: [PATCH v2 0/3] MR117: tests: Simplify and deduplicate option handling a bit. - approved
by Alexandre Julliard (＠julliard) March 10, 2023

March 10, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/117

1 0

[PATCH 0/5] MR2352: uiautomationcore: Miscellaneous COM API patches.
by Connor McAdams (＠cmcadams) March 10, 2023

March 10, 2023

Add support for `UIAutomationType_ElementArray` properties in the COM API, and begin adding support for creating elements from cache requests in the COM API. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2352

3 6

[PATCH 0/4] MR2364: wine{alsa,coreaudio,oss,pulse}: Use GetModuleFileName() instead of hardcoded module filename for registry key.
by Davide Beatrici (＠davidebeatrici) March 10, 2023

March 10, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2364

3 9

[PATCH v4 0/1] MR2346: winsqlite3: Add stub DLL.
by Tareque Md Hanif (＠tmdh) March 10, 2023

March 10, 2023

Required to run winget package manager. -- v4: winsqlite3: Add stub DLL. https://gitlab.winehq.org/wine/wine/-/merge_requests/2346

2 1

[PATCH v3 0/2] MR626: Zooming fixes
by David Kahurani (＠kahurani) March 10, 2023

March 10, 2023

Manipulating the font size results in the script_cache going stale. From MSDN[1] `The application should never pass the same handle for different fonts or different sizes.` This is however exactly what happens when the font size changes as a result of zooming(both in and out). ScriptShape and relative functions will only inspect the hardware device context only if the required data is not cached[2] and hence the data from a previous call to these functions is retrieved even though the font size has changed hence the bug where text both doesn't wrap and doesn't paint as it should. In patch one, I have tried to keep track of the script_cache objects alongside the relevant font. Patch two fixes an issue where the cursor doesn't scale after zooming until after one interacts with the editor. Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> 1. https://docs.microsoft.com/en-us/windows/win32/intl/caching 2. https://docs.microsoft.com/en-us/windows/win32/intl/script-cache -- v3: riched20: update caret on zooming riched20: Cache script_cache alongside font cache https://gitlab.winehq.org/wine/wine/-/merge_requests/626

3 4

[PATCH v7 0/6] MR2275: winewayland.drv: part 1: Introduce the Wayland driver
by Alexandros Frantzis (＠afrantzis) March 10, 2023

March 10, 2023

Introduction ------------ This is the first of (many) parts in the upstreaming of the Wayland driver for Wine. Since the amount of code and commits is large, my approach is to upstream the driver in multiple parts in a serial fashion, with each part being a cohesive (to the degree possible) set of not too many commits. When each part is reviewed and merged, I will move on to proposing the next part. My main goal with this approach is to make reviewing easier and more focused. If you have other ideas about how to improve this process for the reviewers, please let me know. A lot of pieces need to fall into place before the driver becomes even remotely functional, so, some MRs (especially the initial ones) will be a bit more preparatory in nature. To aid in the understanding of and justification for some of the code introduced in such MRs, all the remaining driver commits are always going to be available at https://gitlab.winehq.org/afrantzis/wine/-/tree/wayland. Part 1 ------- ~~This MR introduces the Wayland driver PE and unixlib components with some basic code, and prepares the makedep tool to be able to handle Wayland protocol files.~~ This MR introduces the Wayland driver PE and unixlib components with some basic code, and reports some basic monitor information to Wine. Please see the individual commit message for more details. Some questions I would appreciate some feedback on in the context of this MR: 1. Should the Wayland driver build be enabled by default at this point? (currently it's explicitly opt-in with --with-wayland) 2. How should the Wayland driver build be integrated with CI? (currently piggybacking on gitlab/build-linux by adding --with-wayland) Note that building the Wayland driver should not affect running/testing on X11/Xwayland etc, since it's placed lower in the driver priority list. ~~Part 2 preview: We will handle basic Wayland wl_output (i.e., display) events and populate the Wine monitor information.~~ Part 2 preview: We will report more monitor information and implement GetCurrentDisplaySettings. -- v7: winewayland.drv: Report all advertised monitor modes to Wine. https://gitlab.winehq.org/wine/wine/-/merge_requests/2275

2 6

Re: [PATCH v3 0/1] MR2346: winsqlite3: Add stub DLL.
by Alex Henrie (＠alexhenrie) March 10, 2023

March 10, 2023

Alex Henrie (@alexhenrie) commented about dlls/winsqlite3/winsqlite3.spec: > +@ stub sqlite3_wal_autocheckpoint > +@ stub sqlite3_wal_checkpoint > +@ stub sqlite3_wal_checkpoint_v2 > +@ stub sqlite3_wal_hook > +@ stub sqlite3_win32_is_nt > +@ stub sqlite3_win32_mbcs_to_utf8 > +@ stub sqlite3_win32_mbcs_to_utf8_v2 > +@ stub sqlite3_win32_set_directory > +@ stub sqlite3_win32_set_directory16 > +@ stub sqlite3_win32_set_directory8 > +@ stub sqlite3_win32_sleep > +@ stub sqlite3_win32_unicode_to_utf8 > +@ stub sqlite3_win32_utf8_to_mbcs > +@ stub sqlite3_win32_utf8_to_mbcs_v2 > +@ stub sqlite3_win32_utf8_to_unicode > +@ stub sqlite3_win32_write_deb@ Please always include a newline character at the end of text files. It's required by Unix for commands like `cat`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2346#note_26644

1 0

[PATCH v6 0/6] MR2275: winewayland.drv: part 1: Introduce the Wayland driver
by Alexandros Frantzis (＠afrantzis) March 10, 2023

March 10, 2023

Introduction ------------ This is the first of (many) parts in the upstreaming of the Wayland driver for Wine. Since the amount of code and commits is large, my approach is to upstream the driver in multiple parts in a serial fashion, with each part being a cohesive (to the degree possible) set of not too many commits. When each part is reviewed and merged, I will move on to proposing the next part. My main goal with this approach is to make reviewing easier and more focused. If you have other ideas about how to improve this process for the reviewers, please let me know. A lot of pieces need to fall into place before the driver becomes even remotely functional, so, some MRs (especially the initial ones) will be a bit more preparatory in nature. To aid in the understanding of and justification for some of the code introduced in such MRs, all the remaining driver commits are always going to be available at https://gitlab.winehq.org/afrantzis/wine/-/tree/wayland. Part 1 ------- ~~This MR introduces the Wayland driver PE and unixlib components with some basic code, and prepares the makedep tool to be able to handle Wayland protocol files.~~ This MR introduces the Wayland driver PE and unixlib components with some basic code, and reports some basic monitor information to Wine. Please see the individual commit message for more details. Some questions I would appreciate some feedback on in the context of this MR: 1. Should the Wayland driver build be enabled by default at this point? (currently it's explicitly opt-in with --with-wayland) 2. How should the Wayland driver build be integrated with CI? (currently piggybacking on gitlab/build-linux by adding --with-wayland) Note that building the Wayland driver should not affect running/testing on X11/Xwayland etc, since it's placed lower in the driver priority list. ~~Part 2 preview: We will handle basic Wayland wl_output (i.e., display) events and populate the Wine monitor information.~~ Part 2 preview: We will report more monitor information and implement GetCurrentDisplaySettings. -- v6: winewayland.drv: Report all advertised monitor modes to Wine. winewayland.drv: Report basic monitor information. https://gitlab.winehq.org/wine/wine/-/merge_requests/2275

2 6

[PATCH 0/2] MR2368: wineps: PSDRV_WriteDIBPatternDict fixes
by Piotr Caban (＠piotr) March 10, 2023

March 10, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2368

4 4

[PATCH v5 0/6] MR2275: winewayland.drv: part 1: Introduce the Wayland driver
by Alexandros Frantzis (＠afrantzis) March 10, 2023

March 10, 2023

Introduction ------------ This is the first of (many) parts in the upstreaming of the Wayland driver for Wine. Since the amount of code and commits is large, my approach is to upstream the driver in multiple parts in a serial fashion, with each part being a cohesive (to the degree possible) set of not too many commits. When each part is reviewed and merged, I will move on to proposing the next part. My main goal with this approach is to make reviewing easier and more focused. If you have other ideas about how to improve this process for the reviewers, please let me know. A lot of pieces need to fall into place before the driver becomes even remotely functional, so, some MRs (especially the initial ones) will be a bit more preparatory in nature. To aid in the understanding of and justification for some of the code introduced in such MRs, all the remaining driver commits are always going to be available at https://gitlab.winehq.org/afrantzis/wine/-/tree/wayland. Part 1 ------- This MR introduces the Wayland driver PE and unixlib components with some basic code, and prepares the makedep tool to be able to handle Wayland protocol files. Please see the individual commit message for more details. Some questions I would appreciate some feedback on in the context of this MR: 1. Should the Wayland driver build be enabled by default at this point? (currently it's explicitly opt-in with --with-wayland) 2. How should the Wayland driver build be integrated with CI? (currently piggybacking on gitlab/build-linux by adding --with-wayland) Note that building the Wayland driver should not affect running/testing on X11/Xwayland etc, since it's placed lower in the driver priority list. Part 2 preview: We will handle basic Wayland wl_output (i.e., display) events and populate the Wine monitor information. -- v5: winewayland.drv: Report all advertised monitor modes to Wine. winewayland.drv: Report basic monitor information. win32u: Allow drivers to set the null user driver. winewayland.drv: Perform basic per-process Wayland initialization. winewayland.drv: Add initial unixlib stub. winewayland.drv: Add initial driver stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/2275

2 9

[PATCH v3 0/1] MR246: Allow renaming a file/directory to a different case of itself
by Gabriel Ivăncescu March 10, 2023

March 10, 2023

-- v3: ntdll: Allow renaming a file/directory to a different case of itself. https://gitlab.winehq.org/wine/wine/-/merge_requests/246

1 1

Re: [PATCH v2 0/1] MR246: Allow renaming a file/directory to a different case of itself
by Gabriel Ivăncescu March 10, 2023

March 10, 2023

I've rebased it now to current upstream. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/246#note_26637

1 0

[PATCH v3 0/1] MR2342: Revert "server: Don't invalidate the newly exposed child region on the parent...
by Jinoh Kang (＠iamahuman) March 10, 2023

March 10, 2023

Revert "server: Don't invalidate the newly exposed child region on the parent if it doesn't clip children." This reverts commit 33617af8145b6fadfe41d48968a728ff57b3064b. Apparently, the aforementioned commit might cause the expose region to be incorrectly computed when a window transitions from invisible state to visible state. The commit also had caused regression in the following apps: - Wine regedit.exe (bug 54268) - Dn-FamiTracker (bug 52903) - Unity Assets Bundle Extractor (same cause behind bug 52903) It appears that the commit catalyzes discovery of hidden bugs in Wine's window repaint logic. It's also possible that the algorithm for computing the expose region is incomplete. For these reasons, revert this commit for now. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54268 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52903 -- v3: Revert "server: Don't invalidate the newly exposed child region on the parent if it doesn't clip children." https://gitlab.winehq.org/wine/wine/-/merge_requests/2342

2 2

Re: [PATCH v2 0/1] MR246: Allow renaming a file/directory to a different case of itself
by Olivia/Isabelle Mahadevan (＠doubledge-spec) March 10, 2023

March 10, 2023

Any updates? @huw? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/246#note_26629

1 0

Re: [PATCH 0/3] MR260: ntdll: Improve xstate validation in NtGetContextThread()
by Olivia/Isabelle Mahadevan (＠doubledge-spec) March 10, 2023

March 10, 2023

As I also play Secret Laboratory, would like to see this merged and then go into upstream proton. Any updates, @gofman? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/260#note_26628

1 0

Re: [PATCH v3 0/5] MR131: wined3d: Introduce wined3d_device_check_format_support().
by Olivia/Isabelle Mahadevan (＠doubledge-spec) March 10, 2023

March 10, 2023

Any updates? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/131#note_26627

1 0

[PATCH v6 0/1] MR2359: opengl32: fix bug abort missing convert of glUmapBuffer_params from 32bit to 64bit
by Fan WenJie (＠fanwenjie) March 10, 2023

March 10, 2023

Signed-off-by: Fan WenJie <fanwj(a)mail.ustc.edu.cn> -- v6: opengl32: fix bug abort missing convert of glUmapBuffer_params from 32bit to 64bit https://gitlab.winehq.org/wine/wine/-/merge_requests/2359

2 2

Re: [PATCH v3 0/2] MR2345: Close the bytestream in IMFMediaSource::Shutdown.
by Derek Lesho (＠dlesho) March 10, 2023

March 10, 2023

Does the MR also need approval from Zeb, or is there something else wrong? FWIW I think the test failure is erroneous, it's in dinput which is completely unrelated. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2345#note_26623

1 0

[PATCH v4 0/8] MR1964: dxgi: Catch nested SetFullscreenState invocations.
by Stefan Dösinger March 10, 2023

March 10, 2023

FFXIV depends on this. It calls SetFullscreenState when it receives WM_WINDOWPOSCHANGED. Through luck the recursion aborts after two calls. The user-visible bug is that after leaving fullscreen, the game's window is still TOPMOST because we overwrite the stored pre-fullscreen window flags. -- v4: dxgi/tests: Test nested SetFullscreenState from the same thread. dxgi/tests: Test nested fullscreen application from different thread. dxgi: Catch nested SetFullscreenState invocations. dxgi: Unlock the wined3d mutex after storing the new target. dxgi/tests: Run test_swapchain_window_messages on d3d12. dxgi: Call wined3d_swapchain_state_set_fullscreen in d3d12_swapchain_init. dxgi/tests: Run test_resize_target_wndproc on d3d12 too. dxgi/tests: Fix UnregisterClass call in test_resize_target_wndproc. https://gitlab.winehq.org/wine/wine/-/merge_requests/1964

3 11

[PATCH 0/1] MR2367: comctl32/treeview: Ignore the lParam to WM_PRINTCLIENT and add tests.
by Alex Henrie (＠alexhenrie) March 10, 2023

March 10, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54640 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2367

2 1

[PATCH v7 0/2] MR2183: winecfg: Add an option to enable WinRT app dark theme.
by Mohamad Al-Jaf (＠maljaf) March 10, 2023

March 10, 2023

This is what it looks like: ![Screenshot_20230310_015941](/uploads/99b3d279bcddbd40212808a045444a7b/Screenshot_20230310_015941.png) -- v7: winecfg: Add an option to enable WinRT app dark theme. https://gitlab.winehq.org/wine/wine/-/merge_requests/2183

2 3